Re: [PATCH v2] virtio-scsi: Fix the race condition in virtscsi_handle_event

2015-01-06 Thread Michael S. Tsirkin
On Tue, Jan 06, 2015 at 03:33:36PM +0800, Fam Zheng wrote: There is a race condition in virtscsi_handle_event, when many device hotplug/unplug events flush in quickly. The scsi_remove_device in virtscsi_handle_transport_reset may trigger the BUG_ON in scsi_target_reap, because the state is

re: [SCSI] pmcraid: PMC-Sierra MaxRAID driver to support 6Gb/s SAS RAID controller

2015-01-06 Thread Dan Carpenter
(Sorry, this code is really old, and normally I wouldn't report it but I'm making a tutorial). Hello Anil Ravindranath, The patch 89a368104150: [SCSI] pmcraid: PMC-Sierra MaxRAID driver to support 6Gb/s SAS RAID controller from Aug 25, 2009, leads to the following static checker warning:

[PATCH v1 0/2] Add the PMP support for APM X-Gene SoC AHCI SATA Host Controller driver.

2015-01-06 Thread Suman Tripathi
This patch set implements the PMP support for APM X-Gene SoC AHCI SATA Host Controller driver. Signed-off-by: Suman Tripathi stripa...@apm.com --- Suman Tripathi (2): ahci_xgene: Implement the xgene_ahci_poll_reg_val to support PMP. ahci_xgene: Implement the workaround to support PMP

[PATCH v1 2/2] ahci_xgene: Implement the workaround to support PMP enumeration and discovery.

2015-01-06 Thread Suman Tripathi
Due to H/W errata, the controller is unable to save the PMP field fetched from command header before sending the H2D FIS. When the device returns the PMP port field in the D2H FIS, there is a mismatch and results in command completion failure. The workaround is to write the pmp value to PxFBS.DEV

[PATCH v1 1/2] ahci_xgene: Implement the xgene_ahci_poll_reg_val to support PMP.

2015-01-06 Thread Suman Tripathi
This patch implements the function xgene_ahci_poll_reg_val to poll PxCI for multiple IDENTIFY DEVICE commands to finish before restarting the DMA engine. Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/ahci_xgene.c | 56 ++-- 1 file

Re: [PATCH v2] virtio-scsi: Fix the race condition in virtscsi_handle_event

2015-01-06 Thread Venkatesh Srinivas
On Mon, Jan 5, 2015 at 11:33 PM, Fam Zheng f...@redhat.com wrote: There is a race condition in virtscsi_handle_event, when many device hotplug/unplug events flush in quickly. The scsi_remove_device in virtscsi_handle_transport_reset may trigger the BUG_ON in scsi_target_reap, because the

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

2015-01-06 Thread Suman Tripathi
Hi On Tue, Dec 16, 2014 at 10:19:35PM +0530, Suman Tripathi wrote: This patch addresses the issue with ATA_CMD_PACKET pio mode command for enumeration and device detection with ATAPI devices.It is the same issue as in patch www.spinics.net/lists/linux-ide/msg49092.html Signed-off-by: Suman

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

2015-01-06 Thread Tejun Heo
On Tue, Jan 06, 2015 at 01:51:15PM +0530, Suman Tripathi wrote: Hi On Tue, Dec 16, 2014 at 10:19:35PM +0530, Suman Tripathi wrote: This patch addresses the issue with ATA_CMD_PACKET pio mode command for enumeration and device detection with ATAPI devices.It is the same issue as in patch

Re: [PATCH v1 0/2] Add the PMP support for APM X-Gene SoC AHCI SATA Host Controller driver.

2015-01-06 Thread Tejun Heo
On Tue, Jan 06, 2015 at 03:32:14PM +0530, Suman Tripathi wrote: This patch set implements the PMP support for APM X-Gene SoC AHCI SATA Host Controller driver. Hmm... still doesn't apply to for-3.20 after pulling in for-3.19-fixes. git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git

Re: [PATCH v2] virtio-scsi: Fix the race condition in virtscsi_handle_event

2015-01-06 Thread Fam Zheng
On Tue, 01/06 11:35, Michael S. Tsirkin wrote: On Tue, Jan 06, 2015 at 03:33:36PM +0800, Fam Zheng wrote: There is a race condition in virtscsi_handle_event, when many device hotplug/unplug events flush in quickly. The scsi_remove_device in virtscsi_handle_transport_reset may trigger

[PATCH v3] virtio-scsi: Fix the race condition in virtscsi_handle_event

2015-01-06 Thread Fam Zheng
There is a race condition in virtscsi_handle_event, when many device hotplug/unplug events flush in quickly. The scsi_remove_device in virtscsi_handle_transport_reset may trigger the BUG_ON in scsi_target_reap, because the state is altered behind it, probably by scsi_scan_host of another event.

[PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-01-06 Thread Sreekanth Reddy
For any SCSI command, if the driver receives IOC status = SCSI_IOC_TERMINATED and log info = 0x32010081 then that command will be completed with DID_RESET host status. The definition of this log info value is Virtual IO has failed and has to be retried. Firmware will provide this log info

Re: [PATCH v1 0/2] Add the PMP support for APM X-Gene SoC AHCI SATA Host Controller driver.

2015-01-06 Thread Tejun Heo
On Tue, Jan 06, 2015 at 07:10:31PM +0530, Suman Tripathi wrote: Hi , For more info here is the git log output before applying the patch. git log commit b84b25cb0900b99b28c742dd33101be779f58259 Merge: 0628ee7 36aae28 Author: Tejun Heo t...@kernel.org Date: Tue Jan 6 07:48:24 2015

Re: [PATCH v1 0/2] Add the PMP support for APM X-Gene SoC AHCI SATA Host Controller driver.

2015-01-06 Thread Suman Tripathi
Hi , On Tue, Jan 06, 2015 at 03:32:14PM +0530, Suman Tripathi wrote: This patch set implements the PMP support for APM X-Gene SoC AHCI SATA Host Controller driver. Hmm... still doesn't apply to for-3.20 after pulling in for-3.19-fixes.

Re: [PATCH v1 0/2] Add the PMP support for APM X-Gene SoC AHCI SATA Host Controller driver.

2015-01-06 Thread Suman Tripathi
Hi , For more info here is the git log output before applying the patch. git log commit b84b25cb0900b99b28c742dd33101be779f58259 Merge: 0628ee7 36aae28 Author: Tejun Heo t...@kernel.org Date: Tue Jan 6 07:48:24 2015 -0500 Merge branch 'for-3.19-fixes' of

[Bug 90601] panic on write to 3ware raid array

2015-01-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90601 --- Comment #5 from mer...@liao.homelinux.org --- Created attachment 162641 -- https://bugzilla.kernel.org/attachment.cgi?id=162641action=edit syslog before crash -- You are receiving this mail because: You are the assignee for the bug. -- To

Re: [PATCH v3] virtio-scsi: Fix the race condition in virtscsi_handle_event

2015-01-06 Thread Michael S. Tsirkin
On Tue, Jan 06, 2015 at 09:25:05PM +0800, Fam Zheng wrote: There is a race condition in virtscsi_handle_event, when many device hotplug/unplug events flush in quickly. The scsi_remove_device in virtscsi_handle_transport_reset may trigger the BUG_ON in scsi_target_reap, because the state is

[Bug 90601] panic on write to 3ware raid array

2015-01-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90601 --- Comment #4 from mer...@liao.homelinux.org --- Hi Kashyap, 1. I enabled CONFIG_DMA_API_DEBUG , strangely enough after enabling it I couldn't even boot into the system anymore because it would crash when trying to access the root partition

[Bug 90601] panic on write to 3ware raid array

2015-01-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90601 --- Comment #6 from mer...@liao.homelinux.org --- Created attachment 162651 -- https://bugzilla.kernel.org/attachment.cgi?id=162651action=edit backtrace with CONFIG_DMA_API_DEBUG enabled -- You are receiving this mail because: You are the

[target:nvme_of 3/3] drivers/target/nvme_of/nvme_of_configfs.c:25:31: sparse: symbol 'nvme_of_fabric_configfs' was not declared. Should it be static?

2015-01-06 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git nvme_of head: 40d8c11927282d59855d645b35798edd97828da5 commit: 40d8c11927282d59855d645b35798edd97828da5 [3/3] nvme_of: Initial skeleton commit reproduce: # apt-get install sparse git checkout

[PATCH target] nvme_of: nvme_of_fabric_configfs can be static

2015-01-06 Thread kbuild test robot
drivers/target/nvme_of/nvme_of_configfs.c:25:31: sparse: symbol 'nvme_of_fabric_configfs' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- nvme_of_configfs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] vhost-scsi: Add missing virtio-scsi - TCM attribute conversion

2015-01-06 Thread Michael S. Tsirkin
On Tue, Jan 06, 2015 at 08:18:05PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org While looking at hch's recent conversion to drop the MSG_*_TAG definitions, I noticed a long standing bug in vhost-scsi where the VIRTIO_SCSI_S_* attribute definitions where

Re: [PATCH] vhost-scsi: Add missing virtio-scsi - TCM attribute conversion

2015-01-06 Thread Nicholas A. Bellinger
On Tue, 2015-01-06 at 23:07 +0200, Michael S. Tsirkin wrote: On Tue, Jan 06, 2015 at 08:18:05PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org While looking at hch's recent conversion to drop the MSG_*_TAG definitions, I noticed a long standing bug in

Re: block: remove artifical max_hw_sectors cap

2015-01-06 Thread Nicholas A. Bellinger
On Tue, 2015-01-06 at 14:39 -0800, Nicholas A. Bellinger wrote: On Tue, 2014-12-23 at 09:28 +0100, Christoph Hellwig wrote: On Mon, Dec 22, 2014 at 11:31:53AM +0100, Stefan Priebe - Profihost AG wrote: Hi, since the below patch i've some problems with iscsi. The LIO based

Re: T10-PI: Getting failed tag info

2015-01-06 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@infradead.org writes: Christoph But those extensions require new structures to pass in the PI Christoph info anyway.. Yep. But I still don't see why that warrants having a parallel error passing infrastructure in the kernel to handle data integrity errors.

Re: [PATCH 06/22] [SCSI] mpt2sas, mpt3sas: Removing uppper boundary restriction for the module parameter max_sgl_entries

2015-01-06 Thread Martin K. Petersen
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes: Sreekanth I though to warn the user that the module parameter Sreekanth max_sgl_entries value what they provided is greater than the Sreekanth kernel defined SCSI_MAX_SG_SEGMENTS, whether if this module Sreekanth parameter value

Re: [PATCH 6/8] megaraid_sas : Reserve commands for IOCTLs and internal DCMDs

2015-01-06 Thread Martin K. Petersen
Sumit == sumit.sax...@avagotech.com writes: Sumit 1)For fusion adapters, limited reserved frames for non SCSI Sumit commands to 8(3 for parallel IOCTLs + 5 for driver's internal Sumit DCMDs). Earlier reserved commands for non SCSI IO frames was set Sumit to 32, so with this implementation,

Re: [PATCH 8/8] megaraid_sas : Driver version update

2015-01-06 Thread Martin K. Petersen
Sumit == sumit.sax...@avagotech.com writes: Sumit Update megaraid_sas driver version. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: [LSF/MM ATTEND] discuss blk-mq related to DM-multipath and status of XCOPY

2015-01-06 Thread Martin K. Petersen
Mike == Mike Snitzer snit...@redhat.com writes: Mike Another topic we need to come to terms with is the state of XCOPY Mike (whether the initial approach needs further work, etc) -- Mikulas Mike Patocka reworked aspects of Martin's initial approach but it Mike hasn't progressed upstream: Yeah,

Re: [dm-devel] [LSF/MM ATTEND] discuss blk-mq related to DM-multipath and status of XCOPY

2015-01-06 Thread Martin K. Petersen
Hannes == Hannes Reinecke h...@suse.de writes: Hannes Yep. That definitely needs to be discussed. Especially we'd Hannes need to discuss how to handle exceptions, seeing that XCOPY Hannes might fail basically at any time. Like any SCSI command :) -- Martin K. Petersen Oracle Linux

Re: [PATCH 1/8] megaraid_sas : Endianness related bug fixes and code optimization

2015-01-06 Thread Martin K. Petersen
Sumit == sumit.sax...@avagotech.com writes: Sumit This patch addresses below issues- 1) Few endianness bug fixes. Sumit 2) Break the iteration after (MAX_LOGICAL_DRIVES_EXT - 1)), Sumit instead of MAX_LOGICAL_DRIVES_EXT. 3) Optimization in MFI INIT Sumit frame before firing. 4) MFI IO frame

Re: [PATCH 3/8] megaraid_sas : Fix the problem of non-existing VD exposed to host

2015-01-06 Thread Martin K. Petersen
Sumit == sumit.sax...@avagotech.com writes: Sumit For legacy firmware(64 VD firmware), invalidates LD(by setting LD Sumit value to 0xff) in LdTgtIdtoLd[] array for device index beyond Sumit 127, so that invalid LD(0xff) value should be returned beyond Sumit device index beyond 127.

Re: [PATCH 5/8] megaraid_sas : Complete outstanding IOCTLs before killing adapter

2015-01-06 Thread Martin K. Petersen
Sumit == sumit.sax...@avagotech.com writes: Sumit Driver calls megasas_complete_cmd() to call wake_up() for each Sumit MFI frame that was issued through the ioctl() interface prior to Sumit the kill adapter. This ensures userspace ioctl() system calls Sumit issued just before a kill adapter

Re: [PATCH 7/8] megaraid_sas : Remove redundant code of memset load_balance_info to zero

2015-01-06 Thread Martin K. Petersen
Sumit == sumit.sax...@avagotech.com writes: Sumit struct fusion_context *fusion is already memset to '0', so remove Sumit redundant code of meset fusion-load_balance_info to '0'. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] virtio-scsi: Fix the race condition in virtscsi_handle_event

2015-01-06 Thread Fam Zheng
On Tue, 01/06 16:54, Michael S. Tsirkin wrote: On Tue, Jan 06, 2015 at 09:25:05PM +0800, Fam Zheng wrote: There is a race condition in virtscsi_handle_event, when many device hotplug/unplug events flush in quickly. The scsi_remove_device in virtscsi_handle_transport_reset may trigger

Re: [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-01-06 Thread Martin K. Petersen
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes: Sreekanth For any SCSI command, if the driver receives IOC status = Sreekanth SCSI_IOC_TERMINATED and log info = 0x32010081 then that Sreekanth command will be completed with DID_RESET host status. Reviewed-by: Martin K.

Re: [PATCH 4/8] megaraid_sas : Disable interrupt_mask before enabling hardware interrupts

2015-01-06 Thread Martin K. Petersen
Sumit == sumit.sax...@avagotech.com writes: Sumit Update driver mask_interrupts before enable/disable hardware Sumit interrupt in order to avoid missing interrupts because of Sumit mask_interrupts still set to 1 and hardware interrupts are Sumit enabled. Reviewed-by: Martin K. Petersen

Re: [PATCH 2/8] megaraid_sas : Support for secure JBOD

2015-01-06 Thread Martin K. Petersen
Sumit == sumit.sax...@avagotech.com writes: Sumit This patch will add support for Secure Encrypting Drives(SED) in Sumit JBOD mode. below are the key points- 1) If Firmware supports SED Sumit JBOD, all non Read Write commands to JBODs will be sent via Sumit Firmware path and Read write

[PATCH 2/2] target: Drop left-over fabric_max_sectors attribute

2015-01-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Now that fabric_max_sectors is no longer used to enforce the maximum I/O size, go ahead and drop it's left-over usage in target-core and associated backend drivers. Cc: Christoph Hellwig h...@lst.de Cc: Roland Dreier rol...@purestorage.com

[PATCH 1/2] target: Don't arbitrary limit I/O size to fabric_max_sectors

2015-01-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch avoids the arbitrary limiting of I/O size to fabric_max_sectors, which currently has a hardcoded max of 8192 (4 MB for 512 byte sector devices). This is problematic because Linux initiators have only recently started to honor block limits

Re: RFC: should we deprecate unmaintained isa-only drivers?

2015-01-06 Thread Ondrej Zary
On Tuesday 30 December 2014 17:06:16 Christoph Hellwig wrote: We've got a few very old, isa-only SCSI HBA drivers in the tree. Of those only one (aha152x) sas significant maintaince since the dawn of git, all others only saw global / automatic updates. 4 of those are fairly trivial wrappers

Re: [target:nvme_of 3/3] drivers/target/nvme_of/nvme_of_configfs.c:25:31: sparse: symbol 'nvme_of_fabric_configfs' was not declared. Should it be static?

2015-01-06 Thread Nicholas A. Bellinger
On Wed, 2015-01-07 at 03:35 +0800, kbuild test robot wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git nvme_of head: 40d8c11927282d59855d645b35798edd97828da5 commit: 40d8c11927282d59855d645b35798edd97828da5 [3/3] nvme_of: Initial skeleton commit

[PATCH] scsi_debug: check for bigger value first

2015-01-06 Thread Andy Shevchenko
Even for signed types we have to check for bigger positive value first. Otherwise it will be never happened. Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/scsi/scsi_debug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/scsi_debug.c

Re: block: remove artifical max_hw_sectors cap

2015-01-06 Thread Nicholas A. Bellinger
On Tue, 2014-12-23 at 09:28 +0100, Christoph Hellwig wrote: On Mon, Dec 22, 2014 at 11:31:53AM +0100, Stefan Priebe - Profihost AG wrote: Hi, since the below patch i've some problems with iscsi. The LIO based iscsi Server is full of messages like this: SCSI OP 2ah with too big

Re: [PATCH] Allow EA reservation holders to read from device.

2015-01-06 Thread Lee Duncan
On 01/06/2015 01:23 PM, Nicholas A. Bellinger wrote: Hi Lee, Apologies for the delayed response, just catching up from the holidays. No worries. Comments below. On Mon, 2015-01-05 at 10:49 -0800, Lee Duncan wrote: From: Lee Duncan ldun...@suse.com For PGR reservation type Exclusive

[Bug 90601] panic on write to 3ware raid array

2015-01-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90601 --- Comment #7 from mer...@liao.homelinux.org --- Created attachment 162661 -- https://bugzilla.kernel.org/attachment.cgi?id=162661action=edit kernel config -- You are receiving this mail because: You are the assignee for the bug. -- To

[PATCH] MAINTAINERS: Update maintainer list for qla4xxx

2015-01-06 Thread nilesh.javali
From: Nilesh Javali nilesh.jav...@qlogic.com Signed-off-by: Nilesh Javali nilesh.jav...@qlogic.com --- MAINTAINERS |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index ddb9ac8..f6dee56 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7737,8

Re: [PATCHv3 00/10] scsi logging update: the real thing

2015-01-06 Thread Hannes Reinecke
On 01/05/2015 05:59 PM, Christoph Hellwig wrote: Can you send an updated version against the scsi-for-3.20 tree so that we can get this series in early for the 3.20 cycle? I'm about to prepare it. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-01-06 Thread Tomas Henzl
On 01/05/2015 07:41 PM, Masoud Sharbiani wrote: Dear stable maintainers, Can you please backport commitid 132aa220b45d60e9b20def1e9d8be9422eed9616 (hpsa: refine the pci enable/disable handling) to 3.10 stable (and earlier, if applicable)? Please do not apply this patch isolated from his