Re: [PATCH v7 2/5] phy: qcom-ufs: add support for 20nm phy

2015-01-15 Thread dovl
Reviewed-by: Dov Levenglick d...@codeaurora.org This change adds a support for a 20nm qcom-ufs phy that is required in platforms that use ufs-qcom controller. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/phy/Makefile| 1 + drivers/phy/phy-qcom-ufs-i.h

Re: [PATCH v7 2/5] phy: qcom-ufs: add support for 20nm phy

2015-01-15 Thread dovl
Reviewed-by: Dov Levenglick d...@codeaurora.org This change adds a support for a 20nm qcom-ufs phy that is required in platforms that use ufs-qcom controller. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/phy/Makefile| 1 + drivers/phy/phy-qcom-ufs-i.h

Re: [PATCH v7 4/5] phy: qcom-ufs: add support for 14nm phy

2015-01-15 Thread dovl
Reviewed-by: Dov Levenglick d...@codeaurora.org This change adds a support for a 14nm qcom-ufs phy that is required in platforms that use ufs-qcom controller. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/phy/Makefile| 1 +

Re: [PATCH 0/2] Remove T4 FCoE support

2015-01-15 Thread David Miller
From: Praveen Madhavan prave...@chelsio.com Date: Thu, 15 Jan 2015 19:15:50 +0530 These patches removes FCoE support for chelsio T4 adapter. Please apply on net-next since depends on previous commits. Why is it being removed? You have to state this in the commit log messages at a minimum. --

sysfs methods can race with -remove

2015-01-15 Thread Alan Stern
Tejun: The context is that we have been talking about drivers/scsi/scsi_scan.c:scsi_rescan_device(), which is called by the store_rescan_field() sysfs method in scsi_sysfs.c. The problem is this: What happens in scsi_rescan_device if the device is unbound from its driver before the module_put

Re: dm + blk-mq soft lockup complaint

2015-01-15 Thread Bart Van Assche
On 01/15/15 16:44, Mike Snitzer wrote: How easily could you reproduce your SRP hang? Did it happen every run or did it take multiple runs to see it? Hello Mike, This complaint was easy to trigger. It took less than one minute before the soft lockup complaint appeared. The system did not hang

Re: dm + blk-mq soft lockup complaint

2015-01-15 Thread Mike Snitzer
On Thu, Jan 15 2015 at 3:11am -0500, Bart Van Assche bart.vanass...@sandisk.com wrote: On 01/14/15 20:00, Mike Snitzer wrote: IB aside, I haven't been following along close enough on scsi-mq developments, but does a regular iscsi initiator have support for scsi-mq? I'd like to validate

[PATCH v2] scsi: Avoid crashing if device uses DIX but adapter does not support it

2015-01-15 Thread Ewan D. Milne
From: Ewan D. Milne emi...@redhat.com This can happen if a multipathed device uses DIX and another path is added via an adapter that does not support it. Multipath should not allow this path to be added, but we should not depend upon that to avoid crashing. Signed-off-by: Ewan D. Milne

Re: [PATCH v7 3/5] scsi: ufs-qcom: add support for Qualcomm Technologies Inc platforms

2015-01-15 Thread Dov Levenglick
Reviewed-by: Dov Levenglick d...@codeaurora.org This change adds support for Qualcomm Technologies Inc platforms that use UFS driver. for example, it adds : - PM specific operations during hibern8, suspend, resume, clock setup - qcom-ufs generic phy driver initialization, calibration,

RE: [PATCH v7 0/5] phy: qcom-ufs: add support for QUALCOMM

2015-01-15 Thread Dov Levenglick
Reviewed-by: Dov Levenglick d...@codeaurora.org Dov Levenglick QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -Original Message- From:

Re: [PATCH v7 1/5] phy: qcom-ufs: add support for QUALCOMM Technologies UFS PHY drivers

2015-01-15 Thread dovl
Reviewed-by: Dov Levenglick d...@codeaurora.org This change adds a generic and common API support for ufs phy QUALCOMM Technologies. This support provides common code and also points to specific phy callbacks to differentiate between different behaviors of frequent use-cases (like power on,

Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

2015-01-15 Thread Bart Van Assche
On 01/15/15 10:08, Christoph Hellwig wrote: We're obviously not adding hooks for out of tree code to the kernel. Hello Christoph, My goal is to realize this proposal without adding hooks for out-of-tree code in the upstream kernel. What I had in mind is to raise the abstraction level of the API

Re: [PATCH v7 5/5] scsi: ufs-qcom-ice: add Inline Crypto Engine (ICE) support for UFS

2015-01-15 Thread Dov Levenglick
Reviewed-by: Dov Levenglick d...@codeaurora.org From: Yaniv Gardi yga...@qti.qualcomm.com In-order to enhance storage encryption performance, an Inline Cryptographic Engine is introduced to UFS. This patch adds in-line encryption capabilities to the UFS driver. Signed-off-by: Yaniv Gardi

Re: [PATCH for v3.19, v2] Avoid that sd_shutdown() triggers a kernel warning

2015-01-15 Thread Don Brace
On 01/07/2015 07:03 AM, Bart Van Assche wrote: Since kernel v3.19-rc1 module_refcount() returns 1 instead of 0 when called from inside module_exit(). This breaks the module_refcount() test in scsi_device_put() and hence causes the following kernel warning to be reported when unloading the ib_srp

Re: [PATCH for v3.19, v2] Avoid that sd_shutdown() triggers a kernel warning

2015-01-15 Thread Christoph Hellwig
On Wed, Jan 14, 2015 at 10:07:00AM -0500, Alan Stern wrote: and the kernfs core insures that the underlying device won't be deallocated while a sysfs method runs. It has a reference to keep it from beeing freed, but so far I can't find anything that prevents -remove from beeing called while we

Re: sysfs methods can race with -remove

2015-01-15 Thread Tejun Heo
Hello, Alan. On Thu, Jan 15, 2015 at 01:22:03PM -0500, Alan Stern wrote: It has a reference to keep it from beeing freed, but so far I can't find anything that prevents -remove from beeing called while we are in or just before a method call. There are two types of methods to think about:

Re: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag

2015-01-15 Thread Mike Christie
On 01/12/2015 05:05 PM, Minh Duc Tran wrote: From: Minh Duc Tran Sent: Sunday, November 09, 2014 10:52 PM To: 'linux-scsi@vger.kernel.org' Cc: Mike Christie (micha...@cs.wisc.edu); Jayamohan Kallickal Subject: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag From: Minh Tran

Re: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag

2015-01-15 Thread James Bottomley
On Thu, 2015-01-15 at 17:16 -0600, Mike Christie wrote: On 01/12/2015 05:05 PM, Minh Duc Tran wrote: From: Minh Duc Tran Sent: Sunday, November 09, 2014 10:52 PM To: 'linux-scsi@vger.kernel.org' Cc: Mike Christie (micha...@cs.wisc.edu); Jayamohan Kallickal Subject: [PATCH 1/1]

[LSF/MM TOPIC] Storage tools

2015-01-15 Thread Douglas Gilbert
I have written and continue to maintain several user space packages used for the SCSI and ATA subsystems. These include sg3_utils (a collection of tools), lsscsi, sdparm, ddpt and smp_utils. I also maintain the Linux scsi_debug driver which may be viewed as a test tool rather than a production

Re: [PATCH 0/2] Remove T4 FCoE support

2015-01-15 Thread Praveen Madhavan
On Thu, Jan 15, 2015 at 02:04:53PM -0500, David Miller wrote: From: Praveen Madhavan prave...@chelsio.com Date: Thu, 15 Jan 2015 19:15:50 +0530 These patches removes FCoE support for chelsio T4 adapter. Please apply on net-next since depends on previous commits. Why is it being removed?

Re: [PATCH 0/2] Remove T4 FCoE support

2015-01-15 Thread Hannes Reinecke
On 01/16/2015 05:32 AM, Praveen Madhavan wrote: On Thu, Jan 15, 2015 at 02:04:53PM -0500, David Miller wrote: From: Praveen Madhavan prave...@chelsio.com Date: Thu, 15 Jan 2015 19:15:50 +0530 These patches removes FCoE support for chelsio T4 adapter. Please apply on net-next since depends on

Re: [PATCH v6 1/4] phy: qcom-ufs: add support for 20nm phy

2015-01-15 Thread Kishon Vijay Abraham I
Hi, On Sunday 11 January 2015 06:08 PM, Yaniv Gardi wrote: This change adds a support for a 20nm qcom-ufs phy that is required in platforms that use ufs-qcom controller. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/phy/Kconfig | 7 +

Re: dm + blk-mq soft lockup complaint

2015-01-15 Thread Bart Van Assche
On 01/14/15 20:00, Mike Snitzer wrote: IB aside, I haven't been following along close enough on scsi-mq developments, but does a regular iscsi initiator have support for scsi-mq? I'd like to validate scsi-mq devices with the dm-mpath changes. Hello Mike, scsi-mq support for the iSCSI

Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

2015-01-15 Thread Christoph Hellwig
I don't quite understand whay you're proposing. We're obbiously not adding hooks for out of tree code to the kernel. If you can improve the target core - driver interface (and there's plenty of opportunity for improvement) and it also happens to help your cause it's all fine But all that really

Re: [Lsf-pc] [LSF/MM TOPIC] How SRP initiator performance has been improved via scsi-mq

2015-01-15 Thread Christoph Hellwig
On Wed, Jan 14, 2015 at 10:37:39AM +0100, Bart Van Assche wrote: Recently it has been proposed to discuss how to add scsi-mq support in the iSER initiator during the 2015 edition of the LSF/MM summit. In the discussion that followed that proposal several questions were asked about how scsi-mq

[PATCH] iscsi-target: use '%*ph' specifier to dump hex buffer

2015-01-15 Thread Andy Shevchenko
Instead of pushing each byte via stack the %*ph specifier allows to supply just a pointer and length of the buffer. The patch converts code to use the specifier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/target/iscsi/iscsi_target_configfs.c | 13 -

[PATCH] scsi: qla2xxx: print port name via %*phC

2015-01-15 Thread Andy Shevchenko
Instead of pushing each byte via stack let's use custom specifier which allows to print small buffers as a hex string. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH 28/48] hpsa: use per-controller work queue

2015-01-15 Thread Christoph Hellwig
This should be folded into the previous patch. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/48] hpsa: correct change_queue_depth

2015-01-15 Thread Christoph Hellwig
On Wed, Jan 14, 2015 at 04:00:00PM -0600, Don Brace wrote: scsi_adjust_queue_depth was changed to scsi_change_queue_depth That's not a very good dscription.. +static int hpsa_change_queue_depth(struct scsi_device *sdev, int qdepth) +{ + struct ctlr_info *h = sdev_to_hba(sdev); + +

Re: [PATCH] scsi: Avoid crashing if device uses DIX but adapter does not support it

2015-01-15 Thread Ewan Milne
On Wed, 2015-01-14 at 20:18 -0500, Martin K. Petersen wrote: Ewan == Ewan D Milne emi...@redhat.com writes: Ewan This can happen if a multipathed device uses DIX and another path Ewan is added via an adapter that does not support it. Multipath Ewan should not allow this path to be added,

Re: [PATCH v6 1/4] phy: qcom-ufs: add support for 20nm phy

2015-01-15 Thread ygardi
Hi, On Sunday 11 January 2015 06:08 PM, Yaniv Gardi wrote: This change adds a support for a 20nm qcom-ufs phy that is required in platforms that use ufs-qcom controller. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/phy/Kconfig | 7 +

[PATCH 1/2] csiostor:Remove T4 FCoE support.

2015-01-15 Thread Praveen Madhavan
This patch removes FCoE support for chelsio T4 adapters. and claims only physical function 6 for chelsio T5 adapters. Signed-off-by: Praveen Madhavan prave...@chelsio.com --- drivers/scsi/csiostor/csio_hw.c | 61 +--- drivers/scsi/csiostor/csio_hw_chip.h | 43

[PATCH 0/2] Remove T4 FCoE support

2015-01-15 Thread Praveen Madhavan
These patches removes FCoE support for chelsio T4 adapter. Please apply on net-next since depends on previous commits. Praveen Madhavan (2): csiostor:Remove T4 FCoE support. csiostor:Removed file csio_hw_t4.c drivers/scsi/csiostor/Makefile | 2 +- drivers/scsi/csiostor/csio_hw.c

[PATCH 2/2] csiostor:Removed file csio_hw_t4.c

2015-01-15 Thread Praveen Madhavan
Signed-off-by: Praveen Madhavan prave...@chelsio.com --- drivers/scsi/csiostor/Makefile | 2 +- drivers/scsi/csiostor/csio_hw_t4.c | 404 - 2 files changed, 1 insertion(+), 405 deletions(-) delete mode 100644 drivers/scsi/csiostor/csio_hw_t4.c diff

Re: [PATCH 0/2] Remove T4 FCoE support

2015-01-15 Thread Hannes Reinecke
On 01/15/2015 02:45 PM, Praveen Madhavan wrote: These patches removes FCoE support for chelsio T4 adapter. Please apply on net-next since depends on previous commits. Praveen Madhavan (2): csiostor:Remove T4 FCoE support. csiostor:Removed file csio_hw_t4.c

[PATCH v7 0/5] phy: qcom-ufs: add support for QUALCOMM

2015-01-15 Thread Yaniv Gardi
Changes from V6: - change#1 in the V6 series: 0001-phy-qcom-ufs-add-support-for-20nm-phy has been divided into 2 patches: A: phy: qcom-ufs: add support for QUALCOMM Technologies UFS PHY drivers B: phy: qcom-ufs: add support for 20nm phy in order to seperate the common code of the Qualcomm

[PATCH v7 5/5] scsi: ufs-qcom-ice: add Inline Crypto Engine (ICE) support for UFS

2015-01-15 Thread Yaniv Gardi
From: Yaniv Gardi yga...@qti.qualcomm.com In-order to enhance storage encryption performance, an Inline Cryptographic Engine is introduced to UFS. This patch adds in-line encryption capabilities to the UFS driver. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/scsi/ufs/Kconfig

[PATCH v7 3/5] scsi: ufs-qcom: add support for Qualcomm Technologies Inc platforms

2015-01-15 Thread Yaniv Gardi
This change adds support for Qualcomm Technologies Inc platforms that use UFS driver. for example, it adds : - PM specific operations during hibern8, suspend, resume, clock setup - qcom-ufs generic phy driver initialization, calibration, power-on/off sequence, etc. - UFS Controller specific

[PATCH v7 2/5] phy: qcom-ufs: add support for 20nm phy

2015-01-15 Thread Yaniv Gardi
This change adds a support for a 20nm qcom-ufs phy that is required in platforms that use ufs-qcom controller. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/phy/Makefile| 1 + drivers/phy/phy-qcom-ufs-i.h| 43 +- drivers/phy/phy-qcom-ufs-qmp-20nm.c

[PATCH v7 1/5] phy: qcom-ufs: add support for QUALCOMM Technologies UFS PHY drivers

2015-01-15 Thread Yaniv Gardi
This change adds a generic and common API support for ufs phy QUALCOMM Technologies. This support provides common code and also points to specific phy callbacks to differentiate between different behaviors of frequent use-cases (like power on, power off, phy calibration etc). Signed-off-by: Yaniv

[PATCH v7 4/5] phy: qcom-ufs: add support for 14nm phy

2015-01-15 Thread Yaniv Gardi
This change adds a support for a 14nm qcom-ufs phy that is required in platforms that use ufs-qcom controller. Signed-off-by: Yaniv Gardi yga...@codeaurora.org --- drivers/phy/Makefile| 1 + drivers/phy/phy-qcom-ufs-qmp-14nm.c | 201

RE: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag

2015-01-15 Thread Minh Duc Tran
-Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Thursday, January 15, 2015 3:17 PM To: Minh Duc Tran; linux-scsi@vger.kernel.org Cc: Jayamohan Kallickal Subject: Re: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag On 01/12/2015 05:05 PM, Minh Duc Tran