Remove SCSI_BUF_PA, SCSI_SG_PA, AHA1542_SCATTER and AHA1542_CMDLUN macros
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c | 23 ++-
drivers/scsi/aha1542.h |2 --
2 files changed, 10 insertions(+), 15 deletions(-)
diff --git
Convert aha1542_intr_reset macro to inline function
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
index ebf54b5..2a6308f 100644
---
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.h | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers/scsi/aha1542.h b/drivers/scsi/aha1542.h
index f0b862b..1333a23 100644
--- a/drivers/scsi/aha1542.h
This (incomplete) patch series updates aha1542 driver to not use deprecated
initialization, removes dead code, ugly macros and simplifies the code.
It's probably not checkpatch-clean yet.
aha1542.c | 984 ++
aha1542.h | 99 ++
2
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c | 51 +++-
drivers/scsi/aha1542.h | 12
2 files changed, 24 insertions(+), 39 deletions(-)
diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
Remove gotos that are no longer needed.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c | 58
1 file changed, 19 insertions(+), 39 deletions(-)
diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
index
Unify aha1542_in and aha1542_in1 functions, they differ only in timeout
and printk.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c | 33 +++--
1 file changed, 7 insertions(+), 26 deletions(-)
diff --git a/drivers/scsi/aha1542.c
James Bottomley james.bottom...@hansenpartnership.com writes:
On Mon, 2015-01-19 at 16:21 +1030, Rusty Russell wrote:
Masami Hiramatsu masami.hiramatsu...@hitachi.com writes:
(2015/01/19 1:55), James Bottomley wrote:
From: James Bottomley jbottom...@parallels.com
After e513cc1 module:
Ewan == Ewan D Milne emi...@redhat.com writes:
Ewan This can happen if a multipathed device uses DIX and another path
Ewan is added via an adapter that does not support it. Multipath
Ewan should not allow this path to be added, but we should not depend
Ewan upon that to avoid crashing.
(2015/01/20 9:45), Rusty Russell wrote:
James Bottomley james.bottom...@hansenpartnership.com writes:
On Mon, 2015-01-19 at 16:21 +1030, Rusty Russell wrote:
Masami Hiramatsu masami.hiramatsu...@hitachi.com writes:
(2015/01/19 1:55), James Bottomley wrote:
From: James Bottomley
aha1542_out are in fact two separate functions.
Split them into aha1542_out and aha1542_outb to simplify the code.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c | 75 ++--
1 file changed, 35 insertions(+), 40
Convert the ugly WAIT and WAITd macros into wait_mask function.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c | 104 ++--
1 file changed, 57 insertions(+), 47 deletions(-)
diff --git a/drivers/scsi/aha1542.c
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c | 50
drivers/scsi/aha1542.h | 42
2 files changed, 46 insertions(+), 46 deletions(-)
diff --git a/drivers/scsi/aha1542.c
Convert aha1542 to use scsi_add_host instead of scsi_module.c
Use pnp_driver and isa_driver to manage cards.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c | 300 +++-
drivers/scsi/aha1542.h |2 +-
2 files
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
index af1e8fa..ebc5476 100644
--- a/drivers/scsi/aha1542.c
+++
Remove dead code.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/aha1542.c | 243 +---
drivers/scsi/aha1542.h |6 --
2 files changed, 1 insertion(+), 248 deletions(-)
diff --git a/drivers/scsi/aha1542.c
On Mon, 19 Jan 2015, Alan Stern wrote:
Are you certain the patch had been applied to the kernel you were testing?
Yeah, I definitely remember the result of git status having the patch
ready for commit at the time of build. I'll test it again later tonight.
Maybe you can add a printk statement
On Mon, Jan 19, 2015 at 04:21:15PM +1030, Rusty Russell wrote:
The first one I think should be eliminated, and the second one is simply
an assertion before calling module_put() (which should probably be
eliminated). The others are just printing information.
FYI, I've got a pathcset to
On Fri, Jan 16, 2015 at 11:31:29PM +0100, Ondrej Zary wrote:
Convert aha1542 to use scsi_add_host instead of scsi_module.c
Use pnp_driver and isa_driver to manage cards.
I hope that the PnP code is OK, don't have a PnP card to test.
The code needs much more work, there's a lot of things to
On Mon, Jan 19, 2015 at 12:05:58AM +0900, Akinobu Mita wrote:
While accessing a scsi_device, the use count of the underlying LLDD
module is incremented. The module reference is retrieved through
.module field of struct scsi_host_template.
This mapping between scsi_device and underlying LLDD
On Thu, Jan 15, 2015 at 05:13:00PM +0100, Bart Van Assche wrote:
My goal is to realize this proposal without adding hooks for out-of-tree
code in the upstream kernel. What I had in mind is to raise the
abstraction level of the API between LIO core and target drivers a
little bit (e.g. by using
On 01/19/15 10:22, Christoph Hellwig wrote:
On Thu, Jan 15, 2015 at 05:13:00PM +0100, Bart Van Assche wrote:
My goal is to realize this proposal without adding hooks for out-of-tree
code in the upstream kernel. What I had in mind is to raise the
abstraction level of the API between LIO core
Jeg vil foreslå relasjoner som er av felles interesse. Det er overføring
av en stor sum penger.Jeg skriver til deg fordi du har blitt anbefalt til
meg som en som kan være egnet for mitt prosjekt.
Ta kontakt med meg på min personlige e-postadresse; en rask respons, ville
jeg stor pris på det.
Med
If hba_setup_cid_tbls() fails then this code should return an error code
but instead the current code returns zero (success).
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index f319340..fe59ae6 100644
---
On Mon, 2015-01-19 at 00:28 -0800, Christoph Hellwig wrote:
On Mon, Jan 19, 2015 at 04:21:15PM +1030, Rusty Russell wrote:
The first one I think should be eliminated, and the second one is simply
an assertion before calling module_put() (which should probably be
eliminated). The others are
On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote:
The midlayer logging already prints the cdb details if the logging
level is high enough, no need to duplicate this in the ch driver.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/ch.c | 8
1 file changed,
On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote:
The midlayer scsi logging already logs the command and sense code
if the logging level is high enough, no need to duplicate that
in the sr driver.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/sr_ioctl.c | 18
On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig h...@lst.de
---
include/scsi/scsi_device.h | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index
On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/scsi_logging.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/scsi_logging.c b/drivers/scsi/scsi_logging.c
index
On Mon, 2015-01-19 at 16:21 +1030, Rusty Russell wrote:
Masami Hiramatsu masami.hiramatsu...@hitachi.com writes:
(2015/01/19 1:55), James Bottomley wrote:
From: James Bottomley jbottom...@parallels.com
After e513cc1 module: Remove stop_machine from module unloading,
module_refcount()
If device_add() fails then it should return the error code but instead
the current code returns success.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index ebf35cb6..75a0b55 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@
On Mon, 19 Jan 2015, Kenneth R. Crudup wrote:
Sorry for taking so long to get back to you guys about this (the 3.19-rc
series has been
problematic for me in a couple of areas, so I'd let it go for a while):
On Mon, 5 Jan 2015, Alan Stern wrote:
The patch I posted sets a general limit
If kthread_create() fails then this should return an error code but the
current code returns zero instead.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
index 3e6b866..586f72b 100644
--- a/drivers/scsi/mvumi.c
+++
We should only try to evaluate the cdb if this is an ATAPI
device, for any other device the 'cdb' field and the cdb_len
has no meaning.
Fixes: cbba5b0ee4c6c2fc8b78a21d0900099d480cf2e9
Reported-by: Sergey Senozhatsky sergey.senozhat...@gmail.com
Signed-off-by: Hannes Reinecke h...@suse.de
Sorry for taking so long to get back to you guys about this (the 3.19-rc series
has been
problematic for me in a couple of areas, so I'd let it go for a while):
On Mon, 5 Jan 2015, Alan Stern wrote:
The patch I posted sets a general limit of 32 MB for USB drives that
don't have a quirk flag
Michael,
are you fine with this version?
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Friday, January 16, 2015 4:35 PM
To: Minh Duc Tran
Cc: linux-scsi@vger.kernel.org; Jayamohan Kallickal
Subject: Re: [PATCH v2 1/1] be2iscsi: add block valid bit to iBFT flag
On 01/16/2015 01:44 PM, Minh Duc Tran wrote:
From: Michael
From: Praveen Madhavan prave...@chelsio.com
Date: Fri, 16 Jan 2015 21:30:18 +0530
We found a subtle issue with FCoE on T4 very late in the game
and decided not to productize FCoE on T4 and therefore there
are no customers that will be impacted by this change. FCoE is
supported on T5 cards.
38 matches
Mail list logo
