Re: OOPS: unplugging western digital passport drive

2015-06-17 Thread Alan Stern
Joe or Stanisナ^ツaw: I never heard anything back about this. Does the patch fix the crash? Alan Stern On Wed, 18 Mar 2015, Alan Stern wrote: On Wed, 18 Mar 2015, Alan Stern wrote: On Tue, 17 Mar 2015, Joe Lawrence wrote: On 03/11/2015 12:25 AM, StanisÅ‚aw Pitucha wrote: Hi

Re: [RFC PATCH 1/2] lpfc: add target infrastructure

2015-06-17 Thread Sebastian Herbszt
Hannes Reinecke wrote: On 06/14/2015 05:20 PM, Sebastian Herbszt wrote: Add target infrastructure. Signed-off-by: Sebastian Herbszt herb...@gmx.de --- Hmm. And that hooks into _which_ target mode infrastructure? Currently it is SCST with the lpfc_scst module. I still need to figure out

Re: [PATCH 1/1] scsi: use kzalloc for allocating one thing

2015-06-17 Thread Hannes Reinecke
On 06/18/2015 06:36 AM, Maninder Singh wrote: Use kzalloc rather than kcalloc(1,...) for allocating one thing Signed-off-by: Maninder Singh maninder...@samsung.com Reviewed-by: Vaneet Narang v.nar...@samsung.com --- drivers/scsi/mvsas/mv_init.c |2 +- 1 files changed, 1 insertions(+),

[for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-06-17 Thread Dan Williams
Praveen reports: After some debugging this is what I have found sas_phye_loss_of_signal gets triggered on phy_event from mvsas sas_phye_loss_of_signal calls sas_deform_port sas_deform_port posts a DISCE_DESTRUCT event (sas_unregister_domain_devices-

[PATCH 1/1] scsi: use kzalloc for allocating one thing

2015-06-17 Thread Maninder Singh
Use kzalloc rather than kcalloc(1,...) for allocating one thing Signed-off-by: Maninder Singh maninder...@samsung.com Reviewed-by: Vaneet Narang v.nar...@samsung.com --- drivers/scsi/mvsas/mv_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 1/1] scsi: Initialize sdp after NULL check of cmnd

2015-06-17 Thread Maninder Singh
Currently cmnd pointer is already dereferenced before NULL check and thus getting below warning in static analysis: warn: variable dereferenced before check 'cmnd' So initialize struct scsi_device *sdp after NULL check of cmnd Signed-off-by: Maninder Singh maninder...@samsung.com Reviewed-by:

Re: [PATCH v1 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-17 Thread Tomas Henzl
On 06/17/2015 11:10 AM, Sreekanth Reddy wrote: Driver initialization fails if driver tries to send IOC facts request message when the IOC is in reset or in a fault state. This patch will make sure that 1.Driver to send IOC facts request message only if HBA is in operational or ready

Re: [PATCH 1/1] scsi: Initialize sdp after NULL check of cmnd

2015-06-17 Thread Johannes Thumshirn
On Wed, Jun 17, 2015 at 04:51:07PM +0530, Maninder Singh wrote: Currently cmnd pointer is already dereferenced before NULL check and thus getting below warning in static analysis: warn: variable dereferenced before check 'cmnd' So initialize struct scsi_device *sdp after NULL check of cmnd

Re: [RFC PATCH 1/2] lpfc: add target infrastructure

2015-06-17 Thread Hannes Reinecke
On 06/14/2015 05:20 PM, Sebastian Herbszt wrote: Add target infrastructure. Signed-off-by: Sebastian Herbszt herb...@gmx.de --- Hmm. And that hooks into _which_ target mode infrastructure? Cheers, Hannes -- Dr. Hannes ReineckezSeries Storage h...@suse.de

Re: [PATCH 3/6] target: use 'se_dev_entry' when allocating UAs

2015-06-17 Thread Hannes Reinecke
On 06/17/2015 08:06 AM, Nicholas A. Bellinger wrote: Hey Hannes, Apologies for the delayed follow-up on these, one comment below. On Thu, 2015-06-11 at 10:01 +0200, Hannes Reinecke wrote: We need to use 'se_dev_entry' as argument when allocating UAs, otherwise we'll never see any UAs for

Re: [PATCH] mpt2sas: setpci reset kernel panic fix

2015-06-17 Thread Johannes Thumshirn
On Wed, Jun 17, 2015 at 11:37:53AM +0530, Nagarajkumar Narayanan wrote: Problem Description: https://bugzilla.kernel.org/show_bug.cgi?id=95101 Due to lack of synchronization between ioctl, BRM status access, pci resource removal kernel oops happen as ioctl path and BRM status access path

[PATCH] mpt2sas: setpci reset kernel panic fix

2015-06-17 Thread Nagarajkumar Narayanan
Problem Description: https://bugzilla.kernel.org/show_bug.cgi?id=95101 Due to lack of synchronization between ioctl, BRM status access, pci resource removal kernel oops happen as ioctl path and BRM status access path still tries to access the removed resources kernel: BUG: unable to handle

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

2015-06-17 Thread Dov Levenglick
On Tue, Jun 9, 2015 at 12:53 AM, Dov Levenglick d...@codeaurora.org wrote: On Sun, Jun 7, 2015 at 10:32 AM, yga...@codeaurora.org wrote: 2015-06-05 5:53 GMT+09:00 yga...@codeaurora.org: [...] If ufshcd-pltfrm driver is loaded before ufs-qcom, (what actually happens always), then the

Re: [PATCH 0/6] target: Update UA handling

2015-06-17 Thread Nicholas A. Bellinger
On Thu, 2015-06-11 at 10:01 +0200, Hannes Reinecke wrote: Hi Nic, lio-target is very minimalistic when it comes to generate UAs; primarily they are generated for persistent reservations, but generic changes tend to be ignored. This patchset updates the UA handling and generates UA for

Re: [PATCH 0/6] target: Update UA handling

2015-06-17 Thread Nicholas A. Bellinger
On Wed, 2015-06-17 at 08:25 +0200, Hannes Reinecke wrote: On 06/17/2015 08:10 AM, Nicholas A. Bellinger wrote: On Thu, 2015-06-11 at 10:01 +0200, Hannes Reinecke wrote: Hi Nic, lio-target is very minimalistic when it comes to generate UAs; primarily they are generated for persistent

[PATCH v1 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-17 Thread Sreekanth Reddy
Driver initialization fails if driver tries to send IOC facts request message when the IOC is in reset or in a fault state. This patch will make sure that 1.Driver to send IOC facts request message only if HBA is in operational or ready state. 2.If IOC is in fault state, a diagnostic reset

[PATCH] cxgb4i: Fix neigh entry leak

2015-06-17 Thread Ying Xue
When csk-atid returned by cxgb4_alloc_atid() is less than zero, init_act_open() directly returns with -EINVAL. But as init_act_open() ever invokes dst_neigh_lookup() before it calls cxgb4_alloc_atid(), this leads to the leak of neigh entry searched by dst_neigh_lookup(). Signed-off-by: Ying Xue

Re: [PATCH 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-17 Thread Sreekanth Reddy
On Tue, Jun 16, 2015 at 9:29 PM, Tomas Henzl the...@redhat.com wrote: On 06/12/2015 11:42 AM, Sreekanth Reddy wrote: Driver initialization fails if driver tries to send IOC facts request message when the IOC is in reset or in a fault state. This patch will make sure that 1.Driver to send

Re: optimal io size / custom alignment

2015-06-17 Thread Tom Yan
On 17 June 2015 at 05:28, Martin K. Petersen martin.peter...@oracle.com wrote: There are plenty of SSDs that report 4K physical sectors, fwiw. Oh didn't know that. Wonder if it's yet another garbage info. Though 4k is often a nice value to make use of. We gave up on USB-SATA bridges long ago.

Re: [PATCH 1/1] [PATCH] block: Add blk_max_rw_sectors limit

2015-06-17 Thread Christoph Hellwig
On Tue, Jun 16, 2015 at 06:46:14PM -0400, Martin K. Petersen wrote: Brian, I only have minor nits wrt. your patch since you did what I asked. However, now that I'm less jet lagged and blurry eyed I wonder if the tweak below wouldn't suffice? This would be my preferred version as well. --

Re: [PATCH 1/1] [PATCH] block: Add blk_max_rw_sectors limit

2015-06-17 Thread Brian King
On 06/16/2015 05:46 PM, Martin K. Petersen wrote: Brian, I only have minor nits wrt. your patch since you did what I asked. However, now that I'm less jet lagged and blurry eyed I wonder if the tweak below wouldn't suffice? Works for me. Thanks! Tested-by: Brian King

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

2015-06-17 Thread Rob Herring
On Wed, Jun 17, 2015 at 2:42 AM, Dov Levenglick d...@codeaurora.org wrote: On Tue, Jun 9, 2015 at 12:53 AM, Dov Levenglick d...@codeaurora.org wrote: On Sun, Jun 7, 2015 at 10:32 AM, yga...@codeaurora.org wrote: 2015-06-05 5:53 GMT+09:00 yga...@codeaurora.org: [...] If ufshcd-pltfrm

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

2015-06-17 Thread Dov Levenglick
On Wed, Jun 17, 2015 at 2:42 AM, Dov Levenglick d...@codeaurora.org wrote: On Tue, Jun 9, 2015 at 12:53 AM, Dov Levenglick d...@codeaurora.org wrote: On Sun, Jun 7, 2015 at 10:32 AM, yga...@codeaurora.org wrote: 2015-06-05 5:53 GMT+09:00 yga...@codeaurora.org: [...] If ufshcd-pltfrm

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

2015-06-17 Thread Rob Herring
On Wed, Jun 17, 2015 at 8:17 AM, Dov Levenglick d...@codeaurora.org wrote: On Wed, Jun 17, 2015 at 2:42 AM, Dov Levenglick d...@codeaurora.org wrote: On Tue, Jun 9, 2015 at 12:53 AM, Dov Levenglick d...@codeaurora.org wrote: On Sun, Jun 7, 2015 at 10:32 AM, yga...@codeaurora.org wrote:

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

2015-06-17 Thread James Bottomley
On Wed, 2015-06-17 at 14:21 +, Dov Levenglick wrote: Hi James, Rob raises a point that we don't agree with. On the other hand, we are not capable of convincing him in the validity of our approach - we are at an impasse. I would like to point out that our approach was reviewed by Paul and

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

2015-06-17 Thread Dov Levenglick
Hi James, Rob raises a point that we don't agree with. On the other hand, we are not capable of convincing him in the validity of our approach - we are at an impasse. I would like to point out that our approach was reviewed by Paul and Mita (external reviewers) and neither of them had the

Re: [PATCH] iSCSI: let session recovery_tmo sysfs writes persist across recovery

2015-06-17 Thread Mike Christie
On 06/16/2015 06:07 PM, Chris Leech wrote: The iSCSI session recovery_tmo setting is writeable in sysfs, but it's also set every time a connection is established when parameters are set from iscsid over netlink. That results in the timeout being reset to the default value after every

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

2015-06-17 Thread Dov Levenglick
On Wed, 2015-06-17 at 14:21 +, Dov Levenglick wrote: Hi James, Rob raises a point that we don't agree with. On the other hand, we are not capable of convincing him in the validity of our approach - we are at an impasse. I would like to point out that our approach was reviewed by Paul

Re: [PATCH 3/6] target: use 'se_dev_entry' when allocating UAs

2015-06-17 Thread Nicholas A. Bellinger
Hey Hannes, Apologies for the delayed follow-up on these, one comment below. On Thu, 2015-06-11 at 10:01 +0200, Hannes Reinecke wrote: We need to use 'se_dev_entry' as argument when allocating UAs, otherwise we'll never see any UAs for an implicit ALUA state transition triggered from

Re: [PATCH 0/6] target: Update UA handling

2015-06-17 Thread Hannes Reinecke
On 06/17/2015 08:10 AM, Nicholas A. Bellinger wrote: On Thu, 2015-06-11 at 10:01 +0200, Hannes Reinecke wrote: Hi Nic, lio-target is very minimalistic when it comes to generate UAs; primarily they are generated for persistent reservations, but generic changes tend to be ignored. This

Re: [PATCH] iSCSI: let session recovery_tmo sysfs writes persist across recovery

2015-06-17 Thread Chris Leech
On Wed, Jun 17, 2015 at 09:33:04AM -0500, Mike Christie wrote: On 06/16/2015 06:07 PM, Chris Leech wrote: The iSCSI session recovery_tmo setting is writeable in sysfs, but it's also set every time a connection is established when parameters are set from iscsid over netlink. That results in

Re: [PATCH] iSCSI: let session recovery_tmo sysfs writes persist across recovery

2015-06-17 Thread Mike Christie
On 06/16/2015 06:07 PM, Chris Leech wrote: The iSCSI session recovery_tmo setting is writeable in sysfs, but it's also set every time a connection is established when parameters are set from iscsid over netlink. That results in the timeout being reset to the default value after every