[PATCH v2] scsi: gdth: replace struct timeval with ktime_get_real_seconds()

struct timeval will overflow on 32-bit systems in y2038 and is being removed from the kernel. Replace the use of struct timeval and do_gettimeofday() with ktime_get_real_seconds() which provides a 64-bit seconds value and is y2038 safe. gdth driver requires changes in two areas: 1)

Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

On Tue, 24 Nov 2015, Ondrej Zary wrote: > On Tuesday 24 November 2015 10:13:17 Finn Thain wrote: > > > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > > > On Tuesday 24 November 2015, Finn Thain wrote: > > > > > > > > On Mon, 23 Nov 2015, Ondrej Zary wrote: > > > > > > > > > > > > > > PDMA

Re: [PATCH 0/2] arcmsr: support areca new adapter ARC1203

On Tue, 2015-11-24 at 16:07 +0100, Hannes Reinecke wrote: > On 11/24/2015 09:00 AM, Ching Huang wrote: > > From: Ching Huang > > > > Patch 1 fixes getting wrong configuration data. > > > > Pacth 2 adds codes to support new adapter ARC1203. > > Patch 3 changes driver

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

On Tue, 24 Nov 2015, Ondrej Zary wrote: > On Wednesday 18 November 2015 09:35:17 Finn Thain wrote: > > Linux v2.1.105 changed the algorithm for polling for the BSY signal > > in NCR5380_select() and NCR5380_main(). > > > > Presently, this code has a bug. Back then, NCR5380_set_timer(hostdata,

[PATCH v2 0/3] arcmsr: support areca new adapter ARC1203

From: Ching Huang Patch 1 fixes getting wrong configuration data. Pacth 2 adds codes to support new adapter ARC1203. Patch 3 changes driver version number. -- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

[PATCH v2 1/3] arcmsr: fixed getting wrong configuration data

From: Ching Huang Fixed getting wrong configuration data of adapter type B and type D. Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

From: Ching Huang Support areca new PCIe to SATA RAID adapter ARC1203 Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 10:52:16.28647

[PATCH v2 3/3] arcmsr: changes driver version number

From: Ching Huang Changes driver version number. Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 10:52:13.33447 +0800 +++

Re: [PATCH 2/9] IB: add a proper completion queue abstraction

On Tue, Nov 24, 2015 at 06:47:14PM -0800, Caitlin Bestler wrote: > Acknowledge packet for the last packet of the request has been > committed to the wire (including the appropriate fields for RDMA > READ response). > The target side cannot generate a response before it

Re: [PATCH] Fix a bdi reregistration race, v2

On 11/24/2015 03:13 PM, Christoph Hellwig wrote: What sort of re-registration is this? Seems like we should only release the minor number once the bdi is released. Hello Christoph, As you most likely know the BDI device name for disks is based on the device major and minor number: $ ls -l

Re: [PATCH V2] st: fix potential null pointer dereference.

> On 18.11.2015, at 16.32, Maurizio Lombardi wrote: > > If cdev_add() returns an error, the code calls > cdev_del() passing the STm->cdevs[rew] pointer as parameter; > the problem is that the pointer has not been initialized yet. > > This patch fixes the problem by moving

Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions

> "Doug" == Douglas Gilbert writes: Doug> Ruediger Meier observed a regression with the PREVENT ALLOW MEDIUM Doug> REMOVAL command in lk 3.19: Doug> http://www.spinics.net/lists/util-linux-ng/msg11448.html Applied to 4.4. -- Martin K. Petersen Oracle Linux

Re: [PATCH 2/3] block: Add badblock management for gendisks

On Tue, Nov 24, 2015 at 12:10 PM, Verma, Vishal L wrote: > On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: >> >> I'm not sure whether it makes sense to continue without badblock >> management for the RAID code. I was hoping Neil would comment on >> that. >> >>

Re: [PATCH 2/3] block: Add badblock management for gendisks

On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: > > I'm not sure whether it makes sense to continue without badblock > management for the RAID code.  I was hoping Neil would comment on > that. > > -Jeff Not sure I follow? I believe I've kept all the badblocks functionality RAID already

Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

On Tuesday 24 November 2015 10:13:17 Finn Thain wrote: > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > On Tuesday 24 November 2015, Finn Thain wrote: > > > > > > On Mon, 23 Nov 2015, Ondrej Zary wrote: > > > > > > > > > > > PDMA seems to be broken in multiple ways. NCR5380_pread cannot > >

Re: [PATCH v2 1/3] arcmsr: fixed getting wrong configuration data

On 11/25/2015 04:21 AM, Ching Huang wrote: > From: Ching Huang > > Fixed getting wrong configuration data of adapter type B and type D. > > Signed-of-by: Ching Huang > > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr.

Re: [PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

On 11/25/2015 04:25 AM, Ching Huang wrote: > From: Ching Huang > > Support areca new PCIe to SATA RAID adapter ARC1203 > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h > ---

Re: [PATCH v2 3/3] arcmsr: changes driver version number

On 11/25/2015 04:40 AM, Ching Huang wrote: > From: Ching Huang > > Changes driver version number. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h > ---

Re: [PATCH 2/9] IB: add a proper completion queue abstraction

On Tue, Nov 24, 2015 at 10:08:39AM -0700, c...@asomi.com wrote: >>> My recollection of the IB verbs is that they were unlikely to have >>> overlooked something like that. If it did slip through then there >>> should be an errata. >>verbs reflects the wire protocol and the wire

[PATCH] qla2xxx: Fix regression introduced by configFS changes

this patch fixes following regression # targetcli [Errno 13] Permission denied: '/sys/kernel/config/target/qla2xxx/21:00:00:0e:1e:08:c7:20/tpgt_1/enable' Fixes: 2eafd72939fd ("target: use per-attribute show and store methods") Signed-off-by: Himanshu Madhani

Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

On Tuesday 24 November 2015 13:03:17 Ondrej Zary wrote: > On Tuesday 24 November 2015, Finn Thain wrote: > > > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > > > On Tuesday 24 November 2015, Finn Thain wrote: > > > > > > > > On Mon, 23 Nov 2015, Ondrej Zary wrote: > > > > > > > > > > > > > >

Re: [PATCH 2/3] block: Add badblock management for gendisks

On Tue, 2015-11-24 at 10:34 -0500, Jeff Moyer wrote: > Vishal Verma writes: > > > NVDIMM devices, which can behave more like DRAM rather than block > > devices, may develop bad cache lines, or 'poison'. A block device > > exposed by the pmem driver can then consume

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

On Wednesday 18 November 2015 09:35:17 Finn Thain wrote: > Linux v2.1.105 changed the algorithm for polling for the BSY signal > in NCR5380_select() and NCR5380_main(). > > Presently, this code has a bug. Back then, NCR5380_set_timer(hostdata, 1) > meant reschedule main() after sleeping for 10

Re: [PATCH 2/3] block: Add badblock management for gendisks

"Verma, Vishal L" writes: > On Tue, 2015-11-24 at 10:34 -0500, Jeff Moyer wrote: >> Vishal Verma writes: >> >> > NVDIMM devices, which can behave more like DRAM rather than block >> > devices, may develop bad cache lines, or 'poison'. A block

Re: [PATCH 1/3] badblocks: Add core badblock management code

On 11/20/2015 05:49 PM, Vishal Verma wrote: Take the core badblocks implementation from md, and make it generally available. This follows the same style as kernel implementations of linked lists, rb-trees etc, where you can have a structure that can be embedded anywhere, and accessor functions

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On 11/23/2015 10:21 AM, Ming Lei wrote: On Mon, 23 Nov 2015 10:46:20 +0800 Ming Lei wrote: Hi Mark, On Mon, Nov 23, 2015 at 9:50 AM, Mark Salter wrote: On Mon, 2015-11-23 at 08:36 +0800, Ming Lei wrote: On Mon, Nov 23, 2015 at 7:20 AM, Mark

Re: [PATCH] qla2xxx: Fix regression introduced by configFS changes

Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] arcmsr: support areca new adapter ARC1203

From: Ching Huang Patch 1 fixes getting wrong configuration data. Pacth 2 adds codes to support new adapter ARC1203. -- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

On Tuesday 24 November 2015, Finn Thain wrote: > > On Mon, 23 Nov 2015, Ondrej Zary wrote: > > > > > PDMA seems to be broken in multiple ways. NCR5380_pread cannot process > > less than 128 bytes. In fact, 53C400 datasheet says that it's HW > > limitation: non-modulo-128-byte transfers should

[PATCH 1/2] arcmsr: fixed getting wrong configuration data

From: Ching Huang Fixed getting wrong configuration data of adapter type B and type D. Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-23

[PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203

From: Ching Huang Support areca new PCIe to SATA RAID adapter ARC1203 Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-24 11:36:20.0

Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

On Tue, 24 Nov 2015, Ondrej Zary wrote: > On Tuesday 24 November 2015, Finn Thain wrote: > > > > On Mon, 23 Nov 2015, Ondrej Zary wrote: > > > > > > > > PDMA seems to be broken in multiple ways. NCR5380_pread cannot > > > process less than 128 bytes. In fact, 53C400 datasheet says that > >

Re: [PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203

On Tue, 2015-11-24 at 16:17 +0800, Ching Huang wrote: > From: Ching Huang > > Support areca new PCIe to SATA RAID adapter ARC1203 Why add the dma_free_coherent to an old data path? Is that a general bug fix that should be backported? btw: the printk above the

Re: [PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203

On Tue, 2015-11-24 at 17:53 +0800, Ching Huang wrote: > On Tue, 2015-11-24 at 01:33 -0800, Joe Perches wrote: > > On Tue, 2015-11-24 at 16:17 +0800, Ching Huang wrote: > > > From: Ching Huang > > > > > > Support areca new PCIe to SATA RAID adapter ARC1203 > > > > Why add

[PATCH v2 2/3] scsi: move Additional Sense Codes to separate file

This is a purely mechanical move of the list of additional sense codes to a separate file, in preparation for reducing the impact of choosing CONFIG_SCSI_CONSTANTS=y by about 8k. Signed-off-by: Rasmus Villemoes --- drivers/scsi/constants.c | 830

[PATCH v2 0/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

This reduces the impact of choosing CONFIG_SCSI_CONSTANTS by about 8KB. 2dd951ecd511 ("scsi: Conditionally compile in constants.c") updated the Kconfig help text from 12KB to 75KB. The 12K predated git so was certainly outdated. But I'm not sure where the 75K comes from; using size(1) on a

[PATCH v2 1/3] scsi: make some Additional Sense strings more grep'able

There's little point in breaking these strings over multiple lines. Signed-off-by: Rasmus Villemoes --- drivers/scsi/constants.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/constants.c

[PATCH v2 3/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

On 64 bit, struct error_info has 6 bytes of padding, which amounts to over 4k of wasted space in the additional[] array. We could easily get rid of that by instead using separate arrays for the codes and the pointers. However, we can do even better than that and save an additional 6 bytes per

Re: [PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203

On Tue, 2015-11-24 at 01:33 -0800, Joe Perches wrote: > On Tue, 2015-11-24 at 16:17 +0800, Ching Huang wrote: > > From: Ching Huang > > > > Support areca new PCIe to SATA RAID adapter ARC1203 > > Why add the dma_free_coherent to an old data path? > Is that a general bug

Re: [PATCH] scsi: hisi_sas: remove dependency on of_irq_count

On Thu, Nov 19, 2015 at 6:23 AM, John Garry wrote: > Originally the driver would use of_irq_count to > calculate how much memory is required for storing the > interrupt names, since the number of interrupt sources > for the controller is variable. > Since of_irq_count

Re: [PATCH] Fix a memory leak in scsi_host_dev_release()

On 19/11/2015 00:56, Bart Van Assche wrote: Avoid that kmemleak reports the following memory leak if a SCSI LLD calls scsi_host_alloc() and scsi_host_put() but neither scsi_host_add() nor scsi_host_remove(). The following shell command triggers that scenario: Looks good, Reviewed-by: Sagi

Re: [PATCH] scsi: use sector_div instead of do_div

On 11/20/2015 05:38 PM, Arnd Bergmann wrote: > do_div is the wrong way to divide a sector_t, as it is less > efficient when sector_t is 32-bit wide. With the upcoming > do_div optimizations, the kernel starts warning about this: > > drivers/scsi/scsi_debug.c: In function 'dif_store': >

Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions

On 11/22/2015 06:11 PM, Douglas Gilbert wrote: > Ruediger Meier observed a regression with the PREVENT ALLOW > MEDIUM REMOVAL command in lk 3.19: > http://www.spinics.net/lists/util-linux-ng/msg11448.html > > Inspection indicated the same regression with VERIFY(10). > > The patch is against lk

Re: [PATCH 0/2] arcmsr: support areca new adapter ARC1203

On 11/24/2015 09:00 AM, Ching Huang wrote: > From: Ching Huang > > Patch 1 fixes getting wrong configuration data. > > Pacth 2 adds codes to support new adapter ARC1203. > Please split off the driver version update into a separate patch and add it as the last patch in

Re: [PATCH v2 0/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

On 11/24/2015 10:42 AM, Rasmus Villemoes wrote: > This reduces the impact of choosing CONFIG_SCSI_CONSTANTS by about 8KB. > > 2dd951ecd511 ("scsi: Conditionally compile in constants.c") updated > the Kconfig help text from 12KB to 75KB. The 12K predated git so was > certainly outdated. But I'm

Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions

On Sun, 2015-11-22 at 12:11 -0500, Douglas Gilbert wrote: > Ruediger Meier observed a regression with the PREVENT ALLOW > MEDIUM REMOVAL command in lk 3.19: >http://www.spinics.net/lists/util-linux-ng/msg11448.html > > Inspection indicated the same regression with VERIFY(10). > > The patch

Re: [PATCH 00/18] ALUA device handler update, part 1

On 11/23/2015 05:18 PM, Bart Van Assche wrote: > > > On 11/23/2015 08:10 AM, Hannes Reinecke wrote: >> On 11/20/2015 11:58 PM, Bart Van Assche wrote: [ .. ] >>> BTW, not all storage arrays need STPG retries. Some arrays are able >>> to process an STPG command quickly (this means within a few >>>

Re: [PATCH 01/18] scsi_dh: move 'dh_state' sysfs attribute to generic code

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > As scsi_dh.c is now always compiled in we should be moving > the 'dh_state' attribute to the generic code. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke > --- >  drivers/scsi/scsi_dh.c   

Re: [PATCH 17/18] scsi: Add scsi_vpd_tpg_id()

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Implement scsi_vpd_tpg_id() to extract the target > port group id and the relative port id from > SCSI VPD page 0x83. > > Signed-off-by: Hannes Reinecke > --- >  drivers/scsi/scsi_lib.c| 48 >

Re: [PATCH 18/18] scsi_dh_alua: use scsi_vpd_tpg_id()

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Signed-off-by: Hannes Reinecke > --- >  drivers/scsi/device_handler/scsi_dh_alua.c | 39 +--- > -- >  1 file changed, 6 insertions(+), 33 deletions(-) > > diff --git

Reviews, please

I spent last night cleaning up patchwork. Not entirely done yet but getting down to a manageable size: https://patchwork.kernel.org/project/linux-scsi/list/ These are 4.4 fixes that I'd like to get some more reviews for: scsi_debug: fix prevent_allow+verify regressions

Re: [PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203

On Tue, 2015-11-24 at 02:24 -0800, Joe Perches wrote: > On Tue, 2015-11-24 at 17:53 +0800, Ching Huang wrote: > > On Tue, 2015-11-24 at 01:33 -0800, Joe Perches wrote: > > > On Tue, 2015-11-24 at 16:17 +0800, Ching Huang wrote: > > > > From: Ching Huang > > > > > > > >

Re: [PATCH 16/18] scsi: export 'device_id' to sysfs

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Use scsi_vpd_lun_id() to export the device id to sysfs. > > Signed-off-by: Hannes Reinecke > --- >  drivers/scsi/scsi_sysfs.c | 17 + >  1 file changed, 17 insertions(+) > > diff --git

Re: [PATCH 15/18] scsi: Add scsi_vpd_lun_id()

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Add a function scsi_vpd_lun_id() to return a unique device > identifcation based on the designation descriptors of > VPD page 0x83. > > As devices might implement several descriptors the order > of preference is: > - NAA IEE Registered

Re: [PATCH 08/18] scsi_dh_alua: return standard SCSI return codes in submit_rtpg

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Fixup submit_rtpg() to always return a standard SCSI return code. > > Signed-off-by: Hannes Reinecke > --- >  drivers/scsi/device_handler/scsi_dh_alua.c | 33 +++- > -- >  1 file changed, 17

Re: [PATCH 11/18] scsi_dh_alua: use flag for RTPG extended header

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > We should be using a flag when RTPG extended header is not > supported, that saves us sending RTPG twice for older arrays. > > Reviewed-by: Bart Van Assche > Reviewed-by: Christoph Hellwig >

Re: [PATCH 09/18] scsi_dh_alua: fixup description of stpg_endio()

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Fixup copy-and-paste error in the description of stpg_endio(). > > Signed-off-by: Hannes Reinecke > Reviewed-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen > --- >  

Re: [PATCH 12/18] scsi_dh_alua: use unaligned access macros

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Use 'get_unaligned_XX' and 'put_unaligned_XX' instead of > open-coding it. > > Reviewed-by: Martin K. Petersen > Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke >

Re: [PATCH 14/18] scsi_dh_alua: simplify sense code handling

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Most sense code is already handled in the generic > code, so we shouldn't be adding special cases here. > However, when doing so we need to check for > unit attention whenever we're sending an internal > command. > > Reviewed-by: Ewan

Re: [PATCH 13/18] scsi_dh_alua: rework alua_check_tpgs() to return the tpgs mode

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Instead of returning an error code in alua_check_tpgs() we should > rather return the tpgs mode directly and have a cleaner syntax. > > Signed-off-by: Hannes Reinecke > --- >  drivers/scsi/device_handler/scsi_dh_alua.c |

Re: [PATCH 10/18] scsi: remove scsi_show_sense_hdr()

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Last caller is gone, so remove it. > > Reviewed-by: Bart Van Assche > Reviewed-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen > Signed-off-by: Hannes

Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

On Tuesday 24 November 2015, Finn Thain wrote: > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > On Tuesday 24 November 2015, Finn Thain wrote: > > > > > > On Mon, 23 Nov 2015, Ondrej Zary wrote: > > > > > > > > > > > PDMA seems to be broken in multiple ways. NCR5380_pread cannot > > > >

Re: [PATCH 05/18] scsi_dh_alua: improved logging

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Issue different logging messages if ALUA is not supported > or the TPGS setting is invalid. > > Reviewed-by: Martin K. Petersen > Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke

Re: [PATCH 04/18] scsi_dh_alua: Use vpd_pg83 information

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > The SCSI device now has the VPD page 0x83 information attached, > so there is no need to query it again. > > Reviewed-by: Martin K. Petersen > Reviewed-by: Christoph Hellwig > Signed-off-by:

Re: [PATCH 02/18] scsi: ignore errors from scsi_dh_add_device()

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > device handler initialisation might fail due to a number of > reasons. But as device_handlers are optional this shouldn't > cause us to disable the device entirely. > So just ignore errors from scsi_dh_add_device(). > > Signed-off-by:

Re: [PATCH 03/18] scsi_dh_alua: Disable ALUA handling for non-disk devices

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Non-disk devices might support ALUA, but the firmware > implementation is untested and frequently broken. > As we're don't actually need it disable ALUA support > for non-disk device for now. > > Signed-off-by: Hannes Reinecke

Re: [PATCH 07/18] scsi_dh_alua: use standard logging functions

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > Use standard logging functions instead of hand-crafted ones. > > Reviewed-by: Bart Van Assche > Signed-off-by: Hannes Reinecke > --- >  drivers/scsi/device_handler/scsi_dh_alua.c | 27

Re: [PATCH 06/18] scsi_dh_alua: sanitze sense code handling

On Mon, 2015-11-09 at 16:08 +0100, Hannes Reinecke wrote: > The only check for a valid sense code is calling > scsi_normalize_sense() > and check the return value. So drop the pointless checks and rely on > scsi_normalize_sense() to figure out if the sense code is valid. > With that we can also

Re: [PATCH 1/2] scsi_transport_fc: Introduce scsi_host_{get,put}()

On Fri, 2015-11-20 at 13:33 -0800, Bart Van Assche wrote: > Use scsi_host_{get,put}() instead of open-coding these functions. > Compile-tested only. > > Signed-off-by: Bart Van Assche > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc:

Re: [PATCH] scsi: use sector_div instead of do_div

On 20/11/2015 18:38, Arnd Bergmann wrote: do_div is the wrong way to divide a sector_t, as it is less efficient when sector_t is 32-bit wide. With the upcoming do_div optimizations, the kernel starts warning about this: drivers/scsi/scsi_debug.c: In function 'dif_store':

Re: [RFC PATCH scsi] aacraid: aac_release_resources() can be static

On Tue, 2015-11-10 at 13:59 +0800, kbuild test robot wrote: > Signed-off-by: Fengguang Wu > --- >  linit.c |2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/aacraid/linit.c > b/drivers/scsi/aacraid/linit.c > index 37375cf..7724583f

Re: [PATCH] Fix a memory leak in scsi_host_dev_release()

On Wed, 2015-11-18 at 14:56 -0800, Bart Van Assche wrote: > Avoid that kmemleak reports the following memory leak if a > SCSI LLD calls scsi_host_alloc() and scsi_host_put() but neither > scsi_host_add() nor scsi_host_remove(). The following shell > command triggers that scenario: > > for ((i=0;

Re: [PATCH 2/9] IB: add a proper completion queue abstraction

On 11/24/2015 2:03 AM, Jason Gunthorpe wrote: On Mon, Nov 23, 2015 at 06:35:28PM -0800, Caitlin Bestler wrote: Are there actual HCAs that make this mistake? All IB HCAs have this behavior and require apps to see a send CQ completion before making any statements about the state of the send Q

Re: [PATCH 3/3] MAINTAINERS: Add myself as co-maintainer of the SCSI subsystem.

On Fri, 2015-11-13 at 16:46 -0500, Martin K. Petersen wrote: > Signed-off-by: Martin K. Petersen > --- >  MAINTAINERS | 4 +++- >  1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9de185da5f5b..978df6e36ddf 100644 > ---

Re: [PATCH] scsi: use sector_div instead of do_div

On Fri, 2015-11-20 at 17:38 +0100, Arnd Bergmann wrote: > do_div is the wrong way to divide a sector_t, as it is less > efficient when sector_t is 32-bit wide. With the upcoming > do_div optimizations, the kernel starts warning about this: > > drivers/scsi/scsi_debug.c: In function 'dif_store': >

Re: [PATCH 1/3] sd: Make discard granularity match logical block size when LBPRZ=1

On Fri, 2015-11-13 at 16:46 -0500, Martin K. Petersen wrote: > A device may report an OPTIMAL UNMAP GRANULARITY and UNMAP > GRANULARITY > ALIGNMENT in the Block Limits VPD. These parameters describe the > device's internal provisioning allocation units. By default the block > layer will round and

RE: [RFC PATCH scsi] aacraid: aac_release_resources() can be static

Reviewed-by: Mahesh Rajashekhara -Original Message- From: kbuild test robot [mailto:fengguang...@intel.com] Sent: Tuesday, November 10, 2015 11:29 AM To: Mahesh Rajashekhara Cc: kbuild-...@01.org; linux-scsi@vger.kernel.org; James Bottomley; Tomas Henzl;

Re: [PATCH 2/3] block: Add badblock management for gendisks

Vishal Verma writes: > NVDIMM devices, which can behave more like DRAM rather than block > devices, may develop bad cache lines, or 'poison'. A block device > exposed by the pmem driver can then consume poison via a read (or > write), and cause a machine check. On