Re: [PATCH 2/3] block: Add badblock management for gendisks

"Verma, Vishal L" writes: > On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: >> >> I'm not sure whether it makes sense to continue without badblock >> management for the RAID code.  I was hoping Neil would comment on >> that. >> >> -Jeff > > Not sure I follow? I

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On 11/25/2015 02:04 AM, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ of time trying to debug things here, but none of the ideas I've come up with have

Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

On Wednesday 25 November 2015 10:04:10 Ondrej Zary wrote: > I think that PDMA should work with 53C400A too but seems that the driver was > never able to do it. > > Although there is code for port-mapped transfer in NCR5380_pread(), > NCR53C400_register_offset is defined to 0 in the port-mapped

Re: [PATCH] scsi: rescan VPD attributes

> "Hannes" == Hannes Reinecke writes: Hannes> The VPD page information might change, so we need to be able to Hannes> update it. This patch implements a VPD page rescan whenever the Hannes> 'rescan' sysfs attribute is triggered. I was looking into merging the ALUA series but

Re: [PATCH 0/2] Fix a scsi_host_dev_release() memory leak

> "Bart" == Bart Van Assche writes: Bart> This patch series consists of two patches: - A first patch that Bart> converts the code that accesses shost->shost_gendev to manipulate Bart> the shost reference count into scsi_host_{get,put}() calls. - A Bart> second

Re: [PATCH] scsi: use sector_div instead of do_div

> "Arnd" == Arnd Bergmann writes: Arnd> do_div is the wrong way to divide a sector_t, as it is less Arnd> efficient when sector_t is 32-bit wide. With the upcoming do_div Arnd> optimizations, the kernel starts warning about this: Applied. -- Martin K. Petersen Oracle

Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions

> "Andy" == Andy Shevchenko writes: Andy, Andy> but can you pay a little attention to Andy> http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems Andy> it wasn't applied. Please resubmit to linux-scsi. We'll take a look. -- Martin K. Petersen

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On Wed, Nov 25 2015 at 4:04am -0500, Hannes Reinecke wrote: > On 11/20/2015 04:28 PM, Ewan Milne wrote: > > On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: > >> Can't we have a joint effort here? > >> I've been spending a _LOT_ of time trying to debug things here, but >

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On 11/25/2015 12:10 PM, Hannes Reinecke wrote: On 11/25/2015 06:56 PM, Jens Axboe wrote: On 11/25/2015 02:04 AM, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a

[PATCH v2 0/3] Badblock tracking for gendisks

v2: - In badblocks_free, make 'page' NULL (patch 1) - Move the core badblocks code to a new .c file (patch 1) (Jens) - Fix a sizeof usage in disk_alloc_badblocks (patch 2) (Dan) - Since disk_alloc_badblocks can fail, check disk->bb for NULL in the genhd wrappers (patch 2) (Jeff) -

[PATCH v2 3/3] md: convert to use the generic badblocks code

Retain badblocks as part of rdev, but use the accessor functions from include/linux/badblocks for all manipulation. Signed-off-by: Vishal Verma --- drivers/md/md.c | 507 +++- drivers/md/md.h | 40 + 2 files

[PATCH v2 1/3] badblocks: Add core badblock management code

Take the core badblocks implementation from md, and make it generally available. This follows the same style as kernel implementations of linked lists, rb-trees etc, where you can have a structure that can be embedded anywhere, and accessor functions to manipulate the data. The only changes in

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On 11/25/2015 06:56 PM, Jens Axboe wrote: On 11/25/2015 02:04 AM, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ of time trying to debug things here, but

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On 11/25/2015 07:01 PM, Mike Snitzer wrote: On Wed, Nov 25 2015 at 4:04am -0500, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ of time

[PATCH v2 2/3] block: Add badblock management for gendisks

NVDIMM devices, which can behave more like DRAM rather than block devices, may develop bad cache lines, or 'poison'. A block device exposed by the pmem driver can then consume poison via a read (or write), and cause a machine check. On platforms without machine check recovery features, this would

Re: [PATCH 2/3] block: Add badblock management for gendisks

On Wed, 2015-11-25 at 10:37 -0500, Jeff Moyer wrote: > "Verma, Vishal L" writes: > > > On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: > > > > > > I'm not sure whether it makes sense to continue without badblock > > > management for the RAID code.  I was hoping

[PATCH 72/71] ncr5380: Fix pseudo-DMA

Pseudo-DMA (PDMA) has been broken for ages, resulting in hangs on 53C400-based cards. According to 53C400 datasheet, PDMA transfer length must be a multiple of 128. Check if that's true and use PIO if it's not. This makes PDMA work on 53C400 (Canon FG2-5202). Signed-off-by: Ondrej Zary

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

On Wednesday 25 November 2015 04:17:09 Finn Thain wrote: > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > On Wednesday 18 November 2015 09:35:17 Finn Thain wrote: > > > Linux v2.1.105 changed the algorithm for polling for the BSY signal > > > in NCR5380_select() and NCR5380_main(). > > > > > >

Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions

Martin, sorry for offtopic, but can you pay a little attention to http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems it wasn't applied. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On Wed, Nov 25 2015 at 3:23pm -0500, Mike Snitzer wrote: > On Wed, Nov 25 2015 at 2:24pm -0500, > Jens Axboe wrote: > > > On 11/25/2015 12:10 PM, Hannes Reinecke wrote: > > >The problem is that NOMERGE does too much, as it inhibits _any_ merging. > > > >

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On Wed, Nov 25 2015 at 2:24pm -0500, Jens Axboe wrote: > On 11/25/2015 12:10 PM, Hannes Reinecke wrote: > >On 11/25/2015 06:56 PM, Jens Axboe wrote: > >>On 11/25/2015 02:04 AM, Hannes Reinecke wrote: > >>>On 11/20/2015 04:28 PM, Ewan Milne wrote: > On Fri, 2015-11-20 at 15:55

RE: [PATCH] scsi: rescan VPD attributes

Hi Hannes, I have one probably small nitpick about the patch. I'm not sure how likely what I've put below is likely to happen in real life though. Is there any chance at all that sdev->vpd_pg83_len could change when updated? If there's any chance of that I'd have expected that both the length

Re: [PATCH 0/2] Fix a scsi_host_dev_release() memory leak

On Wed, Nov 25, 2015 at 10:40:44PM -0500, Martin K. Petersen wrote: > I gave a bunch of reviews for v1 but no takers for v2 of the second > patch. I think v1 is the right thing to do. Sorry for leading Bart in the wrong direction - the two different device structures in Scsi_Host confused me. --

[PATCH] block: Always check queue limits for cloned requests

When a cloned request is retried on other queues it always needs to be checked against the queue limits of that queue. Otherwise the calculations for nr_phys_segments might be wrong, leading to a crash in scsi_init_sgtable(). To clarify this the patch renames blk_rq_check_limits() to

Re: [PATCH] scsi: rescan VPD attributes

On Mon, 2015-11-09 at 13:24 +0100, Hannes Reinecke wrote: > The VPD page information might change, so we need to be able to > update it. This patch implements a VPD page rescan whenever > the 'rescan' sysfs attribute is triggered. > > Signed-off-by: Hannes Reinecke > --- >  

Re: [PATCH] Fix a bdi reregistration race, v2

On 11/25/15 00:47, Christoph Hellwig wrote: But what I really wanted to ask for is what your reproducer looks like. Hello Christoph, This race is hard to trigger. I can trigger it by repeatedly removing and re-adding SRP SCSI devices. Enabling debug options like SLUB debugging and kmemleak

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

On Wed, 2015-11-25 at 14:55 +0100, Tomas Henzl wrote: > On 25.11.2015 12:41, Ching Huang wrote: > > From: Ching Huang > > > > Releasing allocated resource if get configuration data failed. > > > > Signed-of-by: Ching Huang > > > > --- > > > > diff

Re: [PATCH] scsi: rescan VPD attributes

On 11/26/2015 06:07 AM, Seymour, Shane M wrote: > Hi Hannes, > > I have one probably small nitpick about the patch. I'm not sure how likely > what I've put below is likely > to happen in real life though. > > Is there any chance at all that sdev->vpd_pg83_len could change when updated? > If

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On 11/20/2015 04:28 PM, Ewan Milne wrote: > On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: >> Can't we have a joint effort here? >> I've been spending a _LOT_ of time trying to debug things here, but >> none of the ideas I've come up with have been able to fix anything. > > Yes. I'm

Re: [Y2038] [PATCH v2] scsi: gdth: replace struct timeval with ktime_get_real_seconds()

On Tuesday 24 November 2015 16:44:07 Alison Schofield wrote: > struct timeval will overflow on 32-bit systems in y2038 and is being > removed from the kernel. Replace the use of struct timeval and > do_gettimeofday() with ktime_get_real_seconds() which provides a 64-bit > seconds value and is

Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

On Wednesday 25 November 2015, Finn Thain wrote: > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > On Tuesday 24 November 2015 10:13:17 Finn Thain wrote: > > > > > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > > > > > On Tuesday 24 November 2015, Finn Thain wrote: > > > > > > > > > > On

Re: [PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

On Wed, 2015-11-25 at 09:43 +0100, Johannes Thumshirn wrote: > On Wed, 2015-11-25 at 11:25 +0800, Ching Huang wrote: > > From: Ching Huang > > > > Support areca new PCIe to SATA RAID adapter ARC1203 > > > > Signed-of-by: Ching Huang > > > > --- >

[PATCH] scsi: aic7xxx: kfree() NULL pointer cleanups

kfree() handles NULL pointers fine - checking is redundant Signed-off-by: Anup Limbu --- drivers/scsi/aic7xxx/aic79xx_core.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c

Re: [PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

On Wed, 2015-11-25 at 08:18 +0100, Hannes Reinecke wrote: > On 11/25/2015 04:25 AM, Ching Huang wrote: > > From: Ching Huang > > > > Support areca new PCIe to SATA RAID adapter ARC1203 > > > > Signed-of-by: Ching Huang > > > > --- > > > > diff

iSCSI and scsi-mq

Hi iSCSI experts, I've been starting to research possible implementations of a scsi-mq capable iSCSI. With my research I found the following thread https://groups.google.com/ forum/#!msg/open-iscsi/qLaXJh2Gqt4/A2NIDZ0fT9oJ and wondered what happened to the efforts layed out there (and what have

Re: [PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

On Wed, 2015-11-25 at 11:25 +0800, Ching Huang wrote: > From: Ching Huang > > Support areca new PCIe to SATA RAID adapter ARC1203 > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h

Re: [PATCH] Fix a bdi reregistration race, v2

Hi Bart, On Tue, Nov 24, 2015 at 03:23:21PM -0800, Bart Van Assche wrote: > So if a driver stops using a (major, minor) number pair and the same device > number is reused before the bdi device has been released the warning > mentioned in the patch description at the start of this thread is

[PATCH v3 3/5] arcmsr: modifies codes for more readable

From: Ching Huang Modifies codes for more readable Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 10:52:16.28647 +0800 +++

Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

On Wed, 2015-11-25 at 19:36 +0800, Ching Huang wrote: > From: Ching Huang > > Fixed getting wrong configuration data of adapter type B and type D. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c >

[PATCH v3 0/5] arcmsr: support areca new adapter ARC1203

From: Ching Huang Patch 1 fixes getting wrong configuration data. Patch 2 fixes not release allocated resource if get configuration data failed. Patch 3 modifies codes for more readable. Pacth 4 adds codes to support new adapter ARC1203. Patch 5 changes driver version

[PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

From: Ching Huang Fixed getting wrong configuration data of adapter type B and type D. Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v3 2/5] arcmsr: fixes not release allocated resource

From: Ching Huang Releasing allocated resource if get configuration data failed. Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-24

Re: [PATCH v3 5/5] arcmsr: changes driver version number

On Wed, 2015-11-25 at 19:52 +0800, Ching Huang wrote: > From: Ching Huang > > Changes driver version number. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h > ---

Re: [PATCH v3 3/5] arcmsr: modifies codes for more readable

On Wed, 2015-11-25 at 19:45 +0800, Ching Huang wrote: > From: Ching Huang > > Modifies codes for more readable > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h > ---

Re: [PATCH v3 4/5] arcmsr: adds code for support areca new adapter ARC1203

On Wed, 2015-11-25 at 19:49 +0800, Ching Huang wrote: > From: Ching Huang > > Support areca new PCIe to SATA RAID adapter ARC1203 > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h

Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

On 11/25/2015 12:36 PM, Ching Huang wrote: > From: Ching Huang > > Fixed getting wrong configuration data of adapter type B and type D. > > Signed-of-by: Ching Huang > > --- > Reviewed-by: Hannes Reinecke Cheers, Hannes --

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

On 11/25/2015 12:41 PM, Ching Huang wrote: > From: Ching Huang > > Releasing allocated resource if get configuration data failed. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c >

Re: [PATCH v3 4/5] arcmsr: adds code for support areca new adapter ARC1203

On 11/25/2015 12:49 PM, Ching Huang wrote: > From: Ching Huang > > Support areca new PCIe to SATA RAID adapter ARC1203 > > Signed-of-by: Ching Huang > > --- > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH v3 5/5] arcmsr: changes driver version number

On 11/25/2015 12:52 PM, Ching Huang wrote: > From: Ching Huang > > Changes driver version number. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h > ---

[PATCH v3 4/5] arcmsr: adds code for support areca new adapter ARC1203

From: Ching Huang Support areca new PCIe to SATA RAID adapter ARC1203 Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 19:10:21.30996

Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

On Wed, 25 Nov 2015, Ondrej Zary wrote: > On Wednesday 25 November 2015, Finn Thain wrote: > > > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > > > Instead of fixing split transfers, simply forced everything > > > non-modulo-128 to PIO: > > > > [...] > > I don't have any reason to think

[PATCH v3 5/5] arcmsr: changes driver version number

From: Ching Huang Changes driver version number. Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 18:25:42.926038000 +0800 +++

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

On Wed, 2015-11-25 at 19:41 +0800, Ching Huang wrote: > From: Ching Huang > > Releasing allocated resource if get configuration data failed. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c >

Re: [PATCH v3 3/5] arcmsr: modifies codes for more readable

On 11/25/2015 12:45 PM, Ching Huang wrote: > From: Ching Huang > > Modifies codes for more readable > > Signed-of-by: Ching Huang > > --- > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

[PATCH] target: use offset_in_page macro

Use offset_in_page macro instead of (addr & ~PAGE_MASK). Signed-off-by: Geliang Tang --- drivers/target/target_core_user.c | 2 +- drivers/target/tcm_fc/tfc_io.c| 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] target: use offset_in_page macro

On Wed, 2015-11-25 at 21:49 +0800, Geliang Tang wrote: > Use offset_in_page macro instead of (addr & ~PAGE_MASK). > > Signed-off-by: Geliang Tang > --- >  drivers/target/target_core_user.c | 2 +- >  drivers/target/tcm_fc/tfc_io.c| 8 >  2 files changed, 5

Re: [PATCH] target: use offset_in_page macro

Looks fine, Reviewed-by: Sagi Grimberg -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

On 25.11.2015 12:41, Ching Huang wrote: > From: Ching Huang > > Releasing allocated resource if get configuration data failed. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c >