Re: [PATCH v2 4/6] cxlflash: Fix to resolve cmd leak after host reset

On 15/12/15 08:07, Uma Krishnan wrote: From: Manoj Kumar After a few iterations of resetting the card, either during EEH recovery, or a host_reset the following is seen in the logs. cxlflash 0008:00: cxlflash_queuecommand: could not get a free command At every reset

Re: [PATCH v2 3/6] cxlflash: Removed driver date print

Acked-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 6/6] cxlflash: Enable device id for future IBM CXL adapter

On 15/12/15 08:07, Uma Krishnan wrote: From: Manoj Kumar This drop enables a future card with a device id of 0x0600 to be recognized by the cxlflash driver. If you do a V3 - this could be better worded in the imperative mood as: "Add a new device ID (0x0600) for a

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

> "Hannes" == Hannes Reinecke writes: >> I'm not opposed to having the module option if others (Martin?) feel >> they need it, but generally I think it's better to keep things as >> simple as possible. So, unless there are strong objections, I would >> say no. Hannes>

Re: [PATCH 0/15] copy offload patches

On Thu, 10 Dec 2015, Martin K. Petersen wrote: > > "Mikulas" == Mikulas Patocka writes: > > Mikulas, > > Mikulas> This patch series adds copy offload (the XCOPY command) to the > Mikulas> block layer, SCSI subsystems and device mapper. > > Now that the VFS stuff

Re: [PATCH 10/20] qla2xxx: Fix interaction issue between qla2xxx and Target Core Module

On Wed, Dec 09, 2015 at 10:07:32PM +, Quinn Tran wrote: > >Err, no. Looking into the refcount inside a kref is never the > >right thing to do. > > QT> even for debug purpose?? No. Please treat struct kref as opaque. > QT> These bits provide indication as to where the command has traversed

[PATCH] be2iscsi: fix handling return value of mgmt_open_connection

The function can return negative values, so its result should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by:

Re: [PATCH 7/9] be2iscsi: Fix to process 25G link speed info from FW

On 12/14/2015 07:11 AM, Jitendra Bhivare wrote: From: Jitendra Async link event provides port_speed info. Use the same to report in ISCSI_HOST_PARAM_PORT_SPEED query. Removed link status query IOCTL used to do the same. 25G and 40G are defined in kernel enum

Re: [PATCH 5/9] be2iscsi: Fix to handle misconfigured optics events

On 12/14/2015 07:11 AM, Jitendra Bhivare wrote: From: Jitendra Log messages for misconfigured transceivers reported by FW. Register async events that driver handles using MCC_CREATE_EXT ioctl. Errors messages for faulted/uncertified/unqualified optics are

Re: [PATCH 6/9] be2iscsi: Fix IOPOLL implementation

On 12/14/2015 07:11 AM, Jitendra Bhivare wrote: From: Jitendra OS not responding when running 2 port traffic on 72 CPUs system. be2iscsi IRQs gets affined to CPU0 when irqbalancer is disabled. be_iopoll processing completions in BLOCK_IOPOLL_SOFTIRQ hogged

Re: [PATCH 8/9] be2iscsi: Fix WRB leak in login/logout path

On 12/14/2015 07:11 AM, Jitendra Bhivare wrote: From: Jitendra Login/Logout loop was hanging after few hours. /var/log/message showed that alloc_wrb_handle() function was not able to allocate any new WRB. Sep 11 11:25:22 Jhelum10 kernel: connection32513:0:

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

On 12/14/2015 04:07 PM, Ewan Milne wrote: On Sun, 2015-12-13 at 11:16 -0800, Lee Duncan wrote: On 12/11/2015 07:31 AM, Ewan Milne wrote: On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote: On 11/17/2015 03:20 PM, Martin K. Petersen wrote: "Lee" == Lee Duncan writes:

Re: [PATCH 0/15] copy offload patches

On 15-12-14 08:22 PM, Mikulas Patocka wrote: On Thu, 10 Dec 2015, Martin K. Petersen wrote: "Mikulas" == Mikulas Patocka writes: Mikulas, Mikulas> This patch series adds copy offload (the XCOPY command) to the Mikulas> block layer, SCSI subsystems and device mapper.

RE: [PATCH 6/9] be2iscsi: Fix IOPOLL implementation

The problem statement indicates affinity issue but IOPOLL implementation had issues too. 1. IOPOLL budget passed in the callback is not being honored. This was the root cause where the driver kept polling in softirq. 2. The interrupts kept coming even when IOPOLL is scheduled. So we needed to fix

RE: [PATCH 1/9] be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx

be_mbox_db_ready_wait was changed to remove wait_event_timeout done under spinlock held for port initialization FW commands. The timeout change and unrecoverable error check inside the wait loop were needed to be addressed too. Though spinlock was replaced with mutex in patch 2/9. -Original

Re: [PATCH 10/13] IB/srp: use the new CQ API

On 12/13/2015 05:26 AM, Sagi Grimberg wrote: > >> Allright. How do you want to proceed? The current rdma-cq branch >> has all kinds of dependencies, but I've also prepared a new rdma-cq.2 >> branch that could go straight on top of your current queue: >> >>

Re: [PATCH 4/6] cxlflash: Fix to resolve cmd leak after host reset

Acked-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/6] cxlflash: Resolve oops in wait_port_offline

Acked-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] cxlflash: Enable device id for future IBM CXL adapter

Acked-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] cxlflash: Enable device id for future IBM CXL adapter

On 12/13/2015 9:47 PM, Andrew Donnellan wrote: On 11/12/15 09:54, Uma Krishnan wrote: From: Manoj Kumar This drop enables a future card with a device id of 0x0600 to be recognized by the cxlflash driver. No card specific programming has been added. These card

Kernel v4.3 - RCU hang, USB + SCSI implicated

Hello, This is a follow-up to an earlier report where I was directed by Oliver Neukum to repost to linux-scsi. I got lazy and forgot, but the same issue happened a second time. Original posting at: https://lkml.org/lkml/2015/11/16/569 This is an Intel Haswell system, DELL U2415 monitor (which

Re: [PATCH 1/6] cxlflash: Fix to escalate LINK_RESET also on port 1

Acked-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/20] qla2xxx: Fix interaction issue between qla2xxx and Target Core Module

Christoph, Thanks for reviewing. I¹ll withdraw this patch. Will rework with new code and submit at a later time. Regards, Quinn Tran On 12/14/15, 2:34 AM, "Christoph Hellwig" wrote: >On Wed, Dec 09, 2015 at 10:07:32PM +, Quinn Tran wrote: >> >Err, no. Looking

Re: [PATCH 11/20] qla2xxx: Add TAS detection for kernel 3.15 n newer

Christoph, Thanks for reviewing. I¹ll withdraw this patch. Will rework with new code and submit at a later time. Regards, Quinn Tran On 12/14/15, 2:37 AM, "Christoph Hellwig" wrote: >On Wed, Dec 09, 2015 at 08:24:57PM +, Quinn Tran wrote: >> >> + if

Re: [PATCH 11/20] qla2xxx: Add TAS detection for kernel 3.15 n newer

On Wed, Dec 09, 2015 at 08:24:57PM +, Quinn Tran wrote: > >> + if (se_cmd->transport_state & CMD_T_ABORTED) { > >> + /* For TCM TAS support n kernel >= 3.15: > >> + * This cmd is attempting to respond with "Task Aborted Status". > >> + */ > >> + if

[PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates

This patch set contains miscellaneous fixes and adds support for a future IBM CXL adapter. This series is intended for 4.5 and is bisectable. Please reference the changelog below for details on what has been altered from previous versions of this patch set. v2 Changes: - Incorporate comments from

[PATCH v2 5/6] cxlflash: Resolve oops in wait_port_offline

From: Manoj Kumar If an async error interrupt is generated, and the error requires the FC link to be reset, it cannot be performed in the interrupt context. So a work element is scheduled to complete the link reset in a process context. If either an EEH event or an

[PATCH v2 1/6] cxlflash: Fix to escalate LINK_RESET also on port 1

From: Manoj Kumar The original fix to escalate a 'login timed out' error to a LINK_RESET was only made for one of the two ports on the card. This fix resolves the same issue for the second port (port 1). Signed-off-by: Manoj N. Kumar

[PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates

This patch set contains miscellaneous fixes and adds support for a future IBM CXL adapter. This series is intended for 4.5 and is bisectable. Please reference the changelog below for details on what has been altered from previous versions of this patch set. v2 Changes: - Incorporate comments from

[PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates

This patch set contains miscellaneous fixes and adds support for a future IBM CXL adapter. This series is intended for 4.5 and is bisectable. Please reference the changelog below for details on what has been altered from previous versions of this patch set. v2 Changes: - Incorporate comments from

[PATCH v2 2/6] cxlflash: Fix to avoid virtual LUN failover failure

From: "Matthew R. Ochs" Applications which use virtual LUN's that are backed by a physical LUN over both adapter ports may experience an I/O failure in the event of a link loss (e.g. cable pull). Virtual LUNs may be accessed through one or both ports of the adapter.

Re: [PATCH 1/7] iscsi-target: Use a variable initialisation in iscsi_set_default_param() directly

On Sat, Dec 12, 2015 at 10:49:40PM +0300, Dan Carpenter wrote: > On Sat, Dec 12, 2015 at 03:34:50PM +0100, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Sat, 12 Dec 2015 11:36:02 +0100 > > > > Omit the unnecessary setting to a null pointer for the