Re: [PATCH] bnx2fc:Add proper locking protection in bnx2fc_ctrlr_enabled

On Sat, 12 Dec 2015, Nicholas Krause wrote: This adds proper locking protection in bnx2fc_ctrl_enabled around the calls to the functions, _bnx2fc_enable and _bnx2fc_disable in order to avoid concurrent access on these functions accessing global referenced data structures in their internal

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

On Tue, Dec 15, 2015 at 09:27:14PM +0800, Ming Lei wrote: > On Tue, Dec 15, 2015 at 9:06 PM, Eryu Guan wrote: > > On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: > >> On Tue, Dec 15, 2015 at 7:20 PM, Eryu Guan wrote: > >> > On Fri, Dec 11, 2015

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

On Tue, Dec 15, 2015 at 11:38:41PM +0800, Ming Lei wrote: > On Tue, 15 Dec 2015 21:06:31 +0800 > Eryu Guan wrote: > > > On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: > > > On Tue, Dec 15, 2015 at 7:20 PM, Eryu Guan wrote: > > > > On Fri, Dec

[PATCH 12/15] be2iscsi: Fix IOPOLL implementation

From: Jitendra OS not responding when running 2 port traffic on 72 CPUs system. be2iscsi IRQs gets affined to CPU0 when irqbalancer is disabled. be_iopoll processing completions in BLOCK_IOPOLL_SOFTIRQ hogged CPU0. 1. Use budget to exit the polling loop.

re: qla2xxx: ISP27xx add tests for incomplete template.

Hello Joe Carnuccio, The patch 299f5e27ac5f: "qla2xxx: ISP27xx add tests for incomplete template." from Sep 25, 2014, leads to the following static checker warning: drivers/scsi/qla2xxx/qla_tmpl.c:779 qla27xx_walk_template() warn: should this be 'count == -1'

RE: [PATCH v2 3/9] aacraid: Added EEH support

Hello All, It looks like the build robot did not merge the previous aacraid patches which contained the functions aac_release_resources and aac_acquire_resources, before applying and building this set of patches. As is evident from the commit messages here

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

> "Eryu" == Eryu Guan writes: Eryu, Does the patch below fix the issue? -- Martin K. Petersen Oracle Linux Engineering diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 3d22fc3e3c1a..d1eb7aa78b8d 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@

RE: [PATCH] bnx2fc:Add proper locking protection in bnx2fc_ctrlr_enabled

Also, the patch fails to do what it's message describes, i.e. the calls _bnx2fc_enable() and _bnx2fc_disable() are outside the lock/unlock. -Original Message- From: Chad Dupuis Sent: Tuesday, December 15, 2015 8:43 AM To: Nicholas Krause Cc: Dept-Eng QLogic

Re: [PATCH 2/3] scsi_transport_sas: add function to get SAS endpoint address

On 12/09/2015 08:13 PM, James Bottomley wrote: For a device known to be SAS connected, this will return the endpoint address. This is useful for getting the SAS address of SATA devices. Signed-off-by: James Bottomley ---

Re: [PATCH] ses: fix additional element traversal bug

On 12/11/2015 06:16 PM, James Bottomley wrote: KASAN found that our additional element processing scripts drop off the end of the VPD page into unallocated space. The reason is that not every element has additional information but our traversal routines think they do, leading to them expecting

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

On Thu, 2015-12-03 at 13:36 -0500, Alan Stern wrote: > This is an old problem, but it was never resolved and it still affects > people (Bugzilla #89511). In short, there are USB-(S)ATA bridges that > claim to be write-back but don't support the SYNCHRONIZE CACHE > command. > This causes errors

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

On Fri, Dec 11, 2015 at 07:53:40PM +0800, Eryu Guan wrote: > Hi, > > I saw this kernel BUG_ON on 4.4-rc4 kernel, and this can be reproduced > easily on ppc64 host by: This is still reproducible with 4.4-rc5 kernel. Thanks, Eryu > > modprobe scsi_debug sector_size=512 physblk_exp=3

Re: [PATCH v2 3/3] ses: fix discovery of SATA devices in SAS enclosures

On 12/09/2015 09:56 PM, James Bottomley wrote: The current discovery routines use the VPD 0x83 inquiry page to find the device SAS address and match it to the end point in the enclosure. This doesn't work for SATA devices because expanders (or hosts) simply make up an endpoint address for STP

Re: [PATCH v2 3/6] cxlflash: Removed driver date print

On 12/14/2015 3:06 PM, Uma Krishnan wrote: Having a date for the driver requires it to be updated quite often. Removing the date which is not necessary. Also made use of the existing symbol to print the driver name. Signed-off-by: Uma Krishnan --- Acked-by: Manoj

RE: qla2xxx: ISP27xx add tests for incomplete template.

Hi Dan, Thanks for reading the code... That loop would normally exit via the break at line 775; if there were exactly count entries, that break avoids count being decremented to -1, so count remains zero. if the loop is ever terminated by the while, then either/or: - if there were more

[PATCH 11/15] be2iscsi: Fix return value for MCC completion

From: Jitendra Change return value of completed MCC EBUSY to EINVAL. Signed-off-by: Jitendra --- drivers/scsi/be2iscsi/be_cmds.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 10/15] be2iscsi: Add FW config validation

From: Jitendra System crash in I+T card personality Fix to add validation for ULP in initiator mode, physical port number, and supported queue, icd, cid counts. Signed-off-by: Jitendra --- drivers/scsi/be2iscsi/be_main.c |2

[PATCH 08/15] be2iscsi: Fix VLAN support for IPv6 network

From: Jitendra Configuring VLAN parameters through IPv6 interface was not supported in driver. Signed-off-by: Jitendra --- drivers/scsi/be2iscsi/be_iscsi.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

[PATCH 09/15] be2iscsi: Fix to handle misconfigured optics events

From: Jitendra Log messages for misconfigured transceivers reported by FW. Register async events that driver handles using MCC_CREATE_EXT ioctl. Errors messages for faulted/uncertified/unqualified optics are logged. Added IOCTL to get port_name to be displayed in

[PATCH 05/15] be2iscsi: Set mbox timeout to 30s

From: Jitendra FW recommended timeout for all mbox command is 30s. Use msleep instead mdelay to relinquish CPU when polling for mbox completion. Signed-off-by: Jitendra --- drivers/scsi/be2iscsi/be_cmds.c |5 +++-- 1 files

[PATCH 04/15] be2iscsi: Fix to synchronize tag allocation using spin_lock

From: Jitendra alloc_mcc_tag/free_mcc_tag is now done under mcc_lock spin_lock Signed-off-by: Jitendra --- drivers/scsi/be2iscsi/be_cmds.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 01/15] be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx

From: Jitendra We are taking mbox_lock spinlock which disables pre-emption before we poll for mbox completion. Waiting there with spinlock held in excess of 20s will cause soft lockup. Actual fix is to change mbox_lock to mutex. The changes are done in phases.

[PATCH 06/15] be2iscsi: Added return value check for mgmt_get_all_if_id

From: Jitendra Use of mutex_lock_interruptible can return -EINTR, handle and log the error. Signed-off-by: Jitendra --- drivers/scsi/be2iscsi/be_iscsi.c |7 --- drivers/scsi/be2iscsi/be_mgmt.c | 10 ++ 2 files

[PATCH 02/15] be2iscsi: Fix mbox synchronization replacing spinlock with mutex

From: Jitendra This is second part of actual fix for soft lockup. All mbox cmds issued using BMBX and MCC are synchronized using mutex mbox_lock instead of spin_lock. Used mutex_lock_interruptible where ever possible. Signed-off-by: Jitendra

[PATCH 03/15] be2iscsi: Fix to use atomic operations for tag_state

From: Jitendra Replace lock based tag_state manipulations with atomic operations. Signed-off-by: Jitendra --- drivers/scsi/be2iscsi/be.h |2 +- drivers/scsi/be2iscsi/be_cmds.c | 26 -- 2 files

[PATCH 07/15] be2iscsi: Fix to remove shutdown entry point

From: Jitendra Null pointer dereference in shutdown path after taking dump. Shutdown path is not needed as FW comes up clean every time during probe after issuing FUNCTION reset MBOX command. Signed-off-by: Jitendra ---

[PATCH 00/15] be2iscsi: driver update 11.0.0.0

From: Jitendra This patch is generated against for-next branch. Jitendra (15): be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx be2iscsi: Fix mbox synchronization replacing spinlock with mutex be2iscsi: Fix to use atomic operations for

[PATCH 13/15] be2iscsi: Fix to process 25G link speed info from FW

From: Jitendra Async link event provides port_speed info. Use the same to report in ISCSI_HOST_PARAM_PORT_SPEED query. Removed link status query IOCTL used to do the same. 25G and 40G are defined in kernel enum iscsi_port_speed. Fixed get_nic_conf structure

[PATCH 14/15] be2iscsi: Fix WRB leak in login/logout path

From: Jitendra Login/Logout loop was hanging after few hours. /var/log/message showed that alloc_wrb_handle() function was not able to allocate any new WRB. Sep 11 11:25:22 Jhelum10 kernel: connection32513:0: Could not send nopout Sep 11 11:25:22 Jhelum10 kernel:

[PATCH v1 0/3] hpsa update

These patches are based on Linus's tree The changes are: - correct missing changes from snprintf to scnprintf in path_info_show by Rasmus Villemoes - fix reported bus for SAS transport devices - add in enclosure information Changes from initial upload - added short patch description for

[PATCH v1 2/3] hpsa: change SAS transport devices to bus 0.

sas transport places devices on bus 0 but driver was setting the bus to 3. Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.h

[PATCH v1 3/3] hpsa: add box and bay information for enclosure devices

Adding a new method to display enclosure device information. Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 108

[PATCH v1 1/3] hpsa: fix path_info_show

left off some changes from Rasmus Villemoes where he changed snprintf to scnprintf Suggested-by: Rasmus Villemoes Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: > On Tue, Dec 15, 2015 at 7:20 PM, Eryu Guan wrote: > > On Fri, Dec 11, 2015 at 07:53:40PM +0800, Eryu Guan wrote: > >> Hi, > >> > >> I saw this kernel BUG_ON on 4.4-rc4 kernel, and this can be reproduced > >> easily on

RE: [PATCH 5/9] be2iscsi: Fix to handle misconfigured optics events

> So please add defines for the individual messages and use a key-value map to lookup the messages. FW events are in sequence 0...5 so key is implied and value is being stored in array of strings. BEISCSI_PORT_MISCONF_EVENT_MAX (replaced with ARRAY_SIZE) is just to verify the event number. Not so

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

On Tue, Dec 15, 2015 at 9:06 PM, Eryu Guan wrote: > On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: >> On Tue, Dec 15, 2015 at 7:20 PM, Eryu Guan wrote: >> > On Fri, Dec 11, 2015 at 07:53:40PM +0800, Eryu Guan wrote: >> >> Hi, >> >> >> >> I saw

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

On Wed, Dec 16, 2015 at 2:29 AM, Martin K. Petersen wrote: >> "Eryu" == Eryu Guan writes: > > Eryu, > > Does the patch below fix the issue? No, it can't. As the debug log shows, it is because you use 'OPTIMAL TRANSFER LENGTH' to set queue's

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

On Wed, Dec 16, 2015 at 12:56 AM, Eryu Guan wrote: > On Tue, Dec 15, 2015 at 09:27:14PM +0800, Ming Lei wrote: >> On Tue, Dec 15, 2015 at 9:06 PM, Eryu Guan wrote: >> > On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: >> >> On Tue, Dec 15, 2015 at

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

> "Ming" == Ming Lei writes: Ming, Ming> No, it can't. Well, it fixes a problem on one of my test systems where max_ws_blocks, by virtue of being 64 bits, clobbers opt_xfer_blocks causing rw_len and thus max_sectors to be set incorrectly. We haven't run into that

Re: [PATCH 0/15] copy offload patches

> "Mikulas" == Mikulas Patocka writes: Mikulas> Is there some software iSCSI implementation that supports Mikulas> token-based copy? So that I could try to make support for it. I did write support for token-based copy but it's in a different branch from the xcopy stuff.

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

> "Ming" == Ming Lei writes: Ming> I think it is wrong to set max sectors from OPTIMAL TRANSFER Ming> LENGTH. OTL is the preferred size for REQ_TYPE_FS requests as reported by the device. The intent is to honor that. Your patch clamps the rw_size to

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

On Tue, 15 Dec 2015, Oliver Neukum wrote: > On Thu, 2015-12-03 at 13:36 -0500, Alan Stern wrote: > > This is an old problem, but it was never resolved and it still affects > > people (Bugzilla #89511). In short, there are USB-(S)ATA bridges that > > claim to be write-back but don't support the

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

On Tue, 15 Dec 2015 21:06:31 +0800 Eryu Guan wrote: > On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: > > On Tue, Dec 15, 2015 at 7:20 PM, Eryu Guan wrote: > > > On Fri, Dec 11, 2015 at 07:53:40PM +0800, Eryu Guan wrote: > > >> Hi, > > >> > > >>

Re: [PATCH 2/3] hpsa: change SAS transport devices to bus 0.

On 12/09/2015 05:21 PM, Matthew R. Ochs wrote: On Dec 9, 2015, at 3:18 PM, Don Brace wrote: sas transport places devices on bus 0 but driver was setting the bus to 3. Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

> "Eryu" == Eryu Guan writes: Eryu, Eryu> This is still reproducible with 4.4-rc5 kernel. Sorry about the delay. I've been busy with a lab move and most of my machines have been disconnected since last week. Almost done getting my equipment back online. However, I

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

On Tue, Dec 15, 2015 at 01:29:59PM -0500, Martin K. Petersen wrote: > > "Eryu" == Eryu Guan writes: > > Eryu, > > Does the patch below fix the issue? Unfortunately no, still BUG_ON. Thanks, Eryu > > -- > Martin K. PetersenOracle Linux Engineering > > diff --git