Re: [PATCH] scsi: export function scsi_scan.c:sanitize_inquiry_string

On 01/20/2016 01:41 PM, Don Brace wrote: The hpsa driver uses this function to cleanup inquiry data. Our new pqi driver will also use this function. This function was copied into both drivers. This patch exports sanitize_inquiry_string so the hpsa and the pqi drivers can use this function

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On 01/22/2016 10:50 AM, Brian King wrote: > On 11/11/2015 11:05 PM, mchri...@redhat.com wrote: >> From: Mike Christie >> >> This patch fixes this oops report by Guilherme Piccol: >> >> list_del corruption. prev->next should be c00f3da2b080, but was >> c00f3da2c080 >

[GIT PULL] final round of SCSI updates for the 4.4+ merge window

This is mostly stuff which missed the first pull request because it needed to incubate longer. It's mainly made up of the ncr 5380 rework but also has a few assorted bug fixes. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc The short

[PATCH 2/2] iscsi_ibft: Always display netmask

From: Hannes Reinecke Some older user-space code might rely on the netmask attribute being present, so we should always display it. This fixes a regression introduced by commit 0b2eb3c4060a16f3ec11a4d6d4c934e7e5d5334f. Signed-off-by: Hannes Reinecke Signed-off-by:

Re: st driver doesn't seem to grok LTO partitioning

Laurence, Shane Seymour from HP provided this useful link: https://docs.oracle.com/cd/E21419_04/en/LTO5_Vol3_E5b/LTO5_Vol3_E5b.pdf That documents the WRITE BUFFER command on pages 228 and 229 used by HP LTO-5 drives. For sending new firmware it looks like you need to use MODE 4 or 5. [That

Re: [PATCH] mptlan: add checks for dma mapping errors

Hi Alexey, [auto build test WARNING on v4.4-rc8] [also build test WARNING on next-20160122] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Alexey-Khoroshilov/mptlan-add-checks-for-dma-mapping

[PATCH] mptlan: add checks for dma mapping errors

mpt_lan_sdu_send() and mpt_lan_post_receive_buckets() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov ---

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

On Wed, Jan 20, 2016 at 08:47:29AM -0800, James Bottomley wrote: > On Wed, 2016-01-20 at 11:40 -0500, Martin K. Petersen wrote: > > > > > > > "James" == James Bottomley < > > > > > > > james.bottom...@hansenpartnership.com> writes: > > > > James> We should mark the commit causing the problems,

spurious use after free bug in dio_bio_complete on scsi disks (with multipath)

When I enable DEBUG_PAGEALLOC (notice: needs also enablement on the command line) I get spurious warnings like the following [ 2664.756567] Unable to handle kernel pointer dereference in virtual kernel address space [ 2664.756575] failing address: 00f9ef84c000 TEID: 00f9ef84c803 [

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Ooops, fat finger posting before I've finished answering... Le Fri, 22 Jan 2016 02:10:03 + "Seymour, Shane M" écrivait: > > > > There seem to be lot of arguments supporting both possible choices. > > Should we use the existing definition (1) or change it for the > >

[PATCH 3/3] xen-scsiback: fix license ident used in MODULE_LICENSE

The comment at the beginning of the file is the canonical source of licenses for this module. Currently it contains GPL and MIT license. Fix the code to reflect the reality. Signed-off-by: Wei Liu --- drivers/xen/xen-scsiback.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Le Fri, 22 Jan 2016 02:10:03 + "Seymour, Shane M" écrivait: > > However, before making the final patch, we should decide which > > partition the specified size should apply to. For the SCSI level > > <=2 it applies to partition 1. For other drives we may have some > >

[PATCH] megaraid: fix null pointer check in megasas_detach_one().

The pd_seq_sync pointer can't be NULL, we have to check its entries instead. Signed-off-by: Maurizio Lombardi --- drivers/scsi/megaraid/megaraid_sas_base.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 3/3] xen-scsiback: fix license ident used in MODULE_LICENSE

On 22/01/16 13:34, Wei Liu wrote: > The comment at the beginning of the file is the canonical source of > licenses for this module. Currently it contains GPL and MIT license. > Fix the code to reflect the reality. > > Signed-off-by: Wei Liu Acked-by: Juergen Gross

Re: [PATCH V3 8/9] aacraid: Fix character device re-initialization

On 20.1.2016 21:43, Raghava Aditya Renukunta wrote: > Hello Tomas, > >> -Original Message- >> From: Tomas Henzl [mailto:the...@redhat.com] >> Sent: Wednesday, January 20, 2016 5:41 AM >> To: Raghava Aditya Renukunta; james.bottom...@hansenpartnership.com; >> martin.peter...@oracle.com;

[PATCH v2] mptlan: add checks for dma mapping errors

mpt_lan_sdu_send() and mpt_lan_post_receive_buckets() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov ---

RE: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client driver implementation for EMC-Symmetrix GuestOS emulated Cut-Through Device

Hello Thumshirn. Thanks for taking out time to review the patch. I appreciate that. Please find my comments inlined. > -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Tuesday, January 19, 2016 7:20 PM > To: Singhal, Maneesh > Cc:

RE: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client driver implementation for EMC-Symmetrix GuestOS emulated Cut-Through Device

Hello Greg, Thanks for taking out time to review the patch. Please find my replies inlined... Will post the next patch for modifications soon. > -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Tuesday, January 19, 2016 11:42 PM > To: Singhal, Maneesh > Cc:

RE: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client driver implementation for EMC-Symmetrix GuestOS emulated Cut-Through Device

Thanks for your time. My replies inlined... > -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Tuesday, January 19, 2016 9:34 PM > To: Singhal, Maneesh > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; > jbottom...@odin.com;

Re: [PATCH V3 7/9] aacraid: Fix AIF triggered IOP_RESET

On 20.1.2016 21:32, Raghava Aditya Renukunta wrote: > >> -Original Message- >> From: Tomas Henzl [mailto:the...@redhat.com] >> Sent: Tuesday, January 19, 2016 8:14 AM >> To: Raghava Aditya Renukunta; james.bottom...@hansenpartnership.com; >> martin.peter...@oracle.com;

[PATCH] scsi: Allow activation of scsi-mq per-driver

Allow the activation of the scsi-mq feature on a per-driver bassis as opposed to the current stack global (de)activation. This allows us to have setups which can combine "slow" rotational media and fast media on two different HBA types. The following is from a host with rotational disks behind a

Re: [PATCH] scsi: Allow activation of scsi-mq per-driver

On 01/22/2016 02:41 PM, Johannes Thumshirn wrote: > Allow the activation of the scsi-mq feature on a per-driver bassis as opposed > to the current stack global (de)activation. > > This allows us to have setups which can combine "slow" rotational media and > fast media on two different HBA types.

[PATCH v2 3/3] xen-scsiback: fix license ident used in MODULE_LICENSE

The comment at the beginning of the file is the canonical source of licenses for this module. The license used to distribute outside of Linux kernel is not BSD license but X11 license. Instead of trying to determine whether X11 license can be mapped into Linux's "MIT" license ident, simply make

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On 11/11/2015 11:05 PM, mchri...@redhat.com wrote: > From: Mike Christie > > This patch fixes this oops report by Guilherme Piccol: > > list_del corruption. prev->next should be c00f3da2b080, but was > c00f3da2c080 Hi Mike! I haven't seen any follow ups on this

Re: [PATCH] scsi_dh_rdac: always retry MODE SELECT on command lock violation

On Fri, Jan 22, 2016 at 03:42:41PM +0100, Hannes Reinecke wrote: > If MODE SELECT returns with sense '05/91/36' (command lock violation) > it should always be retried without counting the number of retries. > During an HBA upgrade or similar circumstances one might see a flood > of MODE SELECT

[PATCH, RESEND 2] qla2xxx: Remove use of 'struct timeval'

struct register_host_info stores a 64-bit UTC system time timestamp. This patch removes the use of 'struct timeval' to obtain that timestamp as its tv_sec value will overflow on 32-bit systems in year 2038 beyond. The patch uses ktime_get_real_seconds() which returns a 64-bit seconds value.

[PATCH] scsi_dh_rdac: always retry MODE SELECT on command lock violation

If MODE SELECT returns with sense '05/91/36' (command lock violation) it should always be retried without counting the number of retries. During an HBA upgrade or similar circumstances one might see a flood of MODE SELECT command from various HBAs, which will easily trigger the sense code and

Re: [Y2038] [PATCH, RESEND 2] qla2xxx: Remove use of 'struct timeval'

On Friday 22 January 2016 15:28:32 Arnd Bergmann wrote: > struct register_host_info stores a 64-bit UTC system time timestamp. > This patch removes the use of 'struct timeval' to obtain that timestamp > as its tv_sec value will overflow on 32-bit systems in year 2038 beyond. > The patch uses

RE: [PATCH V3 7/9] aacraid: Fix AIF triggered IOP_RESET

Hello Tomas, > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Friday, January 22, 2016 5:15 AM > To: Raghava Aditya Renukunta; james.bottom...@hansenpartnership.com; > martin.peter...@oracle.com; linux-scsi@vger.kernel.org > Cc: Mahesh Rajashekhara; Murthy Bhat;

RE: [PATCH V3 8/9] aacraid: Fix character device re-initialization

> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Friday, January 22, 2016 5:08 AM > To: Raghava Aditya Renukunta; james.bottom...@hansenpartnership.com; > martin.peter...@oracle.com; linux-scsi@vger.kernel.org > Cc: Mahesh Rajashekhara; Murthy Bhat; Gana

Re: [PATCH 2/2] target: Fix LUN_RESET active TMR descriptor handling

On Tue, 2016-01-12 at 16:25 +0100, Christoph Hellwig wrote: > > if (dev) { > > spin_lock_irqsave(>se_tmr_lock, flags); > > - list_del(>tmr_list); > > + if (!list_empty(>tmr_list)) > > + list_del_init(>tmr_list); > > list_del_init on a empty

Re: [PATCH] mptlan: add checks for dma mapping errors

Hi Alexey, [auto build test WARNING on v4.4-rc8] [also build test WARNING on next-20160122] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Alexey-Khoroshilov/mptlan-add-checks-for-dma-mapping

[PATCH-v2 2/3] target: Fix LUN_RESET active TMR descriptor handling

From: Nicholas Bellinger This patch fixes a NULL pointer se_cmd->cmd_kref < 0 refcount bug during TMR LUN_RESET with active TMRs, triggered during se_cmd + se_tmr_req descriptor shutdown + release via core_tmr_drain_tmr_list(). To address this bug, go ahead and obtain a

[PATCH-v2 3/3] target: Fix TAS handling for multi-session se_node_acls

From: Nicholas Bellinger This patch fixes a bug in TMR task aborted status (TAS) handling when multiple sessions are connected to the same target WWPN endpoint and se_node_acl descriptor, resulting in TASK_ABORTED status to not be generated for aborted se_cmds on the remote

[PATCH-v2 0/3] target: Fix LUN_RESET active I/O + TMR handling

From: Nicholas Bellinger Hi folks, Here is -v2 series to address two LUN_RESET active I/O + TMR se_cmd->cmd_kref < 0 bugs as reported recently by Quinn & Co. This bug can occur during active I/O remote port TMR LUN_RESET with multi-port LIO configurations. To address

[PATCH-v2 1/3] target: Fix LUN_RESET active I/O handling for ACK_KREF

From: Nicholas Bellinger This patch fixes a NULL pointer se_cmd->cmd_kref < 0 refcount bug during TMR LUN_RESET with active se_cmd I/O, that can be triggered during se_cmd descriptor shutdown + release via core_tmr_drain_state_list() code. To address this bug, add common

Re: [PATCH 1/2] target: Fix LUN_RESET active I/O handling for ACK_KREF

On Tue, 2016-01-12 at 16:20 +0100, Christoph Hellwig wrote: > > It also introduces SCF_ACK_KREF to determine when > > transport_cmd_finish_abort() needs to drop the second > > extra reference, ahead of calling target_put_sess_cmd() > > for the final kref_put(_cmd->cmd_kref). > > It would be