Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

2016-02-01 Thread Laurence Oberman
The new patch did not work for me, but I chatted with Shane and I have his mt version. I will update my DAT to same firmware or newer than his and provide a second tested by. I also expect my LTO5 to show up this week so will be ready for that. Thanks everyone for keeping tapes alive Laurence

Re: [PATCH v2] megaraid_sas: add an i/o barrier

2016-02-01 Thread Greg KH
On Mon, Feb 01, 2016 at 03:12:04PM +0100, Tomas Henzl wrote: > A barrier should be added to ensure proper > ordering of memory mapped writes. > > V2: - added the barrier also to megasas_fire_cmd_skinny, > as suggested by Kashyap Desai > > Signed-off-by: Tomas Henzl > --- >

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

2016-02-01 Thread Seymour, Shane M
Hi Kai, > -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of "Kai Mäkisara (Kolumbus)" > Sent: Tuesday, February 02, 2016 5:43 AM > To: Seymour, Shane M > Cc: Laurence Oberman; Emmanuel Florac; Laurence Oberman; linux- >

RE: [PATCH V4 0/9] aacraid: Patchset for aacraid driver version 41052

2016-02-01 Thread Raghava Aditya Renukunta
Hello Martin, > -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Monday, February 1, 2016 4:57 PM > To: Raghava Aditya Renukunta > Cc: james.bottom...@hansenpartnership.com; > martin.peter...@oracle.com; linux-scsi@vger.kernel.org; Mahesh >

Re: [PATCH 01/12] be2iscsi: Remove unused mcc_cq_lock

2016-02-01 Thread Martin K. Petersen
> "James" == James Bottomley writes: James> On Mon, 2016-02-01 at 15:42 +0530, Jitendra Bhivare wrote: >> mcc_cq_lock spin_lock is used only in beiscsi_process_mcc which is >> called only when all interrupts are disabled from mgmt_epfw_cleanup >> during

Re: [PATCH] bnx2fc: Show information about log levels in 'modinfo'

2016-02-01 Thread Martin K. Petersen
> "Jose" == Jose Castillo writes: Jose> This patch adds the information of the different values that can Jose> be used in the module parameter 'debug_logging', as it is shown Jose> below: Applied to 4.6/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux

Re: [PATCH V4 0/9] aacraid: Patchset for aacraid driver version 41052

2016-02-01 Thread Martin K. Petersen
> "Raghava" == Raghava Aditya Renukunta > writes: Raghava, Raghava> This patchset includes the following changes (bug fixes and new Raghava> feature support) specific to aacraid driver. Please fix the build failure in patch 3/9 when CONFIG_PM is not

Re: [PATCH] bnx2fc: bnx2fc_eh_abort(): fix wrong return code.

2016-02-01 Thread Martin K. Petersen
> "Maurizio" == Maurizio Lombardi writes: Maurizio> If the link is not ready, the bnx2fc_eh_abort() function Maurizio> should return FAILED. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [RESEND PATCH v2 00/23] HiSilicon SAS v2 hw support

2016-02-01 Thread Martin K. Petersen
> "John" == John Garry writes: John> This patchset introduces support for the HiSi SAS v2 hw. The John> major difference between v1 and v2 hw is support for SATA/STP. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

Re: [PATCH 0/2] scsi_transport_fc: LUN masking

2016-02-01 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> Hmm. this seemed to have fallen through -ENOREVIEWS So, yes. Please resend. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH] add support for DWC UFS Host Controller

2016-02-01 Thread Julian Calaby
Hi Joao, On Mon, Feb 1, 2016 at 11:47 PM, Joao Pinto wrote: > This patch includes: > - quirks in the ufs core driver to support Synopsys MPHY Test Chip config > - quirks in the ufs core driver to support DWC configuration sequence > - New Unipro attributes were added > -

RE: [PATCH V4 7/9] aacraid: Fix AIF triggered IOP_RESET

2016-02-01 Thread Raghava Aditya Renukunta
Hello Tomas, > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Monday, February 1, 2016 8:44 AM > To: Raghava Aditya Renukunta; james.bottom...@hansenpartnership.com; > martin.peter...@oracle.com; linux-scsi@vger.kernel.org > Cc: Mahesh Rajashekhara; Murthy Bhat;

Re: [v2 PATCH 1/3] scsi:stex.c Support to Pegasus series.

2016-02-01 Thread Martin K. Petersen
> "Charles" == Charles Chiou writes: Charles> Does this patch has others issues need to fix? Please resubmit your patch series with the review tag from Johannes added. Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list:

Re: [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it

2016-02-01 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> And in anycase, I guess we should be using the same logic sd.c Hannes> is using. Please see the attached patch. I'm OK with this change but please send it as a proper patch submission so somebody else can review it. -- Martin K.

Re: [PATCHv4 00/23] ALUA device handler update, part II

2016-02-01 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> as promised here is now the second part of my ALUA device Hannes> handler update. This contains a major rework of the ALUA device Hannes> handler as execution is moved onto a workqueue. This has the Hannes> advantage that we avoid

investici

2016-02-01 Thread Fu
dobrý vecer, Rád bych Vás informovali o investici stejných výhod pro nás, a ty me meli kontaktovat na e-mailu níže tomto, pokud máte zájem. email: fng.ni...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH] Separate target visibility from reaped state information

2016-02-01 Thread Martin K. Petersen
> "Sebastian" == Sebastian Herbszt writes: >> The only change from the current workflow is that the DEL transition >> (now the reaped flag) is done before the spin lock is dropped which >> would fix a tiny window for two threads both trying to remove the >> same target, but

Re: [PATCH 0/2] RESEND: Enable iBFT IPv6 booting with prefix length

2016-02-01 Thread Martin K. Petersen
> "Lee" == Lee Duncan writes: Lee> [Resending. Apologies if you get this twice.] It turns out that Lee> IPv6 doesn't care about netmask, but instead uses "prefix length" Lee> to determine the subnet, but the iBFT subsystem still just supports Lee> netmask. Mike, care to

Re: [PATCH] megaraid: fix null pointer check in megasas_detach_one().

2016-02-01 Thread Martin K. Petersen
> "Maurizio" == Maurizio Lombardi writes: Maurizio> The pd_seq_sync pointer can't be NULL, we have to check its Maurizio> entries instead. Sumit? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 5/7] scsi: qla4xxx: shut up warning for rd_reg_indirect

2016-02-01 Thread Nilesh Javali
On 27/01/16 9:27 PM, "Arnd Bergmann" wrote: >The qla4_83xx_rd_reg_indirect() function can fail when it is unable >to read a register, but not all callers check its return value before >using the register data, and gcc correctly warns about this: > >qla4xxx/ql4_83xx.c: In

[PATCH 11/12] be2iscsi: _bh for io_sgl_lock and mgmt_sgl_lock

2016-02-01 Thread Jitendra Bhivare
Processing of mgmt and IO tasks are done in process context and sofitrqs. Allocation and freeing of sgl_handles needs to be done under spin_lock_bh/spin_unlock_bh and move the locks to the routines. Signed-off-by: Jitendra Bhivare ---

RE: [PATCH v6 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers

2016-02-01 Thread ygardi
> > >> +cdb_len = min_t(unsigned short, lrbp->cmd->cmd_len, MAX_CDB_SIZE); >> +memcpy(ucd_req_ptr->sc.cdb, lrbp->cmd->cmnd, cdb_len); >> +if (cdb_len < MAX_CDB_SIZE) >> +memset(ucd_req_ptr->sc.cdb + cdb_len, 0, >> + (MAX_CDB_SIZE - cdb_len)); > It's just

[PATCH 01/12] be2iscsi: Remove unused mcc_cq_lock

2016-02-01 Thread Jitendra Bhivare
mcc_cq_lock spin_lock is used only in beiscsi_process_mcc which is called only when all interrupts are disabled from mgmt_epfw_cleanup during unloading of driver. There is no other context where there can be contention for the processing of CQ. Signed-off-by: Jitendra Bhivare

[PATCH 08/12] be2iscsi: Fix MCC WRB leak in open_connection

2016-02-01 Thread Jitendra Bhivare
In open with IP of unknown address family, only tag is freed and error returned. MCC WRB allocated for the operation is not freed. Added check for supported family of IP in the beginning before allocating the tag and WRB. Signed-off-by: Jitendra Bhivare ---

[PATCH 00/12] be2iscsi: critical fixes for 11.0.0.0

2016-02-01 Thread Jitendra Bhivare
This driver update has critical fixes for following issues: - Management tasks with incorrect ExpStatSn - WRB allocation failures in IO path - MCC WRB leak Jitendra Bhivare (12): be2iscsi: Remove unused mcc_cq_lock be2iscsi: Use macros for MCC WRB and CQE fields be2iscsi: Remove redundant

[PATCH 09/12] be2iscsi: Couple MCC tag and WRB alloc and free

2016-02-01 Thread Jitendra Bhivare
WARN_ON(atomic_read(>used) >= mccq->len) seen when FW gets into UE. MCCQ overflow is happening because driver discards any new request and frees up the tag. The tag allocation controls the number of MCC WRB posted. It is being replenished but WRBs are not hence the WARN_ON. Allocation and

[PATCH 05/12] be2iscsi: Remove be_mbox_notify_wait function

2016-02-01 Thread Jitendra Bhivare
be_mbox_notify_wait does exactly same thing as be_mbox_notify. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_cmds.c | 79 +++-- 1 file changed, 4 insertions(+), 75 deletions(-) diff --git

[PATCH 12/12] be2iscsi: Add lock to protect WRB alloc and free

2016-02-01 Thread Jitendra Bhivare
FW got into UE after running IO stress test With kernel change to split session lock in frwd_lock and back_lock for tx and rx path correspondingly, in the IO path, common resource used in driver such as WRB was left unprotected. Add wrb_lock spinlock to protect allocation and freeing of WRB.

[PATCH 03/12] be2iscsi: Remove redundant MCC processing code

2016-02-01 Thread Jitendra Bhivare
be_mcc_compl_process_isr is removed. MCC CQ processing is done only in beiscsi_process_mcc_cq and MCC CQE processing is done only in beiscsi_process_mcc_compl. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_cmds.c | 164

[PATCH 02/12] be2iscsi: Use macros for MCC WRB and CQE fields

2016-02-01 Thread Jitendra Bhivare
Rename mcc_numtag to mcc_tag_status. MCC CQE status is processed using macros already defined in be_cmds.h. Add MCC_Q_WRB_ and MCC_Q_CMD_TAG_MASK macros to map to already defined CQE_STATUS_ macros to be consistent when posting MCC. Signed-off-by: Jitendra Bhivare

[PATCH 07/12] be2iscsi: Cleanup processing of BMBX completion

2016-02-01 Thread Jitendra Bhivare
Remove confusingly named be_mcc_compl_is_new and be_mcc_compl_use functions in processing of BMBX. Rearrange beiscsi_process_mbox_compl function. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_cmds.c | 75 - 1

[PATCH 04/12] be2iscsi: Rename MCC and BMBX processing functions

2016-02-01 Thread Jitendra Bhivare
beiscsi_mccq_compl -> beiscsi_mccq_compl_wait - indicate blocking call. be_mcc_wait_compl -> be_mcc_compl_poll - indicate polling for completion. be_mbox_db_ready_wait -> be_mbox_db_ready_poll - indicate polling for RDY. be_mcc_compl_process -> beiscsi_process_mbox_compl - indicate BMBX compl.

[PATCH 06/12] be2iscsi: Fix be_mcc_compl_poll to use tag_state

2016-02-01 Thread Jitendra Bhivare
be_mcc_compl_poll waits till 'used' count of MCC WRBQ is zero. This is to determine the completion of an MCC sent. Change function to poll for the tag of MCC sent, instead, and wait till its tag_state is cleared. Signed-off-by: Jitendra Bhivare ---

[PATCH 10/12] be2iscsi: Fix ExpStatSn in management tasks

2016-02-01 Thread Jitendra Bhivare
Connection resets observed from some targets when NOP-Out with wrong ExpStatSn is sent. FW keeps track of StatSn and fills up ExpStatSn accordingly. The header filled up by the stack needs to be modified by driver to clear ExpStatSn. If the field is not cleared, FW recalculates ExpStatSn and

Re: mm: another VM_BUG_ON_PAGE(PageTail(page))

2016-02-01 Thread Dmitry Vyukov
On Fri, Jan 29, 2016 at 1:35 PM, Kirill A. Shutemov wrote: > From 691a961bb401c5815ed741dac63591efbc6027e3 Mon Sep 17 00:00:00 2001 > From: "Kirill A. Shutemov" > Date: Fri, 29 Jan 2016 15:06:17 +0300 > Subject: [PATCH 2/2]

re: lpfc: Modularize and cleanup FDMI code in driver

2016-02-01 Thread Dan Carpenter
Hello James Smart, The patch 4258e98ee386: "lpfc: Modularize and cleanup FDMI code in driver" from Dec 16, 2015, leads to the following static checker warning: drivers/scsi/lpfc/lpfc_ct.c:2547 lpfc_fdmi_cmd() error: __memcpy() '>rpl.pe' too small (4 vs 8)

Re: megaraid_sas: add an i/o barrier

2016-02-01 Thread Tomas Henzl
On 1.2.2016 05:45, Kashyap Desai wrote: >> -Original Message- >> From: Tomas Henzl [mailto:the...@redhat.com] >> Sent: Friday, January 29, 2016 11:05 PM >> To: 'linux-scsi@vger.kernel.org' >> Cc: sumit.sax...@avagotech.com; Desai, Kashyap; Uday Lingala >> Subject: megaraid_sas: add an i/o

[PATCH v7 09/14] scsi: ufs: fix error recovery after the hibern8 exit failure

2016-02-01 Thread Yaniv Gardi
Hibern8 exit can be called from 3 different context: - ufshcd_hibern8_exit_work - ufshcd_ungate_work - runtime/system resume If hibern8 exit fails for some reason then we try to bring the link to active state by link startup but this recovery mechanism results into deadlock or errors

[PATCH v7 07/14] scsi: ufs: add retries to dme_peer get and set attribute

2016-02-01 Thread Yaniv Gardi
The dme_peer get/set attribute commands are prone to errors, therefore we add three retries for the UIC command sending. Error code returned from ufshcd_send_uic_cmd() is checked, and unless it was successful or the retries have finished, another command will be sent. Reviewed-by: Gilad Broner

[PATCH v7 06/14] scsi: ufs: avoid exception event handler racing with PM callbacks

2016-02-01 Thread Yaniv Gardi
If device raises the exception event in the response to the commands sent during the runtime/system PM callbacks, exception event handler might run in parallel with PM callbacks and may see unclocked register accesses. This change fixes this issue by not scheduling the exception event handler

[PATCH v7 05/14] scsi: ufs: increase fDeviceInit query response timeout

2016-02-01 Thread Yaniv Gardi
fDeviceInit query response time for some devices is too long that default query request timeout of 100ms may not be enough. Experiments show that fDeviceInit response sometimes takes 500ms so to be on safer side this change sets the timeout to 600ms. Without this change, we might unnecessarily

[PATCH v7 03/14] scsi: ufs: verify command tag validity

2016-02-01 Thread Yaniv Gardi
A race condition appear to exist between request completion when scsi_done() is called to end the request and set the tag back to -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error handling which aborts the command and reuses it to request sense data. Sending the request sense is

RE: megaraid_sas: add an i/o barrier

2016-02-01 Thread Kashyap Desai
> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Monday, February 01, 2016 6:23 PM > To: Kashyap Desai; linux-scsi@vger.kernel.org > Cc: Sumit Saxena; Uday Lingala > Subject: Re: megaraid_sas: add an i/o barrier > > On 1.2.2016 05:45, Kashyap Desai wrote: > >>

[PATCH] add support for DWC UFS Host Controller

2016-02-01 Thread Joao Pinto
Please consider this patch. This patch includes: - quirks in the ufs core driver to support Synopsys MPHY Test Chip config - quirks in the ufs core driver to support DWC configuration sequence - New Unipro attributes were added - ufs core driver was tweaked to support UFS 2.0 - support for

[PATCH v7 01/14] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers

2016-02-01 Thread Yaniv Gardi
Clear the UFS data structures before sending new request. The SCSI command is sent to the device within the UFS UPIU request. As part of the transfer UPIU preparation, the SCSI command is copied to the UPIU structure according to the SCSI command size. As different SCSI commands differ in size

[PATCH v7 10/14] scsi: ufs: retry failed query flag requests

2016-02-01 Thread Yaniv Gardi
UFS flag query requests may fail sometimes due to timeouts etc. Add a wrapper function to retry up to 10 times in case of such failure, similar to retries being made for attribute queries. Reviewed-by: Dolev Raviv Signed-off-by: Gilad Broner

[PATCH v7 11/14] scsi: ufs: reduce the interrupts for power mode change requests

2016-02-01 Thread Yaniv Gardi
DME commands such as Hibern8 enter/exit and gear switch generate 2 completion interrupts, one for confirmation that command is received by local UniPro and 2nd one is the final confirmation after communication with remote UniPro. Currently both of these completions are registered as interrupt

[PATCH v7 12/14] scsi: ufs: add missing memory barriers

2016-02-01 Thread Yaniv Gardi
Performing several writes to UFS host controller registers has no guarantee of ordering, so we must make sure register writes to setup request list base address etc. are performed before the run/stop register is enabled. In addition, when setting up a task request, we must make sure the updating

[PATCH v7 14/14] scsi: ufs: add wrapper for retrying sending query attribute

2016-02-01 Thread Yaniv Gardi
Sometimes queries from the device might return a failure so it is recommended to retry sending the query, before giving up. This change adds a wrapper to retry sending a query attribute, in cases where we need to wait longer, before we continue, or before reporting a failure. Reviewed-by: Gilad

[PATCH v7 13/14] scsi: ufs: commit descriptors before setting the doorbell

2016-02-01 Thread Yaniv Gardi
Add a write memory barrier to make sure descriptors prepared are actually written to memory before ringing the doorbell. We have also added the write memory barrier after ringing the doorbell register so that controller sees the new request immediately. Reviewed-by: Dolev Raviv

[PATCH v7 08/14] scsi: ufs: add retries for hibern8 enter

2016-02-01 Thread Yaniv Gardi
If hibern8 enter command fails then UFS link state may be unknown which may result into timeout of all the commands issued after failure. This change does 2 things (for pre-defined number of retry counts) after hibern8 enter failure: 1. Recovers the UFS link to active state 2. If link is

[PATCH v7 04/14] scsi: ufs: clear outstanding_request bit in case query timeout

2016-02-01 Thread Yaniv Gardi
When sending a query to the device returns with a timeout error, we clear the corresponding bit in the DOORBELL register but we don't clear the outstanding_request field as we should. This patch fixes this bug. Reviewed-by: Subhash Jadavani Reviewed-by: Gilad Broner

[PATCH v7 00/14] Big fixes, retries, handle a race condition

2016-02-01 Thread Yaniv Gardi
V7: updated patch 0001 according to a comment also, removed patch 07/15 from V6, so now there are only 14 patches V6: update Reviewed-by from various reviewers V5: removed un-necessary wmb() V4: fixing a few comments from reviewers V3: removed specific calls to wmb() since they are redundant.

[PATCH v7 02/14] scsi: ufs: clear fields UTRD, UPIU req and rsp before new transfers

2016-02-01 Thread Yaniv Gardi
Some of the data structures (like response UPIU) and/or its elements (unused fields) should be cleared before sending out the respective command to UFS device. This change clears the UPIU response data structure for query commands and NOP command before sending out the command. We also initialize

Re: [Bug 111441] New: iscsi fails to attach to targets

2016-02-01 Thread Mike Christie
On 01/30/2016 01:38 AM, Nicholas A. Bellinger wrote: > On Fri, 2016-01-29 at 17:32 -0600, Mike Christie wrote: >> On 01/29/2016 04:21 PM, Serguei Bezverkhi (sbezverk) wrote: >>> HI Mike, >>> >>> I tried your patch and it is has eliminated first traceback but I still do >>> not see my remote

[PATCH] target: fix cast from pointer to phys_addr_t

2016-02-01 Thread Arnd Bergmann
The uio_mem structure has a member that is a phys_addr_t, but can be a number of other types too. The target core driver attempts to assign a pointer from vmalloc() to it, by casting it to phys_addr_t, but that causes a warning when phys_addr_t is longer than a pointer:

Re: [PATCH 01/12] be2iscsi: Remove unused mcc_cq_lock

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:40PM +0530, Jitendra Bhivare wrote: > mcc_cq_lock spin_lock is used only in beiscsi_process_mcc which is called > only when all interrupts are disabled from mgmt_epfw_cleanup during > unloading of driver. There is no other context where there can be > contention for

Re: [PATCH 01/12] be2iscsi: Remove unused mcc_cq_lock

2016-02-01 Thread James Bottomley
On Mon, 2016-02-01 at 15:42 +0530, Jitendra Bhivare wrote: > mcc_cq_lock spin_lock is used only in beiscsi_process_mcc which is > called > only when all interrupts are disabled from mgmt_epfw_cleanup during > unloading of driver. There is no other context where there can be > contention for the

Re: [PATCH 04/12] be2iscsi: Rename MCC and BMBX processing functions

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:43PM +0530, Jitendra Bhivare wrote: > beiscsi_mccq_compl -> beiscsi_mccq_compl_wait - indicate blocking call. > be_mcc_wait_compl -> be_mcc_compl_poll - indicate polling for completion. > be_mbox_db_ready_wait -> be_mbox_db_ready_poll - indicate polling for RDY. >

Re: [PATCH 08/12] be2iscsi: Fix MCC WRB leak in open_connection

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:47PM +0530, Jitendra Bhivare wrote: > In open with IP of unknown address family, only tag is freed and error > returned. MCC WRB allocated for the operation is not freed. > > Added check for supported family of IP in the beginning before > allocating the tag and WRB.

Re: [PATCH 12/12] be2iscsi: Add lock to protect WRB alloc and free

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:51PM +0530, Jitendra Bhivare wrote: > FW got into UE after running IO stress test > > With kernel change to split session lock in frwd_lock and back_lock for tx > and rx path correspondingly, in the IO path, common resource used in driver > such as WRB was left

Re: [PATCH 04/12] be2iscsi: Rename MCC and BMBX processing functions

2016-02-01 Thread kbuild test robot
Hi Jitendra, [auto build test ERROR on scsi/for-next] [also build test ERROR on next-20160201] [cannot apply to v4.5-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jitendra-Bhivare

Re: [PATCH 11/12] be2iscsi: _bh for io_sgl_lock and mgmt_sgl_lock

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:50PM +0530, Jitendra Bhivare wrote: > Processing of mgmt and IO tasks are done in process context and sofitrqs. > > Allocation and freeing of sgl_handles needs to be done under > spin_lock_bh/spin_unlock_bh and move the locks to the routines. > > Signed-off-by:

[PATCH] add support for DWC UFS Host Controller

2016-02-01 Thread Joao Pinto
This patch includes: - quirks in the ufs core driver to support Synopsys MPHY Test Chip config - quirks in the ufs core driver to support DWC configuration sequence - New Unipro attributes were added - ufs core driver was tweaked to support UFS 2.0 - support for Synopsys PCI ID in the pci glue

Re: [PATCH 03/12] be2iscsi: Remove redundant MCC processing code

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:42PM +0530, Jitendra Bhivare wrote: > be_mcc_compl_process_isr is removed. > MCC CQ processing is done only in beiscsi_process_mcc_cq and MCC CQE > processing is done only in beiscsi_process_mcc_compl. > > Signed-off-by: Jitendra Bhivare

Re: [PATCH v6 07/15] scsi: ufs: set REQUEST_SENSE command size to 18 bytes

2016-02-01 Thread ygardi
> On 10/28/2015 02:13 PM, Yaniv Gardi wrote: >> According to UFS device specification REQUEST_SENSE command can >> only report back up to 18 bytes of data. >> >> Reviewed-by: Dolev Raviv >> Signed-off-by: Gilad Broner >> Signed-off-by: Yaniv Gardi

Re: [PATCH 09/12] be2iscsi: Couple MCC tag and WRB alloc and free

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:48PM +0530, Jitendra Bhivare wrote: > WARN_ON(atomic_read(>used) >= mccq->len) seen when FW gets into UE. > > MCCQ overflow is happening because driver discards any new request and > frees up the tag. The tag allocation controls the number of MCC WRB posted. > It is

Re: scsi_debug, iosize optimal < minimum

2016-02-01 Thread Martin K. Petersen
> "Ruediger" == Ruediger Meier writes: Ruediger> I've noticed a possible problem with scsi_debug devices where Ruediger> optimal_io_size < minimum_io_size. Ruediger> The problem seems reproducable with kernel 4.4.0 and also with Ruediger> stable version 4.1.15. For stable

Re: [PATCH 10/12] be2iscsi: Fix ExpStatSn in management tasks

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:49PM +0530, Jitendra Bhivare wrote: > Connection resets observed from some targets when NOP-Out with wrong > ExpStatSn is sent. > > FW keeps track of StatSn and fills up ExpStatSn accordingly. > The header filled up by the stack needs to be modified by driver to

Re: [PATCH 02/12] be2iscsi: Use macros for MCC WRB and CQE fields

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:41PM +0530, Jitendra Bhivare wrote: > Rename mcc_numtag to mcc_tag_status. > MCC CQE status is processed using macros already defined in be_cmds.h. > > Add MCC_Q_WRB_ and MCC_Q_CMD_TAG_MASK macros to map to already defined > CQE_STATUS_ macros to be consistent when

Re: [PATCH 05/12] be2iscsi: Remove be_mbox_notify_wait function

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:44PM +0530, Jitendra Bhivare wrote: > be_mbox_notify_wait does exactly same thing as be_mbox_notify. > > Signed-off-by: Jitendra Bhivare > --- > drivers/scsi/be2iscsi/be_cmds.c | 79 > +++-- > 1

Re: [PATCH 06/12] be2iscsi: Fix be_mcc_compl_poll to use tag_state

2016-02-01 Thread Johannes Thumshirn
On Mon, Feb 01, 2016 at 03:42:45PM +0530, Jitendra Bhivare wrote: > be_mcc_compl_poll waits till 'used' count of MCC WRBQ is zero. This is to > determine the completion of an MCC sent. > > Change function to poll for the tag of MCC sent, instead, and wait till > its tag_state is cleared. > >

Re: [PATCH V4 7/9] aacraid: Fix AIF triggered IOP_RESET

2016-02-01 Thread Tomas Henzl
On 29.1.2016 23:45, Raghava Aditya Renukunta wrote: > From: Raghava Aditya Renukunta > > while driver removal is in progress or PCI shutdown is invoked, driver > kills AIF aacraid thread, but IOCTL requests from the management tools > re-start AIF thread leading

blk-merge: BIO front merge size check for chunked devices

2016-02-01 Thread Damien Le Moal
Hello, In ll_front_merge_fn, the request size result of the eventual front merge of a BIO with a request is checked against the maximum size allowed for the request using blk_rq_get_max_sectors. This function will also check that the merge result will not span block chunks for chunked block

Re: [PATCH 2/2] iscsi_ibft: Always display netmask

2016-02-01 Thread Mike Christie
On 01/22/2016 01:49 PM, Lee Duncan wrote: > From: Hannes Reinecke > > Some older user-space code might rely on the netmask attribute > being present, so we should always display it. > This fixes a regression introduced by commit > 0b2eb3c4060a16f3ec11a4d6d4c934e7e5d5334f. > >

Re: blk-merge: BIO front merge size check for chunked devices

2016-02-01 Thread Hannes Reinecke
On 02/02/2016 08:06 AM, Damien Le Moal wrote: > > Hello, > > In ll_front_merge_fn, the request size result of the eventual front > merge of a BIO with a request is checked against the maximum > size allowed for the request using blk_rq_get_max_sectors. This > function will also check that the

Re: [PATCH] Separate target visibility from reaped state information

2016-02-01 Thread Bart Van Assche
On 01/19/16 17:03, James Bottomley wrote: On Tue, 2016-01-19 at 19:30 -0500, Martin K. Petersen wrote: "Bart" == Bart Van Assche writes: Bart> Instead of representing the states "visible in sysfs" and "has Bart> been removed from the target list" by a single state

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

2016-02-01 Thread Kai Mäkisara (Kolumbus)
> On 1.2.2016, at 8.31, Seymour, Shane M wrote: > > Hi Kai, > > Thanks for the changes the HPE DAT72 DDS5 drive now works as expected: > Good. Thanks for testing. ... > > I'm asking around again one final time to see if I can lay my hands on a LTO5 > or greater drive

[PATCH v2] megaraid_sas: add an i/o barrier

2016-02-01 Thread Tomas Henzl
A barrier should be added to ensure proper ordering of memory mapped writes. V2: - added the barrier also to megasas_fire_cmd_skinny, as suggested by Kashyap Desai Signed-off-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 1 +

Re: [PATCH] bnx2fc: bnx2fc_eh_abort(): fix wrong return code.

2016-02-01 Thread Ewan Milne
On Mon, 2016-02-01 at 16:08 +0100, Maurizio Lombardi wrote: > If the link is not ready, the bnx2fc_eh_abort() function > should return FAILED. > > Signed-off-by: Maurizio Lombardi > --- > drivers/scsi/bnx2fc/bnx2fc_io.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

[PATCH] bnx2fc: bnx2fc_eh_abort(): fix wrong return code.

2016-02-01 Thread Maurizio Lombardi
If the link is not ready, the bnx2fc_eh_abort() function should return FAILED. Signed-off-by: Maurizio Lombardi --- drivers/scsi/bnx2fc/bnx2fc_io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c

Re: [PATCH] bnx2fc: bnx2fc_eh_abort(): fix wrong return code.

2016-02-01 Thread Chad Dupuis
On Mon, 1 Feb 2016, Maurizio Lombardi wrote: If the link is not ready, the bnx2fc_eh_abort() function should return FAILED. Signed-off-by: Maurizio Lombardi --- drivers/scsi/bnx2fc/bnx2fc_io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git