Re: [PATCH] scsi: Make scsi_vpd_lun_id() able to use T10 vendor ID based designators

2016-05-04 Thread Paul Mackerras
On Wed, May 04, 2016 at 12:04:16PM +0200, Hannes Reinecke wrote: > On 05/04/2016 08:58 AM, Paul Mackerras wrote: > > This adds code to scsi_vpd_lun_id() to enable it to use T10 vendor ID > > based designators. This is needed to allow alua to work on disks that > > don't have any designators of

Re: [PATCH v2.5 6/6] scsi_debug: use locally assigned naa

2016-05-04 Thread Bart Van Assche
On 04/30/2016 07:44 PM, Douglas Gilbert wrote: For reported SAS addresses replace fake IEEE registered NAAs (5) with locally assigned NAAs (3). Signed-off-by: Douglas Gilbert Reviewed-by: Bart Van Assche -- To unsubscribe from this list:

Re: [PATCH v2.5 5/6] scsi_debug: uuid for lu name

2016-05-04 Thread Bart Van Assche
On 04/30/2016 07:44 PM, Douglas Gilbert wrote: Permit changing of a LU name from a (fake) IEEE registered NAA (5) to a locally assigned UUID. Using a UUID (RFC 4122) for a SCSI designation descriptor (e.g. a LU name) was added in spc5r08.pdf (a draft INCITS standard) on 25 January 2016. Add

Re: [PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-05-04 Thread Bart Van Assche
On 04/30/2016 07:44 PM, Douglas Gilbert wrote: +static struct sdebug_queue *get_queue(void) +{ + struct sdebug_queue *sqp = sdebug_q_arr; + + return sqp + (raw_smp_processor_id() % submit_queues); +} Does this function have the same purpose as blk_mq_map_queue()? If so, why has

Re: [PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-05-04 Thread Bart Van Assche
On 05/02/2016 01:35 AM, Hannes Reinecke wrote: On 05/01/2016 04:44 AM, Douglas Gilbert wrote: Add submit_queue parameter (minimum and default: 1; maximum: nr_cpu_ids) that controls how many queues are built, each with their own lock and in_use bit vector. Add statistics parameter which is

Re: [PATCH 1/1] cxlflash: Fix to resolve dead-lock during EEH recovery

2016-05-04 Thread Matthew R. Ochs
Acked-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

2016-05-04 Thread Mike Christie
On 05/04/2016 12:58 PM, Jeff Moyer wrote: > Mike Christie writes: > >> On 05/03/2016 03:44 PM, Jeff Moyer wrote: >>> Hi, Mike, >>> >>> That git tree doesn't seem to exist. I did manage to apply your patch >>> set on top of next-20160415, though. >>> >>> So... what testing

Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

2016-05-04 Thread Jeff Moyer
Mike Christie writes: > On 05/03/2016 03:44 PM, Jeff Moyer wrote: >> Hi, Mike, >> >> That git tree doesn't seem to exist. I did manage to apply your patch >> set on top of next-20160415, though. >> >> So... what testing did you do? ;-) I ran into the following problems >

Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

2016-05-04 Thread Mike Christie
On 05/03/2016 03:44 PM, Jeff Moyer wrote: > mchri...@redhat.com writes: > >> The following patches begin to cleanup the request->cmd_flags and >> bio->bi_rw mess. We currently use cmd_flags to specify the operation, >> attributes and state of the request. For bi_rw we use it for similar >> info

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-04 Thread Antonio Quartulli
On Tue, May 03, 2016 at 04:33:13PM +0200, Florian Westphal wrote: > Replace all trans_start updates with netif_trans_update helper. > change was done via spatch: > > struct net_device *d; > @@ > - d->trans_start = jiffies > + netif_trans_update(d) > > Compile tested only. > > Cc:

Re: libiscsi: Use scsi helper to set information descriptor

2016-05-04 Thread Dan Carpenter
You saw the bug in the end right? 1112 u8 iser_check_task_pi_status(struct iscsi_iser_task *iser_task, 1113 enum iser_data_dir cmd_dir, sector_t *sector) ^^ The caller assumes

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-04 Thread Mugunthan V N
On Tuesday 03 May 2016 08:03 PM, Florian Westphal wrote: > Replace all trans_start updates with netif_trans_update helper. > change was done via spatch: > > struct net_device *d; > @@ > - d->trans_start = jiffies > + netif_trans_update(d) > > Compile tested only. > > Cc:

Re: [PATCH] scsi: Make scsi_vpd_lun_id() able to use T10 vendor ID based designators

2016-05-04 Thread Hannes Reinecke
On 05/04/2016 08:58 AM, Paul Mackerras wrote: > This adds code to scsi_vpd_lun_id() to enable it to use T10 vendor ID > based designators. This is needed to allow alua to work on disks that > don't have any designators of type 2, 3 or 8. Commit 0047220c6c36 > ("scsi_dh_alua: use unique device

[PATCH] scsi: Make scsi_vpd_lun_id() able to use T10 vendor ID based designators

2016-05-04 Thread Paul Mackerras
This adds code to scsi_vpd_lun_id() to enable it to use T10 vendor ID based designators. This is needed to allow alua to work on disks that don't have any designators of type 2, 3 or 8. Commit 0047220c6c36 ("scsi_dh_alua: use unique device id", 2016-02-19) added a requirement that alua can only

Re: Regression in v4.6-rc due to SCSI multipath change

2016-05-04 Thread Hannes Reinecke
On 05/04/2016 08:51 AM, Paul Mackerras wrote: > Current upstream kernels fail to boot on my POWER8 server with > multipath SCSI disks and IPR host bus adapters. What happens is that > the system finds each disk twice (as normal) and then prints messages > like this: > > [2.827761] sd

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-04 Thread Felipe Balbi
Hi, Florian Westphal writes: > Replace all trans_start updates with netif_trans_update helper. > change was done via spatch: > > struct net_device *d; > @@ > - d->trans_start = jiffies > + netif_trans_update(d) > > Compile tested only. > > Cc:

RE: [PATCH v2] megaraid: Downgrade two success messages to info

2016-05-04 Thread Sumit Saxena
> -Original Message- > From: Andy Lutomirski [mailto:l...@kernel.org] > Sent: Tuesday, May 03, 2016 10:55 PM > To: Kashyap Desai; Sumit Saxena; Uday Lingala > Cc: megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org; Andy > Lutomirski > Subject: [PATCH v2] megaraid: Downgrade two

Regression in v4.6-rc due to SCSI multipath change

2016-05-04 Thread Paul Mackerras
Current upstream kernels fail to boot on my POWER8 server with multipath SCSI disks and IPR host bus adapters. What happens is that the system finds each disk twice (as normal) and then prints messages like this: [2.827761] sd 1:2:4:0: alua: supports implicit TPGS [2.827875] sd 1:2:4:0:

Re: [PATCH v2] megaraid: Downgrade two success messages to info

2016-05-04 Thread Hannes Reinecke
On 05/03/2016 07:24 PM, Andy Lutomirski wrote: > I actually read the error messages in my logs, and successful > initialization is not an error. > > Arguably these log lines could be deleted entirely. > > Signed-off-by: Andy Lutomirski > --- > > Changes from v2: Remove hunk

[patch] [SCSI] eata_pio: missing break statement

2016-05-04 Thread Dan Carpenter
This missing break statement bug predates git. It's a very minor thing, it means that we print a '?' instead of a 'z' in dmesg. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c index ca8003f..4299fa4 100644 ---