[PATCH] sd: Fix rw_max for devices that report an optimal xfer size

2016-05-19 Thread Martin K. Petersen
For historic reasons, io_opt is in bytes and max_sectors in block layer sectors. This interface inconsistency is error prone and should be fixed. But for 4.4--4.7 let's make the unit difference explicit via a wrapper function. Fixes: d0eb20a863ba ("sd: Optimal I/O size is in bytes, not sectors")

Re: [PATCH 1/7] snic: fix typo

2016-05-19 Thread Martin K. Petersen
> "Julia" == Julia Lawall writes: Julia> firmare -> firmware Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] aacraid: do not activate events on non-SRC adapters

2016-05-19 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> Only SRC-based adapters support the AifReqEvent function, so Hannes> there is no point in trying to activate it on older, non-SRC Hannes> based adapters. Doing so lead to crashes on older adapters. Applied to 4.7/scsi-fixes. --

Re: [PATCH] sd: get disk reference in sd_check_events()

2016-05-19 Thread Martin K. Petersen
> "Ewan" == Ewan D Milne writes: Ewan> Reviewed-by: Ewan D. Milne Applied to 4.7/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH] scsi_lib: correctly retry failed zero length REQ_TYPE_FS commands

2016-05-19 Thread Martin K. Petersen
> "James" == James Bottomley writes: James> When SCSI was written, all commands coming from the filesystem James> (REQ_TYPE_FS commands) had data. This meant that our signal for James> needing to complete the command was the number of bytes completed

Re: [PATCH 0/2] UFS DWC Test Chip pci driver tweaks

2016-05-19 Thread Martin K. Petersen
> "Joao" == Joao Pinto writes: Joao, Joao> This patch set has the tweaks that I described to you in an Joao> e-mail, all related with the ufs test chip pci driver. I have applied the amended series to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [PATCH] scsi: ultrastor.c depends on ISA_DMA_API

2016-05-19 Thread William Breathitt Gray
On Thu, May 19, 2016 at 02:53:35PM -0400, William Breathitt Gray wrote: >Although request_dma and free_dma are conditionally dependent on >CONFIG_ISA_DMA_API inside the arch/x86/include/asm/dma.h file, they are >defined inside the kernel/dma.c file which depends on >CONFIG_GENERIC_ISA_DMA in order

Re: [PATCH] scsi: ultrastor.c depends on ISA_DMA_API

2016-05-19 Thread William Breathitt Gray
+- > 1 file changed, 1 insertion(+), 1 deletion(-) > >Found in linux-next but also applies to mainline. > >--- linux-next-20160519.orig/drivers/scsi/Kconfig >+++ linux-next-20160519/drivers/scsi/Kconfig >@@ -1433,7 +1433,7 @@ config SCSI_U14_34F_MAX_TAGS > > config SCSI_UL

RE: [PATCH] [SCSI] aacraid: use kmemdup

2016-05-19 Thread Raghava Aditya Renukunta
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Muhammad Falak R Wani > Sent: Thursday, May 19, 2016 7:09 AM > To: Hannes Reinecke > Cc: Adaptec OEM Raid Solutions; James E.J. Bottomley; Martin K. Petersen; >

RE: [PATCH] aacraid: do not activate events on non-SRC adapters

2016-05-19 Thread Raghava Aditya Renukunta
Reviewed-by: Raghava Aditya Renukunta > -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, May 18, 2016 1:17 AM > To: Martin K. Petersen > Cc: James Bottomley; Christoph Hellwig; linux-scsi@vger.kernel.org; >

[PATCH] scsi: ultrastor.c depends on ISA_DMA_API

2016-05-19 Thread Randy Dunlap
Werror=implicit-function-declaration] free_dma(shost->dma_channel); ^ Signed-off-by: Randy Dunlap <rdun...@infradead.org> --- drivers/scsi/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Found in linux-next but also applies to mainline. --- linux-next-20160519.orig/dr

[PATCH] [SCSI] aic7xxx: use kmemdup

2016-05-19 Thread Muhammad Falak R Wani
Use kmemdup when some other buffer is immediately copied into allocated region. It replaces call to allocation followed by memcpy, by a single call to kmemdup. Signed-off-by: Muhammad Falak R Wani --- drivers/scsi/aic7xxx/aic7xxx_core.c | 4 ++-- 1 file changed, 2

[PATCH] [SCSI] aacraid: use kmemdup

2016-05-19 Thread Muhammad Falak R Wani
Use kmemdup when some other buffer is immediately copied into allocated region. It replaces call to allocation followed by memcpy, by a single call to kmemdup. Signed-off-by: Muhammad Falak R Wani --- drivers/scsi/aacraid/commctrl.c | 7 +++ 1 file changed, 3

[PATCH] [SCSI] aic79xx: use kmemdup

2016-05-19 Thread Muhammad Falak R Wani
Use kmemdup when some other buffer is immediately copied into allocated region. It replaces call to allocation followed by memcpy, by a single call to kmemdup. Signed-off-by: Muhammad Falak R Wani --- drivers/scsi/aic7xxx/aic79xx_core.c | 4 ++-- 1 file changed, 2

[PATCH] mptbase: use kmemdup

2016-05-19 Thread Muhammad Falak R Wani
Use kmemdup when some other buffer is immediately copied into allocated region. It replaces call to allocation followed by memcpy, by a single call to kmemdup. Signed-off-by: Muhammad Falak R Wani --- drivers/message/fusion/mptbase.c | 3 +-- 1 file changed, 1

Re: [PATCH v4 22/23] mac_scsi: Fix pseudo DMA implementation

2016-05-19 Thread Geert Uytterhoeven
Hi Finn, On Thu, May 19, 2016 at 2:02 PM, Finn Thain wrote: > On Thu, 19 May 2016, Geert Uytterhoeven wrote: >> In file included from drivers/scsi/mac_scsi.c:335: >> drivers/scsi/NCR5380.h:295: warning: `NCR5380_poll_politely' declared inline >> after being called >>

Re: [PATCH v4 22/23] mac_scsi: Fix pseudo DMA implementation

2016-05-19 Thread Finn Thain
On Thu, 19 May 2016, Geert Uytterhoeven wrote: > > In file included from drivers/scsi/mac_scsi.c:335: > drivers/scsi/NCR5380.h:295: warning: `NCR5380_poll_politely' declared inline > after being called > drivers/scsi/NCR5380.h:295: warning: previous declaration of > `NCR5380_poll_politely'

Re: [PATCH v4 22/23] mac_scsi: Fix pseudo DMA implementation

2016-05-19 Thread Geert Uytterhoeven
Hi Finn, On Wed, Mar 23, 2016 at 11:10 AM, Finn Thain wrote: > Fix various issues: Comments about bus errors are incorrect. The > PDMA asm must return the size of the memory access that faulted so the > transfer count can be adjusted accordingly. A phase change may