Re: [PATCH] Fix for hang of Ordered task in TCM

Hi Bryant, On Mon, 2016-05-23 at 19:17 -0400, Bryant G Ly wrote: > Quoting "Nicholas A. Bellinger" : > > > > > > So AFAICT for delayed commands, the above patch ends up skipping these > > three checks subsequently when doing __target_execute_cmd() directly > > from

Re: [PATCH] Fix for hang of Ordered task in TCM

On Wed, 2016-05-18 at 14:35 -0500, Michael Cyr wrote: > On 5/18/16 12:53 AM, Nicholas A. Bellinger wrote: > > Hi Michael, > > > > On Fri, 2016-05-13 at 17:15 -0500, Michael Cyr wrote: > >> If a command with a Simple task attribute is failed due to a Unit > >> Attention, then a subsequent command

Ahoj?

isem zastupujicí investicní zajem ze strany Dubaji, pro ktere hledáme vasi ucast. Odpoved na e-mailu nize v pripade zajmu. E-mail: pbrt...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] Fix for hang of Ordered task in TCM

Quoting "Nicholas A. Bellinger" : So AFAICT for delayed commands, the above patch ends up skipping these three checks subsequently when doing __target_execute_cmd() directly from target_restart_delayed_cmds(), no..? After pondering this some more, what about moving

Follow up on iSCSI and MQ/MCS discussion

On 01/07/2015 a discussion titled "[LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion"[0] had some good participation, but I can't seem to find anything resulting from a LSF discussion or patches implementing anything discussed in the thread. Can we get an update on where things sit? With the 4.4

[PATCH v2 1/1] uas: remove can_queue set in host template

From: Tom Yan Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") made qdepth limit set in host template (`.can_queue = MAX_CMNDS`) redundant. Removing it to avoid confusion. Signed-off-by: Tom Yan diff --git

Improve device reset for failed HDD

Hi! I've a Seagate Barracuda 7200.14 (ST2000DM001-9YN164) 2TB HDD with some bad sectors and when they're accessed it causes device to fail. It's attached to HighPoint RocketRAID 2760 HBA (mvsas) and kernel 4.6 when accesing bad sector in log can see: kernel:

Re: [PATCH 1/1] uas: leave can_queue as MAX_CMNDS if device reports larger qdepth

On Tue, 2016-05-24 at 02:33 +0800, Tom Yan wrote: > I don't quite get what you mean. Are you saying that it is impossible > that UAS devices would report inappropriately high qdepth, because of > this? > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/ >

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

On 24 May 2016 at 01:36, James Bottomley wrote: > > Are you sure about this? For spinning rust, experiments imply that the > optimal queue depth per device is somewhere between 2 and 4. Obviously > that's not true for SSDs, so it depends on your use case.

Re: [PATCH 1/1] uas: leave can_queue as MAX_CMNDS if device reports larger qdepth

I don't quite get what you mean. Are you saying that it is impossible that UAS devices would report inappropriately high qdepth, because of this? https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/storage/uas.c?h=v4.6#n908 In that case should I send another patch

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote: > Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") > removed the scsi_change_queue_depth() call from uas_slave_configure() > assuming that the slave would inherit the host's queue_depth, which > that commit sets to the

Re: [PATCH 1/1] uas: leave can_queue as MAX_CMNDS if device reports larger qdepth

On Tue, 2016-05-24 at 01:23 +0800, Tom Yan wrote: > Nothing wrong. It's just .can_queue = MAX_CMNDS in the host template > is no longer neceesary, since with his patch, uas will set can_queue > again later (to devinfo->qdepth - 2). > > Originally I thought .can_queue = MAX_CMNDS can hence be

Re: [PATCH 1/1] uas: leave can_queue as MAX_CMNDS if device reports larger qdepth

Nothing wrong. It's just .can_queue = MAX_CMNDS in the host template is no longer neceesary, since with his patch, uas will set can_queue again later (to devinfo->qdepth - 2). Originally I thought .can_queue = MAX_CMNDS can hence be removed; but after a second thought, I think it might probably

Re: [PATCH 1/1] uas: leave can_queue as MAX_CMNDS if device reports larger qdepth

On Tue, May 24, 2016 at 12:02:43AM +0800, tom.t...@gmail.com wrote: > From: Tom Yan > > Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") made > qdepth limit set in host template (`.can_queue = MAX_CMNDS`) useless. > > Instead of removing the template

Re: [PATCH] sd: Fix rw_max for devices that report an optimal xfer size

On 05/19/2016 08:16 PM, Martin K. Petersen wrote: For historic reasons, io_opt is in bytes and max_sectors in block layer sectors. This interface inconsistency is error prone and should be fixed. But for 4.4--4.7 let's make the unit difference explicit via a wrapper function. Reviewed-by: Bart

[PATCH 1/1] uas: leave can_queue as MAX_CMNDS if device reports larger qdepth

From: Tom Yan Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") made qdepth limit set in host template (`.can_queue = MAX_CMNDS`) useless. Instead of removing the template limit, now we only change limit according to the qdepth reported by the device if

Re: [RFC PATCH] libfc: Update rport reference counting

On 05/18/2016 02:52 AM, Hannes Reinecke wrote: Originally libfc would just be initializing the refcount to '1', and using the disc_mutex to synchronize if and when the final put should be happening. This has a race condition as the mutex might be delayed, causing other threads to access an

Re: [regression] uas no longer queues commands since v4.5.2

On Mon, 2016-05-23 at 13:48 +0200, Hans de Goede wrote: > Hi, > > On 22-05-16 12:39, Tom Yan wrote: > > With commit 198de51dbc3454d95b015ca0a055b673f85f01bb, uas no longer > > set `queue_depth` with scsi_change_queue_depth(), so now > > `queue_depth` > > of UAS drives are 1. Even though

[PATCH 1/1] scsi: storvsc: Filter out storvsc messages CD-ROM medium not present

When a virtual scsi DVD device is present with no image file attached the storvsc driver logs all resulting unnecessary sense errors whenever IO is issued to the device. [storvsc] Sense Key : Not Ready [current] [storvsc] Add. Sense: Medium not present - tray closed Signed-off-by: Cathy Avery

[PATCH] USB: uas: Fix slave queue_depth not being set

Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") removed the scsi_change_queue_depth() call from uas_slave_configure() assuming that the slave would inherit the host's queue_depth, which that commit sets to the same value. This is incorrect, without the

Re: [regression] uas no longer queues commands since v4.5.2

Hi, On 22-05-16 12:39, Tom Yan wrote: With commit 198de51dbc3454d95b015ca0a055b673f85f01bb, uas no longer set `queue_depth` with scsi_change_queue_depth(), so now `queue_depth` of UAS drives are 1. Even though `can_queue` is set to `devinfo->qdepth - 2`, but apparently that does not help, since

Re: [PATCH] scsi: use spinlock instead of mutex for RCU-protected VPD inquiry data

On Fri, May 20, 2016 at 08:56:14AM -0400, Ewan D. Milne wrote: > From: "Ewan D. Milne" > > A spinlock is sufficient for this purpose, and much smaller. > > Signed-off-by: Ewan D. Milne Reviewed-by: Johannes Thumshirn -- Johannes

[PATCH] ufs: Adding license info do tc-dwc-g210 and ufshcd-dwc to enable loadable modules

This patch adds license info to the tc-dwc-g210 and ufshcd-dwc files in order for them to have access to some ufshcd symbols when all are built as modules. Signed-off-by: Joao Pinto --- drivers/scsi/ufs/tc-dwc-g210.c | 4 drivers/scsi/ufs/ufshcd-dwc.c | 4 2