Re: block: don't check request size in blk_cloned_rq_check_limits()

> "Mike" == Mike Snitzer writes: >> When checking a cloned request there is no need to check the overall >> request size; this won't have changed even when resubmitting to >> another queue. Without this patch ppc64le on ibmvfc fails to boot. Why is the number of sectors

Re: kernel BUG in drivers/scsi/53c700.c:1129

On 10.06.2016 23:33, James Bottomley wrote: > On Fri, 2016-06-10 at 14:01 -0700, James Bottomley wrote: >> On Fri, 2016-06-10 at 16:58 -0400, Ewan D. Milne wrote: >>> I'm not sure if this is the problem, but the tagging changes to >>> scsi_tcq.h may have altered the 53c700 driver's assumptions.

Re: kernel BUG in drivers/scsi/53c700.c:1129

On Fri, 2016-06-10 at 14:33 -0700, James Bottomley wrote: > On Fri, 2016-06-10 at 14:01 -0700, James Bottomley wrote: > > On Fri, 2016-06-10 at 16:58 -0400, Ewan D. Milne wrote: > > > I'm not sure if this is the problem, but the tagging changes to > > > scsi_tcq.h may have altered the 53c700

[RFC] [PATCH 3/3] ipr: Use libata new EH

Converts ipr to use the new EH API of libata, removing the last user of this API, allowing for its ultimate removal from the kernel. Sending this out only as an RFC for now. The patch will need significantly more testing, but I can now detect and initialize a SATA device and the main functional

[RFC] [PATCH 2/3] scsi: Export SCSI EH commands

Export the following EH commands so that ipr can be converted to use libata's new EH. Signed-off-by: Brian King --- drivers/scsi/scsi_error.c |5 +++-- include/scsi/scsi_eh.h|5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff -puN

[RFC] [PATCH 1/3] ipr: Wait to do async scan until scsi host is initialized

When performing an async scan, make sure the kthread doing scanning doesn't start before the scsi host is fully initialized. Signed-off-by: Brian King --- drivers/scsi/ipr.c |9 + drivers/scsi/ipr.h |1 + 2 files changed, 10 insertions(+) diff -puN

[RFC] [PATCH 0/3] Convert ipr to use ata_port_operations->error_handler

On 05/26/2016 09:12 AM, Brian King wrote: > On 05/25/2016 02:32 PM, Tejun Heo wrote: >> Hello, Brian. >> >> So, of all the ata drivers, ipr seems to be the only driver which >> doesn't implement ata_port_opeations->error_handler and thus depends >> on the old error handling path. I'm wondering

Re: kernel BUG in drivers/scsi/53c700.c:1129

On Fri, 2016-06-10 at 14:01 -0700, James Bottomley wrote: > On Fri, 2016-06-10 at 16:58 -0400, Ewan D. Milne wrote: > > I'm not sure if this is the problem, but the tagging changes to > > scsi_tcq.h may have altered the 53c700 driver's assumptions. > > In one case it sets sdev->current_cmnd and

Re: kernel BUG in drivers/scsi/53c700.c:1129

On Fri, 2016-06-10 at 16:58 -0400, Ewan D. Milne wrote: > I'm not sure if this is the problem, but the tagging changes to > scsi_tcq.h may have altered the 53c700 driver's assumptions. > In one case it sets sdev->current_cmnd and then some of the > tagging calls would return it if the tag was

Re: kernel BUG in drivers/scsi/53c700.c:1129

I'm not sure if this is the problem, but the tagging changes to scsi_tcq.h may have altered the 53c700 driver's assumptions. In one case it sets sdev->current_cmnd and then some of the tagging calls would return it if the tag was SCSI_NO_TAG. NCR_700_queuecommand_lck() does: if

[PATCH][SCSI] 53c700: Use proper debug printk format specifiers

When enabling the debug options NCR_700_DEBUG and NCR_700_TAG_DEBUG various printk format warnings can be seen like: drivers/scsi/53c700.c:357:2: warning: format ‘%p’ expects argument of type ‘void *’, but argument 4 has type ‘dma_addr_t’ [-Wformat=] script_patch_32(hostdata->dev, script,

Re: kernel BUG in drivers/scsi/53c700.c:1129

On 10.06.2016 00:23, James Bottomley wrote: > On Thu, 2016-06-09 at 21:36 +0200, Helge Deller wrote: >> Hi James, >> >> I just tried Debian kernel 4.6.1-1 on my historic 715/64 machine, and it >> ran into this BUG() in the LASI scsi driver: >> >> scsi 0:0:6:0: no saved request for untagged cmd

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On 06/09/2016 02:26 PM, Bryant G. Ly wrote: drivers/scsi/Kconfig | 27 +- drivers/scsi/Makefile|2 +- drivers/scsi/ibmvscsi/Makefile |4 + drivers/scsi/ibmvscsi/ibmvscsi_tgt.c | 4184 ++

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On 05/24/2016 01:00 PM, Bryant G Ly wrote: Quoting Bart Van Assche : On 05/24/2016 06:52 AM, Bryant G. Ly wrote: +static uint64_t ibmvscsis_unpack_lun(const uint8_t *lun, int len) +{ +uint64_t res = NO_SUCH_LUN; +int addressing_method; + +if

Re: [PATCH 2/3] PCI: Use device_match_always()

On Fri, Jun 10, 2016 at 11:13:43AM -0500, Bjorn Helgaas wrote: > On Mon, Jun 06, 2016 at 09:32:37AM +0200, Thierry Reding wrote: > > From: Thierry Reding > > > > There is now a common implementation for a match function that will > > always match, so the PCI-specific

Re: [PATCH 2/3] PCI: Use device_match_always()

On Mon, Jun 06, 2016 at 09:32:37AM +0200, Thierry Reding wrote: > From: Thierry Reding > > There is now a common implementation for a match function that will > always match, so the PCI-specific implementation can be removed. > > Signed-off-by: Thierry Reding

Re: block: don't check request size in blk_cloned_rq_check_limits()

On Fri, Jun 10 2016 at 9:30am -0400, Hannes Reinecke wrote: > On 06/10/2016 03:19 PM, Mike Snitzer wrote: > > On Mon, May 30 2016 at 3:24am -0400, > > Hannes Reinecke wrote: > > > >> When checking a cloned request there is no need to check > >> the overall request

Re: block: don't check request size in blk_cloned_rq_check_limits()

On 06/10/2016 03:19 PM, Mike Snitzer wrote: > On Mon, May 30 2016 at 3:24am -0400, > Hannes Reinecke wrote: > >> When checking a cloned request there is no need to check >> the overall request size; this won't have changed even >> when resubmitting to another queue. >> Without

Re: block: don't check request size in blk_cloned_rq_check_limits()

On Mon, May 30 2016 at 3:24am -0400, Hannes Reinecke wrote: > When checking a cloned request there is no need to check > the overall request size; this won't have changed even > when resubmitting to another queue. > Without this patch ppc64le on ibmvfc fails to boot. By simply

Re: [PATCH v2] scsi/fcoe: convert to kworker

On Tue, Apr 12, 2016 at 05:16:54PM +0200, Sebastian Andrzej Siewior wrote: > The driver creates its own per-CPU threads which are updated based on > CPU hotplug events. It is also possible to use kworkers and remove some > of the kthread infrastrucure. > > The code checked ->thread to decide if

Re: [PATCH V2 0/2] initial submit of Microsemi smartpqi driver

On 06/09/2016 08:50 PM, Don Brace wrote: > These patches are based on Linus's tree > > - add smartpqi to kernel.org > - remove PCI IDs from aacraid driver > - Depends on adoption of smartpqi driver > > Changes since initial upload > - Forgot to give correct ownership to the author. > Changes

Re: [PATCH V2 1/2] smartpqi: initial commit of Microsemi smartpqi driver

-driver/20160610-030826 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: s390-allmodconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git

Re: [PATCH v3 3/3] Add ata pass-through path for ZAC commands.

On Fri, Jun 10, 2016 at 2:19 AM, Hannes Reinecke wrote: > On 06/10/2016 09:10 AM, Shaun Tancheff wrote: >> The current generation of HBA SAS adapters support connecting SATA >> drives and perform SCSI<->ATA translations in hardware. >> Unfortunately the ZBC commands are not being

[PATCH v3 1/3] Add bio/request flags for using ZBC/ZAC commands

T10 ZBC and T13 ZAC specify operations for Zoned devices. To be able to access the zone information and open and close zones adding flags for the report zones command (REQ_REPORT_ZONES) and for Open and Close zone (REQ_OPEN_ZONE and REQ_CLOSE_ZONE) can be added for use by struct bio's bi_rw and

Re: [PATCH v3 3/3] Add ata pass-through path for ZAC commands.

On 06/10/2016 09:10 AM, Shaun Tancheff wrote: > The current generation of HBA SAS adapters support connecting SATA > drives and perform SCSI<->ATA translations in hardware. > Unfortunately the ZBC commands are not being translate (yet). > > Currently users of SAS controllers can only send ZAC

[PATCH v3 1/3] Add bio/request flags for using ZBC/ZAC commands

T10 ZBC and T13 ZAC specify operations for Zoned devices. To be able to access the zone information and open and close zones adding flags for the report zones command (REQ_REPORT_ZONES) and for Open and Close zone (REQ_OPEN_ZONE and REQ_CLOSE_ZONE) can be added for use by struct bio's bi_rw and

[PATCH v3 2/3] Add ioctl to issue ZBC/ZAC commands via block layer

Add New ioctl types BLKREPORT- Issue Report Zones to device. BLKOPENZONE - Issue an Zone Action: Open Zone command. BLKCLOSEZONE - Issue an Zone Action: Close Zone command. BLKRESETZONE - Issue an Zone Action: Reset Zone command. Signed-off-by: Shaun Tancheff

[PATCH v3 0/3] Block layer support ZAC/ZBC commands

Hi Jens, This series is on your for-next branch. As Host Aware drives are becoming available we would like to be able to make use of such drives. This series is also intended to be suitable for use by Host Managed drives. ZAC/ZBC drives add new commands for discovering and working with Zones.

[PATCH v3 3/3] Add ata pass-through path for ZAC commands.

The current generation of HBA SAS adapters support connecting SATA drives and perform SCSI<->ATA translations in hardware. Unfortunately the ZBC commands are not being translate (yet). Currently users of SAS controllers can only send ZAC commands via ata pass-through. This method overloads the

Re: [RFC 7/8] nvmet/admin-cmd: Hookup T10-PI to ID_NS.ms + ID_NS.dps feature bits

On Thu, 2016-06-09 at 15:52 +0200, Christoph Hellwig wrote: > FYI: NVMf requires metadata to be interleaved in the data, and you > need to indicate that in the Identify data. Note that this is only > a requirement for the on the wire format and for the way the Namespaces are > exposed at the

Re: [RFC 0/2] nvme/loop: Add support for controllers-per-port model

On Thu, 2016-06-09 at 15:39 +0200, Christoph Hellwig wrote: > On Wed, Jun 08, 2016 at 10:13:53PM -0700, Nicholas A. Bellinger wrote: > > I still don't see why a loopback controller on a port of an individual > > subsystem NQN can't be created + deleted directly from configfs, and > > operate