Re: [PATCH 0/3] cxlflash: Shutdown notification and reset patch

> "Uma" == Uma Krishnan writes: Uma> This patch set contains support to notify CXL Flash devices of an Uma> impending shutdown and a fix to drain operations prior to a reset. Uma> This series is intended for 4.8 and is bisectable. Applied to 4.8/scsi-queue. --

Re: [PATCH][SCSI] 53c700: Use proper debug printk format specifiers

> "Helge" == Helge Deller writes: Helge> When enabling the debug options NCR_700_DEBUG and Helge> NCR_700_TAG_DEBUG various printk format warnings can be seen Helge> like: drivers/scsi/53c700.c:357:2: warning: format ‘%p’ expects Helge> argument of type ‘void *’, but argument

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

> "Jim" == Jim Gill writes: Updated MAINTAINERS accordingly and applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org

Re: [PATCH V2 resend] libata:fix kernel panic when hotplug

On Mon, Jun 20, 2016 at 6:22 PM, Martin K. Petersen wrote: >> "Tejun" == Tejun Heo writes: > >>> In fact,we don't need libata to deal with hotplug in sas environment. >>> So we can't run ata hotplug task when ata port is sas host. > > Tejun>

Re: [PATCH V2 resend] libata:fix kernel panic when hotplug

> "Tejun" == Tejun Heo writes: >> In fact,we don't need libata to deal with hotplug in sas environment. >> So we can't run ata hotplug task when ata port is sas host. Tejun> Martin, can you please confirm whether the above is true. If so, Tejun> I'll route the patch

Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit

> "Arnd" == Arnd Bergmann writes: As sector_t can be 32-bit wide, this adds a cast to 'u64' and prints that with the correct format. The change to use no_printk() [...] + dprintk("wd7000_biosparam: dev=%s, size=%lld, ", + bdevname(bdev, b),

Re: [PATCH] MAINTAINERS: Update email address for AACRAID

> "Dave" == Dave Carroll writes: Dave> Update the email address for AACRAID from Adaptec to Microsemi Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: Connect-IB not performing as well as ConnectX-3 with iSER

Did you see this kind of regression in SRP ? or with some other target (e.g TGT) ? Trying to understand if it's a ULP issue or LLD... On 6/20/2016 6:23 PM, Robert LeBlanc wrote: Adding linux-scsi This last week I tried to figure out where a 10-15% decrease in performance showed up between 4.5

Re: [PATCH v1 0/4] scsi: some (very) old clean ups

> "Andy" == Andy Shevchenko writes: Andy, Andy> Gentle ping to get know what is the destiny of my patches. -ENOREVIEWS At this point they have expired from patchworks so it's probably best to post them again. And make sure to pester the relevant driver

Re: Connect-IB not performing as well as ConnectX-3 with iSER

I can test with SRP and report back what I find (haven't used SRP in years so I'll need to brush up on it). Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Mon, Jun 20, 2016 at 3:27 PM, Max Gurtovoy wrote: > Did you see

[PATCH v5 1/2] Add bio/request flags for using ZBC/ZAC commands

T10 ZBC and T13 ZAC specify operations for Zoned devices. To be able to access the zone information and open and close zones adding op's for: - Report zones command: REQ_OP_ZONE_REPORT - Open zone: REQ_OP_ZONE_OPEN - Close zone: REQ_OP_ZONE_CLOSE - Reset Write Pointer: REQ_OP_ZONE_RESET

[PATCH v5 2/2] Add ioctl to issue ZBC/ZAC commands via block layer

Add New ioctl types BLKREPORT- Issue Report Zones to device. BLKOPENZONE - Issue an Zone Action: Open Zone command. BLKCLOSEZONE - Issue an Zone Action: Close Zone command. BLKRESETZONE - Issue an Zone Action: Reset Zone command. Signed-off-by: Shaun Tancheff

[PATCH v5 0/2] Block layer support ZAC/ZBC commands

Hi Jens, This series is on linux-next tag next-20160617. As Host Aware drives are becoming available we would like to be able to make use of such drives. This series is also intended to be suitable for use by Host Managed drives. ZAC/ZBC drives add new commands for discovering and working with

Re: [PATCH v2 00/24] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

> This version now looks ok to me. > > I do have a comment (or maybe just a RFD) for future work. > > It does strike me that once we actually change over the inode times to > use timespec64, the calling conventions are going to be fairly > horrendous on most 32-bit architectures. > > Gcc handles

Re: [PATCH v2 00/24] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

On Sun, Jun 19, 2016 at 5:26 PM, Deepa Dinamani wrote: > The series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC > macros. This version now looks ok to me. I do have a comment (or maybe just a RFD) for future work. It does strike me that once we

Re: [PATCH 3/3] cxlflash: Shutdown notify support for CXL Flash cards

> On Jun 15, 2016, at 6:49 PM, Uma Krishnan wrote: > > Some CXL Flash cards need notification of device shutdown > in order to flush pending I/Os. > > A PCI notification hook for shutdown has been added where > the driver notifies the card and returns. When the

Re: Connect-IB not performing as well as ConnectX-3 with iSER

Adding linux-scsi This last week I tried to figure out where a 10-15% decrease in performance showed up between 4.5 and 4.6 using iSER and ConnectX-3 and Connect-IB cards (10.{218,219}.*.17 are Connect-IB and 10.220.*.17 are ConnectX-3). To review, straight RDMA transfers between cards showed

Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

On 06/20/2016 04:48 PM, Arnd Bergmann wrote: On Monday, June 20, 2016 3:54:06 PM CEST Bart Van Assche wrote: On 06/17/2016 05:47 PM, Arnd Bergmann wrote: - jiffies_to_timespec(jiffies, ); - jiffies_to_timespec(lport->boot_time, ); - fc_stats->seconds_since_last_reset = (v0.tv_sec -

Re: [PATCH 2/3] scsi: disable VPD page check on error

On Mon, 2016-06-20 at 06:44 -0700, James Bottomley wrote: > On Mon, 2016-06-20 at 09:25 -0400, Ewan D. Milne wrote: > > On Mon, 2016-06-20 at 08:57 +0200, Hannes Reinecke wrote: > > > If we encounter an error during initial VPD page scan we should be > > > setting the 'skip_vpd_pages' bit to avoid

[PATCH v3] Add support for SCT Write Same

SATA drives may support write same via SCT. This is useful for setting the drive contents to a specific pattern (0's). If UNMAP is not set or TRIM is not available then fall back to SCT WRITE SAME, if it is available. In this way it would be possible to mimic lbprz for devices that support TRIM

[PATCH v3] Add support for Write Same via SCT

At some point the method of issuing Write Same for ATA drives changed. Currently write same is commonly available via SCT so expose the SCT capabilities and use SCT Write Same if available. This is useful for zoned based media that prefers to support discard with lbprz set, aka discard zeroes

Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

On Monday, June 20, 2016 3:54:06 PM CEST Bart Van Assche wrote: > On 06/17/2016 05:47 PM, Arnd Bergmann wrote: > > - jiffies_to_timespec(jiffies, ); > > - jiffies_to_timespec(lport->boot_time, ); > > - fc_stats->seconds_since_last_reset = (v0.tv_sec - v1.tv_sec); > > +

Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

On 06/17/2016 05:47 PM, Arnd Bergmann wrote: - jiffies_to_timespec(jiffies, ); - jiffies_to_timespec(lport->boot_time, ); - fc_stats->seconds_since_last_reset = (v0.tv_sec - v1.tv_sec); + fc_stats->seconds_since_last_reset = (lport->boot_time - jiffies) / HZ; Does this

Re: [PATCH 2/3] scsi: disable VPD page check on error

On Mon, 2016-06-20 at 09:25 -0400, Ewan D. Milne wrote: > On Mon, 2016-06-20 at 08:57 +0200, Hannes Reinecke wrote: > > If we encounter an error during initial VPD page scan we should be > > setting the 'skip_vpd_pages' bit to avoid further accesses. > > Any errors during rescan should be ignored,

Re: [PATCH 1/3] cxlflash: Fix to drain operations from previous reset

> On Jun 15, 2016, at 6:49 PM, Uma Krishnan wrote: > > From: "Manoj N. Kumar" > > While running 'sg_reset -H' in a loop with a user-space application active, > hit the following exception: > > cpu 0x2: Vector: 300 (Data Access) >pc: :

Re: [PATCH 3/3] scsi: consolidate checking for VPD pages

On Mon, 2016-06-20 at 08:57 +0200, Hannes Reinecke wrote: > scsi_get_vpd_page() has a check for 'skip_vpd_pages'. However, > this is not sufficient to test if the device really supports > VPD pages. At the same time, most sites were already calling > scsi_device_supports_vpd() prior to calling

Re: [PATCH 1/3] scsi: Move 'scsi_attach_vpd()' prototype to scsi_priv.h

On Mon, 2016-06-20 at 08:57 +0200, Hannes Reinecke wrote: > scsi_attach_vpd() is not exported, so it should be in scsi_priv.h. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_priv.h | 1 + > include/scsi/scsi_device.h | 1 - > 2 files changed, 1 insertion(+), 1

Re: [BUG] mpt2sas: driver init fails on kernel >=4.2 for 9211-8i IT

Still tracking - small update: So far with the most current esxi 6 (build 3825889 - 2016-05-12) the fix is not there yet. Sidenote: the mpt driver seems to have learned to work around the irq handling issues (I tested kernel 4.6.2) whereas the e1000e ethernet driver still has trouble

[PATCH 0/5] SCSI EH cleanup

Hi all, here's a patchset to cleanup SCSI EH. The main point is that we should finally drop the no_async_abort flag; up to now we haven't had any issues with the asynchronous aborts, and the flag was never used. As usual, comments and reviews are welcome. Christoph Hellwig (1): libsas: allow

[PATCH 3/5] scsi: make eh_eflags persistent

To detect if a failed command has been retried we must not clear scmd->eh_eflags when EH finishes. The flag should be persistent throughout the lifetime of the command. Signed-off-by: Hannes Reinecke --- Documentation/scsi/scsi_eh.txt | 3 --- drivers/scsi/scsi_error.c | 4

[PATCH 1/5] libsas: allow async aborts

From: Christoph Hellwig We now first try to call ->eh_abort_handler from a work queue, but libsas was always failing that for no good reason. Allow async aborts. Reviewed-by: Hannes Reinecke Signed-off-by: Christoph Hellwig ---

[PATCH 2/5] scsi: make scsi_eh_scmd_add() always succeed

scsi_eh_scmd_add() currently only will fail if no error handler thread is started (which will never be the case) or if the state machine encounters an illegal transition. But if we're encountering an invalid state transition chances is we cannot fixup things with the error handler. So better add

[PATCH 4/5] scsi: make asynchronous aborts mandatory

There hasn't been any reports for HBAs where asynchronous abort would not work, so we should make it mandatory and remove the fallback. Signed-off-by: Hannes Reinecke --- Documentation/scsi/scsi_eh.txt | 28 +++ drivers/scsi/scsi_error.c | 81

[PATCH 5/5] scsi: Do not escalate failed EH command

If an EH command fails there is no need to escalate; we are already in EH and the escalation will start anyway. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_error.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/scsi/scsi_error.c

Re: [PATCH v1 0/4] scsi: some (very) old clean ups

On Fri, 2016-05-06 at 19:23 +0300, Andy Shevchenko wrote: > This is a set of independent clean ups that didn't land upstream for > ages (some > are dated 2010!).  As agreed with Martin at some point I resend > them. > > I have more, but the rest is not yet ready for submission. Gentle ping to

[PATCH 1/3] scsi: Move 'scsi_attach_vpd()' prototype to scsi_priv.h

scsi_attach_vpd() is not exported, so it should be in scsi_priv.h. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_priv.h | 1 + include/scsi/scsi_device.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_priv.h

[PATCH 0/3] VPD page check consolidation

Hi all, as per recent discussion this patchset consolidates the VPD page checks. With it VPD page scan will be disabled if the initial scan encounters an error, and also the checks for VPD pages are consolidated in the function scsi_device_supports_vpd(). As usual, comments and reviews are

[PATCH 3/3] scsi: consolidate checking for VPD pages

scsi_get_vpd_page() has a check for 'skip_vpd_pages'. However, this is not sufficient to test if the device really supports VPD pages. At the same time, most sites were already calling scsi_device_supports_vpd() prior to calling this function. So this patchs updates all callers to use

[PATCH 2/3] scsi: disable VPD page check on error

If we encounter an error during initial VPD page scan we should be setting the 'skip_vpd_pages' bit to avoid further accesses. Any errors during rescan should be ignored, as we might encounter temporary I/O errors during rescan. Signed-off-by: Hannes Reinecke ---