Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

2016-07-11 Thread Feng Li
Add ls...@suse.com 2016-07-11 22:23 GMT+08:00 冯力 : > This problem exists at least from v3.16. > The upstream kernel still exists this issue. > > I have tested my patch and the following panic is disappeared. > > Thanks, > - Alex > > #dmesg > > [ 1160.788676] sd 16:0:0:0:

[PATCH v2] xen_pvscsi: reclaim the ring request when the prepairing failed

2016-07-11 Thread Bin Wu
During scsi command queueing or exception handling, if prepairing fails, we need to reclaim the failed request. Otherwise, the garbage request will be pushed into the ring for the backend to work. Signed-off-by: Bin Wu --- drivers/scsi/xen-scsifront.c | 4 ++-- 1 file

Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread Bin Wu
On 2016/7/11 17:53, Juergen Gross wrote: On 11/07/16 11:50, David Vrabel wrote: On 11/07/16 10:33, Juergen Gross wrote: On 11/07/16 04:51, Bin Wu wrote: During scsi command queueing, if mapping data fails, we need to reclaim the failed request. Otherwise, the garbage request will be pushed

Re: [PATCH v3 1/7] lib: string: add functions to case-convert strings

2016-07-11 Thread Markus Mayer
On 9 July 2016 at 08:30, Markus Mayer wrote: > On 9 July 2016 at 05:04, Luis de Bethencourt wrote: >> On 08/07/16 23:43, Markus Mayer wrote: >>> Add a collection of generic functions to convert strings to lowercase >>> or uppercase. >>> >>>

RE: [net-next 0/6] common library for Chelsio drivers

2016-07-11 Thread Steve Wise
> > Hi, > > > > This patch series adds common library module(libcxgb.ko) > > for Chelsio drivers to remove duplicate code. > > > > This series moves common iSCSI DDP Page Pod manager > > code from cxgb4.ko to libcxgb.ko, earlier this code > > was used by only cxgbit.ko now it is used by > > three

Re: [net-next 0/6] common library for Chelsio drivers

2016-07-11 Thread David Miller
From: Varun Prakash Date: Fri, 8 Jul 2016 23:03:53 +0530 > Hi, > > This patch series adds common library module(libcxgb.ko) > for Chelsio drivers to remove duplicate code. > > This series moves common iSCSI DDP Page Pod manager > code from cxgb4.ko to libcxgb.ko, earlier

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-07-11 Thread Alan Stern
On Mon, 11 Jul 2016, Oliver Neukum wrote: > Some SATA to USB bridges fail to cooperate with some > drives resulting in no cache being present being reported > to the host. That causes the host to skip sending > a command to synchronize caches. That causes data loss > when the drive is powered

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

2016-07-11 Thread 冯力
This problem exists at least from v3.16. The upstream kernel still exists this issue. I have tested my patch and the following panic is disappeared. Thanks, - Alex #dmesg [ 1160.788676] sd 16:0:0:0: [sde] Attached SCSI disk [ 1383.962626] target_core_get_fabric() failed for usb_gadget [

Re: [PATCH] scsi: remove current_cmnd field from struct scsi_device

2016-07-11 Thread Ewan D. Milne
On Mon, 2016-07-11 at 13:34 +0900, Christoph Hellwig wrote: > The field is only used by the 53c700 driver, so move it into the > driver-private device data instead of having it in the common structure. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/53c700.c | 8

[PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

2016-07-11 Thread Feng Li
From: Feng Li In MC/S scenario, the conn->sess has been set NULL in iscsi_login_non_zero_tsih_s1 when the second connection comes here, then kernel panic. The conn->sess will be assigned in iscsi_login_non_zero_tsih_s2. So we should check whether it's NULL before calling.

[PATCH] scsi: introduce a quirk for false cache reporting

2016-07-11 Thread Oliver Neukum
Some SATA to USB bridges fail to cooperate with some drives resulting in no cache being present being reported to the host. That causes the host to skip sending a command to synchronize caches. That causes data loss when the drive is powered down. Signed-off-by: Oliver Neukum

Re: [PATCH] scsi: remove current_cmnd field from struct scsi_device

2016-07-11 Thread Tomas Henzl
On 11.7.2016 06:34, Christoph Hellwig wrote: > The field is only used by the 53c700 driver, so move it into the > driver-private device data instead of having it in the common structure. > > Signed-off-by: Christoph Hellwig Reviewed-by: Tomas Henzl Tomas -- To

2% DARLEHEN

2016-07-11 Thread David Rogers
Aufmerksamkeit; Hiermit teilen wir Ihnen mit, dass als privates Unternehmen, Kredite Unternehmen mit Sitz in Großbritannien (Um Financial Ltd). Wir geben Kredite in Höhe von $ 10.000 bis $ 300.000.000 bei 2% Zinssatz für alle Interessierten. Land ist kein Hindernis, so fühlen sich frei, mit

Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread Juergen Gross
On 11/07/16 11:50, David Vrabel wrote: > On 11/07/16 10:33, Juergen Gross wrote: >> On 11/07/16 04:51, Bin Wu wrote: >>> During scsi command queueing, if mapping data fails, we need to >>> reclaim the failed request. Otherwise, the garbage request will >>> be pushed into the ring for the backend

Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread David Vrabel
On 11/07/16 10:33, Juergen Gross wrote: > On 11/07/16 04:51, Bin Wu wrote: >> During scsi command queueing, if mapping data fails, we need to >> reclaim the failed request. Otherwise, the garbage request will >> be pushed into the ring for the backend to work. > > Well spotted. There is another

Re: [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread Juergen Gross
On 11/07/16 04:51, Bin Wu wrote: > During scsi command queueing, if mapping data fails, we need to > reclaim the failed request. Otherwise, the garbage request will > be pushed into the ring for the backend to work. Well spotted. There is another instance of this problem in

Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

2016-07-11 Thread Bruno Prémont
On Mon, 11 Jul 2016 09:30:30 +0200 Thorsten Leemhuis wrote: > Bruno Prémont wrote on 11.07.2016 09:17: > > On Fri, 8 Jul 2016 09:27:18 +0200 Thorsten Leemhuis wrote: > >> Bruno Prémont wrote on 30.06.2016 17:00: > >> > In qla24xx_process_response_queue() rsp->msix->cpuid may trigger NULL > >>

2% lånetilbud

2016-07-11 Thread David Rogers
oppmerksomhet; Dette er for å informere deg gjorde som et privat selskap, Utlån selskap basert i Storbritannia (til økonomisk Ltd). Vi gir ut lån til melodi av $ 10 000 til $ 300 millioner ved 2% rente til alle som er interessert. Country er ikke en barriere, så ta gjerne kontakt med oss på

Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

2016-07-11 Thread Thorsten Leemhuis
Bruno Prémont wrote on 11.07.2016 09:17: > On Fri, 8 Jul 2016 09:27:18 +0200 Thorsten Leemhuis wrote: >> Bruno Prémont wrote on 30.06.2016 17:00: >> > In qla24xx_process_response_queue() rsp->msix->cpuid may trigger NULL >> > pointer dereference when rsp->msix is NULL: >> > […] >> > The affected

Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

2016-07-11 Thread Bruno Prémont
On Fri, 8 Jul 2016 09:27:18 +0200 Thorsten Leemhuis wrote: > Bruno Prémont wrote on 30.06.2016 17:00: > > In qla24xx_process_response_queue() rsp->msix->cpuid may trigger NULL > > pointer dereference when rsp->msix is NULL: > > […] > > The affected code was introduced by commit > >

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-11 Thread Tom Yan
I don't suppose there would be any problem doing it in userspace / with ATA PASS-THROUGH anyway. I just couldn't agree that it would be the reason not to implement the translation (which covers the core part of the feature set) in the kernel. But certainly I wouldn't keep aruging on this. I don't