RE: [PATCH 1/3] megaraid_sas: mark symbols static where possible

2016-09-25 Thread Sumit Saxena
>-Original Message- >From: Baoyou Xie [mailto:baoyou@linaro.org] >Sent: Sunday, September 25, 2016 11:21 AM >To: kashyap.de...@avagotech.com; sumit.sax...@avagotech.com; >uday.ling...@avagotech.com; j...@linux.vnet.ibm.com; >martin.peter...@oracle.com >Cc:

ASAP

2016-09-25 Thread Ms CHIANG Lai Yuen JP
Let me introduce myself, I am Ms CHIANG Lai Yuen JP, the Managing Director & Deputy Chief Executive of Hang Seng Bank LTD. I have a risk-free deal reply for more details --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus -- To unsubscribe

Re: [PATCH 2/3] g_NCR5380: Reduce overrides[] from array to struct

2016-09-25 Thread Finn Thain
On Sat, 24 Sep 2016, Ondrej Zary wrote: > Remove compile-time card type definition GENERIC_NCR5380_OVERRIDE. Then > remove all code iterating the overrides[] array and reduce it to struct > card. There is a reference to the compile-time override in Documentation/scsi/g_NCR5380.txt which

Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c

2016-09-25 Thread Finn Thain
On Sat, 24 Sep 2016, Ondrej Zary wrote: > Convert g_NCR5380 to use scsi_add_host instead of scsi_module.c > Use pnp_driver and isa_driver to manage cards. > > Signed-off-by: Ondrej Zary > --- > drivers/scsi/g_NCR5380.c | 310 >

RE: [PATCH] pm8001: mark symbols static where possible

2016-09-25 Thread lindar_liu
Thanks for fix. Acked-by: Lindar Liu > -Original Message- > From: Baoyou Xie [mailto:baoyou@linaro.org] > Sent: Friday, September 23, 2016 9:54 PM > To: jinpu.w...@profitbricks.com; lindar_...@usish.com; > j...@linux.vnet.ibm.com; martin.peter...@oracle.com >

Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio

2016-09-25 Thread Christoph Hellwig
On Mon, Sep 26, 2016 at 10:37:13AM +1000, Finn Thain wrote: > Let's not do that yet. I have a patch series that fixes the type casting > and related issues that I will post soon. I expect that Ondrej's patches > will be ready before mine are, so I'll rebase mine on this work before I > ask him

Re: [PATCH 1/3] g_NCR5380: Remove deprecated __setup

2016-09-25 Thread Finn Thain
On Sat, 24 Sep 2016, Ondrej Zary wrote: > Remove deprecated __setup for parsing command line parameters. > g_NCR5380.* parameters could be used instead. Removing useful features is deprecated too. The best reason I can see for removing the __setup parameters is that the g_NCR5380 module

Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio

2016-09-25 Thread Finn Thain
On Sun, 25 Sep 2016, Christoph Hellwig wrote: > On Sun, Sep 25, 2016 at 09:39:20PM +0200, Ondrej Zary wrote: > > > #define NCR5380_read(reg) \ > > + ioread8(((struct NCR5380_hostdata *)shost_priv(instance))->iomem + \ > > + ((struct NCR5380_hostdata *)shost_priv(instance))->offset

Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio

2016-09-25 Thread Christoph Hellwig
On Sun, Sep 25, 2016 at 09:39:20PM +0200, Ondrej Zary wrote: > Merge the PIO and MMIO code (with the help of ioport_map) in g_NCR5380 and > delete g_NCR5380_mmio. Awesome! this looks great to me, but we probably should thrown in a MODULE_ALIAS for g_NCR5380_mmio so that existing module

Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c

2016-09-25 Thread Christoph Hellwig
> +static int generic_NCR5380_isa_match(struct device *pdev, unsigned int ndev) > +{ > + struct Scsi_Host *sh = NULL; > + > + sh = generic_NCR5380_hw_init(_template, pdev, base[ndev], > + irq[ndev], card[ndev]); > + if (!sh && base[ndev]) > +

Re: [PATCH 2/3] g_NCR5380: Reduce overrides[] from array to struct

2016-09-25 Thread Christoph Hellwig
On Sat, Sep 24, 2016 at 08:59:04PM +0200, Ondrej Zary wrote: > Remove compile-time card type definition GENERIC_NCR5380_OVERRIDE. > Then remove all code iterating the overrides[] array and reduce it to > struct card. > > Signed-off-by: Ondrej Zary Looks great!

Re: [PATCH 1/3] g_NCR5380: Remove deprecated __setup

2016-09-25 Thread Christoph Hellwig
On Sat, Sep 24, 2016 at 08:59:03PM +0200, Ondrej Zary wrote: > Remove deprecated __setup for parsing command line parameters. > g_NCR5380.* parameters could be used instead. This assumes everyone has moved over to it. But I suspect the remaining hand full of users could adjust.. -- To

[PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio

2016-09-25 Thread Ondrej Zary
Merge the PIO and MMIO code (with the help of ioport_map) in g_NCR5380 and delete g_NCR5380_mmio. Signed-off-by: Ondrej Zary --- drivers/scsi/Kconfig | 32 ++--- drivers/scsi/g_NCR5380.c | 257 +++--

Re: [PATCH] Fix few small typos in lpfc_scsi.c

2016-09-25 Thread Laurence Oberman
- Original Message - > From: "Milan P. Gandhi" > To: linux-scsi@vger.kernel.org, kernel-janit...@vger.kernel.org, "james > smart" , "dick > kennedy" > Sent: Sunday, September 25, 2016 11:58:41 AM > Subject:

[PATCH v4] add u64 number parser

2016-09-25 Thread James Smart
add u64 number parser Reverted back to version 2 of the patch. This adds the interface using existing logic. Comments from the prior reviewers to move to kasprintf were rejected by Linus. Signed-off-by: James Smart --- include/linux/parser.h | 1 + lib/parser.c

[PATCH] Fix few small typos in lpfc_scsi.c

2016-09-25 Thread Milan P. Gandhi
This patch does a cleanup and fixes few small typos in lpfc_scsi.c Signed-off-by: Milan P. Gandhi --- drivers/scsi/lpfc/lpfc_scsi.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c