[RFC 1/6] qed: Add support for hardware offloaded iSCSI.

2016-10-18 Thread manish.rangankar
From: Yuval Mintz This adds the backbone required for the various HW initalizations which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[RFC 5/6] qedi: Add support for iSCSI session management.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This patch adds support for iscsi_transport LLD Login, Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing and Firmware async event handling support. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi

[RFC 0/6] Add QLogic FastLinQ iSCSI (qedi) driver.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This series introduces hardware offload iSCSI initiator driver for the 41000 Series Converged Network Adapters (579xx chip) by Qlogic. The overall driver design includes a common module ('qed') and protocol specific dependent modules ('qedi'

[RFC 2/6] qed: Add iSCSI out of order packet handling.

2016-10-18 Thread manish.rangankar
From: Yuval Mintz This patch adds out of order packet handling for hardware offloaded iSCSI. Out of order packet handling requires driver buffer allocation and assistance. Signed-off-by: Arun Easi Signed-off-by: Yuval Mintz

[RFC 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module for 41000 Series Converged Network Adapters by QLogic. This patch consists of following changes: - MAINTAINERS Makefile and Kconfig changes for qedi, - PCI driver

[RFC 6/6] qedi: Add support for data path.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This patch adds support for data path and TMF handling. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis

[RFC 4/6] qedi: Add LL2 iSCSI interface for offload iSCSI.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This patch adds support for iscsiuio interface using Light L2 (LL2) qed interface. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis

Re: [PATCH v8 0/7] ZBC / Zoned block device support

2016-10-18 Thread Jens Axboe
On 10/18/2016 07:53 PM, Martin K. Petersen wrote: "Jens" == Jens Axboe writes: Jens> I already queued up the other bits, if it's fine with you I'll add Jens> 6/7 as well. Sure. Feel free to add by Acked-by:. Thanks, added and committed the sd bit. I'll push out when I get

Re: [PATCH v8 0/7] ZBC / Zoned block device support

2016-10-18 Thread Martin K. Petersen
> "Jens" == Jens Axboe writes: Jens> I already queued up the other bits, if it's fine with you I'll add Jens> 6/7 as well. Sure. Feel free to add by Acked-by:. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v8 0/7] ZBC / Zoned block device support

2016-10-18 Thread Jens Axboe
On 10/18/2016 06:46 PM, Martin K. Petersen wrote: "Jens" == Jens Axboe writes: Jens> This is starting to look mergeable to me. Yup. Jens> Any objections in getting this applied for 4.10? Looks like 6/7 Jens> should go through the SCSI tree, but I can queue up the rest. I'm

Re: [PATCH v2 0/6] Fixes for ibmvscsis driver

2016-10-18 Thread Martin K. Petersen
> "Michael" == Michael Cyr writes: Michael> Various fixes and cleanups for the ibmvscsis driver. The first Michael> is a sort of prequel to the second, which is the primary change Michael> (and the biggest). The rest are fairly small fixes. Applied to 4.10/scsi-queue.

Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency

2016-10-18 Thread Martin K. Petersen
> "Arnd" == Arnd Bergmann writes: Arnd> The driver was changed to call ioport_map, which breaks platforms Arnd> that cannot provide this function: Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH] fcoe: Fixup missing initialisation in fcoe_dcb_create()

2016-10-18 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> Found by 0-day robot. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Martin K. Petersen
> "Damien" == Damien Le Moal writes: Damien> Implement ZBC support functions to setup zoned disks, both Damien> host-managed and host-aware models. Only zoned disks that Damien> satisfy the following conditions are supported: Damien> 1) All zones are the same size,

Re: [PATCH v8 0/7] ZBC / Zoned block device support

2016-10-18 Thread Martin K. Petersen
> "Jens" == Jens Axboe writes: Jens> This is starting to look mergeable to me. Yup. Jens> Any objections in getting this applied for 4.10? Looks like 6/7 Jens> should go through the SCSI tree, but I can queue up the rest. I'm OK with it at this point. Probably easier if

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Martin K. Petersen
> "Jeff" == Jeff Moyer writes: Jeff, Jeff> Are power of 2 zone sizes required by the standard? I see why Jeff> you've done this, but I wonder if we're artificially limiting the Jeff> implementation, and whether there will be valid devices on the Jeff> market that simply

Re: [PATCH v2 10/10] phy: qcom-ufs: Remove common layer phy exit callback

2016-10-18 Thread Subhash Jadavani
On 2016-10-18 07:28, Vivek Gautam wrote: The common layer phy exit callback ufs_qcom_phy_exit() calls phy_power_off() that has no meaning when phy_power_off() callback is already registered with the phy provider and the consumer makes use of the same. Instead, add a no-op specific phy_exit()

Re: [PATCH v8 2/7] blk-sysfs: Add 'chunk_sectors' to sysfs attributes

2016-10-18 Thread Damien Le Moal
Jeff, On 10/19/16 01:43, Jeff Moyer wrote: > Damien Le Moal writes: > >> diff --git a/Documentation/ABI/testing/sysfs-block >> b/Documentation/ABI/testing/sysfs-block >> index 75a5055..ee2d5cd 100644 >> --- a/Documentation/ABI/testing/sysfs-block >> +++

Re: [PATCH v8 0/7] ZBC / Zoned block device support

2016-10-18 Thread Damien Le Moal
Jens, On 10/19/16 00:58, Jens Axboe wrote: > This is starting to look mergeable to me. Any objections in getting this > applied for 4.10? Looks like 6/7 should go through the SCSI tree, but I > can queue up the rest. Yes, it would be great to get all this queued for 4.10. Indeed 6/7 is SCSI, but

Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency

2016-10-18 Thread Finn Thain
On Tue, 18 Oct 2016, Arnd Bergmann wrote: > The driver was changed to call ioport_map, which breaks platforms that > cannot provide this function: > > drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0': > g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388):

Re: iscsi_trx going into D state

2016-10-18 Thread Robert LeBlanc
Nicholas, We patched this in and for the first time in many reboots, we didn't have iSCSI going straight into D state. We have had to work on a couple of other things, so we don't know if this is just a coincidence or not. We will reboot back into the old kernel and back a few times and do some

Re: [PATCH v3 0/11] Fix race conditions related to stopping block layer queues

2016-10-18 Thread Bart Van Assche
On 10/18/2016 02:48 PM, Bart Van Assche wrote: - blk_mq_quiesce_queue() has been reworked (thanks to Ming Lin and Sagi for their feedback). (replying to my own e-mail) A correction: Ming Lei provided feedback on v2 of this patch series instead of Ming Lin. Bart. -- To unsubscribe from

[PATCH v3 11/11] nvme: Fix a race condition

2016-10-18 Thread Bart Van Assche
Avoid that nvme_queue_rq() is still running when nvme_stop_queues() returns. Signed-off-by: Bart Van Assche Cc: Keith Busch Cc: Sagi Grimberg Cc: Christoph Hellwig --- drivers/nvme/host/core.c | 15

[PATCH v3 09/11] SRP transport, scsi-mq: Wait for .queue_rq() if necessary

2016-10-18 Thread Bart Van Assche
Rename srp_wait_for_queuecommand() into scsi_wait_for_queuecommand(). Ensure that if scsi-mq is enabled that scsi_wait_for_queuecommand() waits until ongoing shost->hostt->queuecommand() calls have finished. Signed-off-by: Bart Van Assche Cc: James Bottomley

[PATCH v3 10/11] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code

2016-10-18 Thread Bart Van Assche
Make nvme_requeue_req() check BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED. Remove the QUEUE_FLAG_STOPPED manipulations that became superfluous because of this change. This patch fixes a race condition: using queue_flag_clear_unlocked() is not safe if any other function that manipulates the

[PATCH v3 08/11] SRP transport: Move queuecommand() wait code to SCSI core

2016-10-18 Thread Bart Van Assche
Additionally, add a comment about the queuecommand() call from scsi_send_eh_cmnd(). Signed-off-by: Bart Van Assche Cc: James Bottomley Cc: Martin K. Petersen Cc: Christoph Hellwig Cc: Sagi Grimberg

[PATCH v3 07/11] dm: Fix a race condition related to stopping and starting queues

2016-10-18 Thread Bart Van Assche
Ensure that all ongoing dm_mq_queue_rq() and dm_mq_requeue_request() calls have stopped before setting the "queue stopped" flag. This allows to remove the "queue stopped" test from dm_mq_queue_rq() and dm_mq_requeue_request(). This patch fixes a race condition because dm_mq_queue_rq() is called

[PATCH v3 06/11] dm: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code

2016-10-18 Thread Bart Van Assche
Instead of manipulating both QUEUE_FLAG_STOPPED and BLK_MQ_S_STOPPED in the dm start and stop queue functions, only manipulate the latter flag. Signed-off-by: Bart Van Assche Cc: Mike Snitzer --- drivers/md/dm-rq.c | 18 ++ 1 file

[PATCH v3 05/11] blk-mq: Add a kick_requeue_list argument to blk_mq_requeue_request()

2016-10-18 Thread Bart Van Assche
Most blk_mq_requeue_request() and blk_mq_add_to_requeue_list() calls are followed by kicking the requeue list. Hence add an argument to these two functions that allows to kick the requeue list. This was proposed by Christoph Hellwig. Signed-off-by: Bart Van Assche Cc:

[PATCH v3 04/11] blk-mq: Introduce blk_mq_quiesce_queue()

2016-10-18 Thread Bart Van Assche
blk_mq_quiesce_queue() waits until ongoing .queue_rq() invocations have finished. This function does *not* wait until all outstanding requests have finished (this means invocation of request.end_io()). Signed-off-by: Bart Van Assche Cc: Ming Lei

[PATCH v3 03/11] blk-mq: Introduce blk_mq_queue_stopped()

2016-10-18 Thread Bart Van Assche
The function blk_queue_stopped() allows to test whether or not a traditional request queue has been stopped. Introduce a helper function that allows block drivers to query easily whether or not one or more hardware contexts of a blk-mq queue have been stopped. Signed-off-by: Bart Van Assche

[PATCH v3 0/11] Fix race conditions related to stopping block layer queues

2016-10-18 Thread Bart Van Assche
Hello Jens, Multiple block drivers need the functionality to stop a request queue and to wait until all ongoing request_fn() / queue_rq() calls have finished without waiting until all outstanding requests have finished. Hence this patch series that introduces the blk_mq_quiesce_queue() and

[PATCH v3 02/11] blk-mq: Introduce blk_mq_hctx_stopped()

2016-10-18 Thread Bart Van Assche
Multiple functions test the BLK_MQ_S_STOPPED bit so introduce a helper function that performs this test. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Sagi Grimberg Cc: Johannes Thumshirn

[PATCH v3 01/11] blk-mq: Do not invoke .queue_rq() for a stopped queue

2016-10-18 Thread Bart Van Assche
The meaning of the BLK_MQ_S_STOPPED flag is "do not call .queue_rq()". Hence modify blk_mq_make_request() such that requests are queued instead of issued if a queue has been stopped. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Hannes

Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent

2016-10-18 Thread Stephen Boyd
On 10/18/2016 07:28 AM, Vivek Gautam wrote: > From: Yaniv Gardi > > Since in future UFS Phy's the tx_iface_clk and rx_iface_clk > are no longer exist, we should not fail when their initialization > fail, but rather just report with debug message. > > Signed-off-by: Yaniv

Re: [PATCH v2 09/10] scsi/ufs: qcom: Add phy_exit call in hcd exit path

2016-10-18 Thread Subhash Jadavani
On 2016-10-18 07:28, Vivek Gautam wrote: Do a phy_exit() over the ufs phy in the ufs qcom exit path to de-initialize the phy. Signed-off-by: Vivek Gautam --- New patch added in v2 series. drivers/scsi/ufs/ufs-qcom.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling

2016-10-18 Thread Subhash Jadavani
On 2016-10-18 07:28, Vivek Gautam wrote: Add phy clock enable code to phy_power_on/off callbacks, and remove explicit calls to enable these phy clocks from the ufs-qcom hcd driver. Signed-off-by: Vivek Gautam --- Changes since v1: - staticized

Re: [PATCH] scsi: update rdac devices at scsi_dh_rdac

2016-10-18 Thread Babu Moger
At this point, I am not the right person to ack this change. However, adding new vendor id's is mostly not an issue. But, removing could be a problem. Sean has to confirm this. On 10/18/2016 10:11 AM, Xose Vazquez Perez wrote: On 10/07/2016 06:55 PM, Xose Vazquez Perez wrote: This patch is

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-18 Thread Sumit Saxena
>-Original Message- >From: James Bottomley [mailto:j...@linux.vnet.ibm.com] >Sent: Monday, October 17, 2016 11:22 PM >To: Kashyap Desai; Ric Wheeler; Hannes Reinecke; Sumit Saxena; linux- >s...@vger.kernel.org >Cc: martin.peter...@oracle.com; the...@redhat.com; Christoph Hellwig; >Martin

Re: [PATCH v2 06/10] phy: qcom-ufs: Remove unnecessary function declarations

2016-10-18 Thread Subhash Jadavani
On 2016-10-18 07:28, Vivek Gautam wrote: Move the functions' definitions to remove unnecessary declarations. Signed-off-by: Vivek Gautam --- New patch added in v2 series. drivers/phy/phy-qcom-ufs.c | 133 + 1 file

Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent

2016-10-18 Thread Subhash Jadavani
On 2016-10-18 07:28, Vivek Gautam wrote: From: Yaniv Gardi Since in future UFS Phy's the tx_iface_clk and rx_iface_clk are no longer exist, we should not fail when their initialization fail, but rather just report with debug message. You may also want to update the

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Shaun Tancheff
On Tue, Oct 18, 2016 at 11:58 AM, Jeff Moyer wrote: > Damien Le Moal writes: > >> + if (!is_power_of_2(zone_blocks)) { >> + if (sdkp->first_scan) >> + sd_printk(KERN_NOTICE, sdkp, >> +

Re: Need some pointers to debug a target hang

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 09:01:34AM +0200, Johannes Thumshirn wrote: [...] > > > > This is likely the missing SCF_ACK_KREF assignment in >= v4.1.y: > > > > http://www.spinics.net/lists/target-devel/msg13530.html Sorry to disappoint you but it didn't fix my issue. Is there any debug data I can

Re: [PATCH 07/20] scsi_transport_fc: rename 'fc_rport_create' to 'fc_remote_port_create'

2016-10-18 Thread James Smart
On 10/18/2016 9:18 AM, Johannes Thumshirn wrote: Hi James, fc_rport_create() in scsi_transport_fc.c is static so there is no interface change here. Johannes ah - that this was the published routine. ok. -- james -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Jeff Moyer
Damien Le Moal writes: > + if (!is_power_of_2(zone_blocks)) { > + if (sdkp->first_scan) > + sd_printk(KERN_NOTICE, sdkp, > + "Devices with non power of 2 zone " > + "size are

[PATCH] scsi_devinfo: apply to HP-rebranded same options as Hitachi

2016-10-18 Thread Xose Vazquez Perez
627511e3e modified some Hitachi entries: Four models, OPEN-/DF400/DF500/DISK-SUBSYSTEM, can handle REPORT_LUN, and the BLIST_REPORTLUN2 flag needs to be set. And DF600 doesn't require any flags because it returns ANSI 03h (SPC). {"HITACHI", "DF400", "*", BLIST_REPORTLUN2},

Re: [PATCH v8 2/7] blk-sysfs: Add 'chunk_sectors' to sysfs attributes

2016-10-18 Thread Jeff Moyer
Damien Le Moal writes: > diff --git a/Documentation/ABI/testing/sysfs-block > b/Documentation/ABI/testing/sysfs-block > index 75a5055..ee2d5cd 100644 > --- a/Documentation/ABI/testing/sysfs-block > +++ b/Documentation/ABI/testing/sysfs-block > @@ -251,3 +251,16 @@

Re: [PATCH 07/20] scsi_transport_fc: rename 'fc_rport_create' to 'fc_remote_port_create'

2016-10-18 Thread James Smart
On 10/18/2016 1:01 AM, Hannes Reinecke wrote: Required for the next patch. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_transport_fc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/scsi_transport_fc.c

Re: [PATCH v8 0/7] ZBC / Zoned block device support

2016-10-18 Thread Jens Axboe
On 10/18/2016 12:40 AM, Damien Le Moal wrote: This series introduces support for zoned block devices. It integrates earlier submissions by Hannes Reinecke and Shaun Tancheff. Compared to the previous series version, the code was significantly simplified by limiting support to zoned devices

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-18 Thread Michal Hocko
On Thu 13-10-16 01:20:10, Lorenzo Stoakes wrote: > This patch series adjusts functions in the get_user_pages* family such that > desired FOLL_* flags are passed as an argument rather than implied by flags. > > The purpose of this change is to make the use of FOLL_FORCE explicit so it is > easier

[PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency

2016-10-18 Thread Arnd Bergmann
The driver was changed to call ioport_map, which breaks platforms that cannot provide this function: drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0': g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388): undefined reference to `ioport_map' This adds a

Re: [PATCH] scsi: update rdac devices at scsi_dh_rdac

2016-10-18 Thread Xose Vazquez Perez
On 10/07/2016 06:55 PM, Xose Vazquez Perez wrote: This patch is pending, ACK is needed! The part of multipath-tools was done time ago. CC: Babu Moger, just in case. > Remove IBM/1745 ghost array. > There is no references nowhere, also removed from multipath-tools > Confirmed by the original

[PATCH v2 04/10] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.

2016-10-18 Thread Vivek Gautam
remove() callback does a phy_exit() only and nothing else now. The phy_exit() over the generic phy is called from the phy consumer, and phy provider driver should not explicitly need to call any phy_exit(). So discard the remove callback for qcom-ufs phy platform drivers. Signed-off-by: Vivek

[PATCH v2 05/10] phy: qcom-ufs: Cleanup clock and regulator initialization

2016-10-18 Thread Vivek Gautam
Different menthods pass around generic phy pointer to extract device pointer. Instead, pass the device pointer directly between function calls. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- No change since v1.

[PATCH 08/10] ufs-qcom: phy/hcd: Refactoring phy clock handling

2016-10-18 Thread Vivek Gautam
Add phy clock enable code to phy_power_on/off callbacks, and remove explicit calls to enable these phy clocks from the ufs-qcom hcd driver. Signed-off-by: Vivek Gautam --- Changes since v1: - staticized ufs_qcom_phy_enable(/disable)_ref_clk(), - staticized

[PATCH v2 06/10] phy: qcom-ufs: Remove unnecessary function declarations

2016-10-18 Thread Vivek Gautam
Move the functions' definitions to remove unnecessary declarations. Signed-off-by: Vivek Gautam --- New patch added in v2 series. drivers/phy/phy-qcom-ufs.c | 133 + 1 file changed, 63 insertions(+), 70 deletions(-)

[PATCH v2 01/10] phy: qcom-ufs: remove failure when rx/tx_iface_clk are absent

2016-10-18 Thread Vivek Gautam
From: Yaniv Gardi Since in future UFS Phy's the tx_iface_clk and rx_iface_clk are no longer exist, we should not fail when their initialization fail, but rather just report with debug message. Signed-off-by: Yaniv Gardi Signed-off-by: Vivek Gautam

[PATCH v2 09/10] scsi/ufs: qcom: Add phy_exit call in hcd exit path

2016-10-18 Thread Vivek Gautam
Do a phy_exit() over the ufs phy in the ufs qcom exit path to de-initialize the phy. Signed-off-by: Vivek Gautam --- New patch added in v2 series. drivers/scsi/ufs/ufs-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/ufs/ufs-qcom.c

[PATCH v2 02/10] phy: qcom-ufs: Remove unnecessary BUG_ON

2016-10-18 Thread Vivek Gautam
BUG_ON() are not preferred in the driver, plus the variable on which BUG_ON is asserted is already checked in the code before passing. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- No change since v1.

[PATCH v2 03/10] phy: qcom-ufs: Use devm sibling of kstrdup for regulator names

2016-10-18 Thread Vivek Gautam
This helps us in avoiding any requirement for kfree() operation to be called exclusively over the allocated string pointer. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- No change since v1. drivers/phy/phy-qcom-ufs.c | 5

[PATCH v2 07/10] phy: qcom-ufs-qmp-xx: Move clock and regulator init out of phy init

2016-10-18 Thread Vivek Gautam
The phy init is meant to do phy initialization rather than just getting the clock and regulator. Move these clock and regulator get to probe(), to make room for actual phy initialization sequence. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani

[PATCH v2 10/10] phy: qcom-ufs: Remove common layer phy exit callback

2016-10-18 Thread Vivek Gautam
The common layer phy exit callback ufs_qcom_phy_exit() calls phy_power_off() that has no meaning when phy_power_off() callback is already registered with the phy provider and the consumer makes use of the same. Instead, add a no-op specific phy_exit() callback for now to add the exit sequence at a

[PATCH v2 00/10] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

2016-10-18 Thread Vivek Gautam
These patches cleanup the ufs phy driver to an extent. Subsequent patches will target to clean the phy_init() of these qcom-ufs phy drivers in order to get rid of a number of exported APIs that phy drivers expose for ufs-qcom hcd driver to use. These patches are based on linux-phy next branch,

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-18 Thread Tomas Henzl
Hi, similar suspicious code path can be found in the queuecommand functions in other drivers too these are - pmcraid.c arcmsr_hba.c cc-ing maintainers - (but both drivers seem to be unmaintained for a while - I've added Ching for arcmsr and Raghava for pmcraid) please read this thread and

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

2016-10-18 Thread Lorenzo Stoakes
On Tue, Oct 18, 2016 at 02:54:25PM +0200, Jan Kara wrote: > > @@ -1282,7 +1282,7 @@ long get_user_pages(unsigned long start, unsigned > > long nr_pages, > > int write, int force, struct page **pages, > > struct vm_area_struct **vmas); > > long

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-18 Thread Sumit Saxena
>-Original Message- >From: Ric Wheeler [mailto:ricwhee...@gmail.com] >Sent: Tuesday, October 18, 2016 6:38 PM >To: Tomas Henzl; Sumit Saxena; linux-scsi@vger.kernel.org >Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com; Kashyap Desai >Subject: Re: [PATCH 4/7] megaraid_sas: Send

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-18 Thread Ric Wheeler
On 10/17/2016 09:57 AM, Tomas Henzl wrote: On 17.10.2016 15:28, Sumit Saxena wrote: -Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Monday, October 17, 2016 6:44 PM To: Sumit Saxena; linux-scsi@vger.kernel.org Cc: martin.peter...@oracle.com;

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:14, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages_locked() > and replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit in callers as use of this flag can result in surprising behaviour > (and >

Re: [PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:13, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from > get_user_pages_unlocked() > and replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit in callers as use of this flag can result in surprising behaviour > (and >

Re: [PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked()

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:12, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from > __get_user_pages_unlocked() to make the use of FOLL_FORCE explicit in callers > as > use of this flag can result in surprising behaviour (and hence bugs) within > the > mm subsystem. > >

Re: [PATCH 01/10] mm: remove write/force parameters from __get_user_pages_locked()

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:11, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from > __get_user_pages_locked() > to make the use of FOLL_FORCE explicit in callers as use of this flag can > result > in surprising behaviour (and hence bugs) within the mm subsystem. > >

Re: [PATCH 07/20] scsi_transport_fc: rename 'fc_rport_create' to 'fc_remote_port_create'

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:41AM +0200, Hannes Reinecke wrote: > Required for the next patch. > > Signed-off-by: Hannes Reinecke > --- Given the comment on the next patch, Acked-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 08/20] libfc: Replace ->rport_create callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 12:23:22PM +0200, Hannes Reinecke wrote: > On 10/18/2016 10:54 AM, Johannes Thumshirn wrote: > > On Tue, Oct 18, 2016 at 10:01:42AM +0200, Hannes Reinecke wrote: > >> The ->rport_create callback only ever had a single implementation, > >> so we can as well call it directly

Re: [PATCH 08/20] libfc: Replace ->rport_create callback with function call

2016-10-18 Thread Hannes Reinecke
On 10/18/2016 10:54 AM, Johannes Thumshirn wrote: > On Tue, Oct 18, 2016 at 10:01:42AM +0200, Hannes Reinecke wrote: >> The ->rport_create callback only ever had a single implementation, >> so we can as well call it directly and drop the callback. >> >> Signed-off-by: Hannes Reinecke

[Bug 153171] scsi host6: runtime PM trying to activate child device host6 but parent (2-2:1.0) is not active

2016-10-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=153171 Scott Mowerson changed: What|Removed |Added CC|

Re: low read performance after removing/adding iscsi device

2016-10-18 Thread Dmitry Melekhov
OK, looks like I found workaround- iscsi target have to map at least one lun for host, before it login. Otherwise I have low read performance and sometimes host doesn't recognize snapshot's lun without logoff/logon. Don't know is it HPE MSA or linux bug.. 17.10.2016 09:46, Dmitry Melekhov

Re: [PATCH 20/20] libfc: Replace ->seq_release callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:54AM +0200, Hannes Reinecke wrote: > The ->seq_release callback only ever had one implementation, > so call the function directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 18/20] libfc: Replace ->seq_set_resp callback with direct function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:52AM +0200, Hannes Reinecke wrote: > The ->seq_set_resp callback only ever had one implementation, > so call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn --

Re: [PATCH 19/20] libfc: Replace ->seq_assign callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:53AM +0200, Hannes Reinecke wrote: > The ->seq_assign callback only ever had one implementation, > so call the function directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 17/20] libfc: Replace ->seq_start_next callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:51AM +0200, Hannes Reinecke wrote: > The ->seq_start_next callback only ever had one implementation, > so call the function directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 16/20] libfc: Replace ->exch_done callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:50AM +0200, Hannes Reinecke wrote: > The ->exch_done callback only ever had one implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 15/20] libfc: Replace ->seq_exch_abort callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:49AM +0200, Hannes Reinecke wrote: > The ->seq_exch_abort callback only ever had one implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 14/20] libfc: Replace ->seq_send callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:48AM +0200, Hannes Reinecke wrote: > The ->seq_send callback only ever had one implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 13/20] libfc: Remove fc_rport_init()

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:47AM +0200, Hannes Reinecke wrote: > Function is empty now and can be removed. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 12/20] libfc: Replace ->rport_flush_queue callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:46AM +0200, Hannes Reinecke wrote: > The ->rport_flush_queue callback only ever had a single > implementation, so we can as well call it directly and > drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes

Re: [PATCH 11/20] libfc: Replace ->rport_recv_req callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:45AM +0200, Hannes Reinecke wrote: > The ->rport_recv_req callback only ever had one implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 10/20] libfc: Replace ->rport_logoff callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:44AM +0200, Hannes Reinecke wrote: > The ->rport_logoff callback only ever had one implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 09/20] libfc: Replace ->rport_login callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:43AM +0200, Hannes Reinecke wrote: > The ->rport_login callback only ever had one implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 08/20] libfc: Replace ->rport_create callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:42AM +0200, Hannes Reinecke wrote: > The ->rport_create callback only ever had a single implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Any reason we can't rename fc_rport_create()

Re: [PATCH 06/20] libfc: Replace ->rport_lookup callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:40AM +0200, Hannes Reinecke wrote: > The ->rport_lookup callback only ever had a single implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 05/20] libfc: Replace ->rport_destroy callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:39AM +0200, Hannes Reinecke wrote: > The ->rport_destroy callback only ever had one implementation, > so we can as well call it directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 04/20] libfc: Replace ->exch_seq_send callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:38AM +0200, Hannes Reinecke wrote: > The ->exch_seq_send callback only ever had one implementation, > so we can call the function directly and drop the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 03/20] libfc: Replace ->lport_recv with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:37AM +0200, Hannes Reinecke wrote: > The ->lport_recv callback only ever had one implementation, > so call the function directly and remove the callback. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 02/20] libfc: Replace ->lport_reset callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:36AM +0200, Hannes Reinecke wrote: > The ->lport_reset callback only ever had one implementation, > which already is exported. So remove it and use the function > directly. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes

Re: [PATCH 01/20] libfc: Replace ->seq_els_rsp_send callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:35AM +0200, Hannes Reinecke wrote: > The 'seq_els_rsp_send' callback only ever had one implementation, > so we might as well drop it and use the function directly. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

Re: [PATCH 01/20] libfc: Replace ->seq_els_rsp_send callback with function call

2016-10-18 Thread Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:35AM +0200, Hannes Reinecke wrote: > The 'seq_els_rsp_send' callback only ever had one implementation, > so we might as well drop it and use the function directly. > > Signed-off-by: Hannes Reinecke > --- Looks good, Acked-by: Johannes Thumshirn

[PATCH 07/20] scsi_transport_fc: rename 'fc_rport_create' to 'fc_remote_port_create'

2016-10-18 Thread Hannes Reinecke
Required for the next patch. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_transport_fc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c index 0f3a386..4534085 100644 ---

[PATCH 20/20] libfc: Replace ->seq_release callback with function call

2016-10-18 Thread Hannes Reinecke
The ->seq_release callback only ever had one implementation, so call the function directly and drop the callback. Signed-off-by: Hannes Reinecke --- drivers/scsi/libfc/fc_exch.c| 6 ++ drivers/target/tcm_fc/tfc_cmd.c | 2 +- include/scsi/libfc.h| 8 +--- 3

[PATCH 08/20] libfc: Replace ->rport_create callback with function call

2016-10-18 Thread Hannes Reinecke
The ->rport_create callback only ever had a single implementation, so we can as well call it directly and drop the callback. Signed-off-by: Hannes Reinecke --- drivers/scsi/fcoe/fcoe_ctlr.c | 2 +- drivers/scsi/libfc/fc_disc.c | 7 +++ drivers/scsi/libfc/fc_lport.c | 6

[PATCH 19/20] libfc: Replace ->seq_assign callback with function call

2016-10-18 Thread Hannes Reinecke
The ->seq_assign callback only ever had one implementation, so call the function directly and drop the callback. Signed-off-by: Hannes Reinecke --- drivers/scsi/libfc/fc_exch.c| 6 ++ drivers/target/tcm_fc/tfc_cmd.c | 2 +- include/scsi/libfc.h| 8 +--- 3

  1   2   >