From: Yuval Mintz
This adds the backbone required for the various HW initalizations
which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ
4 line of adapters - FW notification, resource initializations, etc.
Signed-off-by: Arun Easi
From: Manish Rangankar
This patch adds support for iscsi_transport LLD Login,
Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing
and Firmware async event handling support.
Signed-off-by: Nilesh Javali
Signed-off-by: Adheer Chandravanshi
From: Manish Rangankar
This series introduces hardware offload iSCSI initiator driver for the
41000 Series Converged Network Adapters (579xx chip) by Qlogic. The overall
driver design includes a common module ('qed') and protocol specific
dependent modules ('qedi'
From: Yuval Mintz
This patch adds out of order packet handling for hardware offloaded
iSCSI. Out of order packet handling requires driver buffer allocation
and assistance.
Signed-off-by: Arun Easi
Signed-off-by: Yuval Mintz
From: Manish Rangankar
The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module
for 41000 Series Converged Network Adapters by QLogic.
This patch consists of following changes:
- MAINTAINERS Makefile and Kconfig changes for qedi,
- PCI driver
From: Manish Rangankar
This patch adds support for data path and TMF handling.
Signed-off-by: Nilesh Javali
Signed-off-by: Adheer Chandravanshi
Signed-off-by: Chad Dupuis
From: Manish Rangankar
This patch adds support for iscsiuio interface using Light L2 (LL2) qed
interface.
Signed-off-by: Nilesh Javali
Signed-off-by: Adheer Chandravanshi
Signed-off-by: Chad Dupuis
On 10/18/2016 07:53 PM, Martin K. Petersen wrote:
"Jens" == Jens Axboe writes:
Jens> I already queued up the other bits, if it's fine with you I'll add
Jens> 6/7 as well.
Sure. Feel free to add by Acked-by:.
Thanks, added and committed the sd bit. I'll push out when I get
> "Jens" == Jens Axboe writes:
Jens> I already queued up the other bits, if it's fine with you I'll add
Jens> 6/7 as well.
Sure. Feel free to add by Acked-by:.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe
On 10/18/2016 06:46 PM, Martin K. Petersen wrote:
"Jens" == Jens Axboe writes:
Jens> This is starting to look mergeable to me.
Yup.
Jens> Any objections in getting this applied for 4.10? Looks like 6/7
Jens> should go through the SCSI tree, but I can queue up the rest.
I'm
> "Michael" == Michael Cyr writes:
Michael> Various fixes and cleanups for the ibmvscsis driver. The first
Michael> is a sort of prequel to the second, which is the primary change
Michael> (and the biggest). The rest are fairly small fixes.
Applied to 4.10/scsi-queue.
> "Arnd" == Arnd Bergmann writes:
Arnd> The driver was changed to call ioport_map, which breaks platforms
Arnd> that cannot provide this function:
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line
> "Hannes" == Hannes Reinecke writes:
Hannes> Found by 0-day robot.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
> "Damien" == Damien Le Moal writes:
Damien> Implement ZBC support functions to setup zoned disks, both
Damien> host-managed and host-aware models. Only zoned disks that
Damien> satisfy the following conditions are supported:
Damien> 1) All zones are the same size,
> "Jens" == Jens Axboe writes:
Jens> This is starting to look mergeable to me.
Yup.
Jens> Any objections in getting this applied for 4.10? Looks like 6/7
Jens> should go through the SCSI tree, but I can queue up the rest.
I'm OK with it at this point. Probably easier if
> "Jeff" == Jeff Moyer writes:
Jeff,
Jeff> Are power of 2 zone sizes required by the standard? I see why
Jeff> you've done this, but I wonder if we're artificially limiting the
Jeff> implementation, and whether there will be valid devices on the
Jeff> market that simply
On 2016-10-18 07:28, Vivek Gautam wrote:
The common layer phy exit callback ufs_qcom_phy_exit()
calls phy_power_off() that has no meaning when phy_power_off()
callback is already registered with the phy provider and
the consumer makes use of the same.
Instead, add a no-op specific phy_exit()
Jeff,
On 10/19/16 01:43, Jeff Moyer wrote:
> Damien Le Moal writes:
>
>> diff --git a/Documentation/ABI/testing/sysfs-block
>> b/Documentation/ABI/testing/sysfs-block
>> index 75a5055..ee2d5cd 100644
>> --- a/Documentation/ABI/testing/sysfs-block
>> +++
Jens,
On 10/19/16 00:58, Jens Axboe wrote:
> This is starting to look mergeable to me. Any objections in getting this
> applied for 4.10? Looks like 6/7 should go through the SCSI tree, but I
> can queue up the rest.
Yes, it would be great to get all this queued for 4.10. Indeed 6/7 is
SCSI, but
On Tue, 18 Oct 2016, Arnd Bergmann wrote:
> The driver was changed to call ioport_map, which breaks platforms that
> cannot provide this function:
>
> drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0':
> g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388):
Nicholas,
We patched this in and for the first time in many reboots, we didn't
have iSCSI going straight into D state. We have had to work on a
couple of other things, so we don't know if this is just a coincidence
or not. We will reboot back into the old kernel and back a few times
and do some
On 10/18/2016 02:48 PM, Bart Van Assche wrote:
- blk_mq_quiesce_queue() has been reworked (thanks to Ming Lin and Sagi
for their feedback).
(replying to my own e-mail)
A correction: Ming Lei provided feedback on v2 of this patch series
instead of Ming Lin.
Bart.
--
To unsubscribe from
Avoid that nvme_queue_rq() is still running when nvme_stop_queues()
returns.
Signed-off-by: Bart Van Assche
Cc: Keith Busch
Cc: Sagi Grimberg
Cc: Christoph Hellwig
---
drivers/nvme/host/core.c | 15
Rename srp_wait_for_queuecommand() into scsi_wait_for_queuecommand().
Ensure that if scsi-mq is enabled that scsi_wait_for_queuecommand()
waits until ongoing shost->hostt->queuecommand() calls have finished.
Signed-off-by: Bart Van Assche
Cc: James Bottomley
Make nvme_requeue_req() check BLK_MQ_S_STOPPED instead of
QUEUE_FLAG_STOPPED. Remove the QUEUE_FLAG_STOPPED manipulations
that became superfluous because of this change. This patch fixes
a race condition: using queue_flag_clear_unlocked() is not safe
if any other function that manipulates the
Additionally, add a comment about the queuecommand() call from
scsi_send_eh_cmnd().
Signed-off-by: Bart Van Assche
Cc: James Bottomley
Cc: Martin K. Petersen
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Ensure that all ongoing dm_mq_queue_rq() and dm_mq_requeue_request()
calls have stopped before setting the "queue stopped" flag. This
allows to remove the "queue stopped" test from dm_mq_queue_rq() and
dm_mq_requeue_request(). This patch fixes a race condition because
dm_mq_queue_rq() is called
Instead of manipulating both QUEUE_FLAG_STOPPED and BLK_MQ_S_STOPPED
in the dm start and stop queue functions, only manipulate the latter
flag.
Signed-off-by: Bart Van Assche
Cc: Mike Snitzer
---
drivers/md/dm-rq.c | 18 ++
1 file
Most blk_mq_requeue_request() and blk_mq_add_to_requeue_list() calls
are followed by kicking the requeue list. Hence add an argument to
these two functions that allows to kick the requeue list. This was
proposed by Christoph Hellwig.
Signed-off-by: Bart Van Assche
Cc:
blk_mq_quiesce_queue() waits until ongoing .queue_rq() invocations
have finished. This function does *not* wait until all outstanding
requests have finished (this means invocation of request.end_io()).
Signed-off-by: Bart Van Assche
Cc: Ming Lei
The function blk_queue_stopped() allows to test whether or not a
traditional request queue has been stopped. Introduce a helper
function that allows block drivers to query easily whether or not
one or more hardware contexts of a blk-mq queue have been stopped.
Signed-off-by: Bart Van Assche
Hello Jens,
Multiple block drivers need the functionality to stop a request queue
and to wait until all ongoing request_fn() / queue_rq() calls have
finished without waiting until all outstanding requests have finished.
Hence this patch series that introduces the blk_mq_quiesce_queue() and
Multiple functions test the BLK_MQ_S_STOPPED bit so introduce
a helper function that performs this test.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Sagi Grimberg
Cc: Johannes Thumshirn
The meaning of the BLK_MQ_S_STOPPED flag is "do not call
.queue_rq()". Hence modify blk_mq_make_request() such that requests
are queued instead of issued if a queue has been stopped.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Hannes
On 10/18/2016 07:28 AM, Vivek Gautam wrote:
> From: Yaniv Gardi
>
> Since in future UFS Phy's the tx_iface_clk and rx_iface_clk
> are no longer exist, we should not fail when their initialization
> fail, but rather just report with debug message.
>
> Signed-off-by: Yaniv
On 2016-10-18 07:28, Vivek Gautam wrote:
Do a phy_exit() over the ufs phy in the ufs qcom exit path
to de-initialize the phy.
Signed-off-by: Vivek Gautam
---
New patch added in v2 series.
drivers/scsi/ufs/ufs-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff
On 2016-10-18 07:28, Vivek Gautam wrote:
Add phy clock enable code to phy_power_on/off callbacks, and
remove explicit calls to enable these phy clocks from the
ufs-qcom hcd driver.
Signed-off-by: Vivek Gautam
---
Changes since v1:
- staticized
At this point, I am not the right person to ack this change. However,
adding new vendor id's is mostly not an issue.
But, removing could be a problem. Sean has to confirm this.
On 10/18/2016 10:11 AM, Xose Vazquez Perez wrote:
On 10/07/2016 06:55 PM, Xose Vazquez Perez wrote:
This patch is
>-Original Message-
>From: James Bottomley [mailto:j...@linux.vnet.ibm.com]
>Sent: Monday, October 17, 2016 11:22 PM
>To: Kashyap Desai; Ric Wheeler; Hannes Reinecke; Sumit Saxena; linux-
>s...@vger.kernel.org
>Cc: martin.peter...@oracle.com; the...@redhat.com; Christoph Hellwig;
>Martin
On 2016-10-18 07:28, Vivek Gautam wrote:
Move the functions' definitions to remove unnecessary
declarations.
Signed-off-by: Vivek Gautam
---
New patch added in v2 series.
drivers/phy/phy-qcom-ufs.c | 133
+
1 file
On 2016-10-18 07:28, Vivek Gautam wrote:
From: Yaniv Gardi
Since in future UFS Phy's the tx_iface_clk and rx_iface_clk
are no longer exist, we should not fail when their initialization
fail, but rather just report with debug message.
You may also want to update the
On Tue, Oct 18, 2016 at 11:58 AM, Jeff Moyer wrote:
> Damien Le Moal writes:
>
>> + if (!is_power_of_2(zone_blocks)) {
>> + if (sdkp->first_scan)
>> + sd_printk(KERN_NOTICE, sdkp,
>> +
On Tue, Oct 18, 2016 at 09:01:34AM +0200, Johannes Thumshirn wrote:
[...]
> >
> > This is likely the missing SCF_ACK_KREF assignment in >= v4.1.y:
> >
> > http://www.spinics.net/lists/target-devel/msg13530.html
Sorry to disappoint you but it didn't fix my issue. Is there any debug data I
can
On 10/18/2016 9:18 AM, Johannes Thumshirn wrote:
Hi James,
fc_rport_create() in scsi_transport_fc.c is static so there is no
interface change here.
Johannes
ah - that this was the published routine. ok.
-- james
--
To unsubscribe from this list: send the line "unsubscribe
Damien Le Moal writes:
> + if (!is_power_of_2(zone_blocks)) {
> + if (sdkp->first_scan)
> + sd_printk(KERN_NOTICE, sdkp,
> + "Devices with non power of 2 zone "
> + "size are
627511e3e modified some Hitachi entries:
Four models, OPEN-/DF400/DF500/DISK-SUBSYSTEM, can handle REPORT_LUN,
and the BLIST_REPORTLUN2 flag needs to be set. And DF600 doesn't require
any flags because it returns ANSI 03h (SPC).
{"HITACHI", "DF400", "*", BLIST_REPORTLUN2},
Damien Le Moal writes:
> diff --git a/Documentation/ABI/testing/sysfs-block
> b/Documentation/ABI/testing/sysfs-block
> index 75a5055..ee2d5cd 100644
> --- a/Documentation/ABI/testing/sysfs-block
> +++ b/Documentation/ABI/testing/sysfs-block
> @@ -251,3 +251,16 @@
On 10/18/2016 1:01 AM, Hannes Reinecke wrote:
Required for the next patch.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_transport_fc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/scsi_transport_fc.c
On 10/18/2016 12:40 AM, Damien Le Moal wrote:
This series introduces support for zoned block devices. It integrates
earlier submissions by Hannes Reinecke and Shaun Tancheff. Compared to the
previous series version, the code was significantly simplified by limiting
support to zoned devices
On Thu 13-10-16 01:20:10, Lorenzo Stoakes wrote:
> This patch series adjusts functions in the get_user_pages* family such that
> desired FOLL_* flags are passed as an argument rather than implied by flags.
>
> The purpose of this change is to make the use of FOLL_FORCE explicit so it is
> easier
The driver was changed to call ioport_map, which breaks platforms that
cannot provide this function:
drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0':
g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388): undefined
reference to `ioport_map'
This adds a
On 10/07/2016 06:55 PM, Xose Vazquez Perez wrote:
This patch is pending, ACK is needed!
The part of multipath-tools was done time ago.
CC: Babu Moger, just in case.
> Remove IBM/1745 ghost array.
> There is no references nowhere, also removed from multipath-tools
> Confirmed by the original
remove() callback does a phy_exit() only and nothing else now.
The phy_exit() over the generic phy is called from the phy
consumer, and phy provider driver should not explicitly need to
call any phy_exit().
So discard the remove callback for qcom-ufs phy platform drivers.
Signed-off-by: Vivek
Different menthods pass around generic phy pointer to
extract device pointer. Instead, pass the device pointer
directly between function calls.
Signed-off-by: Vivek Gautam
Reviewed-by: Subhash Jadavani
---
No change since v1.
Add phy clock enable code to phy_power_on/off callbacks, and
remove explicit calls to enable these phy clocks from the
ufs-qcom hcd driver.
Signed-off-by: Vivek Gautam
---
Changes since v1:
- staticized ufs_qcom_phy_enable(/disable)_ref_clk(),
- staticized
Move the functions' definitions to remove unnecessary
declarations.
Signed-off-by: Vivek Gautam
---
New patch added in v2 series.
drivers/phy/phy-qcom-ufs.c | 133 +
1 file changed, 63 insertions(+), 70 deletions(-)
From: Yaniv Gardi
Since in future UFS Phy's the tx_iface_clk and rx_iface_clk
are no longer exist, we should not fail when their initialization
fail, but rather just report with debug message.
Signed-off-by: Yaniv Gardi
Signed-off-by: Vivek Gautam
Do a phy_exit() over the ufs phy in the ufs qcom exit path
to de-initialize the phy.
Signed-off-by: Vivek Gautam
---
New patch added in v2 series.
drivers/scsi/ufs/ufs-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ufs-qcom.c
BUG_ON() are not preferred in the driver, plus the variable
on which BUG_ON is asserted is already checked in the code
before passing.
Signed-off-by: Vivek Gautam
Reviewed-by: Subhash Jadavani
---
No change since v1.
This helps us in avoiding any requirement for kfree() operation
to be called exclusively over the allocated string pointer.
Signed-off-by: Vivek Gautam
Reviewed-by: Subhash Jadavani
---
No change since v1.
drivers/phy/phy-qcom-ufs.c | 5
The phy init is meant to do phy initialization rather than
just getting the clock and regulator. Move these clock and
regulator get to probe(), to make room for actual phy
initialization sequence.
Signed-off-by: Vivek Gautam
Reviewed-by: Subhash Jadavani
The common layer phy exit callback ufs_qcom_phy_exit()
calls phy_power_off() that has no meaning when phy_power_off()
callback is already registered with the phy provider and
the consumer makes use of the same.
Instead, add a no-op specific phy_exit() callback for now
to add the exit sequence at a
These patches cleanup the ufs phy driver to an extent.
Subsequent patches will target to clean the phy_init() of
these qcom-ufs phy drivers in order to get rid of a number of
exported APIs that phy drivers expose for ufs-qcom hcd driver
to use.
These patches are based on linux-phy next branch,
Hi,
similar suspicious code path can be found in the queuecommand functions in
other drivers too
these are -
pmcraid.c
arcmsr_hba.c
cc-ing maintainers -
(but both drivers seem to be unmaintained for a while -
I've added Ching for arcmsr and Raghava for pmcraid)
please read this thread and
On Tue, Oct 18, 2016 at 02:54:25PM +0200, Jan Kara wrote:
> > @@ -1282,7 +1282,7 @@ long get_user_pages(unsigned long start, unsigned
> > long nr_pages,
> > int write, int force, struct page **pages,
> > struct vm_area_struct **vmas);
> > long
>-Original Message-
>From: Ric Wheeler [mailto:ricwhee...@gmail.com]
>Sent: Tuesday, October 18, 2016 6:38 PM
>To: Tomas Henzl; Sumit Saxena; linux-scsi@vger.kernel.org
>Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com; Kashyap Desai
>Subject: Re: [PATCH 4/7] megaraid_sas: Send
On 10/17/2016 09:57 AM, Tomas Henzl wrote:
On 17.10.2016 15:28, Sumit Saxena wrote:
-Original Message-
From: Tomas Henzl [mailto:the...@redhat.com]
Sent: Monday, October 17, 2016 6:44 PM
To: Sumit Saxena; linux-scsi@vger.kernel.org
Cc: martin.peter...@oracle.com;
On Thu 13-10-16 01:20:14, Lorenzo Stoakes wrote:
> This patch removes the write and force parameters from get_user_pages_locked()
> and replaces them with a gup_flags parameter to make the use of FOLL_FORCE
> explicit in callers as use of this flag can result in surprising behaviour
> (and
>
On Thu 13-10-16 01:20:13, Lorenzo Stoakes wrote:
> This patch removes the write and force parameters from
> get_user_pages_unlocked()
> and replaces them with a gup_flags parameter to make the use of FOLL_FORCE
> explicit in callers as use of this flag can result in surprising behaviour
> (and
>
On Thu 13-10-16 01:20:12, Lorenzo Stoakes wrote:
> This patch removes the write and force parameters from
> __get_user_pages_unlocked() to make the use of FOLL_FORCE explicit in callers
> as
> use of this flag can result in surprising behaviour (and hence bugs) within
> the
> mm subsystem.
>
>
On Thu 13-10-16 01:20:11, Lorenzo Stoakes wrote:
> This patch removes the write and force parameters from
> __get_user_pages_locked()
> to make the use of FOLL_FORCE explicit in callers as use of this flag can
> result
> in surprising behaviour (and hence bugs) within the mm subsystem.
>
>
On Tue, Oct 18, 2016 at 10:01:41AM +0200, Hannes Reinecke wrote:
> Required for the next patch.
>
> Signed-off-by: Hannes Reinecke
> ---
Given the comment on the next patch,
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn
On Tue, Oct 18, 2016 at 12:23:22PM +0200, Hannes Reinecke wrote:
> On 10/18/2016 10:54 AM, Johannes Thumshirn wrote:
> > On Tue, Oct 18, 2016 at 10:01:42AM +0200, Hannes Reinecke wrote:
> >> The ->rport_create callback only ever had a single implementation,
> >> so we can as well call it directly
On 10/18/2016 10:54 AM, Johannes Thumshirn wrote:
> On Tue, Oct 18, 2016 at 10:01:42AM +0200, Hannes Reinecke wrote:
>> The ->rport_create callback only ever had a single implementation,
>> so we can as well call it directly and drop the callback.
>>
>> Signed-off-by: Hannes Reinecke
https://bugzilla.kernel.org/show_bug.cgi?id=153171
Scott Mowerson changed:
What|Removed |Added
CC|
OK, looks like I found workaround-
iscsi target have to map at least one lun for host, before it login.
Otherwise I have low read performance and sometimes host doesn't recognize
snapshot's lun without logoff/logon.
Don't know is it HPE MSA or linux bug..
17.10.2016 09:46, Dmitry Melekhov
On Tue, Oct 18, 2016 at 10:01:54AM +0200, Hannes Reinecke wrote:
> The ->seq_release callback only ever had one implementation,
> so call the function directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:52AM +0200, Hannes Reinecke wrote:
> The ->seq_set_resp callback only ever had one implementation,
> so call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
On Tue, Oct 18, 2016 at 10:01:53AM +0200, Hannes Reinecke wrote:
> The ->seq_assign callback only ever had one implementation,
> so call the function directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:51AM +0200, Hannes Reinecke wrote:
> The ->seq_start_next callback only ever had one implementation,
> so call the function directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:50AM +0200, Hannes Reinecke wrote:
> The ->exch_done callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:49AM +0200, Hannes Reinecke wrote:
> The ->seq_exch_abort callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:48AM +0200, Hannes Reinecke wrote:
> The ->seq_send callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:47AM +0200, Hannes Reinecke wrote:
> Function is empty now and can be removed.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:46AM +0200, Hannes Reinecke wrote:
> The ->rport_flush_queue callback only ever had a single
> implementation, so we can as well call it directly and
> drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes
On Tue, Oct 18, 2016 at 10:01:45AM +0200, Hannes Reinecke wrote:
> The ->rport_recv_req callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:44AM +0200, Hannes Reinecke wrote:
> The ->rport_logoff callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:43AM +0200, Hannes Reinecke wrote:
> The ->rport_login callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:42AM +0200, Hannes Reinecke wrote:
> The ->rport_create callback only ever had a single implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Any reason we can't rename fc_rport_create()
On Tue, Oct 18, 2016 at 10:01:40AM +0200, Hannes Reinecke wrote:
> The ->rport_lookup callback only ever had a single implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:39AM +0200, Hannes Reinecke wrote:
> The ->rport_destroy callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:38AM +0200, Hannes Reinecke wrote:
> The ->exch_seq_send callback only ever had one implementation,
> so we can call the function directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:37AM +0200, Hannes Reinecke wrote:
> The ->lport_recv callback only ever had one implementation,
> so call the function directly and remove the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:36AM +0200, Hannes Reinecke wrote:
> The ->lport_reset callback only ever had one implementation,
> which already is exported. So remove it and use the function
> directly.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes
On Tue, Oct 18, 2016 at 10:01:35AM +0200, Hannes Reinecke wrote:
> The 'seq_els_rsp_send' callback only ever had one implementation,
> so we might as well drop it and use the function directly.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:35AM +0200, Hannes Reinecke wrote:
> The 'seq_els_rsp_send' callback only ever had one implementation,
> so we might as well drop it and use the function directly.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
Required for the next patch.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_transport_fc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 0f3a386..4534085 100644
---
The ->seq_release callback only ever had one implementation,
so call the function directly and drop the callback.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libfc/fc_exch.c| 6 ++
drivers/target/tcm_fc/tfc_cmd.c | 2 +-
include/scsi/libfc.h| 8 +---
3
The ->rport_create callback only ever had a single implementation,
so we can as well call it directly and drop the callback.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/fcoe/fcoe_ctlr.c | 2 +-
drivers/scsi/libfc/fc_disc.c | 7 +++
drivers/scsi/libfc/fc_lport.c | 6
The ->seq_assign callback only ever had one implementation,
so call the function directly and drop the callback.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libfc/fc_exch.c| 6 ++
drivers/target/tcm_fc/tfc_cmd.c | 2 +-
include/scsi/libfc.h| 8 +---
3
1 - 100 of 131 matches
Mail list logo