[PATCH] net: return value of skb_linearize should be handled in Linux kernel

kmalloc_reserve may fail to allocate memory inside skb_linearize, which means skb_linearize's return value should not be ignored. Following patch correct the uses of skb_linearize. Compiled in x86_64 Signed-off-by: Zhouyi Zhou --- drivers/infiniband/hw/nes/nes_nic.c

Re: [PATCH] xen-scsifront: Add a missing call to kfree

On 05/12/16 21:53, Dan Carpenter wrote: > On Mon, Nov 21, 2016 at 07:01:36AM +0100, Juergen Gross wrote: >> On 19/11/16 19:22, Quentin Lambert wrote: >>> Most error branches following the call to kmalloc contain >>> a call to kfree. This patch add these calls where they are >>> missing. >>> >>>

Re: [PATCH] sd: make ->no_write_same independent of reported ->max_ws_blocks

> "Nicolai" == Nicolai Stange writes: Nicolai, Nicolai> Due to reported problems with Write Same on ATA devices, commit Nicolai> 0ce1b18c42a5 ("libata: Some drives failing on SCT Write Same") Nicolai> strived to report non-support for Write Same on non-zoned ATA

[PATCH v1 3/4] scsi: ufs: add quirk to increase host PA_SaveConfigTime

The maximum value PA_SaveConfigTime is 250 (10us) but this is not enough for some vendors. Gear switch from PWM to HS may fail even with this max. PA_SaveConfigTime. Gear switch can be issued by host controller as an error recovery and any software delay will not help on this case so we need to

[PATCH v1 4/4] scsi: ufs-qcom: fix bug with read/modify write of UFS_CFG1

ufs_qcom_print_hw_debug_reg_all() function is having a bug where it might incorrectly modify undesired bits in UFS_CFG1 register, this change fixes it. Reviewed-by: Venkat Gopalakrishnan Signed-off-by: Subhash Jadavani ---

[PATCH v1 2/4] scsi: ufs-qcom: add probe_defer in case phy driver not probed yet

From: Yaniv Gardi In case UFS driver is probed before the phy driver does, the UFS driver should return a PROBE_DEFER code. Signed-off-by: Yaniv Gardi Signed-off-by: Subhash Jadavani --- drivers/scsi/ufs/ufs-qcom.c | 11

[PATCH v1 1/4] scsi: ufs: add support for UFS HCI 2.1

From: Yaniv Gardi The UFS HCI v2.1 includes a few additional registers. This change updates the HCI register, the UFS version register content and the Interrupt Status register. Signed-off-by: Yaniv Gardi Signed-off-by: Subhash Jadavani

[PATCH v1 0/4] scsi: ufs: bug fixes, device quirk, HCI 2.1 support

This series has 2 bug fixes, 1 change related to device quirk and 1 change to add UFS HCI 2.1 revision support. Subhash Jadavani (2): scsi: ufs: add quirk to increase host PA_SaveConfigTime scsi: ufs-qcom: fix bug with read/modify write of UFS_CFG1 Yaniv Gardi (2): scsi: ufs: add support

[PATCH] sd: make ->no_write_same independent of reported ->max_ws_blocks

Due to reported problems with Write Same on ATA devices, commit 0ce1b18c42a5 ("libata: Some drives failing on SCT Write Same") strived to report non-support for Write Same on non-zoned ATA devices. However, due to the following control flow in sd_config_write_same() this doesn't always take

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

On 12/5/16, 8:20 AM, "Christoph Hellwig" wrote: >> create mode 100644 drivers/scsi/qla2xxx/qla_bottom.c >> create mode 100644 drivers/scsi/qla2xxx/qla_mq.c >> create mode 100644 drivers/scsi/qla2xxx/qla_top.c > >What's the point of three new fairly small files, two of

Re: [PATCH 1/2 v2] scsi: be2iscsi: set errno on error path

> "Pan" == Pan Bian writes: Pan> Variable ret is reset in the loop, and its value will be 0 during Pan> the after repeat of the loop. Then, if pci_alloc_consistent() Pan> returns NULL, the return value is 0. 0 means no error, which may Pan> make it impossible for the

Re: [PATCH 1/2] scsi: be2iscsi: set errno on error path

> "Pan" == Pan Bian writes: Pan> Variable ret is reset in the loop, and its value will be 0 during Pan> the second and after repeat of the loop. If pci_alloc_consistent() Pan> returns a NULL pointer then, it will leaves with return value 0. 0 Pan> means no error, which

Re: [PATCHv3] hpsa: fallback to use legacy REPORT PHYS command

> "Hannes" == Hannes Reinecke writes: Hannes> Older SmartArray controllers (eg SmartArray 64xx) do not support Hannes> the extended REPORT PHYS command, so fallback to use the legacy Hannes> version here. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

On 12/5/16, 12:43 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Madhani, Himanshu" wrote: > >We need to have the spinlock because currently our NPIV implementation does >not utilizes >Q-pair framework. Looks

Re: [PATCH] scsi: hpsa: use %phN for short hex dumps

> "Rasmus" == Rasmus Villemoes writes: Rasmus> Passing one instead of 8 or 16 arguments reduces the size of the Rasmus> generated code somewhat: Rasmus> add/remove: 2/3 grow/shrink: 1/4 up/down: 1772/-2137 (-365) Rasmus> There's one more candidate, unique_id_show,

Re: [PATCH] scsi: mvsas: Replace pci_pool_alloc by pci_pool_zalloc

> "Souptick" == Souptick Joarder writes: Souptick, Souptick> Any comment on this patch? The patch looked OK to me when you posted it. However, you need one person in addition to me to review it. And you need convince us of the merit of a presumably untested change to

Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove

> "John" == John Garry writes: John> This patch addresses 4 problems in the module probe/remove: John> - When hisi_sas_shost_alloc() fails after we alloc shost memory, John> we should free shost memory before the function returns. John> - When hisi_sas_probe() fails

Re: [PATCH v3 3/6] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls.

On 12/5/16, 4:55 AM, "Christoph Hellwig" wrote: >>+ void *handle; > >Just curious: why do you need this new handle field instead of just >passing the rsp as the old code did? We wanted to make it more generic pointer with new Q-pair frameworks. So just renamed it.

Re: [PATCH v3 6/6] qla2xxx: Fix Target mode handling with Multiqueue changes.

On 12/4/16, 11:42 PM, "Hannes Reinecke" wrote: >On 12/02/2016 10:44 PM, Himanshu Madhani wrote: >> From: Quinn Tran >> >> - Fix race condition between dpc_thread accessing Multiqueue resources >> and qla2x00_remove_one thread trying to free resource. >>

Re: [PATCH] xen-scsifront: Add a missing call to kfree

On Mon, Nov 21, 2016 at 07:01:36AM +0100, Juergen Gross wrote: > On 19/11/16 19:22, Quentin Lambert wrote: > > Most error branches following the call to kmalloc contain > > a call to kfree. This patch add these calls where they are > > missing. > > > > This issue was found with Hector. > > > >

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

On 12/4/16, 11:38 PM, "Hannes Reinecke" wrote: >On 12/02/2016 10:44 PM, Himanshu Madhani wrote: >> From: Michael Hernandez >> >> Replaced existing multiple queue functionality with framework >> that allows for the creation of pairs of request and

Re: scsi: use-after-free in bio_copy_from_iter

On Mon, Dec 05, 2016 at 04:17:53PM +0100, Johannes Thumshirn wrote: > 633 hp = >header; > [...] > 646 hp->dxferp = (char __user *)buf + cmd_size; > So the memory for hp->dxferp comes from: > 633 hp = >header; > >From my debug instrumentation I see that the

Re: [PATCH v3 2/6] qla2xxx: Fix mailbox command timeout due to starvation

On 12/5/16, 8:03 AM, "Christoph Hellwig" wrote: >On Fri, Dec 02, 2016 at 01:44:53PM -0800, Himanshu Madhani wrote: >> From: Samy >> >> This patch helps resolve some of the mailbox timeout issue discovered >> during large SAN emulation testing where

Re: [PATCH v3 1/6] qla2xxx: Only allow operational MBX to proceed during RESET.

On 12/5/16, 8:01 AM, "Christoph Hellwig" wrote: >Can you describe the changes in the body a bit more? Why do you >only want these commands to be sent? Why is the warning added >when it takes longer than nessecary? Otherwise this patch >looks fine to me. This patch is

[PATCH V3 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

Detect sequential IO streams and pass those IOs directly to FW. This patch is depending on patch 3 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 5 +- drivers/scsi/megaraid/megaraid_sas_base.c | 43 +++-

[PATCH V3 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers

An UNMAP command on a PI formatted device will leave the Logical Block Application Tag and Logical Block Reference Tag as all F's (for those LBAs that are unmapped). To avoid IO errors if those LBAs are subsequently read before they are written with valid tag fields, the MPI SCSI IO requests

[PATCH V3 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 11 ++- drivers/scsi/megaraid/megaraid_sas_base.c | 20 ++-

[PATCH V3 02/11] megaraid_sas: 128 MSIX Support

SAS3.5 Generic Megaraid based Controllers will have the support for 128 MSI-X vectors, resulting in the need to support 128 reply queues This patch is depending on patch 1 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 1 +

[PATCH V3 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes

To improve RAID 1/10 Write performance, OS drivers need to issue the required Write IOs as Fast Path IOs (after the appropriate checks allowing Fast Path to be used) to the appropriate physical drives (translated from the OS logical IO) and wait for all Write IOs to complete. If any of the

[PATCH V3 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to have different sizes for different number of supported VDs. This patch is depending on patch 5 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 7 +

[PATCH V3 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers

Update Linux driver to use new pdTargetId field for JBOD target ID This patch is depending on patch 9 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 105 +--- drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH V3 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path

ldio outstanding variable needs to be decremented in io completion path for iMR dual queue depth This patch is depending on patch 8 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 9 +++-- 1 file changed, 7 insertions(+),

[PATCH V3 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

Large SEQ IO workload should sent as non fast path commands This patch is depending on patch 7 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 8 + drivers/scsi/megaraid/megaraid_sas_base.c | 48

[PATCH V3 11/11] megaraid_sas: driver version upgrade

Upgrade driver version. This patch is depending on patch 10 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h

[PATCH V3 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities

The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers Firmware functionality. This patch is depending on patch 6 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas_base.c | 53 ++---

[PATCH V3 00/11] megaraid_sas: Updates for scsi-next

Sasikumar Chandrasekaran (11): megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers megaraid_sas: 128 MSIX Support megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

> create mode 100644 drivers/scsi/qla2xxx/qla_bottom.c > create mode 100644 drivers/scsi/qla2xxx/qla_mq.c > create mode 100644 drivers/scsi/qla2xxx/qla_top.c What's the point of three new fairly small files, two of them very oddly named? Can't we keep the code together by logical groups? > +

Re: [PATCH v3 3/6] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls.

On Mon, Dec 05, 2016 at 04:54:30AM -0800, Christoph Hellwig wrote: > It shouldn't be required in the end, but keeping the switch to the s/shouldn't/should/ > new IRQ helpers from the change to the affinity assignment separate > makes sense. But I can't see the switch anywhere else in the

Re: [PATCH v3 2/6] qla2xxx: Fix mailbox command timeout due to starvation

On Fri, Dec 02, 2016 at 01:44:53PM -0800, Himanshu Madhani wrote: > From: Samy > > This patch helps resolve some of the mailbox timeout issue discovered > during large SAN emulation testing where 1000+ initiators are trying > to log into target mode personality. Since

Re: [PATCH v3 1/6] qla2xxx: Only allow operational MBX to proceed during RESET.

Can you describe the changes in the body a bit more? Why do you only want these commands to be sent? Why is the warning added when it takes longer than nessecary? Otherwise this patch looks fine to me. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

On 05/12/16 16:32, Boris Ostrovsky wrote: > On 12/02/2016 01:15 AM, Juergen Gross wrote: >> >> -static struct vscsiif_request *scsifront_pre_req(struct vscsifrnt_info >> *info) >> +static int scsifront_do_request(struct vscsifrnt_info *info, >> +struct

Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

On 12/02/2016 01:15 AM, Juergen Gross wrote: > > -static struct vscsiif_request *scsifront_pre_req(struct vscsifrnt_info *info) > +static int scsifront_do_request(struct vscsifrnt_info *info, > + struct vscsifrnt_shadow *shadow) > { > struct vscsiif_front_ring

Re: scsi: use-after-free in bio_copy_from_iter

On Mon, Dec 05, 2016 at 03:31:43PM +0100, Dmitry Vyukov wrote: > On Sat, Dec 3, 2016 at 7:19 PM, Johannes Thumshirn wrote: > > On Sat, Dec 03, 2016 at 04:22:39PM +0100, Dmitry Vyukov wrote: > >> On Sat, Dec 3, 2016 at 11:38 AM, Johannes Thumshirn > >>

Re: scsi: use-after-free in bio_copy_from_iter

On Sat, Dec 3, 2016 at 7:19 PM, Johannes Thumshirn wrote: > On Sat, Dec 03, 2016 at 04:22:39PM +0100, Dmitry Vyukov wrote: >> On Sat, Dec 3, 2016 at 11:38 AM, Johannes Thumshirn >> wrote: >> > On Fri, Dec 02, 2016 at 05:50:39PM +0100, Dmitry Vyukov wrote:

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

[Hannes, can you please stop the damn full quotes? reading your answers is a major pain] > Have you modified the irq affinity for this? > Typically the irq-affinity changes will treat all vectors identically, > and spread them out across the available CPUS. > But with this layout vector '0'

Re: [PATCH v3 3/6] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls.

On Fri, Dec 02, 2016 at 01:44:54PM -0800, Himanshu Madhani wrote: > From: Michael Hernandez > > Replaces the old pci_enable_msi[x]* and pci_disable_msi[x] calls. > > Signed-off-by: Michael Hernandez > Signed-off-by: Himanshu Madhani

Re: [PATCH v3 3/6] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls.

> > + if (ha->flags.msix_enabled) { > > + for (i = 0; i < ha->msix_count; i++) { > > + qentry = >msix_entries[i]; > > + if (qentry->have_irq) { > > + irq_set_affinity_notifier(qentry->vector, NULL); > Not sure if that's

[PATCH 09/12] be2iscsi: Remove wq_name from beiscsi_hba

wq_name is used only to set WQ name when its being allocated. Remove it from beiscsi_hba structure and define locally. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.c | 9 + drivers/scsi/be2iscsi/be_main.h | 1 - 2 files changed, 5

[PATCH 11/12] be2iscsi: Add warning message for unsupported adapter

From: Ketan Mukadam Add a warning message to indicate obsolete/unsupported BE2 Adapter Family devices Signed-off-by: Ketan Mukadam Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.c | 2

[PATCH 12/12] be2iscsi: Update driver version

Version 11.2.1.0 Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h index 02a9b2d..2188579 100644 ---

[PATCH 08/12] be2iscsi: Remove unused struct members

Fix errors reported in static analysis. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be.h | 3 -- drivers/scsi/be2iscsi/be_cmds.c | 8 +++--- drivers/scsi/be2iscsi/be_cmds.h | 17 ++-- drivers/scsi/be2iscsi/be_iscsi.c | 2 +-

[PATCH 10/12] be2iscsi: Add checks to validate CID alloc/free

Set CID slot to 0x to indicate empty. Check if connection already exists in conn_table before binding. Check if endpoint already NULL before putting back CID. Break ep->conn link in free_ep to ignore completions after freeing. Signed-off-by: Jitendra Bhivare

[PATCH 07/12] be2iscsi: Remove redundant receive buffers posting

This duplicate code got added during manual merging. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index

[PATCH 04/12] be2iscsi: Set WRB invalid bit for SkyHawk

invalid bit in WRB indicates to FW that IO was invalidated before WRB was fetched from host memory. For SkyHawk, this invalid bit in WRB is at a different offset. Use amap_iscsi_wrb_v2 to mark invalid bit for SkyHawk. Signed-off-by: Jitendra Bhivare ---

[PATCH 01/12] be2iscsi: Fix use of invalidate command table req

Remove shared structure inv_tbl in phba for all sessions to post invalidation IOCTL. Always allocate and then free the table after use in reset handler. Abort handler needs just one instance so define it on stack. Add checks for BE_INVLDT_CMD_TBL_SZ to not exceed invalidation command table size in

[PATCH 05/12] be2iscsi: Add checks to validate completions

Added check in beiscsi_process_cq for pio_handle. pio_handle is cleared in beiscsi_put_wrb_handle. This catches any case where task gets cleaned up just before completion. Use back_lock before accessing pio_handle. Signed-off-by: Jitendra Bhivare ---

[PATCH 02/12] be2iscsi: Fix for crash in beiscsi_eh_device_reset

System crashes when sg_reset is executed in a loop. CPU: 13 PID: 7073 Comm: sg_reset Tainted: GE 4.8.0-rc1+ #4 RIP: 0010:[] [] beiscsi_eh_device_reset+0x160/0x520 [be2iscsi] Call Trace: [] ? scsi_host_alloc_command+0x47/0xc0 [] scsi_try_bus_device_reset+0x2a/0x50 []

[PATCH 00/12] be2iscsi: driver update 11.2.1.0

This patch is generated against for-next branch. Jitendra Bhivare (11): be2iscsi: Fix use of invalidate command table req be2iscsi: Fix for crash in beiscsi_eh_device_reset be2iscsi: Take iscsi_task ref in abort handler be2iscsi: Set WRB invalid bit for SkyHawk be2iscsi: Add checks to

[PATCH 03/12] be2iscsi: Take iscsi_task ref in abort handler

Hold the reference of iscsi_task till invalidation completes. This prevents use of ICD when invalidation of that ICD is being processed. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.c | 45 + 1 file

[PATCH 06/12] be2iscsi: Fix iSCSI cmd cleanup IOCTL

Prepare the IOCTL with appropriate sizes of buffers of V0 and V1. Set missing chute number in V1 IOCTL. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_cmds.c | 33 ++--- drivers/scsi/be2iscsi/be_main.c | 3 +-- 2 files