Re: [PATCH V4 00/11] megaraid_sas: Updates for scsi-next

This seems to be missing the pci_alloc_irq_vectors conversion from Hannes? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

On Tue, Dec 06, 2016 at 05:41:05PM +0200, Michael S. Tsirkin wrote: > __CHECK_ENDIAN__ isn't on by default presumably because > it triggers too many sparse warnings for correct code. > But virtio is now clean of these warnings, and > we want to keep it this way - enable this for > sparse builds. >

Re: [PATCH] scsi: avoid a permanent stop of the scsi device's request queue

Hi, Bart, On 2016/12/7 12:40, Bart Van Assche wrote: > I am aware that commit 5c10e63c943b caused the behavior change. But that > doesn't mean that a fix has to undo the changes introduced by that > commit. We do not only want to make sure that the SCSI core works as > intended but also that

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

On Tue, 2016-12-06 at 15:10 +0800, Zhouyi Zhou wrote: > kmalloc_reserve may fail to allocate memory inside skb_linearize, > which means skb_linearize's return value should not be ignored. > Following patch correct the uses of skb_linearize. > > Compiled in x86_64 > > Signed-off-by: Zhouyi Zhou

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

On Wed, Dec 7, 2016 at 1:02 PM, Cong Wang wrote: > On Mon, Dec 5, 2016 at 11:10 PM, Zhouyi Zhou wrote: >> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c >> b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c >> index 2a653ec..ab787cb

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

On Tue, 2016-12-06 at 17:41 +0200, Michael S. Tsirkin wrote: > It seems that there should be a better way to do it, > but this works too. In some cases there might be: > --- a/drivers/s390/virtio/Makefile > +++ b/drivers/s390/virtio/Makefile > @@ -6,6 +6,8 @@ >  # it under the terms of the GNU

Re: [PATCH] scsi: hisi_sas: support deferred probe for v2 hw

On 2016年12月06日 20:44, John Garry wrote: In the hip06 and hip07 SoCs, the interrupt lines from the SAS controllers are connected to mbigen hw module [1]. The mbigen module is probed with module_init, and, as such, is not guaranteed to probe before the SAS driver. So we need to support deferred

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

On 2016年12月06日 23:41, Michael S. Tsirkin wrote: __CHECK_ENDIAN__ isn't on by default presumably because it triggers too many sparse warnings for correct code. But virtio is now clean of these warnings, and we want to keep it this way - enable this for sparse builds. Signed-off-by: Michael S.

Re: [PATCH v2] qla4xxx: switch to pci_alloc_irq_vectors

On 06/12/16, 7:26 PM, "Christoph Hellwig" wrote: >And simplify the MSI-X logic in general - just request the two >vectors directly instead of going through an indirection table. > >Signed-off-by: Christoph Hellwig >--- > drivers/scsi/qla4xxx/ql4_def.h | 18 +

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

On Mon, Dec 5, 2016 at 11:10 PM, Zhouyi Zhou wrote: > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c > b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c > index 2a653ec..ab787cb 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c > +++

Re: [PATCH] scsi: avoid a permanent stop of the scsi device's request queue

On 12/06/16 19:41, Wei Fang wrote: > On 2016/12/7 10:45, Bart Van Assche wrote: >> The purpose of the scsi_device_set_state(sdev, SDEV_RUNNING) call in >> scsi_sysfs_add_sdev() is to change the device state from SDEV_CREATED >> into SDEV_RUNNING. Have you tried to modify scsi_sysfs_add_sdev() such

Re: [PATCH] scsi: avoid a permanent stop of the scsi device's request queue

Hi, Bart, On 2016/12/7 10:45, Bart Van Assche wrote: > On 12/06/16 17:21, Wei Fang wrote: >> The state of the scsi device first is changed to SDEV_BLOCK in >> scsi_add_lun() as you mentioned, then it will be changed to SDEV_RUNNING >> in scsi_sysfs_add_sdev(). > > Hello Wei, > > The purpose of

Re: [PATCH] scsi: avoid a permanent stop of the scsi device's request queue

On 12/06/16 17:21, Wei Fang wrote: > The state of the scsi device first is changed to SDEV_BLOCK in > scsi_add_lun() as you mentioned, then it will be changed to SDEV_RUNNING > in scsi_sysfs_add_sdev(). Hello Wei, The purpose of the scsi_device_set_state(sdev, SDEV_RUNNING) call in

Re: [PATCH] scsi: avoid a permanent stop of the scsi device's request queue

Hi, Bart, On 2016/12/6 23:51, Bart Van Assche wrote: > On 12/06/16 01:12, Wei Fang wrote: >> The scsi device is being setted to the SDEV_RUNNING state at the end of >> the scan work. When the remote port reappears, scsi_target_unblock() >> will be called, but the QUEUE_FLAG_STOPPED flag will not

[PATCH V4 02/11] megaraid_sas: 128 MSIX Support

SAS3.5 Generic Megaraid based Controllers will have the support for 128 MSI-X vectors, resulting in the need to support 128 reply queues This patch is depending on patch 1 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 1 +

[PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

Detect sequential IO streams and pass those IOs directly to FW. This patch is depending on patch 3 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 5 +- drivers/scsi/megaraid/megaraid_sas_base.c | 43 +++-

[PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

Large SEQ IO workload should sent as non fast path commands This patch is depending on patch 7 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 8 + drivers/scsi/megaraid/megaraid_sas_base.c | 48

[PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities

The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers Firmware functionality. This patch is depending on patch 6 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas_base.c | 53 ++---

[PATCH V4 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes

To improve RAID 1/10 Write performance, OS drivers need to issue the required Write IOs as Fast Path IOs (after the appropriate checks allowing Fast Path to be used) to the appropriate physical drives (translated from the OS logical IO) and wait for all Write IOs to complete. If any of the

[PATCH V4 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers V4: Removed the not supported PCI Device Ids Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 8 +++-

[PATCH V4 11/11] megaraid_sas: driver version upgrade

Upgrade driver version. This patch is depending on patch 10 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h

[PATCH V4 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers

Update Linux driver to use new pdTargetId field for JBOD target ID This patch is depending on patch 9 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 105 +--- drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH V4 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path

ldio outstanding variable needs to be decremented in io completion path for iMR dual queue depth This patch is depending on patch 8 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 9 +++-- 1 file changed, 7 insertions(+),

[PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to have different sizes for different number of supported VDs. This patch is depending on patch 5 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 7 +

[PATCH V4 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers

An UNMAP command on a PI formatted device will leave the Logical Block Application Tag and Logical Block Reference Tag as all F's (for those LBAs that are unmapped). To avoid IO errors if those LBAs are subsequently read before they are written with valid tag fields, the MPI SCSI IO requests

[PATCH V4 00/11] megaraid_sas: Updates for scsi-next

Sasikumar Chandrasekaran (11): megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers megaraid_sas: 128 MSIX Support megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream

RE: [PATCH 2/4] hpsa: add generate controller NMI on lockup

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Don Brace > Sent: Friday, November 11, 2016 10:09 AM > To: Hannes Reinecke; j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; > Mahesh Rajashekhara; h...@infradead.org;

[PATCH 20/22] qla2xxx: Allow relogin to go through if remote login did not finish

From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 2 ++ drivers/scsi/qla2xxx/qla_init.c | 14 -- drivers/scsi/qla2xxx/qla_isr.c| 25

[PATCH 21/22] qla2xxx: Improve submission of non critical MB interface.

From: Quinn Tran Move Get ID list, stats and Get Port Databasae mailbox commands out of MB interface which is serialized to IOCB interface to reduce contention. Current driver wait for FW to be in the ready state before processing in coming commands. For loop mode,

[PATCH 22/22] qla2xxx: Add check for corrupt ATIO.

From: Quinn Tran corrupt ATIO is defined as length of fcp_header & fcp_cmd payload is less than 0x38. It's the minimum size for a frame to carry 8..16 bytes SCSI CDB. The exchange will be drop or terminated if corrupted Signed-off-by: Quinn Tran

[PATCH 17/22] qla2xxx: Rerfactor use of sp context

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 12 +++ drivers/scsi/qla2xxx/qla_bsg.c| 13 --- drivers/scsi/qla2xxx/qla_def.h

[PATCH 11/22] qla2xxx: Refactor session management code.

From: Quinn Tran Current code has 2 structures/codes tracking the same remote port (fc_port & qla_tgt_sess). Merge these structures and code under same fc_port. In target mode, current code does not communicate session state change to initiator side, Merget target and

[PATCH 14/22] qla2xxx: Add interrupt polling mechanism

From: Quinn Tran This patch adds capability to poll for an interrupt, If hardware does not generate any interrupt for 2 seconds. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 05/22] qla2xxx: Add DebugFS node of irq vector cpuid

From: Quinn Tran > cat /sys/kernel/debug/qla2xxx/*/irq_cpuid qla2xxx_81 IRQ Name Vector CPUID qla2xxx (default) 150 9 qla2xxx (rsp_q)151 9 qla2xxx (atio_q) 152 9 Signed-off-by: Quinn Tran Signed-off-by:

[PATCH 19/22] qla2xxx: Reduce exess wait during chip reset

From: Quinn Tran Per HW recommendation, Soft reset and Risc reset should take 100uS to complete. This change pad the timeout up to 400uS, which should be plenty. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH 01/22] qla2xxx: Fix wrong IOCB type assumption.

From: Quinn Tran qlt_reset is call with Immedidate Notification IOCB only. Current code wrongly cast it as ATIO IOCB. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 6

[PATCH 18/22] qla2xxx: Fix slow mem alloc behind lock

From: Quinn Tran In Some instance following stack trace is seen for slow memory allocation with lock held Call Trace: [] dump_stack+0x6b/0xa4 [] ? print_irqtrace_events+0xd0/0xe0 [] ___might_sleep+0x183/0x240 [] __might_sleep+0x52/0x90 []

[PATCH 12/22] qla2xxx: Add Dual mode support in the driver

From: Quinn Tran Add switch to allow both Initiator Mode & Target mode to operate at the same time. Also remove unwanted/unused ini_mode_force option Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 13/22] qla2xxx: Fix invalid handle erroneous message.

From: Quinn Tran Termination of Immediate Notification IOCB was using wrong IOCB handle. IOCB completion code was unable to find appropriate code path due to wrong handle. Following message is seen in the logs. "Error entry - invalid handle/queue ()." Signed-off-by:

[PATCH 15/22] qla2xxx: Rename qlini_mode parameter

From: Quinn Tran Qlogic's adapter is able to behave in multiple modes: initiator, target, exclusive/either, and dual/both. This patch renames the qlini_mode -> qlop_mode and allow different setting for each port and exchange resource control. Usage: modprobe qla2xxx

[PATCH 16/22] qla2xxx: Improve RSCN handling in driver

From: Quinn Tran - Save NPort ID early in link init. - Add session deletion for TPRLO and send acknowledgement for TPRLO. - Enable FW option to move ABTS, RIDA & PUREX from RSPQ to ATIOQ. - Move ABTS & RIDA to ATIOQ helps in keeping command ordering and link up

[PATCH 07/22] qla2xxx: Fix crash due to null pointer access.

From: Quinn Tran This patch fixes crash due to Null pointer access. Following stack trace will be seen. [1469877.797315] Call Trace: [1469877.799940] [] qla2x00_mem_alloc+0xb09/0x10c0 [qla2xxx] [1469877.806980] [] qla2x00_probe_one+0x86a/0x1b50 [qla2xxx]

[PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency

From: Quinn Tran Following changes are done for target code - Move cmd search out of qla to remove symbol dependency. The command list is held in se_session struct. This knowledege should be in tcm_qla2xxx. - Move code that "convert Task Mgmt Command flags fr ATIO

[PATCH 04/22] qla2xxx: Clear BIT 15 in NVRAM during initialization.

Some of the ports have BIT_15 of firmware_options1 set. This is a reserved bit and should not be set for Target Mode. Clear BIT 15 during stage1 initialization. Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali ---

[PATCH 10/22] qla2xxx: Add framework for Async fabric discovery.

From: Quinn Tran Currently code makes login/logout decision after a full scan of the fabric. It's an expensive process in a large SAN. Eliminate duplication of command by moving the login/logout decision from a full fabric scan to an individual scan of the affected port.

[PATCH 03/22] qla2xxx: Set tcm_qla2xxx version to automatically track qla2xxx version.

Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/tcm_qla2xxx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.h

[PATCH 09/22] qla2xxx: Refactor T10-DIF PI support

From: Quinn Tran qla2xxx currently access T10-DIF protection opcode and type field in se_cmd struct. Add translation code so qla2xxx driver would not acces private TCM data structure. Signed-off-by: Quinn Tran Signed-off-by: Anil Gurumurthy

[PATCH 06/22] qla2xxx: Collect addtional debug data for FW

From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git

[PATCH 00/22] qla2xxx: Target code enhancemets and feature update

Hi Nic, Please consider this series for target-pending. This series is based on scsi-misc series that was submitted earlier today. Here's link for that series http://marc.info/?l=linux-scsi=148105128210090=2 This series contains following changes o Clean up Target code and tcm_qla2xxx for

[PATCH 02/22] qla2xxx: Include ATIO queue in firmware dump when in target mode

Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_tmpl.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c

[PATCH] scsi: qla4xxx: Use dma_pool_zalloc

We should use dma_pool_zalloc instead of dma_pool_alloc/memset Signed-off-by: Souptick joarder --- drivers/scsi/qla4xxx/ql4_mbx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c index

[PATCH v4 4/6] qla2xxx: Add multiple queue pair functionality.

From: Michael Hernandez Replaced existing multiple queue functionality with framework that allows for the creation of pairs of request and response queues, either at start of day or dynamically. Queue pair creation depend on module parameter "ql2xmqsupport", which

[PATCH v4 3/6] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls.

From: Michael Hernandez Replaces the old pci_enable_msi[x]* and pci_disable_msi[x] calls. Signed-off-by: Michael Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 2 +-

[PATCH v4 5/6] qla2xxx: Add Block Multi Queue functionality.

From: Michael Hernandez Tell the SCSI layer how many hardware queues we have based on the number of max queue pairs created. The number of max queue pairs created will depend on number of MSI-X vector count. This feature can be turned on via CONFIG_SCSI_MQ_DEFAULT

[PATCH v4 6/6] qla2xxx: Fix Target mode handling with Multiqueue changes.

From: Quinn Tran - Fix race condition between dpc_thread accessing Multiqueue resources and qla2x00_remove_one thread trying to free resource. - Fix out of order free for Multiqueue resources. Also, Multiqueue interrupts needs a workqueue. Interrupt needed to stop

[PATCH v4 1/6] qla2xxx: Only allow operational MBX to proceed during RESET.

This patch is allowing only ROM mailbox command which are necessary to initialize chip after a reset has been issued. In a target environment, there could be a user space daemon which can issue statistics and other management mailbox command which are non-critical. This patch will timeout non

[PATCH v4 2/6] qla2xxx: Fix mailbox command timeout due to starvation

From: Samy This patch helps resolve some of the mailbox timeout issue discovered during large SAN emulation testing where 1000+ initiators are trying to log into target mode personality. Since current mailbox interface handles submission and processing of commands in a

[PATCH v4 0/6] qla2xxx: Feature udpates for driver.

Hi Martin, Please consider this revised series for inclusion into scsi-misc. This series has incorporated partial changes based on review comments from Christop and Hannes. There were few changes that are left out of this series as they will need regression testing and we have patches for

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

On Tue, Dec 06, 2016 at 03:10:33PM +0800, Zhouyi Zhou wrote: > kmalloc_reserve may fail to allocate memory inside skb_linearize, > which means skb_linearize's return value should not be ignored. > Following patch correct the uses of skb_linearize. > > Compiled in x86_64 FWIW compiled also on

Re: [PATCH V3 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

On 5.12.2016 17:27, Sasikumar Chandrasekaran wrote: > This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 11 ++- >

Re: [PATCH] scsi: avoid a permanent stop of the scsi device's request queue

On 12/06/16 01:12, Wei Fang wrote: > The scsi device is being setted to the SDEV_RUNNING state at the end of > the scan work. When the remote port reappears, scsi_target_unblock() > will be called, but the QUEUE_FLAG_STOPPED flag will not be cleared, > since scsi_internal_device_unblock() ignores

Re: scsi: use-after-free in bio_copy_from_iter

On Tue, Dec 6, 2016 at 4:38 PM, Johannes Thumshirn wrote: > On Tue, Dec 06, 2016 at 10:43:57AM +0100, Dmitry Vyukov wrote: >> On Tue, Dec 6, 2016 at 10:32 AM, Johannes Thumshirn >> wrote: >> > On Mon, Dec 05, 2016 at 07:03:39PM +, Al Viro wrote: >> >>

[PATCH 10/10] virtio: enable endian checks for sparse builds

__CHECK_ENDIAN__ isn't on by default presumably because it triggers too many sparse warnings for correct code. But virtio is now clean of these warnings, and we want to keep it this way - enable this for sparse builds. Signed-off-by: Michael S. Tsirkin --- It seems that there

[PATCH 00/10] virtio: sparse fixes

I run latest sparse from git on virtio drivers (turns out the version I had was rather outdated). This patchset fixes a couple of bugs this uncovered, and adds some annotations to make it sparse-clean. In particular, endian-ness is often tricky, so this patchset enabled endian-ness checks for

Re: scsi: use-after-free in bio_copy_from_iter

On Tue, Dec 06, 2016 at 10:43:57AM +0100, Dmitry Vyukov wrote: > On Tue, Dec 6, 2016 at 10:32 AM, Johannes Thumshirn > wrote: > > On Mon, Dec 05, 2016 at 07:03:39PM +, Al Viro wrote: > >> On Mon, Dec 05, 2016 at 04:17:53PM +0100, Johannes Thumshirn wrote: > >> > 633

[PATCH RESEND v2 2/2] blk-mq: Avoid memory reclaim when remapping queues

While stressing memory and IO at the same time we changed SMT settings, we were able to consistently trigger deadlocks in the mm system, which froze the entire machine. I think that under memory stress conditions, the large allocations performed by blk_mq_init_rq_map may trigger a reclaim, which

[PATCH RESEND v2 1/2] blk-mq: Fix failed allocation path when mapping queues

In blk_mq_map_swqueue, there is a memory optimization that frees the tags of a queue that has gone unmapped. Later, if that hctx is remapped after another topology change, the tags need to be reallocated. If this allocation fails, a simple WARN_ON triggers, but the block layer ends up with an

Re: HD is powered off too early during shutdown/reboot (4.8 regression?)

Hi, just FYI, obviously my issue was related to kernel bug #187061 [1]. I did a test build of kernel 4.8.12 with the patch from the bug report applied and this resolved the issue for me. So, I’m voting for a backport of this change to kernel 4.8. If this is the wrong place to ask for a

Re: [PATCH v3 1/6] qla2xxx: Only allow operational MBX to proceed during RESET.

Thanks, please update the patch with this description for next resend. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2] qla4xxx: switch to pci_alloc_irq_vectors

And simplify the MSI-X logic in general - just request the two vectors directly instead of going through an indirection table. Signed-off-by: Christoph Hellwig --- drivers/scsi/qla4xxx/ql4_def.h | 18 + drivers/scsi/qla4xxx/ql4_glbl.h | 1 - drivers/scsi/qla4xxx/ql4_isr.c

Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

Hi Nilesh, > > try_msi: > > /* Trying MSI */ > >-ret = pci_enable_msi(ha->pdev); > >+ret = pci_alloc_irq_vectors(ha->pdev, 1, 1, PCI_IRQ_MSI); > > if (!ret) { > > Since pci_alloc_irq_vectors returns a negative error code upon error, > This should be if (ret). Fixes, thanks. >

RE: [PATCH] megaraid_sas: switch to pci_alloc_irq_vectors

>-Original Message- >From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >ow...@vger.kernel.org] On Behalf Of Hannes Reinecke >Sent: Friday, December 02, 2016 5:22 PM >To: Martin K. Petersen >Cc: Christoph Hellwig; James Bottomley; Sathya Prakash; linux- >s...@vger.kernel.org;

Re: [PATCH] scsi: mvsas: Replace pci_pool_alloc by pci_pool_zalloc

On Mon, Nov 28, 2016 at 04:56:26PM +0530, Souptick Joarder wrote: > Inside mvs_task_prep(), pci_pool_alloc() followed by memset will be > replaced by pci_pool_zalloc() > > Signed-off-by: Souptick joarder > --- FWIW, Reviewed-by: Johannes Thumshirn --

Re: [PATCH] scsi: mvsas: Replace pci_pool_alloc by pci_pool_zalloc

Hi Martin, On Tue, Dec 6, 2016 at 3:34 AM, Martin K. Petersen wrote: >> "Souptick" == Souptick Joarder writes: > > Souptick, > > Souptick> Any comment on this patch? > > The patch looked OK to me when you posted it. However, you need one >

[PATCH] scsi: hisi_sas: support deferred probe for v2 hw

In the hip06 and hip07 SoCs, the interrupt lines from the SAS controllers are connected to mbigen hw module [1]. The mbigen module is probed with module_init, and, as such, is not guaranteed to probe before the SAS driver. So we need to support deferred probe. We check for probe deferral in the

Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

Please see comments inline. Thanks, Nilesh On 18/11/16, 12:45 PM, "Christoph Hellwig" wrote: >And simplify the MSI-X logic in general - just request the two >vectors directly instead of going through an indirection table. > >Signed-off-by: Christoph Hellwig >--- >

Re: [PATCH] xen-scsifront: Add a missing call to kfree

Oops. Sorry for the noise. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: scsi: use-after-free in bio_copy_from_iter

On Tue, Dec 6, 2016 at 10:32 AM, Johannes Thumshirn wrote: > On Mon, Dec 05, 2016 at 07:03:39PM +, Al Viro wrote: >> On Mon, Dec 05, 2016 at 04:17:53PM +0100, Johannes Thumshirn wrote: >> > 633 hp = >header; >> > [...] >> > 646 hp->dxferp = (char

Re: scsi: use-after-free in bio_copy_from_iter

On Mon, Dec 05, 2016 at 07:03:39PM +, Al Viro wrote: > On Mon, Dec 05, 2016 at 04:17:53PM +0100, Johannes Thumshirn wrote: > > 633 hp = >header; > > [...] > > 646 hp->dxferp = (char __user *)buf + cmd_size; > > > So the memory for hp->dxferp comes from: > > 633

[PATCH] scsi: avoid a permanent stop of the scsi device's request queue

A scan work can run simultaneously with fc_remote_port_delete(). If a scsi device is added to the ->__devices list in the scan work, it can be touched and will be blocked in scsi_target_block(), which will be called in fc_remote_port_delete(), and QUEUE_FLAG_STOPPED flag will be setted to the scsi

Re: [PATCH] sd: make ->no_write_same independent of reported ->max_ws_blocks

Hello Martin, "Martin K. Petersen" writes: >> "Nicolai" == Nicolai Stange writes: > Nicolai> Due to reported problems with Write Same on ATA devices, commit > Nicolai> 0ce1b18c42a5 ("libata: Some drives failing on SCT Write Same") > Nicolai>