[scsi 4/4] scsi: ufs: refactor device descriptor reading

2017-01-04 Thread Tomas Winkler
Pull device descriptor reading out of ufs quirk so it can be used also for other purposes. Revamp the fixup setup: 1. Rename ufs_device_info to ufs_dev_desc as very similar name ufs_dev_info is already in use. 2. Make the handlers static as they are not used out of the ufshdc.c file.

[scsi 1/4] scsi: ufs: ufshcd_query_descriptor_retry should be static

2017-01-04 Thread Tomas Winkler
Fix the following compilation warning: drivers/scsi/ufs/ufshcd.c:2076:5: warning: no previous prototype for ‘ufshcd_query_descriptor_retry’ [-Wmissing-prototypes] Also do not export the function, it should not be used out of ufs context. Signed-off-by: Tomas Winkler

[scsi 2/4] scsi: ufs: unexport descritpor reading functions

2017-01-04 Thread Tomas Winkler
Unexport ufshcd_read_device_desc and ufshcd_read_string_desc there is no really possibility to calling them directly outside of UFS context. Signed-off-by: Tomas Winkler --- drivers/scsi/ufs/ufshcd.c | 9 - drivers/scsi/ufs/ufshcd.h | 7 --- 2 files changed,

[scsi 3/4] scsi: ufs: ufshcd_get_max_icc_level fix endianity handling

2017-01-04 Thread Tomas Winkler
Reading big endian value from a buffer requires explicit cast. Fix sparse warning: drivers/scsi/ufs/ufshcd.c:4825:24: warning: cast to restricted __be16 Signed-off-by: Tomas Winkler --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[v1] scsi: qla2xxx: qla_mr:- Release and Unmap memory regions when an error occurred.

2017-01-04 Thread Arvind Yadav
Free memory regions, if qlafx00_iospace_config is not successful. Signed-off-by: Arvind Yadav --- drivers/scsi/qla2xxx/qla_mr.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c

Re: [PATCH] scsi/qla4: comments correction

2017-01-04 Thread Martin K. Petersen
> "Cao" == Cao jin writes: Cao> drivers/scsi/qla4xxx/ql4_os.c | 6 +++--- 1 file changed, 3 Cao> insertions(+), 3 deletions(-) Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH] scsi: qedi: return via va_end to match corresponding va_start

2017-01-04 Thread Martin K. Petersen
> "Colin" == Colin King writes: Colin> Although on most systems va_end is a no-op, it is good practice Colin> to use va_end on the function return path, especially since the Colin> va_start documenation states: Colin> "Each invocation of va_start() must be

Re: [PATCH v2 00/13] be2iscsi: driver update 11.2.1.0

2017-01-04 Thread Martin K. Petersen
> "Jitendra" == Jitendra Bhivare writes: Jitendra> This patch is generated against for-next branch. v2 changes: Jitendra> +be2iscsi: Reinit SGL handle, CID tables after TPE Jitendra> Jitendra Bhivare (12): Jitendra> be2iscsi: Fix use of invalidate command

Re: [LSF/MM TOPIC] blk-trace update vs API stability

2017-01-04 Thread Jeff Moyer
Hannes Reinecke writes: > At LSF I'd like to discuss > - Do we consider blktrace (and any other tracepoint in eg SCSI) as a > stable API? I don't have a strong opinion on this. > - How do we go about modifying blktrace? Blktrace has a version number associated with trace events.

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2017-01-04 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Jan Kara" > Cc: "Johannes Weiner" , "Hugh Dickins" > , "Linus Torvalds" > , "Dave Chinner" , "Chris >

[RFC PATCH] scsi: scsi_transport_fc: Create a lightweight option for Virtual FC Hosts.

2017-01-04 Thread Cathy Avery
This patch represents an attempt to resurrect the conversation based on the submission of patch: [PATCH 1/1] scsi: storvsc: Support manual scan of FC hosts on Hyper-V K. Y. Srinivasan kys at microsoft.com Sat Mar 12 21:52:48 UTC 2016

Re: [PATCH v3] scsi: avoid a permanent stop of the scsi device's request queue

2017-01-04 Thread Ewan D. Milne
On Mon, 2016-12-12 at 11:23 -0500, Ewan D. Milne wrote: > ...I have not heard back yet > from the site that reported this problem to me on their reproducer. Not that it matters much now, but.. The response from my original reporter is that indeed the state was being changed from SDEV_BLOCK ->

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2017-01-04 Thread Laurence Oberman
- Original Message - > From: "Jan Kara" > To: "Johannes Weiner" > Cc: "Hugh Dickins" , "Linus Torvalds" > , "Dave Chinner" > , "Chris Leech" , "Linux Kernel >

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2017-01-04 Thread Christoph Hellwig
On Sat, Dec 24, 2016 at 02:17:26PM +0100, Hannes Reinecke wrote: > Christoph, do you have a pointer to your patchset? Here is a pointer to the current one after splitting it into properly bisectable chunks. Besides proper changelogs the biggest item left is fixing up dm-mpath to not allocate its

Re: [bug report] [SCSI] mpt3sas: add new driver supporting 12GB SAS

2017-01-04 Thread Dan Carpenter
Oops... This one is really old. I didn't look carefully at it before I hit send. Sorry about that. regards, dan carpenter On Wed, Jan 04, 2017 at 04:33:16PM +0300, Dan Carpenter wrote: > Hello Sreekanth Reddy, > > The patch f92363d12359: "[SCSI] mpt3sas: add new driver supporting > 12GB

[bug report] [SCSI] mpt3sas: add new driver supporting 12GB SAS

2017-01-04 Thread Dan Carpenter
Hello Sreekanth Reddy, The patch f92363d12359: "[SCSI] mpt3sas: add new driver supporting 12GB SAS" from Nov 30, 2012, leads to the following static checker warning: drivers/scsi/mpt3sas/mpt3sas_base.c:620 _base_display_event_data() warn: curly braces intended?

Re: [PATCH] mpt3sas: Force request partial completion alignment

2017-01-04 Thread Sreekanth Reddy
Hi Guilherme, Can please share us the driver logs (with driver logging_level set to 0x3f8) for the original issue (i.e. without this patch changes) and the HBA firmware version you have used. Also can you please share us the steps you have followed to reproduce this issue, so that I can try on

Re: [PATCH] target/user: Fix use-after-free cmd->se_cmd if the cmd isexpired

2017-01-04 Thread Xiubo Li
Hi Mike Thanks very much for your analysis. diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 2e33100..6396581 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -684,7 +684,6 @@ static int

[LSF/MM TOPIC] blk-trace update vs API stability

2017-01-04 Thread Hannes Reinecke
Hi all, during investigating performance issues I frequently have the need to include the request tag in the scsi tracepoints. While this can be easily done for scsi, including it in block trace output is not that easy due to the interdependency with the blktrace utilities. Also there had been