Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

Hi James, On Mon, Feb 06, 2017 at 10:38:48PM -0800, James Bottomley wrote: > On Mon, 2017-02-06 at 23:26 +0100, Willy Tarreau wrote: (...) > > We don't have the referenced commit above in 3.10 so we should be > > safe. Additionally I checked that neither 4.4 nor 3.12 have them > > either, so

Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

On Mon, 2017-02-06 at 23:26 +0100, Willy Tarreau wrote: > Hi Sathya, > > On Mon, Feb 06, 2017 at 09:21:44AM -0700, Sathya Prakash Veerichetty > wrote: > > Willy, > > I think this patch had a problem and later modified to a different > > blocking mechanism. Could you please pull in the latest

[Bug 194341] New: drivers/scsi/mpt3sas/mpt3sas_scsih.c _scsih_ir_fastpath ambiguous path structures

https://bugzilla.kernel.org/show_bug.cgi?id=194341 Bug ID: 194341 Summary: drivers/scsi/mpt3sas/mpt3sas_scsih.c _scsih_ir_fastpath ambiguous path structures Product: SCSI Drivers Version: 2.5 Kernel Version: 4.10

[Bug 194321] New: drivers/scsi/mpt3sas/mpt3sas_base.c mpt3sas_base_put_smid_fast_path structure descriptor.Default.DescriptorTypeDependent is not used in fast path

https://bugzilla.kernel.org/show_bug.cgi?id=194321 Bug ID: 194321 Summary: drivers/scsi/mpt3sas/mpt3sas_base.c mpt3sas_base_put_smid_fast_path structure descriptor.Default.DescriptorTypeDependent is not used in

Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup

On Mon, Feb 6, 2017 at 8:09 PM, Jens Axboe wrote: > On 02/06/2017 05:14 PM, James Bottomley wrote: >> On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote: >>> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig wrote: Dan, can you please quote your

Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup

On 02/06/2017 05:14 PM, James Bottomley wrote: > On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote: >> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig wrote: >>> Dan, >>> >>> can you please quote your emails? I can't find any content >>> inbetween all these quotes. >> >>

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

> "Bart" == Bart Van Assche writes: Hi Bart, Bart> Since there is now a resolution for patch 2: have you already Bart> decided when to submit these patches upstream? I queued it in scsi-fixes last week: commit 2780f3c8f0233de90b6b47a23fc422b7780c5436 Author:

Re: [PATCH V4 00/24] aacraid: Patchset for Smart Family Support

> "Raghava" == Raghava Aditya Renukunta > writes: Raghava> This patchset adds support to the HBA1000 and SMARTIOC2000 Raghava> family of cards. The driver version is now updated to 50740 Applied to 4.11/scsi-queue. -- Martin K. Petersen

Re: [PATCH] snic: switch to pci_irq_alloc_vectors

> "Christoph" == Christoph Hellwig writes: Narsimhulu, Please test and review! https://patchwork.kernel.org/patch/9549801/ -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] fnic: switch to pci_alloc_irq_vectors

> "Christoph" == Christoph Hellwig writes: Christoph> Not a full cleanup for the IRQ code, for that we'd need to Christoph> know if the max number of the various CQ types is going to Christoph> stay 1 forever. Satish: Please test and review! -- Martin K. Petersen Oracle

Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup

On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote: > On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig wrote: > > Dan, > > > > can you please quote your emails? I can't find any content > > inbetween all these quotes. > > Sorry, I'm using gmail, but I'll switch to attaching

Re: [PATCH] pm8001: switch to pci_irq_alloc_vectors

> "Christoph" == Christoph Hellwig writes: Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: sort out the ->eh_timed_out mess

> "Christoph" == Christoph Hellwig writes: Christoph> We originally only supported the methods in the Christoph> transport_template, which led to problems with drivers Christoph> needing it and having to fake up a template. Then we added Christoph> it to the host to avoid that

Re: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

> "Martin" == Martin K Petersen writes: Martin> Also, please remove all the "This patch depends on ..." stuff Martin> from the patch descriptions. The dependencies are inherent in Martin> the ordering of the patches and we don't want that in the commit Martin>

Re: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

> "Shivasharan" == Shivasharan Srikanteshwara > writes: Shivasharan, Shivasharan> Are you OK if I re-send only above impacted patch or like Shivasharan> to see complete series with v2 tag and updated patch Shivasharan> numbers? Please send a

Re: [PATCH 13/39] megaraid_sas : set residual bytes count during IO compeltion

> "Shivasharan" == Shivasharan S > writes: Shivasharan> Fixing issue of not setting residual bytes correctly. @@ -1464,6 +1465,15 @@ map_cmd_status(struct fusion_context *fusion, SCSI_SENSE_BUFFERSIZE);

[PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E

NVME Initiator: Base modifications This is part E of parts A..F. Part E is limited to lpfc_sli.c. This is the location of most of changes for the following: - sli3 ring vs sli4 wq splits - io abort interfaces - actual queuing routines and use of dma and sgl pools - service routines to

[PATCH v2 10/18] lpfc: NVME Initiator: bind to nvme_fc api

NVME Initiator: Tie in to NVME Fabrics nvme_fc LLDD initiator api Adds the routines to: - register and deregister the FC port as a nvme-fc initiator localport - register and deregister remote FC ports as a nvme-fc remoteport. - binding of nvme queues to adapter WQs - send/perform NVME LS's -

[PATCH v2 08/18] lpfc: NVME Initiator: Base modifications Part F

NVME Initiator: Base modifications This is part F of parts A..F. Part F is limited to lpfc_debugfs.[ch]. It contains the modifications in the existing debugfs snippets to work with the base modifications. This patch by itself will not result in a compilable driver. All parts A..F must be

[PATCH v2 15/18] lpfc: NVME Target: bind to nvmet_fc api

NVME Target: Tie in to NVME Fabrics nvmet_fc LLDD target api Adds the routines to: - register and deregister the FC port as a nvmet-fc targetport - binding of nvme queues to adapter WQs - receipt and passing of NVME LS's to transport, sending transport response - receipt of NVME FCP CMD IUs,

[PATCH v2 18/18] lpfc: Update lpfc version to 11.2.0.7

Update lpfc version to 11.2.0.7 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h

[PATCH v2 17/18] lpfc: Update copyrights

Update copyrights to 2017 for all files touched in this patch set Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- Modifications in V2: Corporate changed our copyright update to add the official Broadcom copyright

[PATCH v2 16/18] lpfc: NVME Target: Add debugfs support

NVME Target: Add debugfs support Adds debugfs snippets to cover the new NVME target functionality Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- Modifications in V2: Sync with max_hw_queues/io_channel/io_channel_irqs change

[PATCH v2 14/18] lpfc: NVME Target: Merge into FC discovery

NVME Target: Merge into FC discovery Adds NVME PRLI handling and Nameserver registrations for NVME Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- Modifications in V2: Bug fix in reglogin drivers/scsi/lpfc/lpfc_ct.c|

[PATCH v2 13/18] lpfc: NVME Target: Receive buffer updates

NVME Target: Receive buffer updates Allocates buffer pools and configures adapter interfaces to handle receive buffer (asynchronous FCP CMD ius, first burst data) from the adapter. Splits by protocol, etc. Signed-off-by: Dick Kennedy Signed-off-by: James Smart

[PATCH v2 11/18] lpfc: NVME Initiator: Add debugfs support

NVME Initiator: Add debugfs support Adds debugfs snippets to cover the new NVME initiator functionality Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- Modifications in V2: Sync with io_channel/max_hw_queues change Some

[PATCH v2 05/18] lpfc: NVME Initiator: Base modifications Part C

NVME Initiator: Base modifications This is part C of parts A..F. Part C is the 1st half of the mods to lpfc_init.c. This is the location of most of changes for the following: - sli3 ring vs sli4 wq splits - buffer pools are allocated/freed - sgl pools allocated/freed - adapter resources split

[PATCH v2 09/18] lpfc: NVME Initiator: Merge into FC discovery

NVME Initiator: Merge into FC discovery Adds NVME PRLI support and Nameserver registrations and Queries for NVME Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- Modifications in V2: Address review items: Removed the

[PATCH v2 06/18] lpfc: NVME Initiator: Base modifications Part D

NVME Initiator: Base modifications This is part D of parts A..F. Part D is the 2nd half of the mods to lpfc_init.c. This is the location of most of changes for the following: - sli3 ring vs sli4 wq splits - buffer pools are allocated/freed - sgl pools allocated/freed - adapter resources split

[PATCH v2 03/18] lpfc: NVME Initiator: Base modifications Part A

NVME Initiator: Base modifications This is part A of parts A..F. Part A is the bulk of the file list changed by the modifications as most mods are small-ish. Changes may be for any aspect below. This patch by itself will not result in a compilable driver. All parts A..F must be applied to

[PATCH v2 12/18] lpfc: NVME Target: Base modifications

NVME Target: Base modifications This set of patches adds the base modifications for NVME target support to the lpfc driver. The base modifications consist of: - Additional module parameters or configuration tuning - Enablement of configuration mode for NVME target. Ties into the queueing

[PATCH v2 02/18] lpfc: use pci_irq_alloc_vectors and pci_irq_free_vectors

I replaced the v1 patch with Christoph's original james From: Christoph Hellwig This avoids having to store the msix_entries array and simpliefies the shutdown and cleanup path a lot. Signed-off-by: Christoph Hellwig Signed-off-by: James Smart

[PATCH v2 04/18] lpfc: NVME Initiator: Base modifications Part B

NVME Initiator: Base modifications This is part B of parts A..F. Part B is limited to lpfc_attr.c: lpfc attribute modifications This patch by itself will not result in a compilable driver. All parts A..F must be applied to create a compilable driver. * Refer to Part A for a

[PATCH v2 01/18] lpfc: Correct WQ creation for pagesize

Correct WQ creation for pagesize The driver was calculating the adapter command pagesize indicator from the system pagesize. However, the buffers the driver allocates are only one size (SLI4_PAGE_SIZE), so no calculation was necessary. Signed-off-by: Dick Kennedy

[PATCH v2 00/18] lpfc: Add NVME Fabrics support (11.2.0.7)

This patch set add support for NVME over Fabrics FC transport. The internals of the driver are reworked to support being either: a SCSI initiator; a NVME intiator; both a SCSI initiator and a NVME initiator; or a NVME target. More background on the internals is given in patch 3 - for the nvme

Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

Hi Sathya, On Mon, Feb 06, 2017 at 09:21:44AM -0700, Sathya Prakash Veerichetty wrote: > Willy, > I think this patch had a problem and later modified to a different > blocking mechanism. Could you please pull in the latest change for this? Much appreciated, thanks. I've checked and found the

Re: [PATCHv1] net-next: treewide use is_vlan_dev() helper function.

From: Parav Pandit Date: Sat, 4 Feb 2017 11:00:49 -0600 > This patch makes use of is_vlan_dev() function instead of flag > comparison which is exactly done by is_vlan_dev() helper function. > > Signed-off-by: Parav Pandit > Reviewed-by: Daniel Jurgens

RE: [PATCHv1] net-next: treewide use is_vlan_dev() helper function.

> -Original Message- > From: Parav Pandit [mailto:pa...@mellanox.com] > Sent: Saturday, February 4, 2017 12:01 PM > To: dledf...@redhat.com; Sean Hefty ; > hal.rosenst...@gmail.com; mo...@mellanox.com; sant...@chelsio.com; > ganes...@chelsio.com;

Re: [PATCH V3 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

On Mon, 6 Feb 2017, 3:56pm -, Hannes Reinecke wrote: > On 02/03/2017 08:17 PM, Dupuis, Chad wrote: > > From: "Dupuis, Chad" > > > > The QLogic FastLinQ Driver for FCoE (qedf) is the FCoE specific module for > > 41000 > > Series Converged Network Adapters by QLogic.

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

Hey Chris and Guilherme, I'm indeed not responsive under this email address. Thanks for the testing, looks like you have the magic target to reproduce this. I think this verifies what Mike's idea of what was going wrong, and we're way overdue to get this fixed upstream. Thanks to IBM for

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On 06/02/2017 15:27, Chris Leech wrote: > - Original Message - >> On 09/11/2016 03:21, Chris Leech wrote: >>> On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote: Sure! Count on us to test any patches. I guess the first step is to reproduce on upstream

Re: [bug report] qla2xxx: Add framework for async fabric discovery

Dan, Will take a look and submit patch to remove warning. Thanks. Regards, Quinn Tran -Original Message- From: Dan Carpenter Date: Monday, February 6, 2017 at 3:37 AM To: "Tran, Quinn" Cc: "linux-scsi@vger.kernel.org"

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

- Original Message - > On 09/11/2016 03:21, Chris Leech wrote: > > On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote: > >> > >> Sure! Count on us to test any patches. I guess the first step is to > >> reproduce on upstream right? We haven't tested specifically this > >>

RE: [PATCH 33/39] megaraid_sas: call flush_scheduled_work during controller shutdown/detach

> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Monday, February 06, 2017 9:35 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com; > kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; > h...@suse.com

RE: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

Willy, I think this patch had a problem and later modified to a different blocking mechanism. Could you please pull in the latest change for this? Thanks Sathya -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: Sunday, February 05, 2017 12:19 PM To:

Re: [PATCH 39/39] megaraid_sas: driver version upgrade

On 6.2.2017 11:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 38/39] megaraid_sas: Change RAID_1_10_RMW_CMDS to RAID_1_PEER_CMDS and set value to 2

On 6.2.2017 11:00, Shivasharan S wrote: > For RAID1 FastPath writes, driver needs to allocate extra commands > internally to accommodate for the extra peer command being sent. > Currently driver is allocating 2 extra commands for each but only > one extra command is necessary. > Set

Re: [PATCH 37/39] megaraid_sas: Indentation and smatch warning fixes

On 6.2.2017 11:00, Shivasharan S wrote: > Fix indentation issues and smatch warning reported by Dan Carpenter > for previous series as discussed below. > http://www.spinics.net/lists/linux-scsi/msg103635.html > http://www.spinics.net/lists/linux-scsi/msg103603.html > > Reported-by: Dan Carpenter

Re: [PATCH 36/39] megaraid_sas: Cleanup VD_EXT_DEBUG and SPAN_DEBUG related debug prints

On 6.2.2017 11:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 35/39] megaraid_sas: Increase internal command pool

On 6.2.2017 11:00, Shivasharan S wrote: > Fix - increase internal command pool to 8. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 34/39] megaraid_sas: Use synchronize_irq to wait for IRQs to complete

On 6.2.2017 11:00, Shivasharan S wrote: > FIX - Do not use random delay to synchronize with IRQ. Use kernel API. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- Reviewed-by: Tomas Henzl

Re: [PATCH 33/39] megaraid_sas: call flush_scheduled_work during controller shutdown/detach

On 6.2.2017 11:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH 32/39] megaraid_sas: Bail out the driver load if ld_list_query fails

On 6.2.2017 11:00, Shivasharan S wrote: > Error handling: Bail out the driver load if > key FW cmds (LD_LIST) are not return successful. > Clean up error handling in megasas_init_fw. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [PATCH 31/39] megaraid_sas: Change build_mpt_mfi_pass_thru to return void

On 6.2.2017 11:00, Shivasharan S wrote: > Code refactoring to build_mpt_mfi_pass_thru to return void. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 30/39] megaraid_sas: During OCR, if get_ctrl_info fails do not continue with OCR

On 6.2.2017 11:00, Shivasharan S wrote: > Error handling: If controller reset is not able to > recover, kill HBA and quit immediately. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl

Re: [PATCH 28/39] megaraid_sas: Remove unused pd_index from megasas_build_ld_nonrw_fusion

On 6.2.2017 11:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 29/39] megaraid_sas: Do not set fp_possible if TM capable for non-RW syspdIO, change fp_possible to bool

On 6.2.2017 11:00, Shivasharan S wrote: > FIX - firmware wants non-RW SYS PD IOs to avoid FastPath for > better tracking and other functionalities if the device > is task management capable. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [PATCH 27/39] megaraid_sas: megasas_return_cmd does not memset IO frame to zero

On 6.2.2017 11:00, Shivasharan S wrote: > Memset the IO frame to zero after release. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V3 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

On 02/03/2017 08:17 PM, Dupuis, Chad wrote: > From: "Dupuis, Chad" > > The QLogic FastLinQ Driver for FCoE (qedf) is the FCoE specific module for > 41000 > Series Converged Network Adapters by QLogic. This patch consists of following > changes: > > - MAINTAINERS

Re: [PATCH 26/39] megaraid_sas: max_fw_cmds are decremented twice, remove duplicate

On 6.2.2017 10:59, Shivasharan S wrote: > Fix to account for the reply_q_sz not exceeding > the maximum commands that the firmware can support, > instance->max_fw_cmds is already decremented in > megasas_fusion_update_can_queue(). > Remove the extra decrement logic in code. > > Signed-off-by:

Re: [PATCH 24/39] megaraid_sas: Change max_cmd from u32 to u16 in all functions

On 6.2.2017 10:59, Shivasharan S wrote: > Since maximum supported FW commands are all defined as u16, change > all local variables referring to max_cmd from u32 to u16. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [PATCH 25/39] megaraid_sas: update can_queue only if the new value is less

On 6.2.2017 10:59, Shivasharan S wrote: > Minor Optimization: No need to update HBA can_queue value > if the current max FW commands is equal to earlier value. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [PATCH 23/39] megaraid_sas: set pd_after_lb from MR_BuildRaidContext and initialize pDevHandle to MR_DEVHANDLE_INVALID

On 6.2.2017 10:59, Shivasharan S wrote: > Issue is limited for Syncro firmware where pd_after_lb is not set but is > accidentally used. > Not a functional issue, but results in low performance due to improper load > balancing between two LUNs. > > Signed-off-by: Kashyap Desai

Re: [PATCH 22/39] megaraid_sas: latest controller OCR capability from FW before sending shutdown DCMD

On 6.2.2017 10:59, Shivasharan S wrote: > Fetch the latest controller OCR capability from FW before > sending MR_DCMD_CTRL_SHUTDOWN > When application sends a shutdown DCMD (MR_DCMD_CTRL_SHUTDOWN), > driver will fetch latest controller information from firmware. > This is to ensure that driver

Re: [PATCH 21/39] megaraid_sas: avoid unaligned access in ioctl path

On 6.2.2017 10:59, Shivasharan S wrote: > Fix kernel warning for accessing unaligned memory access in driver. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 20/39] megaraid_sas: big endian support changes

On 6.2.2017 10:59, Shivasharan S wrote: > Fix endiannes fixes for Ventura specific. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 19/39] megaraid_sas: Big endian RDPQ mode fix

On 6.2.2017 10:59, Shivasharan S wrote: > Fix if RDPQ mode enabled MR FW is deployed on big endian host machine, > driver does not setup reply address correctly. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH 17/39] megaraid_sas: In validate raid map, raid capability is not converted to cpu format for all lds

On 6.2.2017 10:59, Shivasharan S wrote: > On a host, if an ld is deleted there is a hole in the ld array returned > by the FW. But in MR_ValidateMapInfo we are not accounting for holes in > the ld array and traverse only upto index num_lds. > This patch takes care of converting the capability

Re: [PATCH 16/39] megaraid_sas: reduce size of fusion_context and use vmalloc if kmalloc fails

On 6.2.2017 10:59, Shivasharan S wrote: > Currently fusion context has fixed array load_balance_info. Use dynamic > allocation. > In few places, driver do not want physically contigious memory. > Attempt to use vmalloc if physical contiguous memory is not available. > > Signed-off-by: Shivasharan

Re: [PATCH 15/39] megaraid_sas: add print in device removal path

On 6.2.2017 10:59, Shivasharan S wrote: > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 14/39] megaraid_sas: enhance debug logs in OCR context

On 6.2.2017 10:59, Shivasharan S wrote: > Add additional logging from driver in OCR context. > Add debug logs for partial completion of IOs is iodone context. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH 13/39] megaraid_sas : set residual bytes count during IO compeltion

On 6.2.2017 10:59, Shivasharan S wrote: > Fixing issue of not setting residual bytes correctly. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 12/39] megaraid_sas: raid 1 write performance for large io

On 6.2.2017 10:59, Shivasharan S wrote: > Avoid Host side PCI bandwidth bottleneck and hint FW to do Write buffering > using > RaidFlag MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT. > Once IO is landed in FW with MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT, > it will do single DMA from host and buffer the

Re: [PATCH 11/39] megaraid_sas: NVME interface target prop added

On 6.2.2017 10:59, Shivasharan S wrote: > This patch depends on patch 0008. > This patch fetch true values of NVME property > from FW using New DCMD interface MR_DCMD_DEV_GET_TARGET_PROP > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH 10/39] megaraid_sas: NVME interface target prop added

On 6.2.2017 10:59, Shivasharan S wrote: > This patch depends on patch 0008. > This patch fetch true values of NVME property from FW using New DCMD > interface MR_DCMD_DEV_GET_TARGET_PROP > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

On 6.2.2017 10:59, Shivasharan S wrote: > No functional change. Code clean up. Removing error code which is not > valid scenario. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai I'm not sure if the part which

RE: [PATCH 09/39] megaraid_sas: NVME Interface detection and prop settings

> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Monday, February 06, 2017 4:17 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

Re: [PATCH 07/39] megaraid_sas: Use DID_REQUEUE

On 6.2.2017 10:59, Shivasharan S wrote: > Moving to use DID_REQUEUE return type for reliable unconditional retries. > Driver wants unconditional re-queue, so replace DID_RESET with DID_REQUEUE > Discussed below - > https://www.spinics.net/lists/linux-scsi/msg102848.html > > Signed-off-by:

RE: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Monday, February 06, 2017 4:14 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

Re: [PATCH 05/39] megaraid_sas: Refactor MEGASAS_IS_LOGICAL macro using sdev

On 6.2.2017 10:59, Shivasharan S wrote: > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 04/39] megaraid_sas: 32 bit descriptor fire cmd optimization

On 6.2.2017 10:59, Shivasharan S wrote: > No functional change. Code refactor. > megasas_fire_cmd_fusion can always use 32 bit descriptor write for ventura. > No need to pass extra flag. > Only IOC INIT required 64 bit Descriptor write. > > Signed-off-by: Shivasharan S

Re: [PATCH 03/39] megaraid_sas: raid 1 fast path code optimize

On 6.2.2017 14:27, Kashyap Desai wrote: >>> /** >>> + * megasas_complete_r1_command - >>> + * completes R1 FP write commands which has valid peer smid >>> + * @instance: Adapter soft state >>> + * @cmd_fusion:MPT command frame >>> + * >>> + */ >>> +static

RE: [PATCH 03/39] megaraid_sas: raid 1 fast path code optimize

> > > > /** > > + * megasas_complete_r1_command - > > + * completes R1 FP write commands which has valid peer smid > > + * @instance: Adapter soft state > > + * @cmd_fusion:MPT command frame > > + * > > + */ > > +static inline void > >

RE: [PATCH 06/39] megaraid_sas: RAID map is accessed for SYS PDs when use_seqnum_jbod_fp is not set

> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Monday, February 06, 2017 4:11 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

Re: [PATCH 03/39] megaraid_sas: raid 1 fast path code optimize

On 6.2.2017 10:59, Shivasharan S wrote: > No functional change. Code refactor. > Remove function megasas_fpio_to_ldio as we never require to convert fpio to > ldio because of frame unavailability. > Grab extra frame of raid 1 write fast path before it creates first frame as > Fast Path. >

Re: [PATCH 02/39] megaraid_sas: cpu select rework.

On 6.2.2017 10:59, Shivasharan S wrote: > No functional change. Code refactor. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 01/39] Revert "scsi: megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth"

On 6.2.2017 10:59, Shivasharan S wrote: > This reverts > commit "3e5eadb1a881" ("scsi: megaraid_sas: Enable or Disable Fast path based > on the PCI Threshold Bandwidth") > > This patch was aimed to increase performance of R1 Write operation for large > IO size. > Since this method used timer

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

On 2017/02/06 12:02, Sreekanth Reddy wrote: Hi Ojab, Can I get output of 'lspci -vvv -s' for LSI SAS2 card? On my Supermicro system, I have enabled ASPM in system BIOS but still in lspci output I see this ASPM was disabled for my SAS2 HBA card which has Phase19 firmware (i.e. 19.00.00.00) as

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

Hi Ojab, Can I get output of 'lspci -vvv -s' for LSI SAS2 card? On my Supermicro system, I have enabled ASPM in system BIOS but still in lspci output I see this ASPM was disabled for my SAS2 HBA card which has Phase19 firmware (i.e. 19.00.00.00) as shown below, # lspci -vvv -s 83:00.0 83:00.0

[bug report] qla2xxx: Add framework for async fabric discovery

Hello Quinn Tran, The patch b79414ee4988: "qla2xxx: Add framework for async fabric discovery" from Jan 19, 2017, leads to the following static checker warning: drivers/scsi/qla2xxx/qla_init.c:3910 qla2x00_alloc_fcport() warn: use 'flags' here instead of GFP_XXX?

Re: [PATCH 39/39] megaraid_sas: driver version upgrade

On 02/06/2017 11:00 AM, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 38/39] megaraid_sas: Change RAID_1_10_RMW_CMDS to RAID_1_PEER_CMDS and set value to 2

On 02/06/2017 11:00 AM, Shivasharan S wrote: > For RAID1 FastPath writes, driver needs to allocate extra commands > internally to accommodate for the extra peer command being sent. > Currently driver is allocating 2 extra commands for each but only > one extra command is necessary. > Set

Re: [PATCH 37/39] megaraid_sas: Indentation and smatch warning fixes

On 02/06/2017 11:00 AM, Shivasharan S wrote: > Fix indentation issues and smatch warning reported by Dan Carpenter > for previous series as discussed below. > http://www.spinics.net/lists/linux-scsi/msg103635.html > http://www.spinics.net/lists/linux-scsi/msg103603.html > > Reported-by: Dan

Re: [PATCH 36/39] megaraid_sas: Cleanup VD_EXT_DEBUG and SPAN_DEBUG related debug prints

On 02/06/2017 11:00 AM, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas.h| 2 - > drivers/scsi/megaraid/megaraid_sas_base.c | 15 -- >

Re: [PATCH 34/39] megaraid_sas: Use synchronize_irq to wait for IRQs to complete

On 02/06/2017 11:00 AM, Shivasharan S wrote: > FIX - Do not use random delay to synchronize with IRQ. Use kernel API. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- >

Re: [PATCH 35/39] megaraid_sas: Increase internal command pool

On 02/06/2017 11:00 AM, Shivasharan S wrote: > Fix - increase internal command pool to 8. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas.h| 2 +- >

Re: [PATCH 33/39] megaraid_sas: call flush_scheduled_work during controller shutdown/detach

On 02/06/2017 11:00 AM, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH 32/39] megaraid_sas: Bail out the driver load if ld_list_query fails

On 02/06/2017 11:00 AM, Shivasharan S wrote: > Error handling: Bail out the driver load if > key FW cmds (LD_LIST) are not return successful. > Clean up error handling in megasas_init_fw. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [PATCH 31/39] megaraid_sas: Change build_mpt_mfi_pass_thru to return void

On 02/06/2017 11:00 AM, Shivasharan S wrote: > Code refactoring to build_mpt_mfi_pass_thru to return void. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c |

Re: [PATCH 30/39] megaraid_sas: During OCR, if get_ctrl_info fails do not continue with OCR

On 02/06/2017 11:00 AM, Shivasharan S wrote: > Error handling: If controller reset is not able to > recover, kill HBA and quit immediately. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- >

  1   2   >