Re: scsi: BUG in scsi_init_io

On Tue, Jan 31, 2017 at 07:41:51AM -0800, James Bottomley wrote: > > Please-please-please, let's not use WARN for something that is not a > > kernel bug and is user-triggerable. > > It is a kernel bug and it should not be user triggerable, so it should > have a warn_on or bug_on. It means

Re: [PATCHv2] scsi: use 'scsi_device_from_queue()' for scsi_dh

On Fri, Feb 17, 2017 at 3:27 AM, Christoph Hellwig wrote: > > On Fri, Feb 17, 2017 at 09:06:14AM +0100, Hannes Reinecke wrote: > > We could, but why? > > ATM we're only having SCSI devices able to use device handler; adding > > another layer of indirection doesn't solve anything

Re: [PATCH] qla2xxx: Fix warnings reported by static checker.

On Mon, 2017-02-13 at 12:18 -0800, Himanshu Madhani wrote: > From: Quinn Tran > > Fix following warning reported by static checker > > drivers/scsi/qla2xxx/qla_init.c:3910 qla2x00_alloc_fcport() > warn: use 'flags' here instead of GFP_XXX? > > Fixes: b79414e ("qla2xxx:

Re: g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

On Sat, 18 Feb 2017, Ondrej Zary wrote: > On Friday 17 February 2017 23:38:12 Finn Thain wrote: > > On Thu, 16 Feb 2017, Ondrej Zary wrote: > > > On Tuesday 31 January 2017 02:31:45 Finn Thain wrote: > > > [...] > > > > > > > Are you trying to figure out which commands are going to > > > >

[PATCH] scsi: hpsa: Use 'pci_dma_mapping_error()' instead of 'dma_mapping_error()'

Use 'pci_dma_mapping_error()' instead of 'dma_mapping_error()' because it is more consistent with the rest of the code. It is also a little less verbove. While at it, remove some '(dma_addr_t)' casts in order to be consistent within the file. Signed-off-by: Christophe JAILLET

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Did not apply on linux-next-20170217 > > Signed-off-by: Romain Perier

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: Tested all patches by compilation and checkpatch. All of them compile fine, but patches 11 and 12 need some fixes. You can resend as PATCH instead of RFC. > The current PCI pool API are simple macro functions direct expanded to > the

Re: [RFC v2 12/20] scsi: mpt3sas: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:48AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Please run checkpatch, fix the style issue and resend. > > Signed-off-by: Romain Perier

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: Hi Romain, Checkpatch gives some warnings you can fix related to NULL tests before dma_pool_destroy(), and you changed indentation style in some of your changes. Some times it is important to keep consistency within a file even if

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

Le 18/02/2017 à 14:06, Greg Kroah-Hartman a écrit : > On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: >> The current PCI pool API are simple macro functions direct expanded to >> the appropriated dma pool functions. The prototypes are almost the same >> and semantically, they are

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: > The current PCI pool API are simple macro functions direct expanded to > the appropriated dma pool functions. The prototypes are almost the same > and semantically, they are very similar. I propose to use the DMA pool > API directly

Re: [RFC v2 01/20] block: DAC960: Replace PCI pool old API

On Sat, Feb 18, 2017 at 09:35:37AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > no new errors added, tested by compilation only. > Signed-off-by: Romain Perier

Re: g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

On Friday 17 February 2017 23:38:12 Finn Thain wrote: > On Thu, 16 Feb 2017, Ondrej Zary wrote: > > On Tuesday 31 January 2017 02:31:45 Finn Thain wrote: > > [...] > > > > > Are you trying to figure out which commands are going to disconnect > > > during a transfer? This is really a function of