Re: [PATCH] scsi: sr: fix oob access in get_capabilities

2017-03-05 Thread Kefeng Wang
Hi all, On 2017/3/3 18:17, Kefeng Wang wrote: > 'n = header_length + block_descriptor_length' could be greater than 512, > and will lead to oob access, so enlarge transfer buffer to fix it. I am not familiar with scsi protocol,so the patch may be wrong. Question, is it reasonable for

Re: [PATCH] target/user: Fix possible overwrite of t_data_sg's lastiov[]

2017-03-05 Thread Xiubo Li
On 02/27/2017 09:47 PM, lixi...@cmss.chinamobile.com wrote: From: Xiubo Li If there has BIDI data, its first iov[] will overwrite the last iov[] for se_cmd->t_data_sg. (+CCing orig BIDI and data block code authors) Yeah. It looks like because

Re: [PATCHv4 09/12] mpt3sas: simplify task management functions

2017-03-05 Thread Sreekanth Reddy
I feel that using these flags are not working as expected. From the driver's prospective it should return status of the TM based on whether it has cleared reference of the timed out IO in the driver or not (i.e. if it is successfully able to clear the reference (i.e. cleared from scsi lookup) of

RE: [PATCH v3 00/14] qla2xxx: Bug Fixes and updates for target.

2017-03-05 Thread Madhani, Himanshu
> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Sunday, March 5, 2017 4:43 PM > To: Madhani, Himanshu ; target- > de...@vger.kernel.org; n...@linux-iscsi.org > Cc: linux-scsi@vger.kernel.org; Malavali, Giridhar >

Re: [PATCH v3 00/14] qla2xxx: Bug Fixes and updates for target.

2017-03-05 Thread Bart Van Assche
On Fri, 2017-02-24 at 13:37 -0800, Himanshu Madhani wrote: > Please consider this series for inclusion in target-pending. Hello Himanshu, I applied this patch series on top of kernel v4.11-rc1 and installed it on a test system. Unfortunately the regression I reported one month ago against v2 of

Re: [PATCH] libiscsi: add lock around task lists to fix list corruption regression

2017-03-05 Thread Ilkka Sovanto
Hi! Was running pretty nicely for a week or so, until we got this one: [534630.679965] BUG: unable to handle kernel at 0078 [534630.684035] IP: [] iscsi_xmit_task+0x29/0xc0 [534630.685724] PGD a1fcd3067 [534630.687346] Oops: 0002 [#1] [534630.688846] Modules linked in:

Re: [ANNOUNCE]: Broadcom (Emulex) FC Target driver - efct

2017-03-05 Thread Sebastian Herbszt
Nicholas A. Bellinger wrote: > Hi James & Co, > > Adding target-devel and Sebastian CC' > > On Mon, 2017-02-27 at 15:28 -0800, James Smart wrote: > > I'd like to announce the availability of the Broadcom (Emulex) FC > > Target driver - efct. > > This driver has been part of the Emulex OneCore