Re: [RFC] scsi: reduce protection of scan_mutex in scsi_remove_device

2017-04-25 Thread Song Liu
> On Apr 25, 2017, at 10:23 AM, Bart Van Assche > wrote: > > On Fri, 2017-04-21 at 14:13 -0700, Song Liu wrote: >> When a device is deleted through sysfs handle "delete", the code >> locks shost->scan_mutex. If multiple devices are deleted at the >> same time, these

[PATCH] scsi: stex: make S6flag static

2017-04-25 Thread Colin King
From: Colin Ian King This module specific flag can be made static as it does not need to be in global scope. Signed-off-by: Colin Ian King --- drivers/scsi/stex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC] scsi: reduce protection of scan_mutex in scsi_remove_device

2017-04-25 Thread Bart Van Assche
On Fri, 2017-04-21 at 14:13 -0700, Song Liu wrote: > When a device is deleted through sysfs handle "delete", the code > locks shost->scan_mutex. If multiple devices are deleted at the > same time, these deletes will be handled in series. > > On the other hand, some devices do long latency IO

Re: [PATCH v2 3/7] sd: Cleanup sd_done sense data handling

2017-04-25 Thread Martin K. Petersen
Damien, > good_bytes is already set to 0 at the beginning of sd_done() when > result != 0 and again within the initial switch-case for > REQ_OP_DISCARD and REQ_OP_WRITE_SAME cases, which are the only > commands that can lead to hitting that "else" part in the sense data > processing. I may be

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-25 Thread Logan Gunthorpe
On 25/04/17 12:30 AM, Knut Omang wrote: > Yes, that's why I used 'significant'. One good thing is that given resources > it can easily be done in parallel with other development, and will give > additional > insight of some form. Yup, well if someone wants to start working on an emulated RDMA

Re: [RFC 1/8] Introduce Peer-to-Peer memory (p2pmem) device

2017-04-25 Thread Logan Gunthorpe
On 25/04/17 05:58 AM, Marta Rybczynska wrote: > I would add one issue that doesn't seem to be addressed: in my experience > P2P doesn't work when IOMMU activated. It works best with deactivation at > the BIOS level, even the kernel options are not enough in some cases. Well this would likely be

Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock

2017-04-25 Thread Martin K. Petersen
Michael, > looks good to me, so: > > Reviewed-By: Michael Schmitz Applied to 4.12/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static

2017-04-25 Thread Martin K. Petersen
Colin, > These module parameter variables don't need global scope, make them > static Applied to 4.12/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

2017-04-25 Thread Martin K. Petersen
Bart, >> I was merely objecting to the fact that we already have umpteen existing >> interfaces for displaying SCSI command information. > Do you perhaps want me to change the for-loop into a call to > __scsi_format_command()? If possible, I would love to see some commonality in the

Re: [RFC 1/8] Introduce Peer-to-Peer memory (p2pmem) device

2017-04-25 Thread Marta Rybczynska
> On 02/04/17 03:03 PM, Sinan Kaya wrote: >> Push the decision all the way to the user. Let them decide whether they >> want this feature to work on a root port connected port or under the >> switch. > > Yes, I prefer this too. If other folks agree with that I'd be very happy > to go back to user

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2017-04-25 Thread Sreekanth Reddy
On Thu, Jul 24, 2014 at 1:16 AM, Martin K. Petersen wrote: >> "Sreekanth" == Sreekanth Reddy writes: > > Sreekanth, > > Sreekanth> 2. As per MPI Spec, each set of 8 reply descriptor post > Sreekanth> queues must have the same value

Re: [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static

2017-04-25 Thread Johannes Thumshirn
On Mon, Apr 24, 2017 at 06:04:18PM +0100, Colin King wrote: > From: Colin Ian King > > These module parameter variables don't need global scope, make them static > > Signed-off-by: Colin Ian King > --- Looks good, Acked-by: Johannes

Re: [PATCH v2 1/1] aacraid: pci_alloc_consistent() failures on ARM64

2017-04-25 Thread Christoph Hellwig
On Wed, Apr 05, 2017 at 04:14:16PM +0530, Mahesh Rajashekhara wrote: > There were pci_alloc_consistent() failures on ARM64 platform. > Use dma_alloc_coherent() with GFP_KERNEL flag DMA memory allocations. > > Signed-off-by: Mahesh Rajashekhara > --- > v2: > -

Re: [PATCH] xen/scsifront: use offset_in_page() macro

2017-04-25 Thread Juergen Gross
On 22/04/17 03:21, Geliang Tang wrote: > Use offset_in_page() macro instead of open-coding. > > Signed-off-by: Geliang Tang Pushed to xen/tip for-linus-4.12 Thanks, Juergen

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-25 Thread Knut Omang
On Mon, 2017-04-24 at 10:14 -0600, Logan Gunthorpe wrote: > > On 24/04/17 01:36 AM, Knut Omang wrote: > > My first reflex when reading this thread was to think that this whole domain > > lends it self excellently to testing via Qemu. Could it be that doing this > > inĀ  > > the opposite direction

<    1   2