Re: [PATCH 1/2] libsas: Don't process sas events in static works

Hi Dan, thanks for your review and comments! 在 2017/5/21 11:44, Dan Williams 写道: > On Fri, May 19, 2017 at 11:39 PM, Yijing Wang wrote: >> Now libsas hotplug work is static, LLDD driver queue >> the hotplug work into shost->work_q. If LLDD driver >> burst post lots hotplug

Re: [PATCH 13/25] tcm_qla2xxx: Do not allow aborted cmd to advance.

On Fri, 2017-05-19 at 14:53 -0700, Himanshu Madhani wrote: > From: Quinn Tran > > In case of hardware queue full, commands can loop between > TCM stack and tcm_qla2xx shim layers for retry. While command > is waiting for retry, task mgmt can get ahead and abort the >

Re: [PATCH 15/25] qla2xxx: Convert 32-bit LUN usage to 64-bit

On Fri, 2017-05-19 at 14:53 -0700, Himanshu Madhani wrote: > From: Quinn Tran > > Convert 32bit LUN field to 64bit LUN. > > Signed-off-by: Quinn Tran > Signed-off-by: Himanshu Madhani > --- >

Re: [PATCH 20/25] qla2xxx: Remove redundant code

On Fri, 2017-05-19 at 23:43 +, Bart Van Assche wrote: > On Fri, 2017-05-19 at 14:53 -0700, Himanshu Madhani wrote: > > From: Quinn Tran > > > > During ABTS or Abort task, qla2xxx does a pre-search for > > the se_cmd, based on command's tag. The same search is > >

Re: [PATCH 06/25] qla2xxx: Reduce excessive debug print during 27xx fwdump.

-and-cleanups/20170521-131406 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin

Viable partnership request.

Compliment of the day, I have access to very vital information that can be used to move a huge amount of money . I have done my homework very well and i have the machineries in place to get it done since I am still in active service. If it was possible for me to do it alone I would not have

Re: [PATCH 06/18] scsi: Make scsi_ioctl_reset() pass the request queue pointer to blk_rq_init()

On Sun, 2017-05-21 at 08:50 +0200, Christoph Hellwig wrote: > Although we really need to stop abusing requests/cmds for EH.. > (Hannes, time to dust off your old patches!) Hello Christoph and Hannes, How about passing a struct scsi_device pointer to the eh_*_reset_handler callbacks instead of a

Re: [PATCH 02/18] bsg: Check private request size before attaching to a queue

On Sun, 2017-05-21 at 08:32 +0200, Christoph Hellwig wrote: > And btw, I didn't get your cover letter [0/18], did that get lost > somewhere? Hello Christoph, Thanks for the review comments. The cover letter should have made it to at least the linux-scsi mailing list since it shows up in at least

Re: [PATCH 06/25] qla2xxx: Reduce excessive debug print during 27xx fwdump.

-and-cleanups/20170521-131406 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All

Re: [PATCH v2 3/4] scsi_dh_alua: do not call BUG_ON when updating port group

On Mon, May 15, 2017 at 08:30:19PM +0200, Martin Wilck wrote: > please be assured that I'm not trying to paper over anything. Your > concern about sdev->handler_data is justified. While I think that it's > a separate issue from what my patches were supposed to address, let me > see if I can come

Re: [PATCH blktests 0/3] Add SCSI generic test group

On Thu, May 18, 2017 at 03:29:45PM +0200, Johannes Thumshirn wrote: > On 05/18/2017 03:19 PM, Christoph Hellwig wrote: > > All SG_IO test should also apply to block device nodes that support > > the ioctl.. > > > > But these are not necessarily SG_IO tests, are they? > > The test included is

Re: [PATCH v2] Use ctlr directly in rdac_failover_get()

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 01/18] block: Introduce blk_queue_cmd_size()

On Fri, May 19, 2017 at 11:29:59AM -0700, Bart Van Assche wrote: > This function will be used by later patches in this series. And it could already be used to simplify blk_alloc_flush_queue a bit.. Reviewed-by: Christoph Hellwig

Re: [PATCH 18/18] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 16/18] scsi-mq: Make behavior scsi_mq_prep_fn() closer to that of scsi_prep_fn()

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 17/18] scsi: Consolidate more initialization code

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 15/18] scsi: storvsc: Initialize driver-private command before using it

On Fri, May 19, 2017 at 11:30:13AM -0700, Bart Van Assche wrote: > The storvsc driver is the only SCSI LLD that uses driver-private > command data and that does not zero-initialize that data before > reading it. Make this driver consistent with the other SCSI LLDs > that use driver-private command

Re: [PATCH 06/18] scsi: Make scsi_ioctl_reset() pass the request queue pointer to blk_rq_init()

Looks fine, Reviewed-by: Christoph Hellwig Although we really need to stop abusing requests/cmds for EH.. (Hannes, time to dust off your old patches!)

Re: [PATCH 14/18] scsi: Make scsi_initialize_rq() zero the entire struct scsi_cmnd

On Fri, May 19, 2017 at 11:30:12AM -0700, Bart Van Assche wrote: > This simplifies the memset() call in scsi_initialize_rq() and avoids > that any stale data is left behind in struct scsi_request. > > Signed-off-by: Bart Van Assche > Cc: Christoph Hellwig

Re: [PATCH 13/18] scsi: Move sense buffer pointer initialization into scsi_initialize_rq()

On Fri, May 19, 2017 at 11:30:11AM -0700, Bart Van Assche wrote: > This patch is a preparation for the next patch that will zero > the struct scsi_request embedded in struct scsi_cmnd before > calling scsi_req_init(). Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 12/18] scsi: Inline scsi_init_command()

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 11/18] scsi: Move most of scsi_init_command() into scsi_initialize_rq()

On Fri, May 19, 2017 at 11:30:09AM -0700, Bart Van Assche wrote: > Move the initializations that only have to be performed once and > not every time a request is prepared from scsi_init_command() > into scsi_initialize_rq(). This patch also moves the > jiffies_at_alloc assignment such that it gets

Re: [PATCH 11/18] scsi: Move most of scsi_init_command() into scsi_initialize_rq()

On Sun, May 21, 2017 at 08:45:23AM +0200, Christoph Hellwig wrote: > On Fri, May 19, 2017 at 11:30:09AM -0700, Bart Van Assche wrote: > > Move the initializations that only have to be performed once and > > not every time a request is prepared from scsi_init_command() > > into

Re: [PATCH 11/18] scsi: Move most of scsi_init_command() into scsi_initialize_rq()

On Fri, May 19, 2017 at 11:30:09AM -0700, Bart Van Assche wrote: > Move the initializations that only have to be performed once and > not every time a request is prepared from scsi_init_command() > into scsi_initialize_rq(). This patch also moves the > jiffies_at_alloc assignment such that it gets

Re: [PATCH 10/18] scsi: Only add commands to the device command list if required by the LLD

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 09/18] scsi: Change argument type of scsi_req_init()

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 08/18] block: Make scsi_req_init() calls implicit

On Fri, May 19, 2017 at 11:30:06AM -0700, Bart Van Assche wrote: > Instead of explicitly calling scsi_req_init(), let > blk_get_request() call that function from inside blk_rq_init(). > Add an .initialize_rq_fn() callback function to the block drivers > that need it. Thanks Bart, this looks like

Re: [PATCH 07/18] block: Introduce request_queue.initialize_rq_fn()

On Fri, May 19, 2017 at 11:30:05AM -0700, Bart Van Assche wrote: > Several block drivers need to initialize the driver-private data > after having called blk_get_request() and before .prep_rq_fn() is > called, e.g. when submitting a REQ_OP_SCSI_* request. Avoid that > that initialization code has

Re: [PATCH 02/18] bsg: Check private request size before attaching to a queue

Hi Bart, I think this is the wrong kind of check - while we do care about the size of the queue, we only do it as a side effect of the queue being able to handle REQ_OP_SCSI_IN/REQ_OP_SCSI_OUT commands. I think we'll need a flag for those in the queue instead. And btw, I didn't get your cover