Re: [PATCH 3/3] scsi:ufs:add hi3660 ufs driver code

On Sat, Jun 10, 2017 at 9:21 AM, butao wrote: > add hi3660 ufs driver code > > Signed-off-by: Geng Jianfeng > Signed-off-by: Bu Tao > Signed-off-by: Zang Leigang > Signed-off-by: Yu Jianfeng

Re: [PATCH 2/3] scsi:ufs:add ufs node property for hi3660

Bu Tao, One other issue: the 'sender' of your patchset is "butao". For upstreaming purpose, it is recommended to use your full name, in "first name" + "Surname" format. In your case, you need to specify it in your commit message: $ git commit --amend --author="Bu Tao " You

Re: [PATCH 2/3] scsi:ufs:add ufs node property for hi3660

On Sat, Jun 10, 2017 at 9:20 AM, butao wrote: > add ufs node for hi3660 > > Signed-off-by: Bu Tao > --- > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 20 > 1 file changed, 20 insertions(+) > mode change 100644 => 100755

Re: [PATCH 2/3] scsi:ufs:add ufs node property for hi3660

Bu Tao, 1. Subject line of this patch goes something like "arm64: dts: hi3660: add ufs support xxx" 2. Have you run "./scripts/get_maintainer.pl *.patch" to get the correct maintainers to include into your patch review? I don't think so. Because this is a dts change, however in your email's to/

REPLY ME IMMEDIATELY!!

-- Dear Friend, I Know That This Mail Will Come To You As A Surprise As We Never Met Before. I Need Your Urgent Assistance in Transferring the Sum Of ($15.5m) Into Your Bank Account in your conutry, After Hearing from You I Will Give You More Details about the Transaction. Your full data’s will

[PATCH 2/3] scsi:ufs:add ufs node property for hi3660

add ufs node for hi3660 Signed-off-by: Bu Tao --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 20 1 file changed, 20 insertions(+) mode change 100644 => 100755 arch/arm64/boot/dts/hisilicon/hi3660.dtsi diff --git

[PATCH 3/3] scsi:ufs:add hi3660 ufs driver code

add hi3660 ufs driver code Signed-off-by: Geng Jianfeng Signed-off-by: Bu Tao Signed-off-by: Zang Leigang Signed-off-by: Yu Jianfeng --- drivers/scsi/ufs/Kconfig | 8 +

[PATCH 1/3] scsi:ufs:add AHIT for hi3660 ufs

add Auto-Hibernate Idle Timer value for hi3660 ufs Signed-off-by: Bu Tao Signed-off-by: Geng Jianfeng Signed-off-by: Zang Leigang Signed-off-by: Yu Jianfeng ---

Re: [PATCH 01/15] qla2xxx: Combine Active command arrays.

Hi Bart, > On Jun 7, 2017, at 3:45 PM, Bart Van Assche > wrote: > > On Wed, 2017-06-07 at 14:43 -0700, Himanshu Madhani wrote: >> +enum { >> +TYPE_SRB, >> +TYPE_TGT_CMD, >> +}; >> + >> typedef struct srb { >> +/* >> + * Do not move cmd_type field,

Re: [PATCH 2/3] target: Add TARGET_SCF_LOOKUP_LUN_FROM_TAG support for ABORT_TASK

On 06/08/17 22:52, Nicholas A. Bellinger wrote: > Because qla2xxx doesn't reuse tags, it's not a problem since it's the > only consumer of TARGET_SCF_LOOKUP_LUN_FROM_TAG. Hello Nic, Can you clarify this? Since all target drivers and also the target core use a finite number of bits to represent

patch "scsi: ibmvscsi_tgt: remove use of class_attrs" added to driver-core-next

This is a note to let you know that I've just added the patch titled scsi: ibmvscsi_tgt: remove use of class_attrs to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-next branch. The patch will show

Re: [PATCH] scsi: qla2xxx: fix printk format string warning on 32-bit

Hi Arnd, > On Jun 9, 2017, at 3:46 AM, Arnd Bergmann wrote: > > On 32-bit architectures, we using %lx to print a size_t causes a harmless > warning: > > qla2xxx/qla_init.c: In function 'qla24xx_load_risc_flash': > qla2xxx/qla_init.c:6407:7: error: format '%lx' expects argument

[PATCH v5 17/23] scsi: hisi_sas: add v3 code to send ATA frame

From: Xiang Chen Add code to prepare ATA frame for v3 hw Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 106 + 1 file changed, 106

[PATCH v5 21/23] scsi: hisi_sas: Add v3 code to support ECC and AXI bus fatal error

From: Xiang Chen For ECC 1bit error, logic can recover it, so we only print a warning. For ECC multi-bit and AXI bus fatal error, we panic. Note: once v3 hw controller reset support is added, the panic will be replaced by a controller reset, like v2 hw.

[PATCH v5 08/23] scsi: hisi_sas: create hisi_sas_get_fw_info()

Move the functionality to retrieve the fw info into a dedicated device type-agnostic function, hisi_sas_get_fw_info(). The reasoning is that this function will be required for future pci-based platforms. Also add some debug logs for failure. Signed-off-by: John Garry ---

[PATCH v5 22/23] scsi: hisi_sas: add v3 code to fill some more hw function pointers

From: Xiang Chen Add code to fill the interface of phy_hard_reset, phy_get_max_linkrate, and phy enable/disable. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 39

[PATCH v5 07/23] scsi: hisi_sas: add pci_dev in hisi_hba struct

Since hip08 SAS controller is based on pci device, add hisi_hba.pci_dev for hip08 (will be v3), and also rename hisi_hba.pdev to .platform_dev for clarity. In addition, for common code which wants to reference the controller device struct, add hisi_hba.dev, and change the common code to use it.

[PATCH v5 02/23] scsi: hisi_sas: define hisi_sas_device.device_id as int

Currently hisi_sas_device.device_id is a u64. This can create a problem in selecting the queue for a device, in that this code does a 64b division on device id. For some 32b systems, 64b division is slow and the lib reference must be explicitly included. The device id does not need to be 64b in

[PATCH v5 12/23] scsi: hisi_sas: add v3 hw PHY init

From: Xiang Chen Add code to configure PHYs for v3 hw. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 127 - 1 file changed, 126

[PATCH v5 10/23] scsi: hisi_sas: add initialisation for v3 pci-based controller

Add the code to initialise the controller which is based on pci device in hisi_sas_v3_hw.c The core controller routines are still in hisi_sas_main.c; some common initialisation functions are also exported from hisi_sas_main.c For pci-based controller, the device properties, like phy count and

[PATCH v5 01/23] scsi: hisi_sas: fix timeout check in hisi_sas_internal_task_abort()

From: Xiang Chen We need to check for timeout before task status, or the task will be mistook as completed internal abort command. Also add protection for sas_task.task_state_flags in hisi_sas_tmf_timedout(). Signed-off-by: Xiang Chen

[PATCH v5 23/23] scsi: hisi_sas: modify internal abort dev flow for v3 hw

From: Xiang Chen There is a change for abort dev for v3 hw: add registers to configure unaborted iptt for a device, and then inform this to logic. Signed-off-by: Xiang Chen Signed-off-by: John Garry ---

[PATCH v5 05/23] scsi: hisi_sas: relocate sata_done_v2_hw()

From: Xiang Chen Relocate get_ata_protocol() to a common location, as future hw versions will require it. Also rename with "hisi_sas_" prefix for consistency. Signed-off-by: Xiang Chen Signed-off-by: John Garry ---

[PATCH v5 06/23] scsi: hisi_sas: relocate get_ncq_tag_v2_hw()

From: Xiang Chen Relocate get_ncq_tag_v2_hw() to a common location, as future hw versions will require it. Also rename with "hisi_sas_" prefix for consistency. Signed-off-by: Xiang Chen Signed-off-by: John Garry ---

[PATCH v5 09/23] scsi: hisi_sas: add skeleton v3 hw driver

Add skeleton driver for v3 hw in hisi_sas_v3_hw.c File hisi_sas_v3_hw.c will serve 2 purposes: - probing and initialisation of the controller based on pci device - hw layer for v3-based controllers The controller design is quite similar to v2 hw in hip07. However key differences include: -All

[PATCH v5 20/23] scsi: hisi_sas: add get_wideport_bitmap_v3_hw()

From: Xiang Chen Add code for interface get_wideport_bitmap. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 13 + 1 file changed, 13 insertions(+) diff

[PATCH v5 16/23] scsi: hisi_sas: add v3 code to send SMP frame

From: Xiang Chen Add code to prepare SMP frame. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 74 ++ 1 file changed, 74

[PATCH v5 19/23] scsi: hisi_sas: add v3 code to send internal abort command

From: Xiang Chen Add code to prepare internal abort command. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 38 ++ 1 file changed, 38

[PATCH v5 15/23] scsi: hisi_sas: add v3 code to send SSP frame

From: Xiang Chen Add code to prepare SSP frame and deliver it to hardware. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 208 + 1

[PATCH v5 18/23] scsi: hisi_sas: add v3 code for itct setup and free

From: Xiang Chen Add code to itct setup and free for v3 hw. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 114 + 1 file changed, 114

[PATCH v5 14/23] scsi: hisi_sas: add v3 cq interrupt handler

From: Xiang Chen Add v3 cq interrupt handler slot_complete_v3_hw(). Note: The slot error handling needs to be further refined in the future to examine all fields in the error record, and handle appropriately, instead of current solution - just report

[PATCH v5 11/23] scsi: hisi_sas: add v3 hw init

From: Xiang Chen Add code to initialise v3 hardware. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 277 + 1 file changed, 277

[PATCH v5 00/23] hisi_sas: hip08 support

This patchset adds support for the HiSilicon SAS controller in the hip08 chipset. The key difference compared to earlier chipsets is that the controller is an integrated PCI endpoint in hip08. As such, the controller is a pci device (not a platform device, like v2 hw in hip07). The driver is

[PATCH v5 04/23] scsi: hisi_sas: relocate get_ata_protocol()

From: Xiang Chen Relocate get_ata_protocol() to a common location, as future hw versions will require it. Also rename with "hisi_sas_" prefix for consistency. Signed-off-by: Xiang Chen Signed-off-by: John Garry ---

[PATCH v5 03/23] scsi: hisi_sas: optimise the usage of hisi_hba.lock

From: Xiang Chen Currently hisi_hba.lock is locked to deliver and receive a command to/from any hw queue. This causes much contention at high data-rates. To boost performance, lock on a per queue basis for sending and receiving commands to/from hw. Certain critical

[PATCH v5 13/23] scsi: hisi_sas: add phy up/down/bcast and channel ISR

From: Xiang Chen Add code to initialise interrupts and add some interrupt handlers. Also add function hisi_sas_v3_destroy_irqs() to clean-up irqs upon module unloading. Signed-off-by: John Garry Signed-off-by: Xiang Chen

[PATCH] scsi: qla2xxx: fix printk format string warning on 32-bit

On 32-bit architectures, we using %lx to print a size_t causes a harmless warning: qla2xxx/qla_init.c: In function 'qla24xx_load_risc_flash': qla2xxx/qla_init.c:6407:7: error: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format=]

patch "scsi: ibmvscsi_tgt: remove use of class_attrs" added to driver-core-testing

This is a note to let you know that I've just added the patch titled scsi: ibmvscsi_tgt: remove use of class_attrs to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-testing branch. The patch will

Re: [PATCH] configfs: Fix race between create_link and configfs_rmdir

On Thu, 2017-06-08 at 07:34 -0500, Bryant G. Ly wrote: > > Thanks Nic, > > > > applied to the configfs-for-next tree. I'm not entirely sure if we > > should bother adding this to 4.12 or if it hits rarely enough? > > > It hits for us pretty often when we have a GPFS setup with 10 hosts and 1k+ >

Re: [PATCH] iscsi-target: Reject immediate data underflow larger than SCSI transfer length

On Thu, 2017-06-08 at 15:37 +, Bart Van Assche wrote: > On Thu, 2017-06-08 at 04:21 +, Nicholas A. Bellinger wrote: > > + /* > > +* Check for underflow case where both EDTL and immediate data payload > > +* exceeds what is presented by CDB's TRANSFER LENGTH, and what has > > +

Re: [PATCH 00/15] qla2xxx: Add Target Multiqueue support

Hi Himanshu & Quinn, On Wed, 2017-06-07 at 14:43 -0700, Himanshu Madhani wrote: > Hi Nic, > > This patch series adds support for multiqueue for qla2xxx target mode driver. > > I've also added patch ("qla2xxx: Include Exchange offload/Extended Login > into FW dump") which was dropped from

Re: [PATCH v4 0/5] tcmu: Add Type of reconfig into netlink

Hi Bryant & Co, On Tue, 2017-06-06 at 09:28 -0500, Bryant G. Ly wrote: > From: "Bryant G. Ly" > > This patch consists of adding a netlink to allow for reconfiguration > of a device in tcmu. > > It also changes and adds some attributes that are reconfigurable: > write_cache,