RE: system hung up when offlining CPUs

2017-10-31 Thread Thomas Gleixner
On Mon, 30 Oct 2017, Shivasharan Srikanteshwara wrote: > In managed-interrupts case, interrupts which were affine to the offlined > CPU is not getting migrated to another available CPU. But the > documentation at below link says that "all interrupts" are migrated to a > new CPU. So not all

[PATCH 2/9] iscsi: associate endpoints with a host

2017-10-31 Thread Chris Leech
Right now the iscsi_endpoint is only linked to a connection once that connection has been established. For net namespace filtering of the sysfs objects, associate an endpoint with the host that it was allocated for when it is created. Signed-off-by: Chris Leech ---

[PATCH 0/9] use network namespace for iSCSI control interfaces

2017-10-31 Thread Chris Leech
This series of changes makes the iSCSI netlink and sysfs control interfaces filtered by network namespace. This is required to run iscsid in any network namespace other than the initial default one. Currently the netlink communication will fail if iscsid is started in a non-default network

[PATCH 3/9] iscsi: sysfs filtering by network namespace

2017-10-31 Thread Chris Leech
This makes the iscsi_host, iscsi_session, iscsi_connection, iscsi_iface, and iscsi_endpoint transport class devices only visible in sysfs under a matching network namespace. The network namespace for all of these objects is tracked in the iscsi_cls_host structure. Signed-off-by: Chris Leech

[PATCH 5/9] iscsi: set netns for iscsi_tcp hosts

2017-10-31 Thread Chris Leech
This lets iscsi_tcp operate in multiple namespaces. It uses current during session creation to find the net namespace, but it might be better to manage to pass it along from the iscsi netlink socket. Signed-off-by: Chris Leech --- drivers/scsi/iscsi_tcp.c| 7

[PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace aware

2017-10-31 Thread Chris Leech
Make use of the per-net netlink sockets. Responses are sent back on the same socket/namespace the request was received on. Async events are reported on the socket/namespace stored in the iscsi_cls_host associated with the event. Signed-off-by: Chris Leech ---

[PATCH 6/9] iscsi: check net namespace for all iscsi lookups

2017-10-31 Thread Chris Leech
All internal lookups of iSCSI transport objects need to be filtered by net namespace. Signed-off-by: Chris Leech --- drivers/infiniband/ulp/iser/iscsi_iser.c | 5 +- drivers/scsi/be2iscsi/be_iscsi.c | 4 +- drivers/scsi/bnx2i/bnx2i_iscsi.c | 4 +-

[PATCH 7/9] iscsi: convert flashnode devices from bus to class

2017-10-31 Thread Chris Leech
The flashnode session and connection devices should be filtered by net namespace along with the iscsi_host, but we can't do that with a bus device. As these don't use any of the bus matching functionality, they make more sense as a class device anyway. Signed-off-by: Chris Leech

[PATCH 9/9] iscsi: filter flashnode sysfs by net namespace

2017-10-31 Thread Chris Leech
Finished the net namespace support for flashnode sysfs devices Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/scsi/scsi_transport_iscsi.c

[PATCH 8/9] iscsi: rename iscsi_bus_flash_* to iscsi_flash_*

2017-10-31 Thread Chris Leech
cleanups after the bus to class conversion Signed-off-by: Chris Leech --- drivers/scsi/qla4xxx/ql4_os.c | 52 +- drivers/scsi/scsi_transport_iscsi.c | 102 ++-- include/scsi/scsi_transport_iscsi.h | 48 +

[PATCH 1/9] iscsi: create per-net iscsi netlink kernel sockets

2017-10-31 Thread Chris Leech
Prepare iSCSI netlink to operate in multiple namespaces. Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 67 +++-- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c

[PATCH] storvsc: Avoid excessive host scan on controller change

2017-10-31 Thread Long Li
From: Long Li When there are multiple disks attached to the same SCSI controller, the host may send several VSTOR_OPERATION_REMOVE_DEVICE or VSTOR_OPERATION_ENUMERATE_BUS messages in a row, to indicate there is a change on the SCSI controller. In response, storvsc rescans

Re: [PATCH] scsi: ibmvscsi: Convert timers to use timer_setup()

2017-10-31 Thread Tyrel Datwyler
On 10/25/2017 03:06 AM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "Martin K. Petersen" >

[PATCH RESEND] scsi: fnic: Clean up redundant variables

2017-10-31 Thread Christos Gkekas
Remove variables that are set but not used. Signed-off-by: Christos Gkekas --- drivers/scsi/fnic/fnic_fcs.c | 9 - drivers/scsi/fnic/vnic_rq.c | 3 --- drivers/scsi/fnic/vnic_wq.c | 3 --- 3 files changed, 15 deletions(-) diff --git

[PATCH 4/4] scsi: qla2xxx: Convert qla2x00_sp_timeout() to use timer_setup()

2017-10-31 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly for the qla2x00_sp_timeout() callback and associated timer. Cc: Himanshu Madhani

[PATCH 3/4] scsi: qla2xxx: Convert qla2x00_timer() to use timer_setup()

2017-10-31 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly for the qla2x00_timer() callback and associated timer. Cc: Himanshu Madhani

[PATCH 1/4] scsi: qla2xxx: Convert timers to use setup_timer()

2017-10-31 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, take the first step by switching from init_timer() and open-coded .function and .data assignments to using the old setup_timer() API. Cc: Himanshu Madhani Cc: Bart Van

[PATCH 2/4] scsi: qla2xxx: Refactor qla2x00_start_timer()

2017-10-31 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, this refactors qla2x00_start_timer() to not pass a callback argument, since all callers use the same callback. Cc: Himanshu Madhani Cc: Bart Van Assche

[PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Kees Cook
This breaks out the logical steps to convert the qla2xxx timers: 1) init_timer() -> setup_timer() 2) refactor qla2x00_start_timer() to not pass callback as argument 3) qla2x00_timer() to use timer_setup() 4) qla2x00_sp_timeout() to use timer_setup() The resulting diff is identical to the patch

RE: [PATCH] scsi: megaraid: Convert timers to use timer_setup()

2017-10-31 Thread Sumit Saxena
-Original Message- From: Kees Cook [mailto:keesc...@chromium.org] Sent: Wednesday, October 25, 2017 3:37 PM To: Martin K. Petersen Cc: Kashyap Desai; Sumit Saxena; Shivasharan S; James E.J. Bottomley; megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Kees Cook
On Tue, Oct 31, 2017 at 11:36 AM, Madhani, Himanshu wrote: > Hi Kees, > >> On Oct 31, 2017, at 11:28 AM, Kees Cook wrote: >> >> How very strange. I don't see any code change with this patch. Even >> the passed arguments are the same; it's only

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Madhani, Himanshu
Hi Kees, > On Oct 31, 2017, at 11:28 AM, Kees Cook wrote: > > How very strange. I don't see any code change with this patch. Even > the passed arguments are the same; it's only enforcing the types now. > And the system is fine with only this patch reverted? Yes. Agree

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Kees Cook
On Tue, Oct 31, 2017 at 11:16 AM, Madhani, Himanshu wrote: > Hi Bart, > >> On Oct 31, 2017, at 11:12 AM, Bart Van Assche wrote: >> >> On Tue, 2017-10-31 at 18:03 +, Madhani, Himanshu wrote: >>> On Oct 31, 2017, at 8:49 AM, Martin K.

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Madhani, Himanshu
Hi Bart, > On Oct 31, 2017, at 11:12 AM, Bart Van Assche wrote: > > On Tue, 2017-10-31 at 18:03 +, Madhani, Himanshu wrote: >> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen >> wrote: In preparation for unconditionally passing the

Re: [PATCH] scsi: sas: Convert timers to use timer_setup()

2017-10-31 Thread John Garry
On 25/10/2017 11:08, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. This requires adding a pointer to hold the timer's target task, as

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > That was my plan. Does that sound okay? Yep, that's fine. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Kees Cook
On Tue, Oct 31, 2017 at 10:42 AM, Martin K. Petersen wrote: > > Bart, > >> The tree I tested indeed includes that rebased patch. BTW, since the code >> touched by that patch has not been modified in the past months, the rebased >> patch is identical to the patch I

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Bart Van Assche
On Tue, 2017-10-31 at 18:03 +, Madhani, Himanshu wrote: > On Oct 31, 2017, at 8:49 AM, Martin K. Petersen > wrote: > > > In preparation for unconditionally passing the struct timer_list > > > pointer to all timer callbacks, switch to using the new timer_setup() >

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Madhani, Himanshu
Hi Martin/Kees, > On Oct 31, 2017, at 8:49 AM, Martin K. Petersen > wrote: > > > Kees, > >> In preparation for unconditionally passing the struct timer_list >> pointer to all timer callbacks, switch to using the new timer_setup() >> and from_timer() to pass the

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Bart, > The tree I tested indeed includes that rebased patch. BTW, since the code > touched by that patch has not been modified in the past months, the rebased > patch is identical to the patch I posted in May 2017. OK. Just checking. So what's the plan here? Should both patches be routed

RE: [PATCH 1/2] scsi: megaraid: Remove redundant code in megasas_alloc_cmds

2017-10-31 Thread Sumit Saxena
-Original Message- From: Yisheng Xie [mailto:xieyishe...@huawei.com] Sent: Wednesday, October 25, 2017 3:27 PM To: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; shivasharan.srikanteshw...@broadcom.com; j...@linux.vnet.ibm.com; martin.peter...@oracle.com Cc:

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Bart Van Assche
On Tue, 2017-10-31 at 13:20 -0400, Martin K. Petersen wrote: > > That tree passed the iSCSI target tests I ran so feel free to add my > > Reviewed-by and Tested-by to [PATCH v2] target/iscsi: Convert timers > > to use timer_setup(). > > Is that with your rebased patch from a few days ago? Hello

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Bart, > That tree passed the iSCSI target tests I ran so feel free to add my > Reviewed-by and Tested-by to [PATCH v2] target/iscsi: Convert timers > to use timer_setup(). Is that with your rebased patch from a few days ago? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-31 Thread Bart Van Assche
On Mon, 2017-10-30 at 17:04 -0700, Kees Cook wrote: > On Fri, Oct 27, 2017 at 5:57 AM, Bart Van Assche > wrote: > > On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote: > > > In preparation for unconditionally passing the struct timer_list pointer > > > to > > > all timer

Re: [PATCH] scsi_error.c: DID_SOFT_ERROR comment clean up

2017-10-31 Thread Martin K. Petersen
Petros, > Updated comment. We are keeping track of maximum number of retries per > command via retries/allowed in struct scsi_cmnd. Corrected comment > positioning. This didn't apply to 4.15/scsi-queue. I applied it by hand. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: aic7xxx: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > stat_timer only ever assigns the same function and data, so > consolidate to using timer_setup(), adjust callback, drop everything > else used to pass things around, and remove needless typedefs. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH 1/1] scsi: hisi_sas: fix for the build error log_non_standard_event undefined

2017-10-31 Thread Martin K. Petersen
Shiju, > This patch fix the build error log_non_standard_event undefined > for the i386 build for COMPILE_TEST. This is messy. You have one patch addressing build problems in two different patches. This breaks our ability to bisect. I combined the ECC and AXI patches into one and then added

Re: [PATCH] scsi: sas: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. This requires > adding a pointer to hold the timer's target task, as there isn't a > link back

Re: [PATCH] scsi: qla4xxx: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Cavium folks (for good measure): Please review! Reviewed-by: Martin K. Petersen

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Cavium folks: Please verify! Reviewed-by: Martin K. Petersen

Re: [PATCH] scsi: pmcraid: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi: megaraid: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Also > consolidates the timer setup functions arguments, which are all > identical, and

Re: [PATCH] scsi: lpfc: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Looks good to me but since it's a bit gnarly it would be good for James or Dick to take a

Re: [PATCH] scsi: ipr: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi: ibmvscsi: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi: fcoe: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi: cxgbi: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH] scsi: csiostor: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

[PATCH V3] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-10-31 Thread Cathy Avery
When running multipath on a VM if all available paths go down the driver can schedule large amounts of storvsc_remove_lun work items to the same lun. In response to the failing paths typically storvsc responds by taking host->scan_mutex and issuing a TUR per lun. If there has been heavy IO to the

[PATCH 04/13] mpt3sas: API 's to support NVMe drive addition to SML

2017-10-31 Thread Suganath Prabu S
Below Functions are added in various paths to support NVMe drive addition. _scsih_pcie_add_device _scsih_pcie_device_add _scsih_pcie_device_init_add _scsih_check_pcie_access_status _scsih_pcie_check_device mpt3sas_get_pdev_by_handle mpt3sas_config_get_pcie_device_pg0

[PATCH 00/13] mpt3sas driver NVMe support:

2017-10-31 Thread Suganath Prabu S
Ventura Series controller are Tri-mode. The controller and firmware are capable of supporting NVMe devices and PCIe switches to be connected with the controller. This patch set adds driver level support for NVMe devices and PCIe switches. Suganath Prabu S (13): mpt3sas: Add nvme device support

[PATCH 02/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

2017-10-31 Thread Suganath Prabu S
* Added support for translating the SGLs associated with incoming commands either to IEE SGL or NVMe PRPs for NVMe devices. * The hardware translation of IEEE SGL to NVMe PRPs has limitation and if a command cannot be translated by hardware then it will go to firmware and the firmware needs to

[PATCH 01/13] mpt3sas: Add nvme device support in slave alloc, target alloc and probe

2017-10-31 Thread Suganath Prabu S
1) Added support for probing pcie device and adding NVMe drives to SML and driver's internal list pcie_device_list. 2) Added support for determing NVMe as boot device. 3) Added nvme device support for call back functions scan_finished target_alloc,slave_alloc,target destroy and slave destroy.

答复: 答复: [PATCH v5 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

2017-10-31 Thread liwei (CM)
Hi, Arnd Thank you for your reply. -邮件原件- 发件人: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] 代表 Arnd Bergmann 发送时间: 2017年10月30日 23:22 收件人: liwei (CM) 抄送: Rob Herring; Mark Rutland; xuwei (O); Catalin Marinas; Will Deacon; Vinayak Holikatti; James E.J. Bottomley; Martin K.

[PATCH 06/13] mpt3sas: Handle NVMe PCIe device related events generated from firmware.

2017-10-31 Thread Suganath Prabu S
* The controller firmware sends separate events for NVMe devices and PCIe switches similar to existing SAS events. * NVMe device detection, addition and removal are reported by the firmware through PCIe Topology Change list events. * The PCIe device state change events are sent when the firmware

[PATCH 09/13] mpt3as: Add-Task-management-debug-info-for-NVMe-drives.

2017-10-31 Thread Suganath Prabu S
Added debug information for NVMe/PCIe drives in target rest path Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 80 1 file changed,

[PATCH 08/13] mpt3sas: scan and add nvme device after controller reset

2017-10-31 Thread Suganath Prabu S
After Controller reset, Scan and add nvme device back to the topology. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 194 ++- 1 file

[PATCH 03/13] mpt3sas: Added support for nvme encapsulated request message.

2017-10-31 Thread Suganath Prabu S
* Mpt3sas driver uses the NVMe Encapsulated Request message to send an NVMe command to an NVMe device attached to the IOC. * Normal I/O commands like reads and writes are passed to the controller as SCSI commands and the controller has the ability to translate the commands to NVMe equivalent. *

[PATCH 05/13] mpt3sas: API's to remove nvme drive from sml

2017-10-31 Thread Suganath Prabu S
Below API's are included in nvme drive remove path. _scsih_pcie_device_remove_by_handle _scsih_pcie_device_remove_from_sml Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c |

[PATCH 10/13] mpt3sas: NVMe drive support for BTDHMAPPING ioctl command and log info

2017-10-31 Thread Suganath Prabu S
* Added debug prints for pcie devices in ioctl debug path. Which will be helpful for debugging. * Added PCIe device support for ioctl BTDHMAPPING ioctl. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S ---

[PATCH 11/13] mpt3sas: Fix nvme drives checking for tlr.

2017-10-31 Thread Suganath Prabu S
Check for NVMe drives before enabling or checking tlr. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 22 -- 1 file changed, 16 insertions(+), 6

[PATCH 12/13] mpt3sas: Fix sparse warnings

2017-10-31 Thread Suganath Prabu S
1) Used variable __le64/__le32 whichever required in building NVME PRP, and passed to LE Controller. 2) Remove unused functions, And Declared functions as static which are used only in mpt3sas_scsih.c. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S

[PATCH 07/13] mpt3sas: Set NVMe device queue depth as 128

2017-10-31 Thread Suganath Prabu S
Sets nvme device queue depth, name and displays device capabilities Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 2 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 50

[PATCH 13/13] mpt3sas: Update mpt3sas driver version.

2017-10-31 Thread Suganath Prabu S
Updated mpt3sas driver version to 17.100.00.00 Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] scsi_debug: write_same: fix error report

2017-10-31 Thread Martin K. Petersen
Doug, > The scsi_debug driver incorrectly suggests there is an error with > the SCSI WRITE SAME command when the number_of_logical_blocks is > greater than 1. It will also suggest there is an error when NDOB > (no data-out buffer) is set and the number_of_logical_blocks is > greater than 0. Both

Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-10-31 Thread Cathy Avery
On 10/31/2017 08:24 AM, Martin K. Petersen wrote: If you use alloc_ordered_workqueue directly instead of create_singlethread_workqueue you can pass a format string and don't need the separate allocation. But I'm not sure if Tejun is fine with using __WQ_LEGACY directly.. The only thing that

[PATCH 1/1] scsi: hisi_sas: fix for the build error log_non_standard_event undefined

2017-10-31 Thread shiju.jose
This patch fix the build error log_non_standard_event undefined for the i386 build for COMPILE_TEST. https://lists.01.org/pipermail/kbuild-all/2017-October/039518.html The function call log_non_standard_event is replaced with the function call trace_non_standard_event. Signed-off-by: Shiju Jose

Re: [PATCH] scsi: scsi_transport_iscsi: fix spelling mistake: 'Cound' -> 'Could'

2017-10-31 Thread Martin K. Petersen
Arvind, > Trivial fix to spelling mistakes in 'iscsi_get_host_stats'. Applied to 4.15/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-10-31 Thread Martin K. Petersen
>> If you use alloc_ordered_workqueue directly instead of >> create_singlethread_workqueue you can pass a format string and don't >> need the separate allocation. >> >> But I'm not sure if Tejun is fine with using __WQ_LEGACY directly.. > > The only thing that flag does is exempting the

Re: [PATCH 0/5] nvmet/nvmet_fc: add events for discovery controller rescan

2017-10-31 Thread Martin K. Petersen
James, > Note: These patches were posted to the nvme list this morning. I should > have cc'd the scsi list as well - so I'm not posting to the scsi list. > I fully expect all patches to be pulled via the nvme-4.15 tree then the > block tree. The SCSI pieces look OK to me. Acked-by: Martin K.

Re: scsi/NCR5380: Suppress SDTR and WDTR message logging

2017-10-31 Thread Martin K. Petersen
Finn, > The 5380 drivers only support asynchronous transfers and the 5380 > controllers only have narrow busses. Hence, the core driver will reject > any SDTR and WDTR messages from target devices. Don't log this, it's > expected behaviour. Also, fix the off-by-one array indices in the >

Re: [PATCH 2/2] scsi: megaraid: Track the page allocations for struct fusion_context

2017-10-31 Thread Martin K. Petersen
Yisheng, >> Do you still see leaks reported with the megaraid driver update recently >> merged into 4.15/scsi-queue? >> > No, the related code have been optimized and __get_free_pages is not used > to allocate fusion_context anymore. So, please ignore this one, and sorry > for disturbing. > >

Re: [PATCH 0/3] cxlflash: Miscellaneous fixes

2017-10-31 Thread Martin K. Petersen
Uma, > This patch series contains miscellaneous fixes. All three patches resolve > minor issues. > > This series is intended for 4.15 and is bisectable. Applied to 4.15/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] qla2xxx: Fix oops in qla2x00_probe_one error path

2017-10-31 Thread Martin K. Petersen
Douglas, > On error, kthread_create() returns an errno-encoded pointer, not NULL. > The routine qla2x00_probe_one() detects the error case and jumps > to probe_failed, but has already assigned the return value from > kthread_create() to ha->dpc_thread. Then probe_failed checks to see > if