HP ProLiant DL360p Gen8 hangs with Linux 4.13+.

2018-01-04 Thread Vinson Lee
Hi. HP ProLiant DL360p Gen8 with Smart Array P420i boots to the login prompt and hangs with Linux 4.13 or later. I cannot log in on console or SSH into the machine. Linux 4.12 and older boot fine. I see these messages on the console. [ 242.843206] INFO: task scsi_eh_2:465 blocked for more than

RE: [PATCH v3 1/9] ufs: sysfs: device descriptor

2018-01-04 Thread Stanislav Nijnikov
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, January 3, 2018 3:44 AM > To: Stanislav Nijnikov > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; > gre...@linuxfoundation.org; Alex Lemberg

Business Possibility

2018-01-04 Thread Peter Deng
Hello there, My name is Peter Deng a South African citizen and a friend to Mrs Mugabe sister . I got your contact through Korean business online directory. I represent the interest of Mrs Mugabe who wishes to move a total amount of $19 million into a safe account owns by a trusted business man

[PATCH] tcmu: Allow reconfig to handle multiple attributes

2018-01-04 Thread Bryant G. Ly
This patch allows for multiple attributes to be reconfigured and handled all in one call as compared to multiple netlinks. Example: set attribute dev_reconfig=dev_config=fbo//home/path:dev_size=2147483648 Signed-off-by: Bryant G. Ly ---

Re: [PATCH v17 0/4] Replace PCI pool by DMA pool API

2018-01-04 Thread Romain Perier
Hi, Ok, will do. Thanks ! Romain 2018-01-03 22:34 GMT+01:00 Bjorn Helgaas : > On Tue, Jan 02, 2018 at 04:17:24PM -0600, Bjorn Helgaas wrote: >> On Tue, Jan 02, 2018 at 06:53:52PM +0100, Romain Perier wrote: >> > The current PCI pool API are simple macro functions direct

[PATCH] scsi: libcxgbi: use GFP_ATOMIC in cxgbi_conn_alloc_pdu()

2018-01-04 Thread Varun Prakash
For mgmt cmds ->alloc_pdu() can be called from atomic context so use GFP_ATOMIC instead of GFP_KERNEL. Signed-off-by: Varun Prakash --- drivers/scsi/cxgbi/libcxgbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/cxgbi/libcxgbi.c

Re: [PATCH v3 3/3] scsi: libsas: initialize sas_phy status according to response of DISCOVER

2018-01-04 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

[Resend 03/11] mpt3sas: separate out _base_recovery_check()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke No functional change. Signed-off-by: Hannes Reinecke Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 23 ++- 1 file changed, 14 insertions(+), 9

[Resend 02/11] mpt3sas: use list_splice_init()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke Use 'list_splice_init()' instead of hand-crafted function. No functional change. Signed-off-by: Hannes Reinecke Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 11 ++-

[Resend 04/11] mpt3sas: open-code _scsih_scsi_lookup_get()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke Just a wrapper around the scsi lookup array and only used in one place, so open-code it. Signed-off-by: Hannes Reinecke Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 15

[Resend PATCH 00/11] mpt3sas: Enable scsi MQ & lockless command submission

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke Hi all, This patch set is initially posted by Hannes Reinecke to enable scsi multiqueue for the mpt3sas driver. While the HBA only has a single mailbox register for submitting commands, it does have individual receive queues per MSI-X interrupt and as such

[Resend 05/11] mpt3sas: Introduce mpt3sas_get_st_from_smid()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke Abstract accesses to the scsi_lookup array by introducing mpt3sas_get_st_from_smid(). Signed-off-by: Hannes Reinecke Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 22

[Resend 07/11] mpt3sas: always use first reserved smid for ioctl passthrough

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke ioctl passthrough commands require a SCSIIO smid, but cannot easily integrate with the block layer. But the driver already has reserved some SCSIIO smids and we're only ever allowing one ioctl command at a time we can use the first reserved smid for ioctl

[PATCH v3 2/3] scsi: libsas: fix error when getting phy events

2018-01-04 Thread Jason Yan
The intend purpose here was to goto out if smp_execute_task() returned error. Obviously something got screwed up. We will never get these link error statistics below: ~:/sys/class/sas_phy/phy-1:0:12 # cat invalid_dword_count 0 ~:/sys/class/sas_phy/phy-1:0:12 # cat running_disparity_error_count 0

[Resend 08/11] mpt3sas: simplify task management functions

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke No functional change. Code optimization. One can simply check 'target_busy' or 'device_busy' when figuring out if there are outstanding commands; no need to painstakingly counting them by hand. Signed-off-by: Hannes Reinecke Signed-off-by:

[PATCH v3 1/3] scsi: libsas: fix memory leak in sas_smp_get_phy_events()

2018-01-04 Thread Jason Yan
We've got a memory leak with the following producer: while true; do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null; done The buffer req is allocated and not freed after we return. Fix it. Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver") Signed-off-by: Jason Yan

[Resend 06/11] mpt3sas: check command status before attempting abort

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke When attempting a command abort we should check the command status prior to sending the abort; the command might've been completed already. Signed-off-by: Hannes Reinecke Signed-off-by: Suganath Prabu S

[PATCH v3 0/3] Three small fixes for libsas

2018-01-04 Thread Jason Yan
We've found three small bugs. Please consider including them for 4.15. V3: - Add "Reviewed-by" tag. - Code improvement suggested by Christoph Hellwig. V2: - Add "Fixes" tag. Jason Yan (2): scsi: libsas: fix memory leak in sas_smp_get_phy_events() scsi: libsas: fix

[Resend 09/11] mpt3sas: simplify mpt3sas_scsi_issue_tm()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke Move the check for outstanding commands out of the function allowing us to simplify the overall code. Signed-off-by: Hannes Reinecke Signed-off-by: Suganath Prabu S ---

[Resend 11/11] mpt3sas: lockless command submission

2018-01-04 Thread Suganath Prabu S
Performance improvement using block layer tag. Curent driver gets scsiio tracker and free smid from link list and array based tracking managed by driver. Accessing list in main io path is performance pentaly because of protection using spinlock "scsi_lookup_lock". In this patch - 1. Driver

[Resend 10/11] mpt3sas: simplify _wait_for_commands_to_complete()

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke Use 'host_busy' instead of counting outstanding commands by hand. Signed-off-by: Hannes Reinecke Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 14 -- 1 file

[Resend 01/11] mpt3sas: set default value for cb_idx

2018-01-04 Thread Suganath Prabu S
From: Hannes Reinecke No functional change Signed-off-by: Hannes Reinecke Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v3 3/3] scsi: libsas: initialize sas_phy status according to response of DISCOVER

2018-01-04 Thread Jason Yan
From: chenxiang The status of SAS PHY is in sas_phy->enabled. There is an issue that the status of a remote SAS PHY may be initialized incorrectly: if disable remote SAS PHY through sysfs interface (such as echo 0 > /sys/class/sas_phy/phy-1:0:0/enable), then reboot

Re: [PATCH v2 3/3] scsi: libsas: initialize sas_phy status according to response of DISCOVER

2018-01-04 Thread Jason Yan
On 2018/1/4 20:41, Christoph Hellwig wrote: On Thu, Jan 04, 2018 at 07:47:41PM +0800, Jason Yan wrote: + phy->phy->enabled = (phy->linkrate == SAS_PHY_DISABLED) ? 0:1; missing whitespaces around the ":, but this could just be simplified to: phy->phy->enabled = (phy->linkrate

Re: [PATCH v2 3/3] scsi: libsas: initialize sas_phy status according to response of DISCOVER

2018-01-04 Thread Christoph Hellwig
On Thu, Jan 04, 2018 at 07:47:41PM +0800, Jason Yan wrote: > + phy->phy->enabled = (phy->linkrate == SAS_PHY_DISABLED) ? 0:1; missing whitespaces around the ":, but this could just be simplified to: phy->phy->enabled = (phy->linkrate != SAS_PHY_DISABLED); Otherwise this looks fine.

Re: [PATCH v2 2/3] scsi: libsas: fix error when getting phy events

2018-01-04 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v2 1/3] scsi: libsas: fix memory leak in sas_smp_get_phy_events()

2018-01-04 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns

2018-01-04 Thread Nikola Pajkovsky
Raghava Aditya Renukunta writes: > Hi Nikola, > >> -Original Message- >> From: Nikola Pajkovsky [mailto:npajkov...@suse.cz] >> Sent: Wednesday, January 3, 2018 2:02 AM >> To: Raghava Aditya Renukunta >> >> Cc:

[PATCH v2 0/3] Three small fixes for libsas

2018-01-04 Thread Jason Yan
We've found three small bugs. Please consider including them for 4.15. V2: - Add "Fixes" tag. Jason Yan (2): scsi: libsas: fix memory leak in sas_smp_get_phy_events() scsi: libsas: fix error when getting phy events chenxiang (1): scsi: libsas: initialize sas_phy status according

[PATCH v2 2/3] scsi: libsas: fix error when getting phy events

2018-01-04 Thread Jason Yan
The intend purpose here was to goto out if smp_execute_task() returned error. Obviously something got screwed up. We will never get these link error statistics below: ~:/sys/class/sas_phy/phy-1:0:12 # cat invalid_dword_count 0 ~:/sys/class/sas_phy/phy-1:0:12 # cat running_disparity_error_count 0

[PATCH v2 3/3] scsi: libsas: initialize sas_phy status according to response of DISCOVER

2018-01-04 Thread Jason Yan
From: chenxiang The status of SAS PHY is in sas_phy->enabled. There is an issue that the status of a remote SAS PHY may be initialized incorrectly: if disable remote SAS PHY through sysfs interface (such as echo 0 > /sys/class/sas_phy/phy-1:0:0/enable), then reboot

[PATCH v2 1/3] scsi: libsas: fix memory leak in sas_smp_get_phy_events()

2018-01-04 Thread Jason Yan
We've got a memory leak with the following producer: while true; do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null; done The buffer req is allocated and not freed after we return. Fix it. Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver") Signed-off-by: Jason Yan

Re: [PATCH] scsi: megaraid: Use zeroing memory allocator than allocator/memset

2018-01-04 Thread Himanshu Jha
Hi Shivashran, On Thu, Jan 04, 2018 at 04:52:54PM +0530, Shivasharan Srikanteshwara wrote: > > -Original Message- > > From: Himanshu Jha [mailto:himanshujha199...@gmail.com] > > Sent: Saturday, December 30, 2017 9:18 PM > > To: martin.peter...@oracle.com; j...@linux.vnet.ibm.com > > Cc:

RE: [PATCH] scsi: megaraid: Use zeroing memory allocator than allocator/memset

2018-01-04 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Himanshu Jha [mailto:himanshujha199...@gmail.com] > Sent: Saturday, December 30, 2017 9:18 PM > To: martin.peter...@oracle.com; j...@linux.vnet.ibm.com > Cc: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; > shivasharan.srikanteshw...@broadcom.com; >

Re: [PATCH v5 3/7] scsi: libsas: make the event threshold configurable

2018-01-04 Thread John Garry
On 15/12/2017 12:19, Hannes Reinecke wrote: On 12/08/2017 10:42 AM, Jason Yan wrote: Add a sysfs attr that LLDD can configure it for every host. We made a example in hisi_sas. Other LLDDs using libsas can implement it if they want. Suggested-by: Hannes Reinecke Signed-off-by: