Since the action "reprep" is called from two places, rather than repeat
the code, make a new scsi_io_completion helper with "reprep" as its
suffix.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/scsi_lib.c | 41
The scsi_io_completion function contains three BUG() and BUG_ON() calls.
Replace them with WARN variants.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/scsi_lib.c | 15 ---
1 file changed, 12
Add likely() and unlikely() hints to conditionals on or near the fastpath.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
---
A reviewer wanted any performance improvement (or otherwise) quantified.
The improvement was so small, that
While working of this "[PATCH v4] Make SCSI Status CONDITION MET
equivalent to GOOD" the author had trouble finding how to add another
corner case check in the scsi_io_completion() function (scsi_lib.c).
That function is executed at the completion of every SCSI command but
only 20 or so of its
Place scsi_io_completion()'s complex error processing associated with a
local enumeration into a static helper function. That enumeration's
values start with "ACTION_" so use the suffix "_action" in the helper
function's name.
Signed-off-by: Douglas Gilbert
Reviewed-by:
Change and add some variable names, adjust some associated comments
for clarity. Correct some misleading comments.
Signed-off-by: Douglas Gilbert
---
drivers/scsi/scsi_lib.c | 72 ++---
1 file changed, 39 insertions(+), 33
Break out several intertwined paths when cmd->result is non zero and
place them in the scsi_io_completion_nz_result helper function. The
logic is not changed.
Signed-off-by: Douglas Gilbert
---
A reviewer requested the original helper function's two return values
be
scsi_end_request() is called multiple times from scsi_io_completion()
which branches on its bool returned value. Add comment before the static
definition of scsi_end_request() about the meaning of that return.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
> Il giorno 29 mar 2018, alle ore 05:22, Jens Axboe ha
> scritto:
>
> On 3/28/18 9:13 PM, Zephaniah E. Loss-Cutler-Hull wrote:
>> On 03/28/2018 06:02 PM, Jens Axboe wrote:
>>> On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote:
I am not subscribed to any of the
On Wed, Mar 28, 2018 at 05:37:24PM -0400, Tony Battersby wrote:
> The SCSI generic driver is currently broken in the 3.18, 4.1, 4.4, and
> 4.9 stable kernels. This is the problematic commit:
>
> 109bade9c625 ("scsi: sg: use standard lists for sg_requests")
>
> (all commit ids are from upstream
> Il giorno 29 mar 2018, alle ore 03:02, Jens Axboe ha
> scritto:
>
> On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote:
>> I am not subscribed to any of the lists on the To list here, please CC
>> me on any replies.
>>
>> I am encountering a fairly consistent crash
On 3/28/18 11:07 AM, Piotr Gabriel Kosinski wrote:
> When trying to read raw data from a CD drive using CDROMREADRAW ioctl
> when a CD is not present, the kernel crashes with a stack corruption
> error in mmc_ioctl_cdrom_read_data.
>
> From my (cursory) analysis it looks like the bug is caused by
On 3/28/18 9:13 PM, Zephaniah E. Loss-Cutler-Hull wrote:
> On 03/28/2018 06:02 PM, Jens Axboe wrote:
>> On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote:
>>> I am not subscribed to any of the lists on the To list here, please CC
>>> me on any replies.
>>>
>>> I am encountering a fairly
Hi Vinson,
> Fixes: 2d2c2331673c ("scsi: megaraid_sas: modified few prints in OCR and
IOC
> INIT path")
> Signed-off-by: Vinson Lee
> ---
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Thanks for the patch.
On 03/28/2018 06:02 PM, Jens Axboe wrote:
> On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote:
>> I am not subscribed to any of the lists on the To list here, please CC
>> me on any replies.
>>
>> I am encountering a fairly consistent crash anywhere from 15 minutes to
>> 12 hours after boot
On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote:
> I am not subscribed to any of the lists on the To list here, please CC
> me on any replies.
>
> I am encountering a fairly consistent crash anywhere from 15 minutes to
> 12 hours after boot with scsi_mod.use_blk_mq=1 dm_mod.use_blk_mq=1>
Hi, Arnd
Thanks for your patiences.
-邮件原件-
发件人: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] 代表 Arnd Bergmann
发送时间: 2018年3月28日 20:50
收件人: liwei (CM)
抄送: Rob Herring; Mark Rutland; xuwei (O); Catalin Marinas; Will Deacon; Vinayak
Holikatti; James E.J. Bottomley; Martin K.
Maybe best through greg's char-misc tree since it has generic hv code and
sometime updates both network and scsi.
Alternatively, put common code through one tree, and hold off the network
device change till next release.
-Original Message-
From: Long Li
Sent: Wednesday, March 28,
I am not subscribed to any of the lists on the To list here, please CC
me on any replies.
I am encountering a fairly consistent crash anywhere from 15 minutes to
12 hours after boot with scsi_mod.use_blk_mq=1 dm_mod.use_blk_mq=1
The crash looks like:
[ 5466.075993] general protection fault:
On Wed, 2018-03-28 at 12:45 -0400, Douglas Gilbert wrote:
> + if (sense_valid && (sshdr.sense_key == RECOVERED_ERROR)) {
> + bool do_print = true;
> + /*
> + * if ATA PASS-THROUGH INFORMATION AVAILABLE [0x0, 0x1d]
> + * skip print since caller
> Subject: Re: [Resend Patch 1/3] Vmbus: Add function to report available ring
> buffer to write in total ring size percentage
>
>
> Long,
>
> > Netvsc has a function to calculate how much ring buffer in percentage
> > is available to write. This function is also useful for storvsc and
> >
> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
> blacklist
>
>
> Long, KY: Please confirm.
>
> > The Windows Server 2016 iSCSI target doesn't work with the Linux
> > kernel initiator since the kernel started sending larger requests by
> > default, nor does it
Kashyap/Sumit: Please review!
> Fixes: 2d2c2331673c ("scsi: megaraid_sas: modified few prints in OCR and IOC
> INIT path")
> Signed-off-by: Vinson Lee
> ---
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
Johannes,
> Currently scsi_dh_lookup() doesn't check for NULL as a device
> name. This combined with nvme over dm-mapth results in the following
> messages emitted by device-mapper:
Applied to 4.16/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> The first assignment to shost->use_blk_mq is redundant as it is
> overwritten by the following statement. Remove this redundant code.
Applied to 4.16/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> Trivial fix to spelling mistake in message text
Applied to 4.17/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Ohad,
> Add UFS Protocol Information Units(upiu) trace events for ufs driver,
> used to trace various ufs transaction types- command, task-management
> and device management. The trace-point format is generic and can be
> easily adapted to trace other upius if needed. Currently tracing ufs
>
Long,
> Netvsc has a function to calculate how much ring buffer in percentage is
> available to write. This function is also useful for storvsc and other
> vmbus devices.
What is the submission strategy for this series? Do you expect it to go
through net or scsi? If the latter, I'll need an ack
Bart,
> Are you aware that if the 0-day test infrastructure suggests an improvement
> for a patch that the patch that that improvement applies to gets ignored
> unless either the patch is reposted with the improvement applied or that it
> is explained why the suggested improvement is
https://bugzilla.kernel.org/show_bug.cgi?id=198081
Anthony J. Battersby (to...@cybernetics.com) changed:
What|Removed |Added
CC|
Long, KY: Please confirm.
> The Windows Server 2016 iSCSI target doesn't work with the Linux kernel
> initiator since the kernel started sending larger requests by default,
> nor does it implement the block limits VPD page. Apply the sector limit
> workaround for these targets.
>
>
John,
> In commit 2104551969e8 ("scsi: use per-cpu buffer for formatting
> sense"), function scsi_show_extd_sense() was removed, switching use
> over to scsi_format_extd_sense(). Remove last reference to
> scsi_show_extd_sense() in include/scsi/scsi_dbg.h.
Applied to 4.17/scsi-queue. Thanks!
> On Mar 28, 2018, at 2:45 PM, Martin K. Petersen
> wrote:
>
>
>> The code that fixes the crashes in the following commit introduced a
>> small memory leak:
>>
>> commit 6a2cf8d3663e ("scsi: qla2xxx: Fix crashes in qla2x00_probe_one on
>> probe failure")
>>
>>
> The code that fixes the crashes in the following commit introduced a
> small memory leak:
>
> commit 6a2cf8d3663e ("scsi: qla2xxx: Fix crashes in qla2x00_probe_one on
> probe failure")
>
> Fixing this requires a bit of reworking, which I've explained. Also provide
> some code cleanup.
>
>
The SCSI generic driver is currently broken in the 3.18, 4.1, 4.4, and
4.9 stable kernels. This is the problematic commit:
109bade9c625 ("scsi: sg: use standard lists for sg_requests")
(all commit ids are from upstream git, not stable.git)
There have already been a number of fixes backported
Uma,
> This patch series adds OCXL support to the cxlflash driver. With this
> support, new devices using the OCXL transport will be supported by the
> cxlflash driver along with the existing CXL devices. An effort is made
> to keep this transport specific function independent of the existing
>
hi
AACRAID crashes immediately on PPC32
I have opened this ticket at bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=199223
let me know
On Wed, Mar 28, 2018 at 11:42:16AM +0300, Michal Kalderon wrote:
> This FW contains several fixes and features
>
> RDMA Features
> - SRQ support
> - XRC support
> - Memory window support
> - RDMA low latency queue support
> - RDMA bonding support
>
> RDMA bug fixes
> - RDMA remote invalidate
On Wed, Mar 28, 2018 at 09:14:25PM +0530, Varun Prakash wrote:
> On Wed, Mar 21, 2018 at 09:12:00PM -0400, Martin K. Petersen wrote:
> >
> > Varun: Please look at this. Thanks!
> >
> > > What happened to this one?
> > >
> > > regards,
> > > dan carpenter
> > >
> > >
> > > On Wed, Nov 29, 2017 at
When trying to read raw data from a CD drive using CDROMREADRAW ioctl
when a CD is not present, the kernel crashes with a stack corruption
error in mmc_ioctl_cdrom_read_data.
>From my (cursory) analysis it looks like the bug is caused by size
mismatch between:
- struct request_sense (64 bytes),
On Wed, 2018-03-28 at 17:41 +0100, Colin King wrote:
> From: Colin Ian King
>
> The first assignment to shost->use_blk_mq is redundant as it is
> overwritten by the following statement. Remove this redundant code.
>
> Detected by CoverityScan, CID#1466993 ("Unused
Break out several intertwined paths when cmd->result is non zero and
place them in the scsi_io_completion_nz_result helper function. The
logic is not changed.
Signed-off-by: Douglas Gilbert
---
A reviewer requested the original helper function's two return values
be
The scsi_io_completion function contains three BUG() and BUG_ON() calls.
Replace them with WARN variants.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/scsi_lib.c | 15 ---
1 file changed, 12
Add likely() and unlikely() hints to conditionals on or near the fastpath.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
---
A reviewer wanted any performance improvement (or otherwise) quantified.
The improvement was so small, that
Since the action "reprep" is called from two places, rather than repeat
the code, make a new scsi_io_completion helper with "reprep" as its
suffix.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/scsi_lib.c | 41
Place scsi_io_completion()'s complex error processing associated with a
local enumeration into a static helper function. That enumeration's
values start with "ACTION_" so use the suffix "_action" in the helper
function's name.
Signed-off-by: Douglas Gilbert
Reviewed-by:
While working of this "[PATCH v4] Make SCSI Status CONDITION MET
equivalent to GOOD" the author had trouble finding how to add another
corner case check in the scsi_io_completion() function (scsi_lib.c).
That function is executed at the completion of every SCSI command but
only 20 or so of its
Change some variable names and associated comments for clarity. Correct
some misleading comments.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
Reviewed-by: Bart Van Assche
---
drivers/scsi/scsi_lib.c | 57
scsi_end_request() is called multiple times from scsi_io_completion()
which branches on its bool returned value. Add comment before the static
definition of scsi_end_request() about the meaning of that return.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
From: Colin Ian King
The first assignment to shost->use_blk_mq is redundant as it is
overwritten by the following statement. Remove this redundant code.
Detected by CoverityScan, CID#1466993 ("Unused value")
Signed-off-by: Colin Ian King
---
On Wed, Mar 21, 2018 at 09:12:00PM -0400, Martin K. Petersen wrote:
>
> Varun: Please look at this. Thanks!
>
> > What happened to this one?
> >
> > regards,
> > dan carpenter
> >
> >
> > On Wed, Nov 29, 2017 at 02:42:20PM +0300, Dan Carpenter wrote:
> >> The story is that Smatch marks skb->data
On 03/28/18 08:14, bige...@linutronix.de wrote:
On 2018-03-28 15:05:41 [+], Bart Van Assche wrote:
The names of the two functions touched by patch 1/2 start with a double
underscore. That by itself is already a hint that these should be called with
a lock held (I know that this is not a
On 2018-03-28 15:05:41 [+], Bart Van Assche wrote:
> The names of the two functions touched by patch 1/2 start with a double
> underscore. That by itself is already a hint that these should be called with
> a lock held (I know that this is not a universal convention in the Linux
> kernel). I'm
On Wed, 2018-03-28 at 12:15 +0200, bige...@linutronix.de wrote:
> On 2018-03-26 11:13:59 [-0400], Steven Rostedt wrote:
> > > diff --git a/drivers/target/target_core_tmr.c
> > > b/drivers/target/target_core_tmr.c
> > > index 9c7bc1ca341a..3d35dad1de2c 100644
> > > ---
On Mon, Mar 26, 2018 at 11:35:42AM -0500, Uma Krishnan wrote:
> The following Oops can occur when there is heavy I/O traffic and the host
> is reset by a tool such as sg_reset.
>
> [c000200fff3fbc90] c0081690117c process_cmd_doneq+0x104/0x500
>
On Mon, Mar 26, 2018 at 11:35:34AM -0500, Uma Krishnan wrote:
> The following Oops can occur if an internal command sent to the AFU does
> not complete within the timeout:
>
> [c00ff101b810] c00816020d94 term_mc+0xfc/0x1b0 [cxlflash]
> [c00ff101b8a0] c00816020fb0
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Keith Busch
> Sent: Tuesday, March 27, 2018 10:39 AM
> To: Linux NVMe ; Linux Block bl...@vger.kernel.org>
> Cc: Christoph Hellwig
On Mon, Mar 26, 2018 at 11:35:27AM -0500, Uma Krishnan wrote:
> The following Oops can be encountered if a device removal or system
> shutdown is initiated while an EEH recovery is in process:
>
> [c00ff2f479c0] c00815256f18 cxlflash_pci_slot_reset+0xa0/0x100
>
https://bugzilla.kernel.org/show_bug.cgi?id=198975
--- Comment #4 from lober...@redhat.com ---
On Wed, 2018-03-28 at 11:54 +, bugzilla-dae...@bugzilla.kernel.org
wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=198975
>
> --- Comment #3 from Matthias Lippert (mae.lipp...@gmail.com) ---
>
On Tue, Mar 27, 2018 at 8:15 AM, liwei (CM) wrote:
> Hi, Arnd
>
> At present our ufs module mainly has four clocks from the outside:
> hclk_ufs: main clock of ufs controller ,freq is 207.5MHz
> cfg_phy_clk: configuration clock of MPHY, freq is 51.875MHz
> ref_phy_clk:
https://bugzilla.kernel.org/show_bug.cgi?id=198975
--- Comment #3 from Matthias Lippert (mae.lipp...@gmail.com) ---
Has anybody an idea if this problem is beeing worked on?
--
You are receiving this mail because:
You are watching the assignee of the bug.
This patch adds a device tree platform
driver for Cadence UFS Controller.
Signed-off-by: Jan Kotas
---
drivers/scsi/ufs/Kconfig |8 ++
drivers/scsi/ufs/Makefile |1 +
drivers/scsi/ufs/cdns-pltfrm.c | 148
3 files
This patch adds a device tree platform
driver description for Cadence UFS Controller.
Signed-off-by: Jan Kotas
---
.../devicetree/bindings/ufs/cdns-ufs-pltfrm.txt| 31
1 files changed, 31 insertions(+), 0 deletions(-)
create mode 100644
On 2018-03-26 11:13:59 [-0400], Steven Rostedt wrote:
> > diff --git a/drivers/target/target_core_tmr.c
> > b/drivers/target/target_core_tmr.c
> > index 9c7bc1ca341a..3d35dad1de2c 100644
> > --- a/drivers/target/target_core_tmr.c
> > +++ b/drivers/target/target_core_tmr.c
>
> Can you add a
From: Colin Ian King
Trivial fix to spelling mistake in message text
Signed-off-by: Colin Ian King
---
drivers/scsi/fnic/fnic_trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fnic/fnic_trace.c
Add UFS Protocol Information Units(upiu) trace events for ufs driver,
used to trace various ufs transaction types- command, task-management
and device management.
The trace-point format is generic and can be easily adapted to trace
other upius if needed.
Currently tracing ufs transaction of type
There would be so many same lines printed by frequent prink if one
disk went wrong, like,
[ 546.185242] sd 0:1:0:0: rejecting I/O to offline device
[ 546.185258] sd 0:1:0:0: rejecting I/O to offline device
[ 546.185280] sd 0:1:0:0: rejecting I/O to offline device
[ 546.185307] sd 0:1:0:0:
> From: Jason Gunthorpe [mailto:j...@ziepe.ca]
> Sent: Wednesday, March 28, 2018 1:27 AM
>
> On Tue, Mar 27, 2018 at 08:50:24PM +0300, Leon Romanovsky wrote:
> > On Tue, Mar 27, 2018 at 05:41:51PM +, Kalderon, Michal wrote:
> > > > From: Jason Gunthorpe [mailto:j...@ziepe.ca]
> > > > Sent:
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham
https://bugzilla.kernel.org/show_bug.cgi?id=199003
Wen Yang (wen.yan...@zte.com.cn) changed:
What|Removed |Added
Component|Other |SCSI
--
You are
70 matches
Mail list logo