Re: General protection fault with use_blk_mq=1.

On 03/29/2018 02:12 AM, Zephaniah E. Loss-Cutler-Hull wrote: > On 03/28/2018 10:13 PM, Paolo Valente wrote: >> In addition, the outcome of your attempt without >> CONFIG_DEBUG_BLK_CGROUP would give us useful bisection information: >> - if no failure occurs, then the issue is likely to be confined

Re: [PATCH] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk

On Wed, 2018-03-28 at 16:43 +0800, Wen Yang wrote: > There would be so many same lines printed by frequent prink if one > disk went wrong, like, > [ 546.185242] sd 0:1:0:0: rejecting I/O to offline device > [ 546.185258] sd 0:1:0:0: rejecting I/O to offline device > [ 546.185280] sd 0:1:0:0:

Re: [PATCH v5 7/7] scsi_io_completion convert BUGs to WARNs

On Thu, 2018-03-29 at 01:47 -0400, Douglas Gilbert wrote: > The scsi_io_completion function contains three BUG() and BUG_ON() calls. > Replace them with WARN variants. Reviewed-by: Bart Van Assche

Re: [PATCH v5 6/7] scsi_io_completion hints on fastpatch

On Thu, 2018-03-29 at 01:47 -0400, Douglas Gilbert wrote: > - /* no bidi support for !blk_rq_is_passthrough yet */ > + /* no bidi support yet, other than in pass-through */ > > [ ... ] > > - /* Kill remainder if no retries. */ > + /* Kill remainder if no retries. */ If you would

Re: [PATCH v5 5/7] scsi_io_completion_reprep helper added

On Thu, 2018-03-29 at 01:47 -0400, Douglas Gilbert wrote: > Since the action "reprep" is called from two places, rather than repeat > the code, make a new scsi_io_completion helper with "reprep" as its > suffix. Reviewed-by: Bart Van Assche

Re: [PATCH v5 4/7] scsi_io_completion_action helper added

On Thu, 2018-03-29 at 01:46 -0400, Douglas Gilbert wrote: > + /* > + * Unprep the request and put it back at the head of the > + * queue. A new command will be prepared and issued. > + * This block is the same as case ACTION_REPREP in > +

Re: [PATCH v5 3/7] scsi_io_completion_nz_result function added

On Thu, 2018-03-29 at 01:46 -0400, Douglas Gilbert wrote: > Break out several intertwined paths when cmd->result is non zero and > place them in the scsi_io_completion_nz_result helper function. The > logic is not changed. Reviewed-by: Bart Van Assche

Re: [PATCH v5 2/7] scsi_io_completion rename variables

On Thu, 2018-03-29 at 01:46 -0400, Douglas Gilbert wrote: > Change and add some variable names, adjust some associated comments > for clarity. Correct some misleading comments. Reviewed-by: Bart Van Assche

Re: [PATCH v3 00/41] cxlflash: OCXL transport support and miscellaneous fixes

> On Mar 28, 2018, at 4:34 PM, Martin K. Petersen > wrote: > > > Uma, > >> This patch series adds OCXL support to the cxlflash driver. With this >> support, new devices using the OCXL transport will be supported by the >> cxlflash driver along with the existing

Vmbus series...

Please feel free put it in via the scsi tree: Acked-by: David S. Miller

Re: [PATCH v2 net-next] qed*: Utilize FW 8.33.11.0

From: Michal Kalderon Date: Wed, 28 Mar 2018 11:42:16 +0300 > This FW contains several fixes and features > > RDMA Features > - SRQ support > - XRC support > - Memory window support > - RDMA low latency queue support > - RDMA bonding support > > RDMA bug fixes > -

Re: Multi-Actuator SAS HDD First Look

On 2018-03-26 11:08 AM, Hannes Reinecke wrote: On Fri, 23 Mar 2018 08:57:12 -0600 Tim Walker wrote: Seagate announced their split actuator SAS drive, which will probably require some kernel changes for full support. It's targeted at cloud provider JBODs and RAID.

Re: [PATCH] scsi: qla2xxx: Fix small memory leak in qla2x00_probe_one on probe failure

Hi Bill, > On Mar 23, 2018, at 7:37 AM, Bill Kuzeja wrote: > > The code that fixes the crashes in the following commit introduced a > small memory leak: > > commit 6a2cf8d3663e ("scsi: qla2xxx: Fix crashes in qla2x00_probe_one on > probe failure") > > Fixing this

Re: [PATCH] qla2xxx: Avoid double completion of abort command

Hi Ben, > On Mar 20, 2018, at 2:05 PM, Ben Hutchings > wrote: > > qla2x00_tmf_sp_done() now deletes the timer that will run > qla2x00_tmf_iocb_timeout(), but doesn't check whether the timer > already expired. Check the return value from del_timer() to avoid >

Re: [PATCH v2] qla2xxx: Fix race condition between iocb timeout and initialisation

Hi Ben, > On Mar 21, 2018, at 10:58 AM, Ben Hutchings > wrote: > > On Wed, 2018-03-21 at 17:55 +, Madhani, Himanshu wrote: >> Hi Ben, >> >>> On Mar 21, 2018, at 10:45 AM, Ben Hutchings >>> wrote: >>> >>> On Wed, 2018-03-21

Re: Recent kernels fail to boot on POWER8 with multipath SCSI

On Thu, Mar 29 2018 at 4:39am -0400, Paul Mackerras wrote: > Since commit 8d47e65948dd ("dm mpath: remove unnecessary NVMe > branching in favor of scsi_dh checks", 2018-03-05), upstream kernels > fail to boot on my POWER8 box which has multipath SCSI disks. The > host

Re: [PATCH] scsi: cxgb4i: potential array overflow in t4_uld_rx_handler()

On Wed, Mar 28, 2018 at 08:30:37PM +0300, Dan Carpenter wrote: > On Wed, Mar 28, 2018 at 09:14:25PM +0530, Varun Prakash wrote: > > On Wed, Mar 21, 2018 at 09:12:00PM -0400, Martin K. Petersen wrote: > > > > > > > > > > > On Wed, Nov 29, 2017 at 02:42:20PM +0300, Dan Carpenter wrote: > > > >>

aacraid code passes GFP_DMA32 to kmalloc this will not work

Hi All, Since I made the same mistake myself I've done a quick grep for GFP_DMA32 in the kernel and drivers/scsi/aacraid/commctrl.c came up as a result of this grep, it does: p = kmalloc(sg_count[i], GFP_KERNEL|GFP_DMA32); But kmalloc always returns memory from

[PATCH scsi-next] scsi: mvumi: Using module_pci_driver.

Remove boilerplate code by using macro module_pci_driver. Signed-off-by: YueHaibing --- drivers/scsi/mvumi.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c index fe97401..2e6fd86 100644

Re: General protection fault with use_blk_mq=1.

On 03/28/2018 10:13 PM, Paolo Valente wrote: > > >> Il giorno 29 mar 2018, alle ore 05:22, Jens Axboe ha >> scritto: >> >> On 3/28/18 9:13 PM, Zephaniah E. Loss-Cutler-Hull wrote: >>> On 03/28/2018 06:02 PM, Jens Axboe wrote: On 3/28/18 5:03 PM, Zephaniah E.

Recent kernels fail to boot on POWER8 with multipath SCSI

Since commit 8d47e65948dd ("dm mpath: remove unnecessary NVMe branching in favor of scsi_dh checks", 2018-03-05), upstream kernels fail to boot on my POWER8 box which has multipath SCSI disks. The host adapters are IPR and the userspace is CentOS 7. Before that commit, the system booted fine.

Re: [PATCH v5 3/7] scsi_io_completion_nz_result function added

Looks good (as far as I can tell) Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer,

Re: [PATCH v5 2/7] scsi_io_completion rename variables

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham