On Wed, Aug 01, 2018 at 02:06:11PM +0200, Johannes Thumshirn wrote:
> On Wed, Aug 01, 2018 at 08:00:44PM +0800, Ming Lei wrote:
> > On Wed, Aug 01, 2018 at 07:52:19PM +0800, Ming Lei wrote:
> > > On Wed, Aug 01, 2018 at 12:24:00PM +0100, Matt Hart wrote:
> > > > On 1 August 2018 at 11:59, Mark
On Wed, 2018-08-01 at 21:16 +, Bart Van Assche wrote:
> During my kernel tests of today I noticed that this patch makes booting
> significantly slower: boot time for a VM increases from 6s to 157s. Martin,
> please drop this patch series.
Please ignore my previous message - these two patches
On Mon, 2018-07-30 at 11:40 -0700, Bart Van Assche wrote:
> A long time ago the unfortunate decision was taken to add a self-
> deletion attribute to the sysfs SCSI device directory. That decision
> was unfortunate because self-deletion is really tricky. We can't drop
> that attribute because
On Mon, 2018-07-30 at 14:52 -0400, Douglas Gilbert wrote:
> I designed 'struct sg_io_v4' found in include/uapi/linux/bsg.h to handle
> storage
> related protocols, not just the SCSI command set. After the guard, the next
> two fields in that structure are:
> __u32 protocol; /*
On Wed, 2018-08-01 at 11:44 -0500, Mike Christie wrote:
> I agree knowing the acl info is useful, so how about the following:
>
> 1. Create a file named "acl" in the session's dir.
> 2. For dynamic_node_acl=0 the acl file will return a empty string or
> "generate_node_acls=1" or "demo mode
On 08/01/2018 11:44 AM, Mike Christie wrote:
> 1. Create a file named "acl" in the session's dir.
> 2. For dynamic_node_acl=0 the acl file will return a empty string or
Miswrote this.
Above should be dynamic_node_acl=1
> "generate_node_acls=1" or "demo mode enabled".
> 3. For dynamic_node_acl=1
On 07/19/2018 12:07 PM, Bart Van Assche wrote:
> On Thu, 2018-07-19 at 11:38 -0500, Mike Christie wrote:
>> On 07/19/2018 10:37 AM, Bart Van Assche wrote:
>>> The general recommendation for configfs is that each attribute contains a
>>> single value, just like for sysfs. Patch 11/15 exports two
On Mon, Jul 30, 2018 at 11:40:52AM -0700, Bart Van Assche wrote:
> A long time ago the unfortunate decision was taken to add a self-
> deletion attribute to the sysfs SCSI device directory. That decision
> was unfortunate because self-deletion is really tricky. We can't drop
> that attribute
On Mon, Jul 30, 2018 at 11:40:51AM -0700, Bart Van Assche wrote:
> Introduce these two functions and export them such that the next patch
> can add calls to these functions from the SCSI core.
>
> Signed-off-by: Bart Van Assche
> Cc: Greg Kroah-Hartman
> Cc: Tejun Heo
> Cc:
Acked-by: Tejun
On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote:
> + struct uic_command uc = {0};
Please use "{ }" or "{}" for structure initialization as is done elsewhere in
the kernel instead of "{0}".
> +#define UIC_CMD_SIZE (sizeof(u32) * 4)
Please add a comment above this definition that
On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote:
> + if (qr->opcode != UPIU_QUERY_OPCODE_WRITE_DESC ||
> + desc_size <= 0)
> + return -EINVAL;
Please use the full line length and don't split lines if that is not necessary.
> + ret =
On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote:
> +/**
> + * ufshcd_exec_raw_upiu_cmd - API function for sending raw upiu commands
> + * @hba: per-adapter instance
> + * @req_upiu:upiu request - 8 dwards
> + * @rsp_upiu:upiu reply - 8 dwards
> + * @msgcode: message code,
On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote:
> + wait_event(hba->tm_tag_wq, ufshcd_get_tm_free_slot(hba, _slot));
The above is the weirdest API I have seen so far for tag allocation.
Why does ufshcd_get_tm_free_slot() does a linear search through a bitmap
instead of using the sbitmap
On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote:
> +++ b/drivers/scsi/ufs/ufs_bsg.c
> @@ -0,0 +1,127 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * SSCSI transport companion for UFS HBA
What is "SSCSI"?
> diff --git a/drivers/scsi/ufs/ufs_bsg.h b/drivers/scsi/ufs/ufs_bsg.h
> new file
Johannes,
Thanks a lot for your comments.
Cheers,
Avri
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org
> On Behalf Of Johannes Thumshirn
> Sent: Wednesday, August 01, 2018 2:17 PM
> To: Avri Altman
> Cc: Christoph Hellwig ; Hannes Reinecke ;
> Bart Van Assche ; James E.J.
On Wed, Aug 01, 2018 at 02:50:40PM +0100, Guillaume Tucker wrote:
>
> Sure, although it didn't make any apparent difference, still on
> next-20180731:
>
> https://lava.collabora.co.uk/scheduler/job/1215417
>
> The .config file I used is available here, with just
> CONFIG_BLK_DEV_RAM=y on
On 01/08/18 13:40, Johannes Thumshirn wrote:
On Wed, Aug 01, 2018 at 01:37:17PM +0100, Guillaume Tucker wrote:
The kernel images I used have the git revision in their file name
to make it clear where they came from, they were built with
x86_64_defconfig. The links to the kernel and ramdisks
On 01/08/18 12:25, Johannes Thumshirn wrote:
On Wed, Aug 01, 2018 at 11:59:19AM +0100, Mark Brown wrote:
On Wed, Aug 01, 2018 at 06:51:09PM +0800, Ming Lei wrote:
You may have to provide some clue, such as dmesg log, boot disk, ...
I guess you don't use virtio-scsi/virtio-blk since both
On Wed, Aug 01, 2018 at 08:00:44PM +0800, Ming Lei wrote:
> On Wed, Aug 01, 2018 at 07:52:19PM +0800, Ming Lei wrote:
> > On Wed, Aug 01, 2018 at 12:24:00PM +0100, Matt Hart wrote:
> > > On 1 August 2018 at 11:59, Mark Brown wrote:
> > > > On Wed, Aug 01, 2018 at 06:51:09PM +0800, Ming Lei wrote:
On Wed, Aug 01, 2018 at 07:52:19PM +0800, Ming Lei wrote:
> On Wed, Aug 01, 2018 at 12:24:00PM +0100, Matt Hart wrote:
> > On 1 August 2018 at 11:59, Mark Brown wrote:
> > > On Wed, Aug 01, 2018 at 06:51:09PM +0800, Ming Lei wrote:
> > >
> > >> You may have to provide some clue, such as dmesg
On Wed, Aug 01, 2018 at 07:52:21PM +0800, Ming Lei wrote:
> On Wed, Aug 01, 2018 at 12:24:00PM +0100, Matt Hart wrote:
> > On 1 August 2018 at 11:59, Mark Brown wrote:
> > > On Wed, Aug 01, 2018 at 06:51:09PM +0800, Ming Lei wrote:
> > >
> > >> You may have to provide some clue, such as dmesg
On Wed, Aug 01, 2018 at 12:24:00PM +0100, Matt Hart wrote:
> On 1 August 2018 at 11:59, Mark Brown wrote:
> > On Wed, Aug 01, 2018 at 06:51:09PM +0800, Ming Lei wrote:
> >
> >> You may have to provide some clue, such as dmesg log, boot disk, ...
> >
> >> I guess you don't use
On Wed, Aug 01, 2018 at 12:24:00PM +0100, Matt Hart wrote:
> And a full LAVA boot log from my lab
> http://lava.streamtester.net/scheduler/job/138067
>
> QEMU command line here:
> http://lava.streamtester.net/scheduler/job/138067#L75
>
> And a LAVA job definition, which includes the url of the
On Wed, Aug 01, 2018 at 08:33:23AM +0200, Hannes Reinecke wrote:
> On 07/31/2018 05:07 PM, Varun Prakash wrote:
> > If number of interrupt vectors are more than num_online_cpus()
> > then pci_alloc_irq_vectors_affinity() assigns cpumask based
> > on num_possible_cpus() to the remaining vectors
On Wed, Aug 01, 2018 at 11:59:19AM +0100, Mark Brown wrote:
> On Wed, Aug 01, 2018 at 06:51:09PM +0800, Ming Lei wrote:
>
> > You may have to provide some clue, such as dmesg log, boot disk, ...
>
> > I guess you don't use virtio-scsi/virtio-blk since both run at blk-mq
> > mode at default, even
On 1 August 2018 at 11:59, Mark Brown wrote:
> On Wed, Aug 01, 2018 at 06:51:09PM +0800, Ming Lei wrote:
>
>> You may have to provide some clue, such as dmesg log, boot disk, ...
>
>> I guess you don't use virtio-scsi/virtio-blk since both run at blk-mq
>> mode at default, even though without
Hi Avri,
On Wed, Aug 01, 2018 at 11:04:27AM +0300, Avri Altman wrote:
[...
> +#include
Why do you include bsg.h here and bsg-lib.h in the scsi_transport_ufs.h?
[...]
> +#define to_ufs_internal(tmpl)container_of(tmpl, struct ufs_internal,
> t)
I'd personally prefer this to be a
On Wed, Aug 01, 2018 at 06:51:09PM +0800, Ming Lei wrote:
> You may have to provide some clue, such as dmesg log, boot disk, ...
> I guess you don't use virtio-scsi/virtio-blk since both run at blk-mq
> mode at default, even though without d5038a13eca72fb.
Boot logs and so on can be found here:
On Wed, Aug 01, 2018 at 11:33:03AM +0100, Mark Brown wrote:
> On Wed, Aug 01, 2018 at 11:05:36AM +0100, Guillaume Tucker wrote:
> > On 31/07/18 16:14, kernelci.org bot wrote:
>
> > > Boot Regressions Detected:
> > [...]
> > > x86:
> > >
> > > x86_64_defconfig:
> > > qemu:
> > >
On Wed, Aug 01, 2018 at 11:05:36AM +0100, Guillaume Tucker wrote:
> On 31/07/18 16:14, kernelci.org bot wrote:
> > Boot Regressions Detected:
> [...]
> > x86:
> >
> > x86_64_defconfig:
> > qemu:
> > lab-baylibre: failing since 1 day (last pass: next-20180727 -
> >
On 31/07/18 16:14, kernelci.org bot wrote:
next/master boot: 179 boots: 11 failed, 167 passed with 1 offline
(next-20180731)
Full Boot Summary:
https://kernelci.org/boot/all/job/next/branch/master/kernel/next-20180731/
Full Build Summary:
This patch adds Configfs support to provision UFS device at
runtime. This feature can be primarily useful in factory or
assembly line as some devices may be required to be configured
multiple times during initial system development phase.
Configuration Descriptors can be written multiple times
Add support to those uic commands, that are currently supported
by ufshcd api: the variants of dme_{peer}_{set_get}.
At this point better not to add any new api, as careless
uic command may turn the device into a brick.
Signed-off-by: Avri Altman
---
drivers/scsi/ufs/ufs_bsg.c | 56
Do that for the currently supported UPIUs:
query, nop out, and task management.
We do not support UPIU of type scsi command yet, while
we are using the job's request and reply pointers to hold
the payload. We will look into it in later patches.
We might need to elaborate the raw upiu api for
The UFS host software uses a combination of a host register set,
and Transfer Request Descriptors in system memory to communicate
with host controller hardware. In its mmio space, a separate places
are assigned to UTP Transfer Request Descriptor ("utrd") list, and
to UTP Task Management Request
Call the Attach/Probe/Remove APIs.
Signed-off-by: Avri Altman
---
drivers/scsi/ufs/ufshcd.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 3560185..c2ae406 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++
A LLD companion for the ufs scsi transport.
For now, just provide an API to instantiate the ufs transport,
allocating and removing ufs-ports.
As we are attaching the transport template to the scsi host
that was already alocated for the ufs hba,
we'll need to pay extra attention on where to call
Scsi transport is a framework that allow to send scsi commands to
a non-scsi devices. Still, it is flexible enough to allow
sending non-scsi commands as well. We will use this framework to
manage ufs devices by sending UPIU transactions.
In addition to the basic SCSI core objects this transport
Here is a proposal to use the scsi transport subsystem to manage
ufs devices.
scsi transport is a framework that allow to send scsi commands to
a non-scsi devices. Still, it is flexible enough to allow
sending non-scsi commands as well. We will use this framework to
manage ufs devices by sending
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org
> On Behalf Of Douglas Gilbert
> Sent: Monday, July 30, 2018 9:53 PM
> To: Hannes Reinecke ; Bart Van Assche
> ; h...@lst.de; j...@linux.vnet.ibm.com; linux-
> s...@vger.kernel.org; jthumsh...@suse.de;
On 07/31/2018 05:07 PM, Varun Prakash wrote:
> If number of interrupt vectors are more than num_online_cpus()
> then pci_alloc_irq_vectors_affinity() assigns cpumask based
> on num_possible_cpus() to the remaining vectors because of
> this interrupt does not generate for these vectors.
>
> This
From: Quinn Tran
Fix race condition between switch cmd completion and timeout
timer. Timer has popped triggers command free. On IOCB completion,
stale sp point was reused. Instead, an abort will be sent to FW
to nudge the command out of FW, where the normal completion
will take place.
RIP:
From: Quinn Tran
This patch sets discovery state back to GNL (Get
Name List) when session is stuck at GPDB (Get Port
DataBase). This will allow state machine to retry
login and move session state ahead in discovery.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
From: Quinn Tran
After selecting the NPort handle/loop_id, set a bit
in the loop_id_map to prevent others from selecting the same
NPort handle.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gbl.h | 1 +
drivers/scsi/qla2xxx/qla_init.c | 28
From: Quinn Tran
Login retry count was not properly decrementing,
which lead to endless login retry.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gs.c | 16 +++
drivers/scsi/qla2xxx/qla_init.c | 23 +++---
drivers/scsi/qla2xxx/qla_mbx.c
From: Quinn Tran
Flush pending mailbox commands on chip reset. Wake up
command that's waiting for an interrupt and wait for
mailbox counters to go to zero.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 5 +
From: Quinn Tran
In case of N2N connect, when sg_regset for bus/device/host
was causing driver and firmware state to go out of sync.
This patch fixes this link instablity when reconnect is
attempted after link flap.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
From: Quinn Tran
Prevent multiple registration with transport layer for
the same remote port.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git
Hi Martin,
This patch series addresses issue with N2N connection for FCP and FC-NVMe by
moving login to state machine and handle various state change.
Please apply this series to 4.19/scsi-queue at your earliest.
Changes from v1 -> v2
o Rebased on 4.19/scsi-queue
Thanks,
Himanshu
Himanshu
From: Quinn Tran
Save frame payload size from init control block. This
field/data is used to register with switch data base.
This allow the init control block temp buf to be reuse
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 1 +
From: Quinn Tran
During normal IO, FW can return IO with 'port unavailble' status.
Driver would send a LOGO to remote port for session resync. On
an off chance, a PLOGI could arrive before sending the LOGO.
This patch will skip sendiing LOGO, if a PLOGI just came in.
Signed-off-by: Quinn Tran
From: Quinn Tran
This patch fixes regression introduced for the N2N support
for FC-NVMe. For FC-NVMe with N2N connection, instead of FW
initiating the Login, Driver starts Login process. This
patch migrate that new process from a standalone path into
existing session management state machine.
From: Quinn Tran
The qla2x00_reset_active only cover the window of
turning the chip off, add check to cover Chip on.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_dbg.c | 3 +++
drivers/scsi/qla2xxx/qla_tmpl.c | 4 +++-
2 files changed, 6
This patch sets and clears FCF_ASYNC_{SENT|ACTIVE} flags to
prevent stalling of relogin attempt. Once flag are correctly
set/cleared, relogin timer can retry relogin attempt for driver
to continue login.
Fixes: fa83e65885b9 ("scsi: qla2xxx: ensure async flags are reset correctly")
Cc:
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 1ad7582220c3..3850b28518e5 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
+++
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 112
drivers/scsi/qla2xxx/qla_iocb.c | 25 -
2 files changed, 137 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index
56 matches
Mail list logo
