On Wed, Oct 17, 2018 at 04:40:01PM -0700, Bart Van Assche wrote:
> Make sure that a complaint appears in the kernel log if the driver core
> locking assumptions are violated.
>
> Cc: Lee Duncan
> Cc: Hannes Reinecke
> Cc: Luis Chamberlain
> Cc: Johannes Thumshirn
> Cc: Christoph Hellwig
>
On Wed, Oct 17, 2018 at 04:40:00PM -0700, Bart Van Assche wrote:
> This patch avoids that complaints similar to the following appear in the
> system log:
>
> sysfs: cannot create duplicate filename
> '/devices/pseudo_0/adapter0/host3/target3:0:0/3:0:0:133/driver'
>
> Cc: Lee Duncan
> Cc:
On Wed, Oct 17, 2018 at 05:54:56PM -0700, Dan Williams wrote:
> On Wed, Oct 17, 2018 at 4:41 PM Bart Van Assche wrote:
> >
> > Instead of probing devices sequentially in the PROBE_PREFER_ASYNCHRONOUS
> > mode, scan devices concurrently. This helps when the wall clock time for
> > a single probe
Add the missing unlock before return from function hisi_sas_phy_read32()
in the error handling case.
Fixes: 784b46b7cba0 ("scsi: hisi_sas: Use block layer tag instead for IPTT")
Signed-off-by: Wei Yongjun
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 4 +++-
1 file changed, 3 insertions(+), 1
Jens,
> Would be nice to fix up the SCSI midlayer instead, but this will
> do for now.
Applied to 4.20/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> A lot of SCSI drivers still use the legacy PCI DMA API. While a few
> of them have various oddities that should be deal with separately,
> most of them can be very trivially converted over.
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> A few bits found when auditing DMA API use. The first list cleanup
> isn't directly related, but I had to to do this first to fully
> understand the code..
Applied to 4.20/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Laurence,
Patch completely mangled by your mailer, please use git send-email for
submissions. I applied the change by hand.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
On Wed, Oct 17, 2018 at 4:41 PM Bart Van Assche wrote:
>
> Instead of probing devices sequentially in the PROBE_PREFER_ASYNCHRONOUS
> mode, scan devices concurrently. This helps when the wall clock time for
> a single probe is significantly above the CPU time needed for a single
> probe, e.g.
Bryant,
> There is currently a bug with the driver where there is never a call
> to target_sess_cmd_list_set_waiting(), it only called
> target_wait_for_sess_cmd(), which basically means that the
> sess_wait_list would always be empty.
>
> Thus, list_empty(>sess_wait_list) = true, (eg: no
As explained during the LSF/MM session about increasing SCSI disk
probing concurrency, the problems with the current probing approach
are as follows:
- The driver core is unaware of asynchronous SCSI LUN probing.
wait_for_device_probe() waits for all asynchronous probes except
asynchronous
Instead of probing devices sequentially in the PROBE_PREFER_ASYNCHRONOUS
mode, scan devices concurrently. This helps when the wall clock time for
a single probe is significantly above the CPU time needed for a single
probe, e.g. when scanning SCSI LUNs over a storage network.
Cc: Lee Duncan
Cc:
This patch does not change any functionality.
Cc: Lee Duncan
Cc: Hannes Reinecke
Cc: Luis Chamberlain
Cc: Johannes Thumshirn
Cc: Christoph Hellwig
Cc: Greg Kroah-Hartman
Signed-off-by: Bart Van Assche
---
drivers/scsi/sd.c | 101 --
1 file
Make sure that a complaint appears in the kernel log if the driver core
locking assumptions are violated.
Cc: Lee Duncan
Cc: Hannes Reinecke
Cc: Luis Chamberlain
Cc: Johannes Thumshirn
Cc: Christoph Hellwig
Cc: Greg Kroah-Hartman
Signed-off-by: Bart Van Assche
---
drivers/base/dd.c |
Since __device_release_driver() is called with the device lock held
and since the same device lock is obtained by the functions that
perform asynchronous probing (driver_attach_async() and
__device_attach_async_helper()), asynchronous probing is already
serialized against
Although the power management code never calls the system-wide and runtime
suspend callbacks concurrently, runtime power state changes can happen
while the system is being suspended or resumed. See also the dpm_suspend()
and dpm_resume() calls in hibernation_snapshot(). Make sure the sd driver
This patch avoids that complaints similar to the following appear in the
system log:
sysfs: cannot create duplicate filename
'/devices/pseudo_0/adapter0/host3/target3:0:0/3:0:0:133/driver'
Cc: Lee Duncan
Cc: Hannes Reinecke
Cc: Luis Chamberlain
Cc: Johannes Thumshirn
Cc: Christoph Hellwig
Hello Martin,
During the 2018 edition of LSF/MM there was a session about increasing SCSI
disk probing concurrency. This patch series implements what has been proposed
during that session, namely:
- Make sure that the driver core is aware of asynchronous SCSI LUN probing.
- Avoid unnecessary
On Wed, 2018-10-17 at 13:27 -0700, Bart Van Assche wrote:
> Although the power management code never calls the system-wide and runtime
> suspend callbacks concurrently, runtime power state changes can happen
> while the system is being suspended or resumed. See also the dpm_suspend()
> and
On Mon, 2018-10-15 at 08:51 -0400, Laurence Oberman wrote:
> On Sat, 2018-10-13 at 10:42 -0400, Laurence Oberman wrote:
> > On Fri, 2018-10-12 at 17:51 -0700, Bart Van Assche wrote:
> > > On 10/12/18 1:36 PM, Laurence Oberman wrote:
> > > > While I have for the longest time used 4.5 as a base for
Although the power management code never calls the system-wide and runtime
suspend callbacks concurrently, runtime power state changes can happen
while the system is being suspended or resumed. See also the dpm_suspend()
and dpm_resume() calls in hibernation_snapshot(). Make sure the sd driver
On 10/17/18 12:08 PM, Douglas Gilbert wrote:
> On 2018-10-17 11:55 a.m., Benjamin Block wrote:
>> On Tue, Oct 16, 2018 at 08:43:01AM -0600, Jens Axboe wrote:
>>> Requires a few changes to the FC transport class as well.
>>>
>>> Cc: Johannes Thumshirn
>>> Cc: Benjamin Block
>>> Cc:
>
> Am 17.10.18 um 10:14 schrieb Christoph Hellwig:
> > On Tue, Oct 16, 2018 at 07:33:53PM +0200, Stefan Priebe - Profihost AG
> wrote:
> >> Hi David,
> >>
> >> can you give as any hint? We're running aroud 120 Adaptec Controllers
> >> and i don't want to replace them all...
> >
> > 4.15 had a
On 2018-10-17 11:55 a.m., Benjamin Block wrote:
On Tue, Oct 16, 2018 at 08:43:01AM -0600, Jens Axboe wrote:
Requires a few changes to the FC transport class as well.
Cc: Johannes Thumshirn
Cc: Benjamin Block
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Jens Axboe
---
block/bsg-lib.c
On 10/16/2018 12:34 PM, Ly, Bryant wrote:
> From: "Bryant G. Ly"
>
> There is currently a bug with the driver where there is never a
> call to target_sess_cmd_list_set_waiting(), it only called
> target_wait_for_sess_cmd(), which basically means that the
> sess_wait_list would always be empty.
>
We provide photoshop services to some of the companies from around the
world.
Some online stores use our services for retouching portraits, jewelry,
apparels, furnitures etc.
Here are the details of what we provide:
Clipping path
Deep etching
Image masking
Portrait retouching
Jewelry retouching
We provide photoshop services to some of the companies from around the
world.
Some online stores use our services for retouching portraits, jewelry,
apparels, furnitures etc.
Here are the details of what we provide:
Clipping path for photos
Deep etching for photos
Image masking for photos
On 10/17/18 9:55 AM, Benjamin Block wrote:
> On Tue, Oct 16, 2018 at 08:43:01AM -0600, Jens Axboe wrote:
>> Requires a few changes to the FC transport class as well.
>>
>> Cc: Johannes Thumshirn
>> Cc: Benjamin Block
>> Cc: linux-scsi@vger.kernel.org
>> Signed-off-by: Jens Axboe
>> ---
>>
On Tue, Oct 16, 2018 at 08:43:01AM -0600, Jens Axboe wrote:
> Requires a few changes to the FC transport class as well.
>
> Cc: Johannes Thumshirn
> Cc: Benjamin Block
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Jens Axboe
> ---
> block/bsg-lib.c | 102
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_stat.c | 14 +-
include/target/iscsi/iscsi_target_stat.h | 2 --
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_stat.c
b/drivers/target/iscsi/iscsi_target_stat.c
The cumulative session errors metric matches cxn_timeout_errors, so drop
the duplicate.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_stat.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_stat.c
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_stat.c | 14 +-
include/target/iscsi/iscsi_target_stat.h | 2 --
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_stat.c
b/drivers/target/iscsi/iscsi_target_stat.c
This patchset removes a couple of unused error stat counters and a
redundant cumulative counter.
I've tagged this patchset RFC, as it may be considered a kernel<->user
(configfs) API change.
Cheers, David
---
drivers/target/iscsi/iscsi_target_stat.c | 40
On Wed, 2018-10-17 at 11:30 -0400, Doug Ledford wrote:
> On Wed, 2018-10-17 at 07:43 -0700, Bart Van Assche wrote:
> > On 10/17/18 12:20 AM, Hannes Reinecke wrote:
> > > The WARN_ON() is pointless as the rport is placed in
> > > SDEV_TRANSPORT_OFFLINE
> > > at that time, so no new commands can be
On Wed, 2018-10-17 at 07:43 -0700, Bart Van Assche wrote:
> On 10/17/18 12:20 AM, Hannes Reinecke wrote:
> > The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
> > at that time, so no new commands can be submitted via srp_queuecommand()
> >
> > Signed-off-by: Hannes
On 10/17/18 12:20 AM, Hannes Reinecke wrote:
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
at that time, so no new commands can be submitted via srp_queuecommand()
Signed-off-by: Hannes Reinecke
Reviewed-by: Jens Axboe
Reviewed-by: Johannes Thumshirn
---
- Original Message -
From: "Laurence Oberman"
To: "linux-scsi"
Cc: "Hannes Reinecke" , "Ewan Milne" , "Bart
Van Assche" , "James Bottomley"
Sent: Tuesday, October 16, 2018 4:39:16 PM
Subject: [PATCH] scsi_error: Remove scsi_block_when_processing_errors: message
This message floods
On Tue, 16 Oct 2018, 4:39pm, Laurence Oberman wrote:
> External Email
>
> This message floods the log when enabling mask 0x7 for
> /proc/sys/dev/scsi/logging_level
> kernel: scsi_block_when_processing_errors: rtn: 1
> Its not needed and makes tracing just scsi_eh* messages way too
Am 17.10.18 um 10:14 schrieb Christoph Hellwig:
> On Tue, Oct 16, 2018 at 07:33:53PM +0200, Stefan Priebe - Profihost AG wrote:
>> Hi David,
>>
>> can you give as any hint? We're running aroud 120 Adaptec Controllers
>> and i don't want to replace them all...
>
> 4.15 had a fair amount of
On Tue, Oct 16, 2018 at 07:33:53PM +0200, Stefan Priebe - Profihost AG wrote:
> Hi David,
>
> can you give as any hint? We're running aroud 120 Adaptec Controllers
> and i don't want to replace them all...
4.15 had a fair amount of aacraid changes. You can't bisect them by
any chance?
From: Xiubo Li
Currently there has one cmd timeout timer and one qfull timer for
each udev, and whenever there has any new coming cmd it will update
the cmd timer or qfull timer. And for some corner case the timers
are always working only for the ringbuffer's and full queue's newest
cmd. That's
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
at that time, so no new commands can be submitted via srp_queuecommand()
Signed-off-by: Hannes Reinecke
Reviewed-by: Jens Axboe
Reviewed-by: Johannes Thumshirn
---
drivers/infiniband/ulp/srp/ib_srp.c | 7 ---
1
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index e52b9d3c0bd6..c777b36ba62a 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -483,6 +483,8 @@ nvme_fc_signal_discovery_scan(struct nvme_fc_lport *lport,
> char hostaddr[FCNVME_TRADDR_LENGTH];/*
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
at that time, so no new commands can be submitted via srp_queuecommand()
Signed-off-by: Hannes Reinecke
Reviewed-by: Jens Axboe
Reviewed-by: Johannes Thumshirn
---
drivers/infiniband/ulp/srp/ib_srp.c | 7 ---
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 994c6ac6f920..8edba2227cd3 100644
---
The print related to number of VDs that a particular firmware supports is
misleading in some cases.
Even though supportMaxExtLDs is set, certain firmware profiles only
supports upto 64VDs.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 6 +++---
1 file changed, 3
IOC INIT frame needs to be fired with a timeout of 180seconds.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index b13fd1c601d7..a26abc041435 100644
---
In megasas_init_adapter_fusion(), max_mfi_cmds is being calcuated as
(MEGASAS_FUSION_INTERNAL_CMDS + MEGASAS_FUSION_IOCTL_CMDS).
max_mfi_cmds can be used in megasas_configure_queue_sizes.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +---
1 file changed, 1
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 2c044106c35f..994c6ac6f920 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++
No functional change.
Use local variables when accessing raid context in IO path.
Improves code readability.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 74 -
1 file changed, 31 insertions(+), 43 deletions(-)
diff --git
Optimization -
No need to hold hba_lock in dpc context for reading atomic variable.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
When driver fails to start the heartbeat timer, exit from FW init.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
No functional change.
Rename the scratch pad registers to match firmware headers.
Signed-off-by: Sumit Saxena
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h| 9 +++
drivers/scsi/megaraid/megaraid_sas_base.c | 40 +--
Fix -
For SRIOV based adapters, driver should not set the STOP_ADP bit as part
of kill adapter.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
Fix -
For Invader series, if FW supports more than 8 MSI-x vectors, driver needs
to enable combined reply queue mode. For Ventura series, driver enables
combined reply queue mode in case of more than 16 MSI-x vectors.
Signed-off-by: Sumit Saxena
Signed-off-by: Shivasharan S
---
Module parameter description for rdpq_enable incorrectly lists the default
as enabled.
Also, provide range of valid values for resetwaittime in the description.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Issue -
Currently driver checks for Firmware state change from ISR context, and
only when there are interrupts tied with no I/O completions.
We have seen multiple cases where doorbell interrupts sent by firmware,
to indicate FW state change are not processed by driver and it takes long
time for
Fix -
During init, if pci_alloc_irq_vectors() fails, the driver has not yet
setup the IRQs. Fix the goto labels and error handling for this case.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
Change copyright to Broadcom Inc. Also update any references to Avago with
Broadcom. Update copyright duration wherever required.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h| 14 ++
drivers/scsi/megaraid/megaraid_sas_base.c | 18 --
Latest firmware adds a mechanism to save firmware logs just before
controller reset on pre-allocated internal controller DRAM. This feature
is called snapdump which will help debugging firmware issues.
This feature requires extra time and firmware reports these values through
new driver interface.
Issue -
In megasas_transition_to_ready() driver waits 180seconds for controller
to change FW state. Here we are calling msleep(1) in a loop for this.
As explained in timers-howto.txt, msleep(1) will actually sleep longer
than 1ms. If a faulty controller is connected, we will end up waiting for
For SAS3 and later controllers, FW sets the reset adapter bit indicating
the driver to perform a controller reset.
Driver needs to check if this bit is set before doing a reset.
This reduces the driver probe failure time to 180seconds in case there
is a faulty controller connected.
Signed-off-by:
Changes in V2:
- Rebased the entire series on top of below patches -
"scsi: megaraid_sas: fix a missing-check bug"
"megaraid_sas: switch to generic DMA API"
- Patch 2/19: Replace PCI DMA APIs with generic DMA APIs.
Shivasharan S (19):
megaraid_sas: Add watchdog thread to detect Firmware
On 10/16/18 10:39 PM, Laurence Oberman wrote:
This message floods the log when enabling mask 0x7 for
/proc/sys/dev/scsi/logging_level
kernel: scsi_block_when_processing_errors: rtn: 1
Its not needed and makes tracing just scsi_eh* messages way too verbose
so get rid of it
65 matches
Mail list logo
