On Wed, 2018-03-21 at 17:55 +, Madhani, Himanshu wrote:
> Hi Ben,
>
> > On Mar 21, 2018, at 10:45 AM, Ben Hutchings <ben.hutchi...@codethink.co.uk>
> > wrote:
> >
> > On Wed, 2018-03-21 at 17:17 +, Madhani, Himanshu wrote:
> > > Hi Ben,
&g
On Wed, 2018-03-21 at 17:17 +, Madhani, Himanshu wrote:
> Hi Ben,
>
> > On Mar 20, 2018, at 2:36 PM, Ben Hutchings <ben.hutchi...@codethink.co.uk>
> > wrote:
> >
> > qla2x00_init_timer() calls add_timer() on the iocb timeout timer,
> > which means
, and dropped either at the end
of the timer function or after the timer is cancelled
- One reference is held by the completion path, and dropped by
qla2x00_sp_free()
Signed-off-by: Ben Hutchings <ben.hutchi...@codethink.co.uk>
---
This probably isn't quite right, since it's based on only a brie
a completion structure
needed by the timeout function, so move the call to add_timer() after
that.
Signed-off-by: Ben Hutchings <ben.hutchi...@codethink.co.uk>
---
Changes from v1:
Rebased to remove textual dependency on a patch I haven't yet sent
(oops).
Ben.
drivers/scsi/qla2xxx/ql
a completion structure
needed by the timeout function, so move the call to add_timer() after
that.
Signed-off-by: Ben Hutchings <ben.hutchi...@codethink.co.uk>
Cc: sta...@vger.kernel.org
---
drivers/scsi/qla2xxx/qla_gs.c | 12 +++-
drivers/scsi/qla2xxx/qla_init.c
onous ...")
Fixes: 1514839b3664 ("scsi: qla2xxx: Fix NULL pointer crash due to active ...")
Signed-off-by: Ben Hutchings <ben.hutchi...@codethink.co.uk>
---
drivers/scsi/qla2xxx/qla_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ql
unused by everybody? I've got
> it by running qemu with default flags...
If the bug is in libata then it's not on Doug to fix it since he's only
maintaining sg.
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
hanged, 1 insertion(+)
> create mode 100755 qed/qed_init_values_zipped-8.33.1.0.bin
[...]
Applied; sorry for the delay.
Ben.
--
Ben Hutchings
When in doubt, use brute force. - Ken Thompson
signature.asc
Description: This is a digitally signed message part
gned 32-bit time_t overflow in y2106 */
> + disable_req.tv_sec = be32_to_cpu(ktime_get_real_seconds());
> bfa_ioc_mbox_send(ioc, _req, sizeof(struct bfi_ioc_ctrl_req_s));
> }
>
--
Ben Hutchings
Software Developer, Codethink Ltd.
table()") moved that code, and reintroduced the
bug (perhaps due to a botched rebase). Fix it again.
Fixes: 4759df905a47 ("scsi: sg: factor out sg_fill_request_table()")
Cc: sta...@vger.kernel.org
Signed-off-by: Ben Hutchings <ben.hutchi...@codethink.co.uk>
---
drivers/scsi/
8.30.16.0.bin
[...]
The new file needs an entry in WHENCE.
Ben.
--
Ben Hutchings
Humour is the best antidote to reality.
signature.asc
Description: This is a digitally signed message part
Martin K. Petersen" <martin.peter...@oracle.com>
Cc: Hannes Reinecke <h...@suse.de>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com>
[bwh: Backported to 3.16: adjust context]
Si
<h...@suse.de>
Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com>
Signed-off-by: Ben Hutchings <b...@decadent.org.uk>
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
--- a/drivers/scsi/mpt3sas/mpt3sas_scsi
with:
commit f4327a95dd080ed6aecb185478a88ce1ee4fa3c4
Author: Martin K. Petersen <martin.peter...@oracle.com>
Date: Sat Mar 5 17:52:02 2016 -0500
sd: Fix discard granularity when LBPRZ=1
)
Ben.
--
Ben Hutchings
When in doubt, use brute force. - Ken Thompson
signature.asc
Description: This is a digitally signed message part
for 4.3
(though it's already in 4.4 which I'll probably upload to unstable soon).
Ben.
--
Ben Hutchings
Design a system any fool can use, and only a fool will want to use it.
signature.asc
Description: This is a digitally signed message part
000 0001 fff5 f6a7d150 f6a30cd8 f6a30d3c
> > f6989bbc c1390cb7 f6a30cd8 f8334660 f6989bd0 c1390d0f f6a30cd8
> > f8334660 f6989c0c c13916cb f694a614 f68dd040 0000 0008
> > Call Trace:
> > […] ? scsi_runtime_suspend+0x63/0x
On Sun, 2015-08-09 at 02:01 +, KY Srinivasan wrote:
-Original Message-
From: KY Srinivasan
Sent: Saturday, August 8, 2015 7:55 AM
To: 'Ben Hutchings' b...@decadent.org.uk
Cc: Long Li lon...@microsoft.com; linux-scsi linux-scsi@vger.kernel.org
Subject: RE: [PATCH] scsi
, size;
+ u32 offs = 0, size;
struct asd_ll_el *el;
struct asd_ctrla_phy_settings *ps;
struct asd_ctrla_phy_settings dflt_ps;
--
Ben Hutchings
Life would be so much easier if we could look at the source code.
signature.asc
Description: This is a digitally signed message part
into a couple of times.
Many thanks,
Masoud Sharbiani msharbi...@twitter.com msharbi...@twopensource.com
PS: Apologies for duplicate message that may have been captured in
your spam folder.
I've queued this up for 3.2, thanks.
Ben.
--
Ben Hutchings
Kids! Bringing about Armageddon can
.
Signed-off-by: Jens Axboe ax...@fb.com
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
block/scsi_ioctl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -505,7 +505,7 @@ int sg_scsi_ioctl(struct request_queue *
if (bytes
On !x86 we currently don't read the existing support flags:
/home/benh/linux-3.14.13/drivers/scsi/hpsa.c:4375:17: warning: 'driver_support'
is used uninitialized in this function [-Wuninitialized]
driver_support |= ENABLE_UNIT_ATTN;
^
Signed-off-by: Ben Hutchings b
On Sun, 2014-07-20 at 17:42 -0700, Christoph Hellwig wrote:
On Mon, Jul 21, 2014 at 01:09:17AM +0100, Ben Hutchings wrote:
On !x86 we currently don't read the existing support flags:
Arnd already sent this and I've included it in the for-3.17 queue.
Thanks.
Ben.
--
Ben Hutchings
Make
On Wed, 2014-06-25 at 22:44 -0400, Martin K. Petersen wrote:
Christoph == Christoph Hellwig h...@infradead.org writes:
Christoph On Sun, Jun 08, 2014 at 11:37:44PM +0100, Ben Hutchings wrote:
asd_process_ctrl_a_user() attempts to find user settings in flash,
and if they are missing
of type
[enabled by default]
addr = bfa_sgaddr_le(sg_dma_address(sg));
^
drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: right shift count = width of
type [enabled by default]
Avoid this by adding casts to u64 in bfa_swap_words().
Compile-tested only.
Signed-off-by: Ben Hutchings b
' has not been initialised.
Since asd_common_setup() already sets default PHY settings, there
seems to be no need to repeat them here, and we can just return 0.
Compile-tested only.
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
drivers/scsi/aic94xx/aic94xx_sds.c | 18 ++
1
of type
[enabled by default]
addr = bfa_sgaddr_le(sg_dma_address(sg));
^
drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: right shift count = width of
type [enabled by default]
Avoid this by adding casts to u64 in bfa_swap_words().
Compile-tested only.
Signed-off-by: Ben Hutchings b
I'm adding this revert to 3.2.58, taking your 'drop commit 584ec1226519'
as an ack.
Ben.
---
From: Ben Hutchings b...@decadent.org.uk
Date: Wed, 30 Apr 2014 13:22:22 +0100
Subject: Revert isci: fix reset timeout handling
This reverts commit 584ec12265192bf49dfa270d517380f6723a6956, which
880312127ba8
[ 34.766735] CR2: 0060
[ 34.778493] ---[ end trace 7cf83da47bb3f354 ]---
--
Ben Hutchings
When you say `I wrote a program that crashed Windows', people just stare ...
and say `Hey, I got those with the system, *for free*'. - Linus Torvalds
signature.asc
Description
udelay() does not work on some architectures for values above
2000, in particular on ARM:
ERROR: __bad_udelay [drivers/scsi/bfa/bfa.ko] undefined!
Reported-by: Vagrant Cascadian vagr...@debian.org
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
drivers/scsi/bfa/bfa_ioc.c | 2 +-
1 file
]
[...]
Add it to the device table as chip_9485.
Reported-by: Matt Taggart tagg...@debian.org
Tested-by: Matt Taggart tagg...@debian.org
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
drivers/scsi/mvsas/mv_init.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi
this situation (no caching mode page) is really
serious enough to deserve logging at ERR severity?
Ben.
--
Ben Hutchings
Logic doesn't apply to the real world. - Marvin Minsky
signature.asc
Description: This is a digitally signed message part
bytes
ctfw-3.2.3.0.bin | Bin 0 - 538712 bytes
4 files changed, 3 insertions(+)
create mode 100644 cbfw-3.2.3.0.bin
create mode 100644 ct2fw-3.2.3.0.bin
create mode 100644 ctfw-3.2.3.0.bin
[...]
Applied, thanks.
Ben.
--
Ben Hutchings
It is easier to write an incorrect program than
\:_3.2.23.0_Firmware_for_Brocade_Adapters.mbox
Applying: linux-firmware: 3.2.23.0 Firmware for Brocade Adapters
error: corrupt binary patch at line 13542: znHIKNgBV5FJqIQgo|#@us1Wq_D(J
Please re-send (but not to the mailing lists; it's pointless to send
binaries there).
Ben.
--
Ben Hutchings
]
[...]
Add it to the device table as chip_9485.
Reported-by: Matt Taggart tagg...@debian.org
Tested-by: Matt Taggart tagg...@debian.org
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
drivers/scsi/mvsas/mv_init.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi
of type
[enabled by default]
addr = bfa_sgaddr_le(sg_dma_address(sg));
^
drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: right shift count = width of
type [enabled by default]
Avoid this by adding casts to u64 in bfa_swap_words().
Compile-tested only.
Signed-off-by: Ben Hutchings b
' has not been initialised.
Since asd_common_setup() already sets default PHY settings, there
seems to be no need to repeat them here, and we can just return 0.
Compile-tested only.
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
drivers/scsi/aic94xx/aic94xx_sds.c | 18 ++
1
Various bits of code are mixing making assumptions about the size of
dma_addr_t or resource_size_t, or mixing up pointer and integer types.
All these fixes are based on compiler warnings and so far as I can see
the bugs are practically harmless.
Ben.
Ben Hutchings (8):
IB/cxgb4: Fix
]);
err = vm_insert_page(vma, addr, page);
if (err)
return err;
--
Ben Hutchings
If at first you don't succeed, you're doing about average.
signature.asc
Description: This is a digitally signed message part
) {
rc = -EFAULT;
--
Ben Hutchings
If at first you don't succeed, you're doing about average.
signature.asc
Description: This is a digitally signed message part
are for,
we can just make MSI-X variants.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi
does.
There is one major flaw in min-max approach - the generic MSI layer
will have to take decisions on exact number of MSIs to request, not
device drivers.
[...
No, the min-max functions should be implemented using the same loop that
drivers are expected to use now.
Ben.
--
Ben Hutchings
On Fri, 2013-10-04 at 10:29 +0200, Alexander Gordeev wrote:
On Thu, Oct 03, 2013 at 11:49:45PM +0100, Ben Hutchings wrote:
On Wed, 2013-10-02 at 12:48 +0200, Alexander Gordeev wrote:
This update converts pci_enable_msix() and pci_enable_msi_block()
interfaces to canonical kernel functions
.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord
;
[...]
Shouldn't this also return -EINVAL?
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi
and
maximum number of vectors from the driver. This wouldn't allow the
driver to specify that it could only accept, say, any even number within
a certain range, but you could still leave the current functions
available for any driver that needs that.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
.bin | Bin 0 - 582440 bytes
ctfw-3.2.1.1.bin | Bin 0 - 537160 bytes
4 files changed, 27 insertions(+)
create mode 100644 cbfw-3.2.1.1.bin
create mode 100644 ct2fw-3.2.1.1.bin
create mode 100644 ctfw-3.2.1.1.bin
[...]
Applied, thanks. Sorry for the delay.
Ben.
--
Ben Hutchings
Life
to the same or a smaller mask than
the streaming mask.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line unsubscribe
]
[...]
Add it to the device table as chip_9485.
Reported-by: Matt Taggart tagg...@debian.org
Tested-by: Matt Taggart tagg...@debian.org
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
drivers/scsi/mvsas/mv_init.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi
On Wed, 2013-07-24 at 16:20 +0200, Andi Kleen wrote:
On Wed, Jul 24, 2013 at 04:42:42AM +0100, Ben Hutchings wrote:
This looks like a candidate for stable:
Don't know if it's a security issue, but should be fine for stable.
OK, I've queued it up for 3.2.
Ben.
commit
, which is a security issue, but I don't know whether that's
true in this case.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
signature.asc
Description: This is a digitally signed message part
The ufs driver doesn't build on s390 with CONFIG_PCI disabled as it
requires MMIO functions.
Marking for 3.9-stable only as CONFIG_SCSI_UFSHCD was previously
dependent on CONFIG_PCI.
Signed-off-by: Ben Hutchings b...@decadent.org.uk
Cc: sta...@vger.kernel.org # 3.9
---
--- a/drivers/scsi/ufs
() does what was intended.
Compile-tested only.
Signed-off-by: Ben Hutchings b...@decadent.org.uk
Cc: sta...@vger.kernel.org
---
drivers/scsi/sd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index c1c5552..6f6a1b4 100644
'aac_src_deliver_message':
drivers/scsi/aacraid/src.c:410:3: warning: right shift count = width of type
[enabled by default]
drivers/scsi/aacraid/src.c:434:2: warning: right shift count = width of type
[enabled by default]
Signed-off-by: Ben Hutchings b...@decadent.org.uk
Cc: stable sta...@vger.kernel.org
);
iscsit_free_cmd(cmd);
[...]
This changes cmd-cmd_sn to cmd-stat_sn, but the commit message only
describes fixes to wrap-around. Is that another fix or a bug?
Ben.
--
Ben Hutchings
If God had intended Man to program,
we'd have been born with serial I/O ports
-driver-backport.mbox
I've committed these, but we should really get some more users of both
old and new hardware to test the result.
Ben.
--
Ben Hutchings
Always try to do things in chronological order;
it's less confusing that way.
signature.asc
Description: This is a digitally signed message
' has not been initialised.
Since asd_common_setup() already sets default PHY settings, there
seems to be no need to repeat them here, and we can just return 0.
This matches what is done if any empty user settings area is found.
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
Compile-tested
. All clear? Apparently not; I can't
think why.
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
drivers/scsi/mvsas/mv_sas.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index a3776d6..9f91359 100644
On Wed, 2012-10-10 at 09:18 -0500, scame...@beardog.cce.hp.com wrote:
Yes, I think so. Thanks.
I've queued this up for 3.2, thanks.
Ben.
-- steve
On Wed, Oct 10, 2012 at 04:47:38AM +0100, Ben Hutchings wrote:
Should this fix for hpsa be included in stable updates? It looks like
1 11:43:42 2012 -0500
[SCSI] hpsa: dial down lockup detection during firmware flash
Ben.
--
Ben Hutchings
Who are all these weirdos? - David Bowie, about L-Space IRC channel #afp
signature.asc
Description: This is a digitally signed message part
to existing round_up() in kernel.h could you use that?
I will replace it with round_up() if it serves the same purpose. Thanks.
Stephen is probably thinking of DIV_ROUND_UP(). round_up() does
something different.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's
would not crash any more.
Signed-off-by: Wang Sen senw...@linux.vnet.ibm.com
[...]
This is not the correct way to submit a change for stable. See
Documentation/stable_kernel_rules.txt.
Ben.
--
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.
signature.asc
61 matches
Mail list logo
