[PATCH] iscsi: respond to netlink with unicast when appropriate

. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/scsi_transport_iscsi.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index f4b52b44b966..65f6c9

Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

e_bounce_limit(sdev->request_queue, BLK_BOUNCE_ANY); > blk_queue_dma_alignment(sdev->request_queue, 0); > return 0; > -- Thanks for fixing this issue with data digests! Signed-off-by: Chris Leech <cle...@redhat.com>

Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()

correct? Just want to make sure that's still needed with the call to put_device. Other than that question, I this all looks good. Thanks. Signed-off-by: Chris Leech <cle...@redhat.com>

Re: [PATCH] libiscsi: ensure session spin lock usage consistent

I overlooked it by mentally swapping out the session->lock in the patch for session->frwd_lock from the warning when looking at this, but what kernel was this patch built against? It doesn't have the frwd_lock/back_lock split stuff. - Chris On Mon, Feb 05, 2018 at 11:13:23AM -0800, Lee Duncan

Re: [PATCH] libiscsi: ensure session spin lock usage consistent

On Mon, Feb 05, 2018 at 11:13:23AM -0800, Lee Duncan wrote: > The libiscsi code was using both spin_lock()/spin_unlock() > and spin_lock_bh()/spin_unlock_bh() on its session lock. > In addition, lock validation found that libiscsi.c was > taking a HARDIRQ-unsafe lock while holding an HARDIRQ- >

Re: [PATCH v3 2/2] qedi: Cleanup local str variable

On Wed, Feb 07, 2018 at 08:12:36AM -0800, Nilesh Javali wrote: > Signed-off-by: Nilesh Javali <nilesh.jav...@cavium.com> Signed-off-by: Chris Leech <cle...@redhat.com> > --- > drivers/scsi/qedi/qedi_main.c | 43 > --- > 1

Re: [PATCH v3 1/2] qedi: Fix truncation of CHAP name and secret

utput length and ensures that the newline and \0 are always in the output. Signed-off-by: Chris Leech <cle...@redhat.com> > --- > drivers/scsi/qedi/qedi_main.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/scsi/qedi/qedi_m

Re: network namespace, netlink and sysfs changes for iSCSI (Re: [PATCH 0/9] use network namespace for iSCSI control interfaces)

On Tue, Nov 07, 2017 at 12:45:26PM -0800, James Bottomley wrote: > On Tue, 2017-11-07 at 10:01 -0800, Chris Leech wrote: > > Hello, > > > > I have this set of changes to the iSCSI control interfaces pending > > review, but seeing as it's sysfs and netlink changes there'

network namespace, netlink and sysfs changes for iSCSI (Re: [PATCH 0/9] use network namespace for iSCSI control interfaces)

, 2017 at 03:40:55PM -0700, Chris Leech wrote: > This series of changes makes the iSCSI netlink and sysfs control > interfaces filtered by network namespace. This is required to run > iscsid in any network namespace other than the initial default one. > > Currently the netlin

Re: [PATCH 0/9] use network namespace for iSCSI control interfaces

, Chris Leech wrote: > This series of changes makes the iSCSI netlink and sysfs control > interfaces filtered by network namespace. This is required to run > iscsid in any network namespace other than the initial default one. > > Currently the netlink communication will fail if is

[PATCH 2/9] iscsi: associate endpoints with a host

Right now the iscsi_endpoint is only linked to a connection once that connection has been established. For net namespace filtering of the sysfs objects, associate an endpoint with the host that it was allocated for when it is created. Signed-off-by: Chris Leech <cle...@redhat.com> --- d

[PATCH 0/9] use network namespace for iSCSI control interfaces

could be added later to allow assignment of iSCSI HBAs to network namespace, much as is done for network interfaces. Chris Leech (9): iscsi: create per-net iscsi netlink kernel sockets iscsi: associate endpoints with a host iscsi: sysfs filtering by network namespace iscsi: make all iSCSI

[PATCH 3/9] iscsi: sysfs filtering by network namespace

This makes the iscsi_host, iscsi_session, iscsi_connection, iscsi_iface, and iscsi_endpoint transport class devices only visible in sysfs under a matching network namespace. The network namespace for all of these objects is tracked in the iscsi_cls_host structure. Signed-off-by: Chris Leech <

[PATCH 5/9] iscsi: set netns for iscsi_tcp hosts

This lets iscsi_tcp operate in multiple namespaces. It uses current during session creation to find the net namespace, but it might be better to manage to pass it along from the iscsi netlink socket. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/iscsi_tcp.c

[PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace aware

Make use of the per-net netlink sockets. Responses are sent back on the same socket/namespace the request was received on. Async events are reported on the socket/namespace stored in the iscsi_cls_host associated with the event. Signed-off-by: Chris Leech <cle...@redhat.com> --- driver

[PATCH 6/9] iscsi: check net namespace for all iscsi lookups

All internal lookups of iSCSI transport objects need to be filtered by net namespace. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/infiniband/ulp/iser/iscsi_iser.c | 5 +- drivers/scsi/be2iscsi/be_iscsi.c | 4 +- drivers/scsi/bnx2i/bnx2i_iscsi.c

[PATCH 7/9] iscsi: convert flashnode devices from bus to class

The flashnode session and connection devices should be filtered by net namespace along with the iscsi_host, but we can't do that with a bus device. As these don't use any of the bus matching functionality, they make more sense as a class device anyway. Signed-off-by: Chris Leech <

[PATCH 9/9] iscsi: filter flashnode sysfs by net namespace

Finished the net namespace support for flashnode sysfs devices Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/scsi_transport_iscsi.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/driver

[PATCH 8/9] iscsi: rename iscsi_bus_flash_* to iscsi_flash_*

cleanups after the bus to class conversion Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/qla4xxx/ql4_os.c | 52 +- drivers/scsi/scsi_transport_iscsi.c | 102 ++-- include/scsi/scsi_transport_iscsi.h

[PATCH 1/9] iscsi: create per-net iscsi netlink kernel sockets

Prepare iSCSI netlink to operate in multiple namespaces. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/scsi_transport_iscsi.c | 67 +++-- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/scsi_transport_iscs

Re: [PATCH] scsi: libiscsi: Convert timers to use timer_setup()

Reviewed-by: Chris Leech <cle...@redhat.com> - Original Message - > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > >

Re: [PATCH 00/10] be2iscsi: driver update 11.4.0.1

These all look good to me. Acked-by: Chris Leech <cle...@redhat.com> On Tue, Oct 10, 2017 at 04:18:10PM +0530, Jitendra Bhivare wrote: > This patch is generated against for-next branch. > > Jitendra Bhivare (10): > be2iscsi: Fix boot flags in sysfs > be2is

Re: [PATCH] scsi: fix the issue that iscsi_if_rx doesn't parse nlmsg properly

Acked-by: Chris Leech <cle...@redhat.com> On Sun, Aug 27, 2017 at 08:25:26PM +0800, Xin Long wrote: > ChunYu found a kernel crash by syzkaller: > > [ 651.617875] kasan: CONFIG_KASAN_INLINE enabled > [ 651.618217] kasan: GPF could be caused by NULL-ptr deref or use

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

Thanks. Acked-by: Chris Leech <cle...@redhat.com> On Thu, Jul 13, 2017 at 09:11:22AM -0700, 'Khazhismel Kumykov' via open-iscsi wrote: > iscsi_session_teardown was the only user of this function. Function > currently is just short for iscsi_remove_session + iscsi_free_session. >

Re: [Patch v2 1/2] libiscsi: Fix use-after-free race during iscsi_session_teardown

Looks good to me, fixes up the code given that the comment there about calling iscsi_remove_session wasn't being followed. Thanks Acked-by: Chris Leech <cle...@redhat.com> On Thu, Jul 13, 2017 at 09:11:21AM -0700, 'Khazhismel Kumykov' via open-iscsi wrote: > Session attributes expose

Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface.

On Tue, Jun 06, 2017 at 12:07:10PM -0600, Robert LeBlanc wrote: > This patchset enables iSCSI offload drivers to have access to the iface > information provided by iscsid. This allows users to have more control > of how the driver connects to the iSCSI target. iSER is updated to use >

Re: [PATCH v3 00/10] be2iscsi: driver update 11.4.0.0

This series looks good to me. Reviewed-by: Chris Leech <cle...@redhat.com> On Fri, Mar 24, 2017 at 02:11:39PM +0530, Jitendra Bhivare wrote: > This patch is generated against for-next branch. > > v3 changes: > be2iscsi: Fix closing of connection > - Fixed per To

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

> situations. > > Signed-off-by: Elena Reshetova <elena.reshet...@intel.com> > Signed-off-by: Hans Liljestrand <ishkam...@gmail.com> > Signed-off-by: Kees Cook <keesc...@chromium.org> > Signed-off-by: David Windsor <dwind...@gmail.com> This loo

[PATCH v2] libiscsi: add lock around task lists to fix list corruption regression

s been tested there successfully. v2: changed WARN_ONCE to pr_debug_once Signed-off-by: Chris Leech <cle...@redhat.com> Fixes: 659743b02c41 ("[SCSI] libiscsi: Reduce locking contention in fast path") Reported-by: Prashantha Subbarao <psubb...@us.ibm.com> Reviewed-by: Guilherme G. Picco

Re: [PATCH] libiscsi: add lock around task lists to fix list corruption regression

Yikes, my git-send-email settings suppressed the important CCs. Sorry! Guilherme and Ilkka, can you comment about your testing results or review please? - Chris Leech - Original Message - > There's a rather long standing regression from commit > 659743b [SCSI] libiscsi: Reduce l

[PATCH] libiscsi: add lock around task lists to fix list corruption regression

ted there successfully. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/libiscsi.c | 26 +- include/scsi/libiscsi.h | 1 + 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 834d121

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

- Original Message - > On 09/11/2016 03:21, Chris Leech wrote: > > On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote: > >> > >> Sure! Count on us to test any patches. I guess the first step is to > >> reproduce on upstream r

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Fri, Dec 23, 2016 at 07:53:50AM +0800, Ming Lei wrote: > On Fri, Dec 23, 2016 at 2:50 AM, Chris Leech <cle...@redhat.com> wrote: > > I'm not reproducing any problems with xfstests running over iscsi_tcp > > right now. Two 10G luns exported from an LIO target, attached dire

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Thu, Dec 22, 2016 at 05:50:12PM +1100, Dave Chinner wrote: > On Wed, Dec 21, 2016 at 09:46:37PM -0800, Linus Torvalds wrote: > > On Wed, Dec 21, 2016 at 9:13 PM, Dave Chinner wrote: > > > > > > There may be deeper issues. I just started running scalability tests > > >

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Wed, Dec 21, 2016 at 03:19:15PM -0800, Linus Torvalds wrote: > Hi, > > On Wed, Dec 21, 2016 at 2:16 PM, Dave Chinner <da...@fromorbit.com> wrote: > > On Fri, Dec 16, 2016 at 10:59:06AM -0800, Chris Leech wrote: > >> Thanks Dave, > >> > >> I'm

Re: iscsi: make mutex for target scanning and unbinding per-session

On Thu, Nov 10, 2016 at 05:22:44PM -0600, Mike Christie wrote: > On 11/07/2016 12:22 PM, Chris Leech wrote: > > Currently the iSCSI transport class synchronises target scanning and > > unbinding with a host level mutex. For multi-session hosts (offloading > > iSCSI HBAs)

Re: iscsi: make mutex for target scanning and unbinding per-session

On Thu, Nov 10, 2016 at 10:00:54AM -0800, The Lee-Man wrote: > On Monday, November 7, 2016 at 11:22:23 AM UTC-7, Chris Leech wrote: > > > > Currently the iSCSI transport class synchronises target scanning and > > unbinding with a host level mutex. For multi-session hosts (

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote: > > Sure! Count on us to test any patches. I guess the first step is to > reproduce on upstream right? We haven't tested specifically this > scenario for long time. Will try to reproduce on 4.9-rc4 and update here. Great, I'm

iscsi: make mutex for target scanning and unbinding per-session

, speeding up connecting to a large number of targets. Note that as iscsi_tcp creates a virtual host for each session, software iSCSI is effectively doing this already. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/scsi_transport_iscsi.c | 19 ++- includ

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

like having known list locking violations hanging around, based on an expectation that we'll never hit that path with well behaved targets. If we can get a fix worked up for the list locking here, can we get any testing on it from the original reports at IBM? That was very helpful in testing a full

Re: [PATCH 1/1] libfc: don't have fc_exch_find log errors on a new exchange

On Mon, Oct 24, 2016 at 04:37:59PM +0200, Hannes Reinecke wrote: > On 10/21/2016 11:10 PM, Chris Leech wrote: > >With the error message I added in "libfc: sanity check cpu number > >extracted from xid" I didn't account for the fact that fc_exch_find is > >called w

[PATCH 1/1] libfc: don't have fc_exch_find log errors on a new exchange

ally every exchange for a target. By checking the xid for FC_XID_UNKNOWN first, we not only prevent the erroneous error message, but skip the unnecessary lookup attempt as well. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/libfc/fc_exch.c | 3 +++ 1 file changed, 3 insertion

Re: [PATCH 2/2] be2iscsi: Replace _bh with _irqsave/irqrestore

ree_index=%d\n", > @@ -1078,7 +1087,7 @@ free_mgmt_sgl_handle(struct beiscsi_hba *phba, struct > sgl_handle *psgl_handle) > "BM_%d : Double Free in eh SGL ," > "eh_sgl_free_index=%d\n", >

Re: [PATCH 1/2] libiscsi: Fix locking in __iscsi_conn_send_pdu

ck and verifying that irqsave wasn't needed here, I was concerned about adding more interrupt disabled sections outside of the error handling paths. Reviewed-by: Chris Leech <cle...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2] libfc: sanity check cpu number extracted from xid

trying to use it. I'm currently looking at such a case, and I don't yet know why a cpu number > nr_cpu_ids is appearing in an exchange id. But adding a sanity check in libfc prevents a system panic, and seems like good idea when dealing with frames coming in from the network. Signed-off-by: Ch

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

his in user space, though, > than to limit the value range for the session ID here. > > Signed-off-by: Lee Duncan <ldun...@suse.com> Acked-by: Chris Leech <cle...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a m

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On Tue, Feb 16, 2016 at 12:40:12PM -0600, Mike Christie wrote: > On 02/15/2016 12:26 PM, Chris Leech wrote: > > On Fri, Feb 12, 2016 at 09:54:51AM -0800, James Bottomley wrote: > >> On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: > >>> The scsi_trans

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On Fri, Feb 12, 2016 at 09:54:51AM -0800, James Bottomley wrote: > On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: > > The scsi_transport_iscsi module already uses the ida_simple > > routines for managing the target ID, if requested to do > > so. This change replaces an ever-increasing atomic

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On Thu, Nov 12, 2015 at 4:03 AM, Sagi Grimberg wrote: > >> The bug is caused by this patch: >> >> 659743b02c411075b26601725947b21df0bb29c8 >> >> which allowed the task lists to be manipulated under different locks >> in the xmit and completion path. >> >> To fix the oops

Re: [Open-FCoE] [PATCH] fcoe:Fix incorrect use of non wrapper version of skb_buff helper function in fcoe_percpu_recieve_thread

On Sun, Sep 20, 2015 at 06:22:39PM -0400, Nicholas Krause wrote: > This fixes the incorrect use of the non wrapper version of the > function skb_dequeue in fcoe_percpu_receive_thread to use the > wrapper version as we need to protect avoid other users from > concurrently access on the sk_buff_head

[PATCH] iscsi: make mutex for target scanning and unbinding per-session

, speeding up connecting to a large number of targets. Note that as iscsi_tcp creates a virtual host for each session, software iSCSI is effectively doing this already. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/scsi_transport_iscsi.c | 19 ++- includ

Re: [PATCH] libiscsi: Fix host busy blocking during connection teardown

Bump. We've done some testing, and this does prevent a deadlock that can be triggered with a session logout while other sessions on the same HBA are under high IO load. I'd be nice to see this merged. - Chris On Tue, Jun 23, 2015 at 6:11 PM, John Soni Jose sony.j...@avagotech.com wrote:

Re: [PATCH] libiscsi: Fix host busy blocking during connection teardown

); iscsi_destroy_conn(cls_conn); } -- Looks good to me, solid reasoning on why host_busy is the wrong thing to check. Reviewed-by: Chris Leech cle...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] iSCSI: let session recovery_tmo sysfs writes persist across recovery

On Wed, Jun 17, 2015 at 09:33:04AM -0500, Mike Christie wrote: On 06/16/2015 06:07 PM, Chris Leech wrote: The iSCSI session recovery_tmo setting is writeable in sysfs, but it's also set every time a connection is established when parameters are set from iscsid over netlink. That results

[PATCH] iSCSI: let session recovery_tmo sysfs writes persist across recovery

once it's been modified via the sysfs interface. My thinking here is that the sysfs interface is much simpler for external tools to influence the session timeout, but if we're going to allow it to be modified directly we should ensure that setting is maintained. Signed-off-by: Chris Leech cle

iscsi flashnode bus? Re: [RFC PATCH 2/4] iscsi: sysfs filtering by network namespace

On Wed, May 13, 2015 at 03:12:45PM -0700, Chris Leech wrote: This makes the iscsi_host, iscsi_session, iscsi_connection, and iscsi_endpoint transport class devices only visible in sysfs under a matching network namespace. The network namespace for all of these objects is tracked

Re: [RFC PATCH 0/4] Make iSCSI network namespace aware

On Wed, May 20, 2015 at 11:45:43AM -0700, Andy Grover wrote: On 05/13/2015 03:12 PM, Chris Leech wrote: This is only about the structures and functionality involved in maintaining the iSCSI session, the SCSI host along with it's discovered targets and devices has no association

[PATCH RESEND] iscsi_tcp: consider session state in iscsi_sw_sk_state_check

are in the process of logging out. Signed-off-by: Chris Leech cle...@redhat.com Reviewed-by: Mike Christie micha...@cs.wisc.edu --- drivers/scsi/iscsi_tcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index 9e2588a..add6d15 100644 --- a/drivers/scsi

[PATCH v2] fnic: BUG: sleeping function called from invalid context during probe

hardware I had access to isn't actually attached to an FCoE SAN. Signed-off-by: Chris Leech cle...@redhat.com --- Patch Changelog v2: At Hiral's request I've bumped the driver version drivers/scsi/fnic/fnic.h | 2 +- drivers/scsi/fnic/fnic_main.c | 22 +- 2 files

[PATCH] iscsi_tcp: consider session state in iscsi_sw_sk_state_check

are in the process of logging out. Signed-off-by: Chris Leech cle...@redhat.com --- drivers/scsi/iscsi_tcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index 9e2588a..add6d15 100644 --- a/drivers/scsi/iscsi_tcp.c +++ b/drivers/scsi/iscsi_tcp.c @@ -116,6

[PATCH] fnic: BUG: sleeping function called from invalid context during probe

hardware I had access to isn't actually attached to an FCoE SAN. Signed-off-by: Chris Leech cle...@redhat.com --- drivers/scsi/fnic/fnic_main.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: The following series implements a move from using module parameters as control interfaces to /sys/bus/fcoe based interfaces. A sysfs infrastructure was added to the kernel a few cycles ago, this series builds on that

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

On Mon, Sep 10, 2012 at 5:05 PM, Bhanu Prakash Gollapudi bprak...@broadcom.com wrote: I'm concerned that we will be breaking user space compatibility with this change, as there should be a corresponding fcoemon/fipvlan change along with this, and existing utilities will not work. Also the way

Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project

Christoph Hellwig wrote: I just did a very quick glance over the tree. Some extremly highlevel comments to start with before actually starting the source review: Thanks for taking a look Christoph - why do you need your own libcrc? lib/crc32.c has a crc32_le We shouldn't, but we may