RE: aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't work

> I have already set up many drives of this size previously, using > ASR8xx5 controllers, without any problem. > > On another machine with a simple 8x1TB array, it doesn't work any better, > while > an older kernel works perfectly fine too: > > 4.14.48 : > > [ 61.069190] Adaptec aacraid

RE: aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't work

> After a very long time, it finally boots up and sees the disks, but > here's the output from dmesg | grep aacraid: > > [1.357760] Adaptec aacraid driver 1.2.1[50877]-custom > [1.388119] aacraid: Comm Interface type2 enabled > [3.405113] scsi host0: aacraid > [ 50.156024]

RE: aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't work

> -Original Message- > From: Dave Carroll > Sent: Wednesday, June 27, 2018 12:46 PM > To: Emmanuel Florac ; linux-scsi@vger.kernel.org > Cc: dl-esc-Aacraid Linux Driver > Subject: RE: aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't >

RE: aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't work

Hi Emmanual, > [ 346.869001] scsi host6: aacraid > [ 346.869500] scsi 6:0:2:0: Direct-Access ASR8885 raid3V1.0 > PQ: 0 > ANSI: 2 > [ 346.869692] sd 6:0:2:0: [sdb] Very big device. Trying to use READ > CAPACITY(16). > [ 346.869712] sd 6:0:2:0: [sdb] 632763166720 512-byte

[PATCH] aacraid: Correct hba_send to include iu_type

Misner <nmis...@us.ibm.com> cc: sta...@vger.kernel.org Signed-off-by: Dave Carroll <david.carr...@microsemi.com> Reviewed-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/commsup.c | 8 1 file changed, 4 insertions(+), 4 delet

RE: aacraid code passes GFP_DMA32 to kmalloc this will not work

> -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: Thursday, March 29, 2018 8:51 AM > To: dl-esc-Aacraid Linux Driver ; James E.J. > Bottomley ; Martin K. Petersen > ; SCSI development

[PATCH] aacraid: Insure command thread is not recursively stopped

cf8d4945ad95 ]- So flag when the thread is stopped by setting the thread pointer to NULL. Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/commsup.c | 4 +++- drivers/scsi/aacraid/linit.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/dr

RE: [PATCH] aacraid: fix shutdown crash when init fails

it down later. > > Fix it by returning error from aac_probe_one() when card-specific init > function > fails. > > This fixes reboot on my HP NetRAID-4M with dead battery. > > Signed-off-by: Meelis Roos <mr...@linux.ee> Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH 3/3] scsi: aacraid: Auto detect INTx or MSIx mode during sync cmd processing

rathnam <prasad.munirath...@microsemi.com> > Signed-off-by: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> > --- Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH 2/3] scsi: aacraid: Preserve MSIX mode in the OMR register

unta > <raghavaaditya.renuku...@microsemi.com> > --- > drivers/scsi/aacraid/src.c | 22 ++ > 1 file changed, 22 insertions(+) > Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH 1/3] scsi: aacraid: Implement DropIO sync command

s/scsi/aacraid/aacraid.h | 4 + > drivers/scsi/aacraid/src.c | 167 > +++-- > 2 files changed, 163 insertions(+), 8 deletions(-) Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH 1/3] scsi: aacraid: Check for PCI state of device in a generic way

ch makes use of generic PCI state checks, which are > lightweight and non-dependent of arch configs - also, it makes > the code cleaner. > > Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> > --- Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH] aacraid: use timespec64 instead of timeval

ut aacraid by that time. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH] scsi: aacraid: Add a small delay after IOP reset

> > > Guilherme, > > > James/Martin, am I expected to send a v2 with some change? Perhaps > > with Dave's ack? Sorry to annoy, thanks in advance for any advice! > > I was just about to mail Dave and ask for confirmation that your > interpretation > of the controller behavior is correct. >

RE: [PATCH] scsi: aacraid: Add a small delay after IOP reset

t; <raghavaaditya.renuku...@microsemi.com>; Dave Carroll > <david.carr...@microsemi.com>; brk...@linux.vnet.ibm.com; > dougm...@linux.vnet.ibm.com; sta...@vger.kernel.org > Subject: [PATCH] scsi: aacraid: Add a small delay after IOP reset > > Commit 0e9973ed3382 ("scsi: aacraid:

RE: [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

> Dave, > > > Hi Christoph, > > > >> > + if ((le32_to_cpu(dresp->status) == ST_OK) && > >> > + (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE)) { > >> > + _aac_probe_container2(context, fibptr); > >> > + return; > >> > >>

RE: [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

Hi Christoph, > > + if ((le32_to_cpu(dresp->status) == ST_OK) && > > + (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE)) { > > + _aac_probe_container2(context, fibptr); > > + return; > > if (dresp->status ==

RE: [PATCH] scsi: aacraid: error: testing array offset 'bus' after use

--- > drivers/scsi/aacraid/linit.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

[PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/aachba.c | 12 ++-- drivers/scsi/aacraid/aacraid.h | 5 + 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index 4591113..18a1a1f

RE: [PATCH] aacraid: Fix command send race condition

data pattern of > AAC_OWNER_FIRMWARE and it was at the same offset that aacraid writes, > which is scsicmd->SCp.phase. The patch below resolves this issue. > > Cc: stable<sta...@vger.kernel.org> > Signed-off-by: Brian King <brk...@linux.vnet.ibm.com> > --- > Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH 3/6] scsi: aacraid: constify pci_error_handlers structures

static const struct pci_error_handlers aac_pci_err_handler = { > .error_detected = aac_pci_error_detected, > .mmio_enabled = aac_pci_mmio_enabled, > .slot_reset = aac_pci_slot_reset, Acked-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH 2/2] scsi: aacraid: Off by one NUL terminator

> Dave, > > > The issue is that we are making an inquiry response from > > container/RAID info. We could also have included a "pad" byte to > > terminate the string, as the fib data is 512 bytes. My assumption is > > that somehow back in the day, someone managed to get odd characters > > into the

RE: [PATCH 2/2] scsi: aacraid: Off by one NUL terminator

> > Dan, > > > We're putting a NUL terminator one character beyond the end of the > > struct and that's obviously wrong. On the other hand, I'm not > > positive this is the correct fix. This change was added deliberately > > and was mentioned in the changlog of commit b836439faf04 ("aacraid:

RE: [PATCH 1/2] scsi: aacraid: reading out of bounds

> > Dan, > > > "qd.id" comes directly from the copy_from_user() on the line before so > > we should verify that it's within bounds. > > Applied to 4.13/scsi-fixes. Thanks! > > -- > Martin K. Petersen Oracle Linux Engineering Acked-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH 04/47] aacraid: use aac_tmf_callback for reset fib

> > > When sending a reset fib we shouldn't rely on the scsi command, but rather set > the TMF status in the map_info->reset_state variable. > That allows us to send a TMF independent on a scsi command. > > Signed-off-by: Hannes Reinecke > --- > /* > * aac_eh_dev_reset

RE: [PATCH 19/35] aacraid: split off lun reset function

-Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Hannes Reinecke > Sent: Friday, June 23, 2017 7:03 AM > To: Martin K. Petersen > Cc: Christoph Hellwig ; James Bottomley >

RE: [PATCH] scsi: aacraid: fix leak of data from stack back to userspace

#1435473 ("Uninitialized scalar variable") > > Fixes: 423400e64d377 ("scsi: aacraid: Include HBA direct interface") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- > drivers/scsi/aacraid/commctrl.c | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH V2 15/19] aacraid: Make sure ioctl returns on controller reset

> -Original Message- > From: Raghava Aditya Renukunta > [mailto:raghavaaditya.renuku...@microsemi.com] > Sent: Wednesday, May 10, 2017 10:40 AM > To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org > Cc: Dave Carroll <david.carr

RE: [PATCH V2 02/19] aacraid: Fix DMAR issues with iommu=pt

> -Original Message- > From: Raghava Aditya Renukunta > [mailto:raghavaaditya.renuku...@microsemi.com] > Sent: Wednesday, May 10, 2017 10:40 AM > To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org > Cc: Dave Carroll <david.carr

RE: [PATCH V2 01/19] aacraid: Remove __GFP_DMA for raw srb memory

> -Original Message- > From: Raghava Aditya Renukunta > [mailto:raghavaaditya.renuku...@microsemi.com] > Sent: Wednesday, May 10, 2017 10:40 AM > To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org > Cc: Dave Carroll <david.carr

RE: [PATCH v2 1/1] aacraid: pci_alloc_consistent() failures on ARM64

> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Tuesday, April 25, 2017 12:07 AM > To: Mahesh Rajashekhara <mahesh.rajashekh...@microsemi.com> > Cc: Dave Carroll <david.carr...@microsemi.com>; linux-scsi@vger.kernel.org

RE: [PATCH] scsi: aacraid: fix PCI error recovery path

org # v4.6+ > Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> > --- Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

RE: [PATCH] aacraid: Fix potential null access

> -Original Message- > From: Raghava Aditya Renukunta > [mailto:raghavaaditya.renuku...@microsemi.com] > Sent: Tuesday, March 14, 2017 10:20 AM > To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org > Cc: Dave Carroll; Gana Sridaran

RE: [PATCH] aacraid: Fix typo in blink status

Carpenter <dan.carpen...@oracle.com> > Signed-off-by: Raghava Aditya Renukunta > <raghavaaditya.renuku...@microsemi.com> > --- > drivers/scsi/aacraid/src.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

RE: [bug report] scsi: aacraid: Reorder Adapter status check

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > Sent: Monday, February 27, 2017 8:32 AM > To: Raghava Aditya Renukunta > Cc: linux-scsi@vger.kernel.org > Subject: [bug report] scsi: aacraid: Reorder

RE: [PATCH] scsi: aacraid: remove redundant zero check on ret

us we can remove the > zero check and also the dead-code non-zero case too. > > Detected by CoverityScan, CID#1411632 ("Logically Dead Code") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- > drivers/scsi/aacraid/commsup.c | 6 +- >

RE: [PATCH] aacraid: Fixed expander hotplug for SMART family

> -Original Message- > From: Raghava Aditya Renukunta > [mailto:raghavaaditya.renuku...@microsemi.com] > Sent: Wednesday, February 22, 2017 8:23 AM > To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org > Cc: Dave Carroll; Gana S

[PATCH] aacraid: Fix INTx/MSI-x issue with older controllers

.org Fixes: 78cbccd3bd683c295a44af8050797dc4a41376ff Reported-by: Arkadiusz Miskiewicz <a.miskiew...@gmail.com> Signed-off-by: Dave Carroll <david.carr...@microsemi.com> Reviewed-by: Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> --- drivers/scsi/aacraid/comminit.c | 8 ++--

RE: aacraid: kernel: AAC: Host adapter dead -1 (bisected)

> > > Hi. > > There is a bug with handling of adaptec raid cards (in my case it is Adaptec > 3405) where kernel logs hundreds of "AAC: Host adapter dead -1" > messages. > > Bug was reported previously on lkml but there was no progres in solving it. > > There is also bugzilla entry: >

[PATCH] aacraid: Check size values after double-fetch from user

Fixes: 7c00ffa31 '[SCSI] 2.6 aacraid: Variable FIB size (updated patch)' Cc: sta...@vger.kernel.org Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/commctrl.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aacraid/

[PATCH V2] aacraid: Check size values after double-fetch from user

Fixes: 7c00ffa31 '[SCSI] 2.6 aacraid: Variable FIB size (updated patch)' Cc: sta...@vger.kernel.org Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- drivers/scsi/aacraid/commctrl.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aacraid/

[PATCH] MAINTAINERS: Update email address for AACRAID

Update the email address for AACRAID from Adaptec to Microsemi Signed-off-by: Dave Carroll <david.carr...@microsemi.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2ebe195..a327ba2 100644 --- a/MAINTAINERS +++ b/MAINT