RE: [PATCH 19/55] scsi: Mark function as static in isci/phy.c

2014-03-31 Thread Dorau, Lukasz
On Saturday, March 29, 2014 7:04 PM Rashika Kheria rashika.khe...@gmail.com wrote: Mark function as static in isci/phy.c because it is not used outside this file. This eliminates the following warning in isci/phy.c: drivers/scsi/isci/phy.c:672:6: warning: no previous prototype for

RE: [PATCH 21/55] scsi: Mark function as static in isci/port.c

2014-03-31 Thread Dorau, Lukasz
On Saturday, March 29, 2014 7:07 PM Rashika Kheria rashika.khe...@gmail.com wrote: Mark function as static in isci/port.c because they are not used outside this file. This eliminates the following warning in isci/port.c: drivers/scsi/isci/port.c:65:13: warning: no previous prototype for

RE: [PATCH 20/55] scsi: Mark function as static in isci/remote_device.c

2014-03-31 Thread Dorau, Lukasz
On Saturday, March 29, 2014 7:05 PM Rashika Kheria rashika.khe...@gmail.com wrote: Mark function as static in isci/remote_device.c because it is not used outside this file. This eliminates the following warning in isci/remote_device.c: drivers/scsi/isci/remote_device.c:1387:6: warning: no

RE: [PATCH 19/55] scsi: Mark function as static in isci/phy.c

2014-03-31 Thread Dorau, Lukasz
On Monday, March 31, 2014 11:36 AM Josh Triplett j...@joshtriplett.org wrote: On Mon, Mar 31, 2014 at 08:54:49AM +, Dorau, Lukasz wrote: On Saturday, March 29, 2014 7:04 PM Rashika Kheria rashika.khe...@gmail.com wrote: Mark function as static in isci/phy.c because it is not used

RE: [PATCH v2 10/23] isci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-03-03 Thread Dorau, Lukasz
On Monday, February 24, 2014 9:02 AM Alexander Gordeev agord...@redhat.com wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or

RE: [PATCH 10/22] isci: Use pci_enable_msix_range()

2014-02-06 Thread Dorau, Lukasz
On Tuesday, February 04, 2014 12:17 PM Alexander Gordeev agord...@redhat.com wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and

RE: [PATCH] isci: update version to 1.2

2014-01-23 Thread Dorau, Lukasz
On Thursday, January 23, 2014 10:39 AM Lukasz Dorau lukasz.do...@intel.com wrote: The version of isci driver has not been updated for 2 years. It was 83 isci commits ago. Suspend/resume support has been implemented and many bugs have been fixed since 1.1. Now update the version to 1.2.

RE: [PATCH] isci: correct erroneous for_each_isci_host macro

2014-01-21 Thread Dorau, Lukasz
On Monday, January 20, 2014 7:26 PM Dan Williams dan.j.willi...@intel.com wrote: On Mon, Jan 20, 2014 at 8:54 AM, Lukasz Dorau lukasz.do...@intel.com wrote: In the first place, the loop 'for' in the macro 'for_each_isci_host' (drivers/scsi/isci/host.h:314) is incorrect, because it accesses

RE: [PATCH] isci: reformulate for_each_isci_host macro to fix an oops

2014-01-20 Thread Dorau, Lukasz
On Thursday, January 16, 2014 2:16 PM Lukasz Dorau lukasz.do...@intel.com wrote: The loop 'for' in macro 'for_each_isci_host' (drivers/scsi/isci/init.c:717) is executed more times than it can be. Regardless the condition: 'id ARRAY_SIZE(to_pci_info(pdev)-hosts)'

RE: Why is (2 2) true? Is it a gcc bug?

2014-01-18 Thread Dorau, Lukasz
alexei.starovoi...@gmail.com wrote: On Fri, Jan 17, 2014 at 5:37 AM, Dorau, Lukasz lukasz.do...@intel.com wrote: Hi My story is very simply... I applied the following patch: diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c --- a/drivers/scsi/isci/init.c +++ b

Why is (2 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
Hi My story is very simply... I applied the following patch: diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c --- a/drivers/scsi/isci/init.c +++ b/drivers/scsi/isci/init.c @@ -698,8 +698,11 @@ static int isci_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)

RE: Why is (2 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
On Friday, January 17, 2014 2:37 PM Dorau, Lukasz lukasz.do...@intel.com wrote: Hi My story is very simply... I applied the following patch: diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c --- a/drivers/scsi/isci/init.c +++ b/drivers/scsi/isci/init.c @@ -698,8

RE: Why is (2 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
On Friday, January 17, 2014 2:58 PM Richard Weinberger richard.weinber...@gmail.com wrote: Can you reproduce this using a standalone test? I.e: #include assert.h int main() { assert(2 2 != 1); return 0; } No, I can't of course. Lukasz -- To unsubscribe from

RE: Why is (2 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
On Friday, January 17, 2014 5:40 PM Sebastian Riemer sebastian.rie...@profitbricks.com wrote: On 17.01.2014 14:55, Dorau, Lukasz wrote: Some additional information: The loop 'for' in macro ' for_each_isci_host ' defined as (drivers/scsi/isci/host.h:313): #define for_each_isci_host

RE: [PATCH] isci: fix reset timeout handling

2013-12-10 Thread Dorau, Lukasz
On Monday, December 09, 2013 8:47 PM Williams, Dan J dan.j.willi...@intel.com wrote: Remove an erroneous BUG_ON() in the case of a hard reset timeout. If a SATA device is unable to restore the link in time we expect the port to go back to the awaiting link-up state. Since the timeout path

RE: [PATCH 14/19] scsi: Change variable type to bool

2013-09-23 Thread Dorau, Lukasz
On Sunday, September 22, 2013 12:28 AM Peter Senna Tschudin peter.se...@gmail.com wrote: The variable success is only assigned the values true and false. Change its type to bool. The simplified semantic patch that find this problem is as follows (http://coccinelle.lip6.fr/): @exists@

RE: [PATCH] scsi/isci/phy.c: Code tidiness, delete the redundant function call sci_change_state(iphy-sm, SCI_PHY_STOPPED)

2013-09-23 Thread Dorau, Lukasz
On 07/19/2013 Xinghai Yu yuxing...@cn.fujitsu.com wrote: The sci_phy_link_layer_initialization() was called only once in sci_phy_initialize() and it is called before a call of sci_change_state(iphy- sm, SCI_PHY_STOPPED). So the same call in the end of sci_phy_link_layer_initialization() is

RE: [PATCH] scsi/isci/port_config: Fix a infinite loop.

2013-07-31 Thread Dorau, Lukasz
On Wednesday, July 17, 2013 4:54 AM Xinghai Yu yuxing...@cn.fujitsu.com wrote: It seems the phy_index++; have been placed in wrong place, without it the while circle up will do a infinite loop. Signed-off-by: Xinghai Yu yuxing...@cn.fujitsu.com Acked-by: Lukasz Dorau lukasz.do...@intel.com

RE: [PATCH] isci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-04-04 Thread Dorau, Lukasz
On Tue, 26 Mar 2013 00:01:38 -0700 Jingoo Han jg1@samsung.com wrote: Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when the

4 isci patches from isci-for-3.6 tag?

2012-09-11 Thread Dorau, Lukasz
Hi James What are you going to do with the following four ISCI patches from isci-for-3.6 tag?: 6734092e66011def7875bd67beef889d0fee1cc9isci: add a couple __iomem annotations 67787c330762eb884bf8c169fe942263d55ec162isci: make function declaration match implementation