Hi All,
Since I made the same mistake myself I've done a quick grep for
GFP_DMA32 in the kernel and drivers/scsi/aacraid/commctrl.c
came up as a result of this grep, it does:
p = kmalloc(sg_count[i], GFP_KERNEL|GFP_DMA32);
But kmalloc always returns memory from
Hi,
On 10-01-18 16:23, Oliver Neukum wrote:
Am Mittwoch, den 10.01.2018, 08:13 +0100 schrieb Hans de Goede:
If we return 1 from our post_reset handler, then our disconnect handler
will be called immediately afterwards. Since pre_reset blocks all scsi
requests our disconnect handler
error")
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/usb/storage/uas.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 5d04c40ee40a..5471422aa1ab 100644
--- a/drivers/usb/storage/uas
Since commit 7fee72d5e8f1 ("uas: Always apply US_FL_NO_ATA_1X quirk to
Seagate devices"), the US_FL_NO_ATA_1X is always set for Seagate devices,
so the per device unusual_uas.h entries for Seagate devices can be
removed.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
dri
Hi,
On 15-11-17 10:06, Oliver Neukum wrote:
Am Dienstag, den 14.11.2017, 18:44 +0100 schrieb Hans de Goede:
Greg, please do no merge the 2 recent uas seagate quirks I send
then. I will submit a patch with the new approach right away.
Hi,
I am afraid in that case we will need a way
We've been adding this as a quirk on a per device basis hoping that
newer disk enclosures would do better, but that has not happened,
so simply apply this quirk to all Seagate devices.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/usb/storage/uas-detect.h | 4
Hi,
On 11/14/2017 04:25 PM, Alan Stern wrote:
On Tue, 14 Nov 2017, Hans de Goede wrote:
Hi,
On 14-11-17 15:00, Hans de Goede wrote:
Just like all previous UAS capable Seagate disk enclosures, this
one needs a US_FL_NO_ATA_1X quirk.
Cc: sta...@vger.kernel.org # 3.16
Reported-by: Wido <w
Hi,
On 14-11-17 15:00, Hans de Goede wrote:
Just like all previous UAS capable Seagate disk enclosures, this
one needs a US_FL_NO_ATA_1X quirk.
Cc: sta...@vger.kernel.org # 3.16
Reported-by: Wido <wido...@gmail.com>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
So far we've
Just like all previous UAS capable Seagate disk enclosures, this
one needs a US_FL_NO_ATA_1X quirk.
Cc: sta...@vger.kernel.org # 3.16
Reported-by: Wido <wido...@gmail.com>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 fil
Hi,
On 13-11-17 07:14, Jérôme Carretero wrote:
On Mon, 13 Nov 2017 07:01:30 +0300
Andrey Astafyev <1...@246060.ru> wrote:
13.11.2017 00:42, Jérôme Carretero пишет:
Nov 12 16:20:59 Bidule kernel: sd 22:0:0:0: [sdaa] tag#2
uas_eh_abort_handler 0 uas-tag 3 inflight: CMD OUT
[...]
Do you see
Just like all previous UAS capable Seagate disk enclosures, this
one needs a US_FL_NO_ATA_1X quirk.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Andrey Astafyev <1...@246060.ru>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/usb/storage/unusual_uas.h | 7 +++
Hi,
On 08-05-17 11:06, Ricard Wanderlof wrote:
On Mon, 8 May 2017, David Woodhouse wrote:
On Mon, 8 May 2017, David Woodhouse wrote:
Our empirical testing trumps your "can never happen" theory :)
I'm sure it does. But what is the explanation then? Has anyone analyzed
what is going on
Hi,
On 21-12-16 13:07, George Cherian wrote:
On 12/21/2016 05:12 PM, Oliver Neukum wrote:
On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote:
Hi Oliver,
I was working with this JMicron device and using the uas driver.
I am seeing the following 2 issues.
1) On connect I see the
Hi,
On 21-12-16 12:42, Oliver Neukum wrote:
On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote:
Hi Oliver,
I was working with this JMicron device and using the uas driver.
I am seeing the following 2 issues.
1) On connect I see the following messages.
Thanks. Do you want to submit it
USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+US_FL_NO_REPORT_OPCODES),
+
/* Reported-by: Hans de Goede <hdego...@redhat.com> */
UNUSUAL_DEV(0x2109, 0x0711, 0x, 0x,
"VIA",
->8
2) On disconnect I am seeing the follo
Oliver Neukum is taking over uas maintainership from me and
Gerd Hoffmann.
Cc: Oliver Neukum <oneu...@suse.com>
Cc: Gerd Hoffmann <kra...@redhat.com>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deleti
Hi,
On 13-06-16 14:05, Oliver Neukum wrote:
On Tue, 2016-05-31 at 09:18 +0200, Hans de Goede wrote:
Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level")
removed the scsi_change_queue_depth() call from uas_slave_configure()
assuming that the slave would inherit
Hi Greg,
There was some discussion about this patch during its initial posting,
but the concensus seems to be that this patch, which is in essence a
partial revert of the patch causing the problem, is the best way to fix
this.
So I'm resending this to make sure it does not fall through the
.t...@gmail.com>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/usb/storage/uas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 16bc679..ecc7d4b 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/us
Hi,
On 24-05-16 14:44, James Bottomley wrote:
On Tue, 2016-05-24 at 08:53 +0200, Hans de Goede wrote:
Hi,
On 23-05-16 19:36, James Bottomley wrote:
On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote:
Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host
level"
Hi,
On 24-05-16 10:18, Tom Yan wrote:
In this commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/usb/storage/uas.c?id=198de51dbc3454d95b015ca0a055b673f85f01bb
There is the following comment:
1 tag is reserved for untagged commands
So my question is, what
: Tom Yan <tom.t...@gmail.com>
I agree removing this is good:
Acked-by: Hans de Goede <hdego...@redhat.com>
Regards,
Hans
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 4d49fce..e03c490 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/st
Hi,
On 23-05-16 19:36, James Bottomley wrote:
On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote:
Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level")
removed the scsi_change_queue_depth() call from uas_slave_configure()
assuming that the slave would inherit
.t...@gmail.com>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/usb/storage/uas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 16bc679..ecc7d4b 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/us
Hi,
On 22-05-16 12:39, Tom Yan wrote:
With commit 198de51dbc3454d95b015ca0a055b673f85f01bb, uas no longer
set `queue_depth` with scsi_change_queue_depth(), so now `queue_depth`
of UAS drives are 1. Even though `can_queue` is set to
`devinfo->qdepth - 2`, but apparently that does not help, since
Hi,
On 23-04-16 23:10, Johannes Stezenbach wrote:
Hi,
I bought a new backup disk which turned out to be UAS capable,
but when I plugged it in I got an order 7 page allocation failure.
My hunch is that the .can_queue = 65536 in drivers/usb/storage/uas.c
is much too large. Maybe 256 would be a
Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with
an usb-id of: 0bc2:331a, as these will fail to respond to a
REPORT_LUNS command.
Cc: sta...@vger.kernel.org
Reported-and-tested-by: David Webb <d...@noc.ac.uk>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
C
1315013
Cc: sta...@vger.kernel.org # 4.4.x and 4.5.x
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
Changes in v2:
-Fix some spelling issues in the commit message and in a comment
---
drivers/usb/storage/uas.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --g
Hi,
On 31-03-16 17:11, James Bottomley wrote:
On Thu, 2016-03-31 at 17:03 +0200, Hans de Goede wrote:
Hi,
On 31-03-16 16:48, James Bottomley wrote:
On Thu, 2016-03-31 at 14:22 +0200, Hans de Goede wrote:
Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with
an usb-id of: 0bc2
Hi,
On 31-03-16 16:48, James Bottomley wrote:
On Thu, 2016-03-31 at 14:22 +0200, Hans de Goede wrote:
Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with
an usb-id of: 0bc2:331a, as these will fail to respond to a
REPORT_LUNS command.
Actually, if we're sending them a report
Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with
an usb-id of: 0bc2:331a, as these will fail to respond to a
REPORT_LUNS command.
Cc: sta...@vger.kernel.org
Reported-and-tested-by: David Webb <d...@noc.ac.uk>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
13
Cc: sta...@vger.kernel.org # 4.4.x and 4.5.x
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/usb/storage/uas.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index c90a7e4..b5cb7ab 100644
--- a/dri
Hi,
On 09-03-16 19:26, Christoph Hellwig wrote:
On Wed, Mar 09, 2016 at 06:58:48PM +0100, Hans de Goede wrote:
So my question is how do I tell the scsi layer to not submit more then X
commands with
scsi_init_shared_tag_map() gone ?
By setting ->can_queue in the Scsi_Host struct
Hi Christoph,
I've received a bug report that uas is causing a 2-disk enclosure to
lookup with 4.4 and later:
https://bugzilla.redhat.com/show_bug.cgi?id=1315013
Looking at the dmesg this stands out:
Mar 09 01:55:21 larry kernel: sd 2:0:0:1: [sdc] tag#31 uas_eh_abort_handler 0
uas-tag 32
with a "Page allocation
failure (order 7)" error on systems which have been running for a while
and thus have fragmented memory.
Cc: sta...@vger.kernel.org
Reported-and-tested-by: Yves-Alexis Perez <cor...@corsac.net>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers
Hi,
On 04-03-16 08:13, Yves-Alexis Perez wrote:
On mar., 2016-03-01 at 11:49 +0100, Hans de Goede wrote:
Hi,
On 01-03-16 10:42, Yves-Alexis Perez wrote:
Hi,
[sorry if this is not the right point for reporting bugs, I took the email
addresses from MAINTAINERS but please point me
Hi,
On 01-03-16 10:42, Yves-Alexis Perez wrote:
Hi,
[sorry if this is not the right point for reporting bugs, I took the email
addresses from MAINTAINERS but please point me to the correct place if needed]
I have an external USB drive (Samsung M3), which apparently uses the UAS code.
Starting
adds support
for US_FL_MAX_SECTORS_64 to uas.c.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Changes in v2:
-Document new 'g' flag in kernel-parameters.txt
-Add Cc stable@vger
---
Documentation/kernel-parameters.txt | 2 ++
drivers/usb/storage/uas.c
Testing has shown that ASM1053 devices do not work properly with transfers
larger than 240 sectors, so set max_sectors to 240 on these.
Cc: sta...@vger.kernel.org # 3.16
Reported-by: Steve Bangert sbang...@frontier.com
Signed-off-by: Hans de Goede hdego...@redhat.com
Tested-by: Steve Bangert
...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Changes in v2:
-Add Cc stable@vger
---
drivers/usb/storage/uas-detect.h | 6 +-
drivers/usb/storage/uas.c| 6 +++---
drivers/usb/storage/usb.c| 2 +-
3 files changed, 9 insertions(+), 5 deletions(-)
diff --git
-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas-detect.h | 6 +-
drivers/usb/storage/uas.c| 6 +++---
drivers/usb/storage/usb.c| 2 +-
3 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h
Testing has shown that ASM1053 devices do not work properly with transfers
larger than 240 sectors, so set max_sectors to 240 on these.
Reported-by: Steve Bangert sbang...@frontier.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas-detect.h | 5 -
1 file changed
adds support for
US_FL_MAX_SECTORS_64 to uas.c.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 10 +-
drivers/usb/storage/usb.c | 6 +-
include/linux/usb_usual.h | 2 ++
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/usb
: Benjamin Tissoires benjamin.tissoi...@redhat.com
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b/drivers/usb/storage
Like the JMicron JMS567 enclosures with the JMS539 choke on report-opcodes,
so avoid it.
Tested-and-reported-by: Tom Arild Naess tana...@gmail.com
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed
akinobu.m...@gmail.com
Cc: Hans de Goede hdego...@redhat.com
Cc: Tejun Heo t...@kernel.org
Cc: Christoph Hellwig h...@lst.de
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: linux-...@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Looks good to me:
Acked-by: Hans de Goede hdego...@redhat.com
Like some other uas devices these devices hang when a report-opcodes scsi
command is send to them.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1124119
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1
Just like all previous UAS capable Seagate disk enclosures, these need the
US_FL_NO_ATA_1X to not crash when udev probes them.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 14 ++
1 file changed, 14
descriptors are not 100% identical, unlike the previous
models the ASM1153 has bMaxPower == 0, so use that to differentiate it.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas-detect.h | 33 -
drivers/usb/storage/unusual_uas.h | 8
. Wong wrote:
On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote:
Hi,
On 09-12-14 20:31, Darrick J. Wong wrote:
Hi,
I have an Apricorn USB 3 disk dongle thing that claims to support UAS.
However, the kernel crashes when I plug it in[1].
Yes there are some known issues with uas
Looks good:
Acked-by: Hans de Goede hdego...@redhat.com
Greg, can you add this to your tree please ?
Regards,
Hans
---
drivers/usb/storage/unusual_uas.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b/drivers/usb/storage/unusual_uas.h
Hi,
On 09-12-14 20:31, Darrick J. Wong wrote:
Hi,
I have an Apricorn USB 3 disk dongle thing that claims to support UAS.
However, the kernel crashes when I plug it in[1].
Yes there are some known issues with uas error handling which are fixed
in 3.18, can you try with a 3.18 kernel please ?
Like the JMicron JMS567 enclosures with the JMS566 choke on report-opcodes,
so avoid it.
Tested-and-reported-by: Takeo Nakayama javh...@gmx.com
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7
This is yet another Seagate device which needs the US_FL_NO_ATA_1X quirk
Reported-by: Marcin Zajączkowski msz...@wp.pl
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git
These disks have a broken uas implementation, the tag field of the status
iu-s is not set properly, so we need to fall-back to usb-storage for these.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file
These drives hang when receiving ATA12 commands, so set the US_FL_NO_ATA_1X
quirk to filter these out.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb
These drives hang when receiving ATA12 commands, so set the US_FL_NO_ATA_1X
quirk to filter these out.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 14 ++
1 file changed, 14 insertions(+)
diff --git
involved code anyways also rename the uas_cmd_info stream
field to uas_tag, because when using uas over usb-2 streams are not used.
Cc: Christoph Hellwig h...@infradead.org
Reported-by: Douglas Gilbert dgilb...@interlog.com
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Christoph Hellwig
Just like some Seagate enclosures, these devices do not seem to grok ata
pass through commands.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage
Hi,
On 10/04/2014 04:46 PM, James Bottomley wrote:
On Sat, 2014-10-04 at 10:53 +0200, Hans de Goede wrote:
Hi,
On 10/03/2014 11:47 PM, Greg Kroah-Hartman wrote:
On Fri, Oct 03, 2014 at 12:08:57PM +0200, Hans de Goede wrote:
With uas over usb-3 the tags inside the uas iu-s must match the usb
Hi,
On 10/05/2014 11:10 AM, Christoph Hellwig wrote:
On Sun, Oct 05, 2014 at 11:06:00AM +0200, Hans de Goede wrote:
This patch sits on top of a lot of other uas fixes which are already
in usb-next, so this needs to go in through usb-next.
What is the actual conflict? If it's just your
Hi,
On 10/03/2014 11:47 PM, Greg Kroah-Hartman wrote:
On Fri, Oct 03, 2014 at 12:08:57PM +0200, Hans de Goede wrote:
With uas over usb-3 the tags inside the uas iu-s must match the usb-3 stream
ids, and those go from 1 - qdepth.
Before blk-mq calling scsi_activate_tcq(sdev, qdepth
this assumption. A fix is under way for 3.18, but sits on top of
large changes so can't easily be backported. Set the disable_blk_mq
path so that a uas device can't easily crash the system when using
blk-mq for SCSI.
Signed-off-by: Christoph Hellwig h...@lst.de
Acked-by: Hans de Goede hdego
The stream_id and pipe are already present in uas_cmd_info resp uas_dev_info,
so there is no need to pass a copy along.
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
drivers/usb/storage/uas.c | 29 ++---
1 file changed, 14
involved code anyways also rename the uas_cmd_info stream
field to uas_tag, because when using uas over usb-2 streams are not used.
Cc: Christoph Hellwig h...@infradead.org
Reported-by: Douglas Gilbert dgilb...@interlog.com
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Christoph Hellwig
The stream_id and pipe are already present in uas_cmd_info resp uas_dev_info,
so there is no need to pass a copy along.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git
involved code anyways also rename the uas_cmd_info stream
field to uas_tag, because when using uas over usb-2 streams are not used.
Cc: Christoph Hellwig h...@infradead.org
Reported-by: Douglas Gilbert dgilb...@interlog.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c
Hi,
On 10/02/2014 01:26 PM, Christoph Hellwig wrote:
Looks fine to me (and actually removes code..)
Reviewed-by: Christoph Hellwig h...@lst.de
It's fairly late in 3.17 to get something like this in, but would you
consider Ccing it to stable so we can get it into the first 3.17 stable
Hi,
On 10/02/2014 03:06 PM, Christoph Hellwig wrote:
On Thu, Oct 02, 2014 at 02:35:10PM +0200, Hans de Goede wrote:
This patch sits on top of a whole bunch of uas cleanups / fixes which
are going into 3.18, and which are to big of a change to backport.
Can add a patch to set disable_blk_mq
Hi,
On 10/02/2014 03:12 PM, Christoph Hellwig wrote:
On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote:
Yes, although that likely would need to go through stable, without
going into 3.18 .
Greg, is this ok with you and how do I get a patch in stable which
is not in upstream
Hi,
On 10/02/2014 03:25 PM, James Bottomley wrote:
On Thu, 2014-10-02 at 15:18 +0200, Hans de Goede wrote:
Hi,
On 10/02/2014 03:12 PM, Christoph Hellwig wrote:
On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote:
Yes, although that likely would need to go through stable, without
Hi Christoph,
Douglas Gilbert (in the CC), has been testing uas with
scsi_mod.blk_mq=Y and this fails. When it fails the following
messages appear in dmesg:
kernel: scsi host8: uas
kernel: blk-mq: reduced tag depth to 10240
mtp-probe: checking bus 2, device 3:
Hi,
On 10/01/2014 02:45 PM, Christoph Hellwig wrote:
On Wed, Oct 01, 2014 at 10:17:41AM +0200, Hans de Goede wrote:
The problematic part here, which I believe is caused by scsi_mod.blk_mq=Y,
is the tag number 33. uas.c does the following in slave_configure:
scsi_activate_tcq(sdev
As most ASM1051 based devices, this one has unfixable issues with uas too.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b
https://bbs.archlinux.org/viewtopic.php?pid=1457492
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b/drivers/usb/storage/unusual_uas.h
index 3e62437..94fb09f
Hi Greg, et al,
Another day, another uas quirk. Although you may not see it that way, this
is
actually a good thing :) With the new uas error handling code (which users
are
testing through a stand-alone version of the uas driver), people are now
actually sending me logs with useful error messages
a quirk
for this, and set it for the JMS567.
*) Which has become a non-issue since we've completely blacklisted uas on
the ASM1051 for other reasons
Cc: sta...@vger.kernel.org
Reported-and-tested-by: Claudio Bizzarri claudio.bizza...@gmail.com
Signed-off-by: Hans de Goede hdego...@redhat.com
for usb-storage
quirks.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
Changes in v3: Fix typo in documentation
Changes in v4: Also apply the quirk to (0bc2:3312)
---
Documentation/kernel
Hi Greg,
Sorry for the high number of iterations on this one. After the documentation
issues pointed out during review, I've just received a report from a user
that (as I already suspected) another seagate disk enclosure also benifits
from this quirk. So this version sets the quirk for 2
Hi,
On 09/15/2014 10:42 AM, David Laight wrote:
From: Alan Stern
...
p = quirks;
while (*p) {
@@ -543,6 +544,9 @@ void usb_stor_adjust_quirks(struct usb_device *udev,
unsigned long *fflags)
case 's':
f |= US_FL_SINGLE_LUN;
for usb-storage
quirks.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
Changes in v3: Fix typo in documentation
Changes in v4: Also apply the quirk to (0bc2:3312)
Changes in v5: Rebased
Hi,
On 09/15/2014 04:08 PM, Greg Kroah-Hartman wrote:
On Mon, Sep 15, 2014 at 04:04:12PM +0200, Hans de Goede wrote:
And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one
seems to hang upon receiving an ATA_12 or ATA_16 command.
https://bugzilla.kernel.org/show_bug.cgi
.
Reported-by: Hans de Goede hdego...@redhat.com
Signed-off-by: Christoph Hellwig h...@lst.de
---
include/scsi/scsi_tcq.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h
index cdcc90b..e645835 100644
--- a/include/scsi
Hi,
On 09/13/2014 09:31 PM, Sergei Shtylyov wrote:
Hello.
On 9/13/2014 1:26 PM, Hans de Goede wrote:
The data urbs are all killed before calling zap_pending, and their completion
handler should have cleared their inflight flag.
Do not 0 the data inflight flags, and add a check
While at it also add missing documentation for the u value for usb-storage
quirks.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
---
Documentation/kernel-parameters.txt
Hi,
On 09/13/2014 07:50 PM, Christoph Hellwig wrote:
On Sat, Sep 13, 2014 at 12:28:41PM +0200, Hans de Goede wrote:
Yes this one does the trick and fixes things. Note the git tree I used for
testing also had your previous fix to split up the blk_tcq union in 2
separate struct members. Let me
# 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
Changes in v3: Fix typo in documentation
---
Documentation/kernel-parameters.txt | 3 +++
drivers/usb/storage/uas.c | 13 +
drivers/usb/storage
Hi,
On 09/14/2014 12:29 PM, James Bottomley wrote:
On Sun, 2014-09-14 at 11:26 +0200, Hans de Goede wrote:
Hi,
On 09/13/2014 09:31 PM, Sergei Shtylyov wrote:
Hello.
On 9/13/2014 1:26 PM, Hans de Goede wrote:
The data urbs are all killed before calling zap_pending, and their
completion
And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one
seems to hang upon receiving an ATA_12 or ATA_16 command.
https://bugzilla.kernel.org/show_bug.cgi?id=79511
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c
Hi Greg,
As the subject indicates, if possible I would like to still get this into
3.17.
For now this impacts only a single usb-id, but looking at
https://bbs.archlinux.org/viewtopic.php?id=183190
It seems more seagate uas capable enclosures are having issues, I'm waiting
for feedback from
From: Sanjeev Sharma sanjeev_sha...@mentor.com
On some architecture spin_is_locked() always return false in
uniprocessor configuration and therefore it would be advise to replace
with lockdep_assert_held().
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
Signed-off-by: Hans de Goede
Hi Greg, et al,
Here is v2 of my uas error handling rewrite + cleanups series.
Note this has been rebased on top of the
[PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands
patch which I've just send, so if that does not make 3.17, you should still
apply that one
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 0b3d3a5..1dcaeee 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers
It was only used to sanity check against completing the same cmnd twice,
but that is the case we're likely operating on free-ed memory, and doing
sanity checks on free-ed memory is not really helpful.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 10
The data urbs are all killed before calling zap_pending, and their completion
handler should have cleared their inflight flag.
Do not 0 the data inflight flags, and add a check for try_complete succeeding,
as it should always succeed when called from zap_pending.
Signed-off-by: Hans de Goede
sense iu-s regardless, as can be seen for scsi cmnds where there is sense
data.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 47 +--
1 file changed, 1 insertion(+), 46 deletions(-)
diff --git a/drivers/usb/storage/uas.c
change various sanity checks (which should never trigger) from:
scmd_printk(KERN_ERR, cmnd, sanity foo failed\n) to calling the new
uas_log_cmd_state(), so that when they do trigger we get more info.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 52
in that case.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 61 ++-
1 file changed, 55 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index fca8775..f4fe816 100644
We've removed all hack from the driver for pre-production hardware.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index cbd4312..a77c5e0 100644
Check for both type of cancellation codes for sense and data urbs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 187e7bf
1 - 100 of 207 matches
Mail list logo
