Re: [PATCH 3/3] zfcp: drop open coded assignments of timer_list.function

2017-11-16 Thread Heiko Carstens
On Thu, Nov 16, 2017 at 01:38:18PM +0100, Steffen Maier wrote: > If this has not been picked/merged yet (it's not in Linus' tree yet), > could you please drop it because it's buggy? > > This would buy me time to come up with a proper solution, > otherwise I would be forced to fix it within

Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-23 Thread Heiko Carstens
VIRT_TO_BUS + select ARCH_HAS_SG_CHAIN Acked-by: Heiko Carstens heiko.carst...@de.ibm.com FWIW, it would have been nice to keep the list of selected configs sorted. However no need to resend. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [PATCH RESEND 0/9] zfcp features and bugfixes for 3.10 merge window

2013-04-27 Thread Heiko Carstens
On Fri, Apr 26, 2013 at 09:10:44AM -0700, James Bottomley wrote: On Fri, 2013-04-26 at 17:44 +0200, Steffen Maier wrote: On 04/26/2013 05:10 PM, James Bottomley wrote: On Fri, 2013-04-26 at 16:13 +0200, Steffen Maier wrote: James, here is a series of zfcp features and bugfixes.

[PATCH] libfcoe: fix section mismatches

2012-07-11 Thread Heiko Carstens
with the init section. So this patch only removes the compile time warning. Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com --- drivers/scsi/fcoe/fcoe_sysfs.c |2 +- drivers/scsi/fcoe/fcoe_transport.c |4 ++-- include/scsi/fcoe_sysfs.h |2 +- 3 files changed, 4

Re: [PATCH] zfcp: add some internal zfcp adapter statistics

2007-11-03 Thread Heiko Carstens
+static void zfcp_fsf_req_latency(struct zfcp_fsf_req *fsf_req) +{ + struct fsf_qual_latency_info *lat_inf; + struct zfcp_unit *unit; + + lat_inf = fsf_req-qtcb-prefix.prot_status_qual.latency_info; + unit = fsf_req-unit; + + switch

Re: [PATCH] zfcp: add some internal zfcp adapter statistics

2007-11-03 Thread Heiko Carstens
+ if (!(adapter-adapter_features FSF_FEATURE_MEASUREMENT_DATA)) { + ZFCP_LOG_NORMAL(error: Enhanced measurement feature not + supported); + return -EOPNOTSUPP; + } Btw. any user can flood the console with these messages if the adapter

Re: [PATCH 1/2] zfcp: whitespace cleanup

2007-09-08 Thread Heiko Carstens
/* - * function: + * function: * - * purpose: + * purpose: * * returns: If you do a whitespace cleanup you might as well kill these lines. They don't contain that much information... ;) - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: [PATCH 2/2] zfcp: zfcp: add statistics and other zfcp relatedinformation to sysfs

2007-09-08 Thread Heiko Carstens
+dev_set_drvdata(adapter-stat_services, adapter); + +if (device_register(adapter-stat_services)) +goto services_failed; + +if (zfcp_sysfs_statistic_services_create_files(adapter-stat_services)) +{ +device_unregister(adapter-stat_services); Sorry,

Re: [PATCH] zfcp: add statistics and other zfcp relatedinformation to sysfs

2007-09-06 Thread Heiko Carstens
- * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2, or (at your option) - * any later version. - * - * This program is distributed in

Re: [PATCH 3/3] zfcp: Don't report device as LUN 0 to SCSI stack

2007-06-18 Thread Heiko Carstens
On Mon, Jun 18, 2007 at 10:47:28AM +0200, Hannes Reinecke wrote: James Bottomley wrote: On Tue, 2007-05-29 at 15:29 +0200, Swen Schillig wrote: From: Christof Schmitt [EMAIL PROTECTED] zfcp reported units to the SCSI stack starting with number 0. LUN 0 reported to the SCSI stack is

Re: Proposals to change the way all drivers work with SCSI commands

2007-05-12 Thread Heiko Carstens
On Fri, May 11, 2007 at 01:33:41PM -0500, James Bottomley wrote: It strikes me that in all of this, we could also consider doing the DMA mapping inside the mid layer (instead of in every driver). This is essentially what libata is already doing ... leading to confusion in SCSI drivers that

zfcp: fix likely/unlikely usage

2007-02-21 Thread Heiko Carstens
From: Heiko Carstens [EMAIL PROTECTED] zfcp_fsf_protstatus_eval() takes always the 'wrong' branch. Likely Profiling Results - [+- ] Type | # True | # False | Function:[EMAIL PROTECTED] +unlikely | 11042|0

Re: [PATCH] zfcp: Invalid locking order

2007-02-08 Thread Heiko Carstens
On Wed, Feb 07, 2007 at 05:06:43PM +0100, Andreas Herrmann wrote: On Wed, Feb 07, 2007 at 01:17:57PM +0100, Swen Schillig wrote: From: Swen Schillig [EMAIL PROTECTED] Invalid locking order. Kernel hangs after trying to take two locks which are dependend on each other. Introducing

Re: [patch 17/30] scsi: fix uaccess handling

2006-12-15 Thread Heiko Carstens
On Fri, Dec 15, 2006 at 01:50:14PM -0600, James Bottomley wrote: On Mon, 2006-12-04 at 15:18 -0800, [EMAIL PROTECTED] wrote: From: Heiko Carstens [EMAIL PROTECTED] Signed-off-by: Heiko Carstens [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] No in current form

[PATCH] zfcp: updates for -bk

2005-01-24 Thread Heiko Carstens
Hi James, could you please apply the patch below? Thanks, Heiko From: Heiko Carstens [EMAIL PROTECTED] From: Andreas Herrmann [EMAIL PROTECTED] From: Maxim Shchetynin [EMAIL PROTECTED] zfcp changes: - revert kfree patch leftovers - don't call del_timer_sync() in interrupt context - correct

Re: [PATCH] zfcp: updates for -bk

2005-01-24 Thread Heiko Carstens
I thought that having release methods that just called kfree() were also verboten? We do a kmalloc(sizeof(struce device),...) somewhere and this is how we get rid of it again. How are we supposed to free this object otherwise? The release function gets called when there is no more