[PATCH 03/15] lpfc: refactor mailbox structure context fields

there were mixups. Refactored the structure so that the generic contexts become a node context and a buffer context and all code standardizes on their use. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 10 ++--- drivers/scsi/lpfc/lpfc_bsg.c

[PATCH 14/15] lpfc: Fix dif and first burst use in write commands

burst are used. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index e8c6f5de4440..14a62253b099 100644 --- a/drivers

[PATCH 11/15] lpfc: Correct code setting non existent bits in sli4 ABORT WQE

field settings - initialize to zero, don't bother to set fields to zero. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 2 -- drivers/scsi/lpfc/lpfc_sli.c | 14 +++--- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCH 05/15] lpfc: Fix a duplicate 0711 log message number.

Renumber one of the 0711 log messages so there isn't a duplication. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index

[PATCH 08/15] lpfc: rport port swap discovery issue.

. Clean up the node swap so that the NLP_RPI_REGISTERED flag is handled properly. Fix the handling of the fc4_types when the nodes are swapped as well Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 43 +++ 1 file

[PATCH 10/15] lpfc: Defer LS_ACC to FLOGI on point to point logins

o an FLOGI (if not yet received). Fortunately, to implement this, it only took another state flag and deferring any FLOGI response if the FLOGI has yet to be transmit. All subsequent actions were already in place. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h

[PATCH 07/15] lpfc: Cap NPIV vports to 256

. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 3 ++- drivers/scsi/lpfc/lpfc_attr.c | 12 ++-- drivers/scsi/lpfc/lpfc_init.c | 3 +++ 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc

[PATCH 09/15] lpfc: ls_rjt erroneus FLOGIs

-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 20 drivers/scsi/lpfc/lpfc_hw.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index e4cf648c951b..48610bcd6962 100644

[PATCH 12/15] lpfc: Correct topology type reporting on G7 adapters

-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 5 +++-- drivers/scsi/lpfc/lpfc_mbox.c | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index feaaa015150e..83924d66fd39 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c

[PATCH 06/15] lpfc: Fix kernel Oops due to null pring pointers

checking to lpfc_phba_elsring() and status checking to all callers. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 6 ++ drivers/scsi/lpfc/lpfc_els.c | 2 ++ drivers/scsi/lpfc/lpfc_init.c | 7 ++- drivers/scsi/lpfc/lpfc_sli.c | 2 ++ 4 files

[PATCH 15/15] lpfc: update driver version to 12.0.0.9

Update the driver version to 12.0.0.9 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index d0b2dd9b737f

[PATCH 13/15] lpfc: Fix driver release of fw-logging buffers

-by: James Smart --- drivers/scsi/lpfc/lpfc_bsg.c | 22 ++ drivers/scsi/lpfc/lpfc_crtn.h | 1 + drivers/scsi/lpfc/lpfc_init.c | 11 +-- drivers/scsi/lpfc/lpfc_sli.c | 19 +++ 4 files changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/scsi

[PATCH 04/15] lpfc: Fix discovery failures during port failovers with lots of vports

vs the RPI registrations. Filter out multiple UNREG_RPIs being queued up for the same remote port. Beef up log messages in this area. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_crtn.h | 1 - drivers/scsi/lpfc/lpfc_debugfs.c | 2 ++ drivers/scsi

[PATCH 00/15] lpfc updates for 12.0.0.9

Update lpfc to revision 12.0.0.9 This patch contains lpfc bug fixes The patches were cut against Martin's 4.21/scsi-queue tree James Smart (15): lpfc: Fix panic when FW-log buffsize is not initialized lpfc: update manufacturer attribute to reflect Broadcom lpfc: refactor mailbox

[PATCH 01/15] lpfc: Fix panic when FW-log buffsize is not initialized

as an error, not only a couple codes Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_bsg.c | 16 +++- drivers/scsi/lpfc/lpfc_init.c | 3 ++- drivers/scsi/lpfc/lpfc_sli.c | 14 -- 3 files changed, 21 insertions(+), 12 deletions(-) diff

[PATCH 02/15] lpfc: update manufacturer attribute to reflect Broadcom

Update manufacturer attribute to reflect Broadcom Inc, not Emulex Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_ct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c index

Re: [PATCH] scsi: lpfc: fix block guard enablement on SLI3 adapters

pfc_init.c | 6 +- drivers/scsi/lpfc/lpfc_sli.c | 1 - 2 files changed, 5 insertions(+), 2 deletions(-) thanks Signed-off-by:  James Smart -- james

Re: [PATCH v4 5/5] qla2xxx: Update driver version to 11.00.00.00-k

On 10/31/2018 9:40 AM, Himanshu Madhani wrote: Signed-off-by: Himanshu Madhani --- Reviewed-by:  James Smart  -- james

Re: [PATCH v4 4/5] qla2xxx_nvmet: Add SysFS node for FC-NVMe Target

On 10/31/2018 9:40 AM, Himanshu Madhani wrote: From: Anil Gurumurthy This patch adds SysFS node for NVMe Target configuration Signed-off-by: Anil Gurumurthy Signed-off-by: Himanshu Madhani --- looks good to me. Reviewed-by:   James Smart  -- james

Re: [PATCH v4 3/5] qla2xxx_nvmet: Add FC-NVMe Target handling

On 10/31/2018 9:40 AM, Himanshu Madhani wrote: From: Anil Gurumurthy This patch Adds following code in the driver to support FC-NVMe Target - Updated ql2xenablenvme to allow FC-NVMe Target operation - Added Link Service Request handling for NVMe Target - Added passthru IOCB for LS4 request

Re: [PATCH v4 2/5] qla2xxx_nvmet: Add files for FC-NVMe Target support

a couple more comments On 10/31/2018 9:40 AM, Himanshu Madhani wrote: +/* + * qla_nvmet_handle_abts + * Handle an abort from the initiator + * Invoke nvmet_fc_rcv_fcp_abort to pass the abts to the nvmet + */ +int qla_nvmet_handle_abts(struct scsi_qla_host *vha, + struct

Re: [PATCH v4 2/5] qla2xxx_nvmet: Add files for FC-NVMe Target support

On 10/31/2018 9:40 AM, Himanshu Madhani wrote: From: Anil Gurumurthy This patch adds files to enable NVMe Target Support Signed-off-by: Anil Gurumurthy Signed-off-by: Giridhar Malavali Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvmet.c |

Re: [PATCH v4 1/5] qla2xxx_nvmet: Add FC-NVMe Target Link Service request handling

On 10/31/2018 9:40 AM, Himanshu Madhani wrote: From: Anil Gurumurthy This patch provides link service pass through feature handling in the driver. This feature is implemented mainly by the firmware and the same implementation is handled in the driver via an IOCB interface. Signed-off-by:

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

that have to be parsed? Sigh. It's already been solved, there's no need for this attribute. nvme-fc already sends a uevent whenever a new nvme rport is attached, (check nvme_fc_register_remoteport()->nvme_fc_signal_discovery_scan(). James Smart added a sysfs entry for retrigger

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

been solved, there's no need for this attribute. nvme-fc already sends a uevent whenever a new nvme rport is attached, (check nvme_fc_register_remoteport()->nvme_fc_signal_discovery_scan(). James Smart added a sysfs entry for retriggering these uevents, and I've posted a set of scri

Re: [PATCH v4 0/5] qla2xxx: Add FC-NVMe Target support

Madhani, I'll be looking through it over the weekend. -- james On 11/8/2018 8:58 AM, Madhani, Himanshu wrote: Hi James, Any more review comments? On Oct 31, 2018, at 9:40 AM, Himanshu Madhani wrote: Hi Martin, This series adds support for FC-NVMe Target. Patch #1 adds infrastructure

Re: [PATCH v3 2/5] qla2xxx_nvmet: Add files for FC-NVMe Target support

On 9/28/2018 3:46 PM, Himanshu Madhani wrote: + .target_features= NVMET_FCTGTFEAT_READDATA_RSP | + NVMET_FCTGTFEAT_CMD_IN_ISR | + NVMET_FCTGTFEAT_OPDONE_IN_ISR, Himanshu, I'm looking at these but had

[PATCH 09/12] lpfc: Correct loss of fc4 type on remote port address change

Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 27 +++ drivers/scsi/lpfc/lpfc_nportdisc.c | 5 +++-- 2 files changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index a200cdaf34a6

[PATCH 04/12] lpfc: Reset link or adapter instead of doing infinite nameserver PLOGI retry

. This brings back connectivity to the nameserver. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_crtn.h | 1 + drivers/scsi/lpfc/lpfc_els.c | 83 ++- 2 files changed, 83 insertions(+), 1 deletion(-) diff --git

[PATCH 00/12] lpfc updates for 12.0.0.8

This patch contains lpfc bug fixes and 2 enhancements. The patches were cut against Martin's 4.20/scsi-queue tree James Smart (12): lpfc: Correct speeds on SFP swap lpfc: Fix lpfc_sli4_read_config return value check lpfc: Fix LOGO/PLOGI handling when triggerd by ABTS Timeout event lpfc

[PATCH 07/12] lpfc: Correct LCB RJT handling

When LCB's are rejected, if beaconing was already in progress, the Reason Code Explanation was not being set. Should have been set to command in progress. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 12/12] lpfc: update driver version to 12.0.0.8

Update the driver version to 12.0.0.8 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 5a0d512ff497

[PATCH 08/12] lpfc: Fix odd recovery in duplicate FLOGIs in point-to-point

is received after the link is already up and FLOGI's accepted. While debugging the issue, realized that some debug traces should be clarified to help in the future. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_els.c | 66

[PATCH 10/12] lpfc: Implement GID_PT on Nameserver query to support faster failover

Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_attr.c | 14 +++ drivers/scsi/lpfc/lpfc_crtn.h | 1 + drivers/scsi/lpfc/lpfc_ct.c| 206 + drivers/scsi/lpfc/lpfc_els.c | 10 +- drivers

[PATCH 01/12] lpfc: Correct speeds on SFP swap

. If READ_CONFIG fails, set supported speeds to unknown and log. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 63 +++ 1 file changed, 46 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c

[PATCH 03/12] lpfc: Fix LOGO/PLOGI handling when triggerd by ABTS Timeout event

;good" and the XRI quarantined for a exchange qualifier window. - PLOGI is issued as soon a LOGO state is resolved. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 49 -- drivers/scsi/lpfc/lpfc_nportdisc.c | 5 +++

[PATCH 06/12] lpfc: fcoe: Fix link down issue after 1000+ link bounces

between FLOGI's. Fix by monitoring FLOGI failures and once a repeated error is seen repeat FCF discovery. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 2 ++ drivers/scsi/lpfc/lpfc_hbadisc.c | 20 drivers/scsi/lpfc/lpfc_init.c

[PATCH 11/12] lpfc: add Trunking support

s of 128GB and 256GB. Added handling of trunk-related ACQEs, mainly logging and trapping of physical link statuses. Added additional bsg interface to query trunk state by applications. Augment link_state sysfs attribtute to display trunk link status Signed-off-by: Dick Kennedy Signed-off-by: J

[PATCH 02/12] lpfc: Fix lpfc_sli4_read_config return value check

An error is an error - but not to the existing return value check. Revise check to handle any failure, not just EIO. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi

[PATCH 05/12] lpfc: Correct errors accessing fw log

Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_bsg.c | 64 +--- 1 file changed, 25 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c index 7bd7ae86bed5..eb2e8c941b78 100644 --- a/drivers/scsi/lpfc

[PATCH v2] lpfc: Synchronize access to remoteport via rport

the dereferences. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- v2: Needed to reinit nrport to NULL at start of every ndlp check --- drivers/scsi/lpfc/lpfc_attr.c| 15 ++- drivers/scsi/lpfc/lpfc_debugfs.c | 10 +- drivers/scsi/lpfc/lpfc_nvme.c| 11

Re: [PATCH] lpfc: Synchronize access to remoteport via rport

On 9/12/2018 4:28 PM, James Smart wrote: The driver currently uses the ndlp to get the local rport which is then used to get the nvme transport remoteport pointer. There can be cases where a stale remoteport pointer is obtained as synchronization isn't done through the different dereferences

[PATCH] lpfc: Synchronize access to remoteport via rport

the dereferences. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c| 16 ++-- drivers/scsi/lpfc/lpfc_debugfs.c | 10 +- drivers/scsi/lpfc/lpfc_nvme.c| 11 --- 3 files changed, 23 insertions(+), 14 deletions(-) diff --git

[PATCH 10/11] lpfc: add support to retrieve firmware logs

attribute enables or disables loggy by firmware. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 25 drivers/scsi/lpfc/lpfc_attr.c | 32 drivers/scsi/lpfc/lpfc_bsg.c | 341 +- drivers/scsi/lpfc/lpfc_bsg.h

[PATCH 11/11] lpfc: update driver version to 12.0.0.7

Update the driver version to 12.0.0.7 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 501249509af4

[PATCH 08/11] lpfc: Fix errors in log messages.

Message 6408 is displayed for each entry in an array, but the cpu and queue numbers were incorrect for the entry. Message 6001 includes an extraneous character. Resolve both issues Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 2 +- drivers/scsi

[PATCH 07/11] lpfc: Correct invalid EQ doorbell write on if_type=6

doorbell format. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 495de99ed82d..99fddd056675 100644 --- a/drivers/scsi

[PATCH 09/11] lpfc: reduce locking when updating statistics

the lock. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index 200b5bca1f5f..f2d5420be413 100644

[PATCH 06/11] lpfc: Correct irq handling via locks when taking adapter offline

rom the lpfc_els_retry_delay routine and recursively requests the same phba->hbalock spinlock causing deadlock. Address the deadlocks by creating a new port_list lock. The softirq behavior can then be managed a level deeper into the calling sequences. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- d

[PATCH 04/11] lpfc: Correct race with abort on completion path

, null the pointer using an xchg operation rather than under lock. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc

[PATCH 05/11] lpfc: Correct soft lockup when running mds diagnostics

ng routine to 64 elements. This ensures that the cpu will be given up and the handler reschedule to process additional items. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/lpfc/lp

[PATCH 02/11] lpfc: raise sg count for nvme to use available sg resources

Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 3 +- drivers/scsi/lpfc/lpfc_attr.c | 69 +++--- drivers/scsi/lpfc/lpfc_init.c | 42 ++--- drivers/scsi/lpfc/lpfc_nvme.c | 13 ++-- drivers/scsi/lpfc/lpfc_nvmet.c

[PATCH 03/11] lpfc: Raise nvme defaults to support a larger io and more connectivity

requests to for larger nvme configs. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 7d81f44630ee..9d2397b795f4 100644

[PATCH 00/11] lpfc updates for 12.0.0.7

This patch contains lpfc bug fixes, a couple of performance mods, and a new diagnostic ability The patches were cut against Martin's 4.19/scsi-queue tree James Smart (11): lpfc: Fix GFT_ID and PRLI logic for RSCN lpfc: raise sg count for nvme to use available sg resources lpfc: Raise nvme

[PATCH 01/11] lpfc: Fix GFT_ID and PRLI logic for RSCN

in the DEVICE_RECOVERY state. Also ensure that rport registration is done for all nlp_fc4_types. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_ct.c| 5 - drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- drivers/scsi/lpfc/lpfc_nportdisc.c | 3 +++ 3 files changed, 4

[PATCH] lpfc: Correct MDS diag and nvmet configuration

: Add MDS Diagnostic support.") Cc: # 4.12 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h index e0d0da5f43d6..43732e8d1347 100644 ---

[PATCH] lpfc: Default fdmi_on to on

Change default behavior for fdmi registration to on. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index

[PATCH 3/8] lpfc: Fix list corruption on the completion queue.

pointers to the original io that has already completed, and the io manipulation (for the second time) corrupts the list. Correct by taking the ring lock early in the abort handler so the erroneous abort won't be sent if the io has/is completing. Signed-off-by: Dick Kennedy Signed-off-by: James

[PATCH 7/8] lpfc: Remove lpfc_enable_pbde as module parameter

Enablement of the PBDE optimization brought out some incompatible behaviors under error scenarios. Best to disable and remove the PBDE optimization. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 12 ++-- 1 file changed, 2 insertions(+), 10

[PATCH 8/8] lpfc: update driver version to 12.0.0.6

Update the driver version to 12.0.0.6 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index a669af45fce7

[PATCH 2/8] lpfc: Fix sysfs Speed value on CNA ports

CNA ports were showing speed as "unknown" even if the link is up. Add speed decoding for FCOE-based adapters Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers

[PATCH 6/8] lpfc: Correct LCB ACCept payload

-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index df655f1284d0..4dda969e947c 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -5662,6 +5662,7

[PATCH 0/8] lpfc updates for 12.0.0.6

This patch contains lpfc bug fixes The patches were cut against the Martin's 4.19/scsi-queue tree James Smart (8): lpfc: Fix ELS abort on SLI-3 adapters lpfc: Fix sysfs Speed value on CNA ports lpfc: Fix list corruption on the completion queue. lpfc: Fix driver crash when re-registering

[PATCH 1/8] lpfc: Fix ELS abort on SLI-3 adapters

For ABORT_XRI_CN command, firmware identifies XRI to abort by IOTAG and RPI combination. For ELS aborts, driver specifies IOTAG correctly but RPI is not specified. Fix by setting RPI in WQE. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nportdisc.c | 3

[PATCH 5/8] lpfc: Limit tracking of tgt queue depth in fast path

by only performing the target increment/decrement when the target queue depth is less than the overall adapter depth, thus is actually meaningful. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_disc.h | 3 ++ drivers/scsi/lpfc/lpfc_nportdisc.c | 6

[PATCH 4/8] lpfc: Fix driver crash when re-registering NVME rports.

, then ndlp value from at rport. Note the entering ndlp may be replacing by the rport->ndlp due to an address change swap. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) d

[PATCH 07/10] lpfc: Fix NVME Target crash in defer rcv logic

in callback routine to detect this condition and log a message, then bail. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvmet.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc

[PATCH 09/10] lpfc: update driver version to 12.0.0.5

Update the driver version to 12.0.0.5 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 18c23afcf46b

[PATCH 08/10] lpfc: devloss timeout race condition caused null pointer reference

igned-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 5 + drivers/scsi/lpfc/lpfc_sli.c | 13 + 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index c31c43f43553..5e4

[PATCH 10/10] lpfc: Revise copyright for new company language

Change references from "Broadcom Limited" to "Broadcom Inc." in the copyright message. Update copyright duration if not yet updated for 2018. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/Makefile | 4 ++-- drivers/scsi/lpfc/

[PATCH 06/10] lpfc: Support duration field in Link Cable Beacon V1 command

Current implementation missed setting the duration field. Correct the code to set the field. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 64 +++ drivers/scsi/lpfc/lpfc_hw.h | 18 +++- drivers/scsi

[PATCH 05/10] lpfc: Make PBDE optimizations configurable

the PBDE optimizations aren't supported in all firmware revs. Make to optimizations configurable in case there's a side effect on old firmware. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 3 +-- drivers/scsi/lpfc/lpfc_attr.c | 10

[PATCH 00/10] lpfc updates for 12.0.0.5

This patch contains lpfc bug fixes and some minor functional additions. The patches were cut against the Martin's 4.18/scsi-queue tree James Smart (10): lpfc: Add Buffer overflow check, when nvme_info larger than PAGE_SIZE lpfc: Fix driver not setting dpp bits correctly in doorbell word

[PATCH 04/10] lpfc: Fix abort error path for NVMET

was not cleaned up properly and lpfc_sli4_xri_exchange_busy_wait silently hung forever. Clean failed abort properly and make lpfc_sli4_xri_exchange_busy_wait not hangs silently while waiting for aborts to complete. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc

[PATCH 02/10] lpfc: Fix driver not setting dpp bits correctly in doorbell word

Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 4b70d53acb72..74547f437813 100644 --- a/drivers/scsi/lpfc/lpfc_s

[PATCH 03/10] lpfc: Fix panic if driver unloaded when port is offline

System crashes when the lpfc module is unloaded after making the port offline The nvme queue pointers were freed during port offline, but were later accessed in pci remove path. Validate the pointers in pci remove path before accessing them. Signed-off-by: Dick Kennedy Signed-off-by: James

[PATCH 01/10] lpfc: Add Buffer overflow check, when nvme_info larger than PAGE_SIZE

ncated to fit within PAGE_SIZE bytes. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 432 +- 1 file changed, 257 insertions(+), 175 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpf

[PATCH 2/6] lpfc: correct oversubscription of nvme io requests for an adapter

enn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c | 7 +++ drivers/scsi/lpfc/lpfc_nportdisc.c | 6 ++ drivers/scsi/lpfc/lpfc_nvme.c | 23 +++ 3 files changed, 32 insertions(+), 4 deletions(-) diff --g

[PATCH 5/6] lpfc: Fix port initialization failure.

even on the older adapters. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_init.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.

[PATCH 4/6] lpfc: Fix 16gb hbas failing cq create.

page sizes. As knowing the actual chip revision is unnecessary, the now unused definitions are removed Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_hw4.h | 11 --- drivers/scsi/lpfc/lpfc

[PATCH 6/6] lpfc: update driver version to 12.0.0.4

Update the driver version to 12.0.0.4 Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version

[PATCH 3/6] lpfc: Fix crash in blk_mq layer when executing modprobe -r lpfc

eep alive. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_nvme.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c ind

[PATCH 0/6] lpfc updates for 12.0.0.4

This patch contains lpfc bug fixes and a few message updates and cleanups. The patches were cut against the Martin's 4.18/scsi-queue tree James Smart (6): lpfc: Fix MDS diagnostics failure (Rx < Tx) lpfc: correct oversubscription of nvme io requests for an adapter lpfc: Fix cr

[PATCH 1/6] lpfc: Fix MDS diagnostics failure (Rx < Tx)

. lpfc_drain_txq attempts to submit IOCBS that are queued in ELS txq but MDS frames are posted to FCP WQ. Attempt to submit IOCBs that are present in FCP txq when MDS loopback is running. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com>

[PATCH 01/10] lpfc: Change IO submit return to EBUSY if remote port is recovering

status codes to the blk-mq layer. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_nvme.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/l

[PATCH 04/10] lpfc: Handle new link fault code returned by adapter firmware.

tus. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_hw4.h | 1 + drivers/scsi/lpfc/lpfc_init.c | 31 ++- 2 files changed, 15 insertions(+), 17 deletions(-) diff -

[PATCH 06/10] lpfc: Check if SCSI scanning is complete, before allowing I/O commands

such that it will be retried. If so, then normal processing resumes. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_scsi.c | 48 +++ drivers/scsi/lpfc/lpfc

[PATCH 08/10] lpfc: Enhance log messages when reporting CQE errors

Enhance log messages for CQEs as they were not reporting certain fields. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_sli.c | 23 --- 1 file changed, 16 insertions(+),

[PATCH 09/10] lpfc: update driver version to 12.0.0.3

Update the driver version to 12.0.0.3 Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version

[PATCH 05/10] lpfc: Driver NVME load fails when CPU cnt > WQ resource cnt

to SCSI and the control/ELS path, and scale down if necessary. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_init.c | 34 ++ 1 file changed, 34 insertions(+) diff --g

[PATCH 10/10] lpfc: Comment cleanup regarding Broadcom copyright header

Fix small formatting and wording nits in Broadcom copyright header Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c| 2 +- drivers/scsi/lpfc/lpfc_debugfs.c | 2 +- drivers/scsi/lpf

[PATCH 07/10] lpfc: Fix up log messages and stats counters in IO submit code path

Fix up log messages and add an fcp error stat counter in the IO submit code path to make diagnosing problems easier Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c| 3 ++- drive

[PATCH 00/10] lpfc updates for 12.0.0.3

This patch contains lpfc bug fixes and a few message updates and cleanups. The patches were cut against the Martin's 4.17/scsi-queue tree James Smart (10): lpfc: Change IO submit return to EBUSY if remote port is recovering lpfc: enhance LE data structure copies to hardware lpfc: Correct

[PATCH 02/10] lpfc: enhance LE data structure copies to hardware

to not change things for the minor optimization. Thus PPC 64-bit systems sticks with doing 32-bit copies. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_sli.c | 56 +--

[PATCH 03/10] lpfc: Correct fw download error message

error. Revise the initial checks to validate the image vs asic type so that the correct message is displayed and the download process is avoided. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpf

[PATCH v2 04/13] lpfc: Enlarge nvmet asynchronous receive buffer counts

for a configurable number of buffers to be posted to each RQ, using the new attribute lpfc_nvmet_mrq_post. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/scsi/lpfc/lpfc.h

[PATCH v2 13/13] lpfc: update driver version to 12.0.0.2

Update the driver version to 12.0.0.2 Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v2 08/13] lpfc: Fix WQ/CQ creation for older asic's.

and limit them to the restricted sizes. Fixes: c176ffa0841c ("scsi: lpfc: Increase CQ and WQ sizes for SCSI") Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> Reviewed-by: Hannes Reinecke <h...@suse.com> ---

[PATCH v2 10/13] lpfc: Fix nvme remoteport registration race conditions

, it is only cleared when the wait has not been superceded by a prior registration. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/scsi/lpfc/lpfc_nvme.c | 16 ++

[PATCH v2 06/13] lpfc: Fix lingering lpfc_wq resource after driver unload

. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> Reviewed-by: Hannes Reinecke <h...@suse.com> --- drivers/scsi/lpfc/lpfc_init.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a

  1   2   3   4   5   6   7   8   9   10   >