Re: [PATCH RESEND v2] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-08-01 Thread Jan Vesely
On Mon 25 Mar 2013 20:40:09 CET, Jens Axboe wrote: On Mon, Mar 25 2013, Jan Vesely wrote: 51506edc5741209311913 On Mon 25 Mar 2013 15:24:57 CET, Jens Axboe wrote: On Mon, Mar 25 2013, Jan Vesely wrote: v2: changed a comment The original behavior was to refuse all pages after the maximum

[PATCH 0/2] mpt{2,3}sas remove disconnected phys on topology change

2013-08-01 Thread Jan Vesely
From: Jan Vesely jves...@redhat.com These two patches add phy removal on link loss. This change keeps sysfs up-to-date with actually connected phys. Without these patches, disconnected phys remain listed under their former ports. tested on both mpt2sas and mpt3sas hw. CC: Nagalakshmi Nandigama

[PATCH 1/2] mpt2sas: Remove phys on topology change.

2013-08-01 Thread Jan Vesely
From: Jan Vesely jves...@redhat.com CC: Nagalakshmi Nandigama nagalakshmi.nandig...@lsi.com CC: Sreekanth Reddy sreekanth.re...@lsi.com CC: Tomas Henzl the...@redhat.com Signed-off-by: Jan Vesely jves...@redhat.com --- drivers/scsi/mpt2sas/mpt2sas_transport.c |5 - 1 files changed, 4

[PATCH 2/2] mpt3sas: Remove phys on topology change

2013-08-01 Thread Jan Vesely
From: Jan Vesely jves...@redhat.com CC: Nagalakshmi Nandigama nagalakshmi.nandig...@lsi.com CC: Sreekanth Reddy sreekanth.re...@lsi.com CC: Tomas Henzl the...@redhat.com Signed-off-by: Jan Vesely jves...@redhat.com --- drivers/scsi/mpt3sas/mpt3sas_transport.c |5 - 1 files changed, 4

Re: [PATCH v4 0/2] block: Fix regression since 46081b166415acb66d4b3150ecefcd9460bb48a1 (was: Allow merging of tail pages into the last segment)

2013-07-26 Thread Jan Vesely
On 12/07/13 17:52, Jan Vesely wrote: Hi These patches modify __bio_add_page to accept pages that extent the last bio segment. some drivers craft their buffers and rely on this behavior (see message in patch 2 for details) jan v4: whitespace fixes to make checkpatch happy v3: Use

[PATCH v4 2/2] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-07-12 Thread Jan Vesely
From: Jan Vesely jves...@redhat.com The original behavior was to refuse all pages after the maximum number of segments has been reached. However, some drivers (like st) craft their buffers to potentially require exactly max segments and multiple pages in the last segment. This patch modifies

[PATCH v4 0/2] block: Allow merging of tail pages into the last segment

2013-07-12 Thread Jan Vesely
Hi These patches modify __bio_add_page to accept pages that extent the last bio segment. some drivers craft their buffers and rely on this behavior (see message in patch 2 for details) jan v4: whitespace fixes to make checkpatch happy v3: Use code from __blk_recalc_rq_segments to decide

[PATCH v4 1/2] block: factor out vector mergeable decision to a helper function

2013-07-12 Thread Jan Vesely
From: Jan Vesely jves...@redhat.com Export the function so it can be used to predict segment counts without calling the recalc function. This will be used in the next patch. Signed-off-by: Jan Vesely jves...@redhat.com CC: Alexander Viro v...@zeniv.linux.org.uk CC: James Bottomley james.bottom

[PATCH] [SCSI] scsilun_to_int should ignore the highest 2 bits

2013-06-06 Thread Jan Vesely
From: Jan Vesely jves...@redhat.com The comment says the function does this but it does not. Reported luns change from weirdly high numbers (like 16640) to something saner (256), when using flat space addressing. CC: James Bottomley jbottom...@parallels.com CC: Dan Williams dan.j.willi

Re: [PATCH] [SCSI] scsilun_to_int should ignore the highest 2 bits

2013-06-06 Thread Jan Vesely
On Thu 06 Jun 2013 10:42:16 CEST, Hannes Reinecke wrote: On 06/06/2013 10:18 AM, Jan Vesely wrote: From: Jan Vesely jves...@redhat.com The comment says the function does this but it does not. Reported luns change from weirdly high numbers (like 16640) to something saner (256), when using

Re: block: Allow merging of tail pages into the last segment

2013-06-03 Thread Jan Vesely
On 16/04/13 10:24, Jan Vesely wrote: On 28/03/13 10:38, Jan Vesely wrote: Hi These patches modify __bio_add_page to accept pages that extent the last bio segment. some drivers craft their buffers and rely on this behavior (see message in patch 2 for details) any comments on this version

Re: block: Allow merging of tail pages into the last segment

2013-04-16 Thread Jan Vesely
On 28/03/13 10:38, Jan Vesely wrote: Hi These patches modify __bio_add_page to accept pages that extent the last bio segment. some drivers craft their buffers and rely on this behavior (see message in patch 2 for details) any comments on this version would be appreciated thanks jan

block: Allow merging of tail pages into the last segment

2013-03-28 Thread Jan Vesely
a comment Jan Vesely (2): block: factor out vector mergeable decision to a helper function block: modify __bio_add_page check to accept pages that don't start a new block/blk-merge.c | 52 +++- fs/bio.c| 29

[PATCH v3 1/2] block: factor out vector mergeable decision to a helper function

2013-03-28 Thread Jan Vesely
Export the function so it can be used to predict segment counts without calling the recalc function. This will be used in the next patch. Signed-off-by: Jan Vesely jves...@redhat.com Cc: Alexander Viro v...@zeniv.linux.org.uk Cc: James Bottomley james.bottom...@hansenpartnership.com Cc: Jens

[PATCH v3 2/2] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-03-28 Thread Jan Vesely
be merged into the last segment. Fixes EBUSY failures when using large tape block size in high memory fragmentation condition. This regression was introduced by commit 46081b166415acb66d4b3150ecefcd9460bb48a1 st: Increase success probability in driver buffer allocation Signed-off-by: Jan Vesely jves

Re: [PATCH] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-03-25 Thread Jan Vesely
On Thu 07 Mar 2013 12:23:13 CET, Jan Vesely wrote: On Thu 21 Feb 2013 09:30:26 CET, Jan Vesely wrote: The original behavior was to refuse all pages after the maximum number of segments has been reached. However, some drivers (like st) craft their buffers to potentially require exactly max

[PATCH RESEND v2] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-03-25 Thread Jan Vesely
-by: Jan Vesely jves...@redhat.com CC: Alexander Viro v...@zeniv.linux.org.uk CC: FUJITA Tomonori fujita.tomon...@lab.ntt.co.jp CC: Kai Makisara kai.makis...@kolumbus.fi CC: James Bottomley james.bottom...@hansenpartnership.com CC: Jens Axboe ax...@kernel.dk CC: sta...@vger.kernel.org --- fs/bio.c

Re: [PATCH RESEND v2] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-03-25 Thread Jan Vesely
On Mon 25 Mar 2013 15:24:57 CET, Jens Axboe wrote: On Mon, Mar 25 2013, Jan Vesely wrote: v2: changed a comment The original behavior was to refuse all pages after the maximum number of segments has been reached. However, some drivers (like st) craft their buffers to potentially require

Re: [PATCH v2] st: Take additional queue ref in st_probe

2013-03-15 Thread Jan Vesely
On 05/03/13 16:57, Joe Lawrence wrote: Changes from v1: Corrected error paths as noted by Ewan Milne and Jan Vesely. thanks, Acked-by: Jan Vesely jves...@redhat.com These changes were applied to scsi.git, branch misc. This patch fixes a reference count bug in the SCSI tape driver

Re: [PATCH] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-03-07 Thread Jan Vesely
Hi Jens, I have added you to cc, I'm not sure who to bug to get this patch merged. thanks, Jan Vesely On Thu 21 Feb 2013 09:30:26 CET, Jan Vesely wrote: The original behavior was to refuse all pages after the maximum number of segments has been reached. However, some drivers (like st) craft

Re: [PATCH] st: Take additional queue ref in st_probe

2013-03-05 Thread Jan Vesely
: spin_lock(st_index_lock); idr_remove(st_index_idr, dev_num); spin_unlock(st_index_lock); +out_put_queue: + blk_put_queue(disk-queue); out_put_disk: put_disk(disk); kfree(tpnt); -- - Jan Vesely jves...@redhat.com -- To unsubscribe from this list: send

[PATCH] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-02-21 Thread Jan Vesely
be merged into the last segment. This change fixes EBUSY failures when using large (1mb) tape block size in high memory fragmentation condition. Signed-off-by: Jan Vesely jves...@redhat.com --- fs/bio.c | 26 -- 1 files changed, 16 insertions(+), 10 deletions(-) diff --git