[patch] sg: clean up gfp_mask in sg_build_indirect

nd there's only one user of the gfp_mask. Just or in the __GFP_ZERO flag at the top of the function and be done with it. Signed-off-by: Jeff Moyer p.s. I'm not even sure why the original patch was committed -- it does nothing for security. I assume that the zeroing isn't done for CAP

Re: [PATCH] preview - block layer help to detect sequential IO

Hi, Kashyap, I'm CC-ing Kent, seeing how this is his code. Kashyap Desai writes: > Objective of this patch is - > > To move code used in bcache module in block layer which is used to > find IO stream. Reference code @drivers/md/bcache/request.c >

Re: RFC: 512e ZBC host-managed disks

Christoph Hellwig writes: > On Thu, Jan 12, 2017 at 05:13:52PM +0900, Damien Le Moal wrote: >> (3) Any other idea ? > > Do nothing and ignore the problem. This whole idea so braindead that > the person coming up with the T10 language should be shot. Either a device > has 511

Re: [LSF/MM TOPIC] blk-trace update vs API stability

Hannes Reinecke writes: > At LSF I'd like to discuss > - Do we consider blktrace (and any other tracepoint in eg SCSI) as a > stable API? I don't have a strong opinion on this. > - How do we go about modifying blktrace? Blktrace has a version number associated with trace events.

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

Shaun Tancheff <shaun.tanch...@seagate.com> writes: > On Tue, Oct 18, 2016 at 11:58 AM, Jeff Moyer <jmo...@redhat.com> wrote: >> Damien Le Moal <damien.lem...@wdc.com> writes: >> >>> + if (!is_power_of_2(zone_blocks)

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

"Martin K. Petersen" <martin.peter...@oracle.com> writes: >>>>>> "Jeff" == Jeff Moyer <jmo...@redhat.com> writes: > > Jeff, > > Jeff> Are power of 2 zone sizes required by the standard? I see why > Jeff> you've done this,

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

Damien Le Moal writes: > + if (!is_power_of_2(zone_blocks)) { > + if (sdkp->first_scan) > + sd_printk(KERN_NOTICE, sdkp, > + "Devices with non power of 2 zone " > + "size are

Re: [PATCH v8 2/7] blk-sysfs: Add 'chunk_sectors' to sysfs attributes

Damien Le Moal writes: > diff --git a/Documentation/ABI/testing/sysfs-block > b/Documentation/ABI/testing/sysfs-block > index 75a5055..ee2d5cd 100644 > --- a/Documentation/ABI/testing/sysfs-block > +++ b/Documentation/ABI/testing/sysfs-block > @@ -251,3 +251,16 @@

Re: HDD Unrecovered readerror issue

Dmitry Monakhov writes: > But once I rewrite this block, problem goes away. > #xfs_io -c "pwrite -S 0x0 $((80069000/2))k 4k" -d /dev/sda > > Now I can read it w/o any errors and smartctl is happy > #smartctl -t short /dev/sda > #smartctl -l selftest /dev/sda > Num

Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

Mike Christie <mchri...@redhat.com> writes: > On 05/03/2016 03:44 PM, Jeff Moyer wrote: >> Hi, Mike, >> >> That git tree doesn't seem to exist. I did manage to apply your patch >> set on top of next-20160415, though. >> >> So... what testing did

Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

mchri...@redhat.com writes: > The following patches begin to cleanup the request->cmd_flags and > bio->bi_rw mess. We currently use cmd_flags to specify the operation, > attributes and state of the request. For bi_rw we use it for similar > info and also the priority but then also have another

Re: [PATCH 03/12] BUG: Losing bits on request.cmd_flags

Shaun Tancheff writes: > In a few places a temporary value smaller than a cmd_flags > is used to test for bits and or build up a new cmd_flags. > > Change to use explicit u64 values where appropriate. This is not a bug fix, so please fix your subject. I'm not against

Re: [PATCH 2/3] block: Add badblock management for gendisks

"Verma, Vishal L" <vishal.l.ve...@intel.com> writes: > On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: >> >> I'm not sure whether it makes sense to continue without badblock >> management for the RAID code.  I was hoping Neil would comment on >>

Re: [PATCH 2/3] block: Add badblock management for gendisks

"Verma, Vishal L" <vishal.l.ve...@intel.com> writes: > On Tue, 2015-11-24 at 10:34 -0500, Jeff Moyer wrote: >> Vishal Verma <vishal.l.ve...@intel.com> writes: >> >> > NVDIMM devices, which can behave more like DRAM rather than block >> > dev

Re: [PATCH 2/3] block: Add badblock management for gendisks

Vishal Verma writes: > NVDIMM devices, which can behave more like DRAM rather than block > devices, may develop bad cache lines, or 'poison'. A block device > exposed by the pmem driver can then consume poison via a read (or > write), and cause a machine check. On

Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq

fix. Reviewed-by: Jeff Moyer jmo...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] block: bsg.c: Cleaning up missing null-terminate in conjunction with strncpy

Rickard Strandqvist rickard_strandqv...@spectrumdigital.se writes: Replacing strncpy with strlcpy to avoid strings that lacks null terminate. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- block/bsg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: scsi-mq V2

Benjamin LaHaise b...@kvack.org writes: [ 186.339064] ioctx_alloc: nr_events=-2 aio_max_nr=65536 [ 186.339065] ioctx_alloc: nr_events=-2 aio_max_nr=65536 [ 186.339067] ioctx_alloc: nr_events=-2 aio_max_nr=65536 [ 186.339068] ioctx_alloc: nr_events=-2 aio_max_nr=65536 [ 186.339069]

Re: scsi-mq V2

Elliott, Robert (Server Storage) elli...@hp.com writes: -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Thursday, 10 July, 2014 11:15 AM To: Elliott, Robert (Server Storage) Cc: Jens Axboe; dgilb...@interlog.com; James Bottomley; Bart Van Assche;

Re: scsi-mq V2

Jeff Moyer jmo...@redhat.com writes: Hi, Rob, Can you get sysrq-t output for me? I don't know how/why we'd continue to get io_submits for an exiting process. Also, do you know what sys_io_submit is returning? -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: scsi-mq V2

Jens Axboe ax...@kernel.dk writes: On 2014-07-10 17:11, Jeff Moyer wrote: Benjamin LaHaise b...@kvack.org writes: [ 186.339064] ioctx_alloc: nr_events=-2 aio_max_nr=65536 [ 186.339065] ioctx_alloc: nr_events=-2 aio_max_nr=65536 [ 186.339067] ioctx_alloc: nr_events=-2 aio_max_nr=65536

Re: [PATCH 2/6] io: define an interface for IO extensions

Darrick J. Wong darrick.w...@oracle.com writes: Define a generic interface to allow userspace to attach metadata to an IO operation. This interface will be used initially to implement protection information (PI) pass through, though it ought to be usable by anyone else desiring to extend the

Re: [RFC PATCH 0/5] userspace PI passthrough via AIO/DIO

Darrick J. Wong darrick.w...@oracle.com writes: This RFC provides a rough implementation of a mechanism to allow userspace to attach protection information (e.g. T10 DIF) data to a disk write and to receive the information alongside a disk read. The interface is an extension to the AIO

Re: [LSF/MM TOPIC] atomic block device

James Bottomley james.bottom...@hansenpartnership.com writes: OK, so what the Database people are currently fretting about is how the Linux cache fights with the WAL. Pretty much all DBs sit on filesystems these days, so the first question is are block operations even relevant Yes, they are

Re: [patch] block: fix race between request completion and timeout handling

Ewan Milne emi...@redhat.com writes: If the request completes after blk_mark_rq_complete() is called but before blk_clear_req_complete() is called, the completion will not be processed, and we will have to wait for the request to timeout again. Maybe this is not so bad, as it should be

[patch] block: fix race between request completion and timeout handling

, but nothing more. Signed-off-by: Jeff Moyer jmo...@redhat.com Acked-by: Hannes Reinecke h...@suse.de diff --git a/block/blk-core.c b/block/blk-core.c index 93a18d1..236ae0a 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -2229,6 +2229,7 @@ void blk_start_request(struct request *req

Re: [patch|rfc] block: fix race between request completion and timeout handling

Hannes Reinecke h...@suse.de writes: So, looked into things a bit more. It looks as if you're on the right track, although I doubt your patch will fix the issue for me :-( Thing is, you're right there is a race window between requeuing and softirq triggering, which could well be fixed by

[patch|rfc] block: fix race between request completion and timeout handling

Hi, We have several reports (against a distro kernel) of panics in blk_requeue_request that look like this: kernel BUG at block/blk-core.c:1045! invalid opcode: [#1] SMP last sysfs file: /sys/devices/pci:40/:40:03.0/:55:00.0/infiniband_mad/umad0/port CPU 0 Modules linked in:

Re: [RFC/PATCH 4/4] block: Add URGENT request notification support to CFQ scheduler

Tanya Brokhman tlin...@codeaurora.org writes: When the scheduler reports to the block layer that there is an urgent request pending, the device driver may decide to stop the transmission of the current request in order to handle the urgent one. This is done in order to reduce the latency of

[patch] scsi_dh_hp_sw.c: return DEV_OFFLINED when blk_get_request fails

Hi, If blk_get_requet fails here, it means that the queue is dead. It seems better to return a DEV_OFFLINED error code than the misleading TEMP_UNAVAIL. Comments? Signed-off-by: Jeff Moyer jmo...@redhat.com diff --git a/drivers/scsi/device_handler/scsi_dh_hp_sw.c b/drivers/scsi

Re: [LSF/MM TOPIC][ATTEND] protection information and userspace

Boaz Harrosh bharr...@panasas.com writes: I also pondered simply adding a new io_prep_* function + IO_CMD_ code to libaio and all the other plumbing necessary to make that happen... void io_prep_preadv_pi(struct iocb *iocb, int fd, const struct iovec *iov, int iovcnt,

Re: [patch,v3,repost 00/10] make I/O path allocations more numa-friendly

James Bottomley james.bottom...@hansenpartnership.com writes: On Mon, 2012-12-10 at 12:59 -0500, Jeff Moyer wrote: Jeff Moyer jmo...@redhat.com writes: Hi, This patch set makes memory allocations for data structures used in the I/O path more numa friendly by allocating them from

Re: [patch,v3,repost 00/10] make I/O path allocations more numa-friendly

Jeff Moyer jmo...@redhat.com writes: Hi, This patch set makes memory allocations for data structures used in the I/O path more numa friendly by allocating them from the same numa node as the storage device. I've only converted a handful of drivers at this point. My testing is limited

[patch,v3,repost 00/10] make I/O path allocations more numa-friendly

patch, as Al pointed out some fundamental problems with it - credited Bart van Assche properly Jeff Moyer (10): scsi: add scsi_host_alloc_node scsi: make __scsi_alloc_queue numa-aware scsi: make scsi_alloc_sdev numa-aware scsi: allocate scsi_cmnd-s from the device's local numa node sd: use

[patch,v3,repost 06/10] ata: use scsi_host_alloc_node

Acked-by: Jeff Garzik jgar...@redhat.com Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/ata/libata-scsi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index e3bda07..9d5dd09 100644 --- a/drivers/ata

[patch,v3,repost 01/10] scsi: add scsi_host_alloc_node

Allow an LLD to specify on which numa node to allocate scsi data structures. Thanks to Bart Van Assche for the suggestion. Reviewed-by: Bart Van Assche bvanass...@acm.org Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/hosts.c | 13 +++-- include/scsi/scsi_host.h

[patch,v3,repost 03/10] scsi: make scsi_alloc_sdev numa-aware

Use the numa node id set in the Scsi_Host to allocate the sdev structure on the device-local numa node. Reviewed-by: Bart Van Assche bvanass...@acm.org Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi_scan.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[patch,v3,repost 07/10] megaraid_sas: use scsi_host_alloc_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/megaraid/megaraid_sas_base.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index d2c5366..707a6cd 100644

[patch,v3,repost 10/10] cciss: use blk_init_queue_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/block/cciss.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index b0f553b..5fe5546 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -1930,7 +1930,8

[patch,v3,repost 09/10] lpfc: use scsi_host_alloc_node

Acked-By: James Smart james.sm...@emulex.com Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/lpfc/lpfc_init.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 7dc4218..65956d3 100644

[patch,v3,repost 08/10] mpt2sas: use scsi_host_alloc_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/mpt2sas/mpt2sas_scsih.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c index af4e6c4..a4d6b36 100644 --- a/drivers/scsi/mpt2sas

[patch,v3,repost 05/10] sd: use alloc_disk_node

Reviewed-by: Bart Van Assche bvanass...@acm.org Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 12f6fdf..a5dae6b 100644 --- a/drivers/scsi/sd.c +++ b/drivers

[patch,v3,repost 02/10] scsi: make __scsi_alloc_queue numa-aware

Pass the numa node id set in the Scsi_Host on to blk_init_queue_node in order to keep all allocations local to the numa node the device is closest to. Reviewed-by: Bart Van Assche bvanass...@acm.org Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi_lib.c |3 ++- 1 files

[patch,v3,repost 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node

Reviewed-by: Bart Van Assche bvanass...@acm.org Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2936b44..1750702 100644 --- a/drivers/scsi

Re: [patch,v2 00/10] make I/O path allocations more numa-friendly

- From: Jeff Moyer [mailto:jmo...@redhat.com] Sent: Monday, 12 November, 2012 3:27 PM To: Bart Van Assche Cc: Elliott, Robert (Server Storage); linux-scsi@vger.kernel.org Subject: Re: [patch,v2 00/10] make I/O path allocations more numa-friendly Bart Van Assche bvanass...@acm.org writes

Re: [patch,v2 00/10] make I/O path allocations more numa-friendly

Bart Van Assche bvanass...@acm.org writes: On 11/09/12 21:46, Jeff Moyer wrote: On 11/06/12 16:41, Elliott, Robert (Server Storage) wrote: It's certainly better to tie them all to one node then let them be randomly scattered across nodes; your 6% observation may simply be from that. How do

[patch,v3 00/10] make I/O path allocations more numa-friendly

structure member dependent on CONFIG_NUMA - Got rid of a GFP_ZERO I added accidentally changes from v1-v2: - got rid of the vfs patch, as Al pointed out some fundamental problems with it - credited Bart van Assche properly Jeff Moyer (10): scsi: add scsi_host_alloc_node scsi: make

[patch,v3 02/10] scsi: make __scsi_alloc_queue numa-aware

Pass the numa node id set in the Scsi_Host on to blk_init_queue_node in order to keep all allocations local to the numa node the device is closest to. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi_lib.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[patch,v3 09/10] lpfc: use scsi_host_alloc_node

Acked-By: James Smart james.sm...@emulex.com Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/lpfc/lpfc_init.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 7dc4218..65956d3 100644

[patch,v3 10/10] cciss: use blk_init_queue_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/block/cciss.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index b0f553b..5fe5546 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -1930,7 +1930,8

[patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2936b44..1750702 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -173,16

[patch,v3 05/10] sd: use alloc_disk_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 12f6fdf..a5dae6b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2714,7 +2714,7 @@ static int

[patch,v3 03/10] scsi: make scsi_alloc_sdev numa-aware

Use the numa node id set in the Scsi_Host to allocate the sdev structure on the device-local numa node. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi_scan.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi

[patch,v3 01/10] scsi: add scsi_host_alloc_node

Allow an LLD to specify on which numa node to allocate scsi data structures. Thanks to Bart Van Assche for the suggestion. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/hosts.c | 13 +++-- include/scsi/scsi_host.h | 28 2 files changed

[patch,v3 08/10] mpt2sas: use scsi_host_alloc_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/mpt2sas/mpt2sas_scsih.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c index af4e6c4..a4d6b36 100644 --- a/drivers/scsi/mpt2sas

[patch,v3 06/10] ata: use scsi_host_alloc_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/ata/libata-scsi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index e3bda07..9d5dd09 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c

[patch,v3 07/10] megaraid_sas: use scsi_host_alloc_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/megaraid/megaraid_sas_base.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index d2c5366..707a6cd 100644

Re: [patch,v2 00/10] make I/O path allocations more numa-friendly

Bart Van Assche bvanass...@acm.org writes: On 11/06/12 16:41, Elliott, Robert (Server Storage) wrote: It's certainly better to tie them all to one node then let them be randomly scattered across nodes; your 6% observation may simply be from that. How do you think these compare, though (for

Re: [patch,v2 01/10] scsi: add scsi_host_alloc_node

Bart Van Assche bvanass...@acm.org writes: On 11/02/12 22:45, Jeff Moyer wrote: diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index 593085a..7d7ad8b 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -336,16 +336,25 @@ static struct device_type scsi_host_type

Re: [patch,v2 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node

Bart Van Assche bvanass...@acm.org writes: On 11/02/12 22:45, Jeff Moyer wrote: diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2936b44..4db6973 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -173,16 +173,20 @@ static DEFINE_MUTEX(host_cmd_pool_mutex); * NULL

Re: [patch,v2 05/10] sd: use alloc_disk_node

Bart Van Assche bvanass...@acm.org writes: On 11/02/12 22:45, Jeff Moyer wrote: Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 12f6fdf..8deb915 100644

Re: [patch 01/10] scsi: make __scsi_alloc_queue numa-aware

Bart Van Assche bvanass...@acm.org writes: On 10/30/12 21:14, Jeff Moyer wrote: Pass the numa node id set in the Scsi_Host on to blk_init_queue_node in order to keep all allocations local to the numa node the device is closest to. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers

[patch,v2 09/10] lpfc: use scsi_host_alloc_node

Acked-By: James Smart james.sm...@emulex.com Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/lpfc/lpfc_init.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 7dc4218..65956d3 100644

[patch,v2 07/10] megaraid_sas: use scsi_host_alloc_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/megaraid/megaraid_sas_base.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index d2c5366..707a6cd 100644

[patch,v2 06/10] ata: use scsi_host_alloc_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/ata/libata-scsi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index e3bda07..9d5dd09 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c

[patch,v2 01/10] scsi: add scsi_host_alloc_node

Allow an LLD to specify on which numa node to allocate scsi data structures. Thanks to Bart Van Assche for the suggestion. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/hosts.c | 13 +++-- include/scsi/scsi_host.h |8 2 files changed, 19 insertions

[patch,v2 02/10] scsi: make __scsi_alloc_queue numa-aware

Pass the numa node id set in the Scsi_Host on to blk_init_queue_node in order to keep all allocations local to the numa node the device is closest to. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi_lib.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[patch,v2 05/10] sd: use alloc_disk_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 12f6fdf..8deb915 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2714,7 +2714,7 @@ static int

[patch,v2 08/10] mpt2sas: use scsi_host_alloc_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/mpt2sas/mpt2sas_scsih.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c index af4e6c4..a4d6b36 100644 --- a/drivers/scsi/mpt2sas

[patch,v2 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2936b44..4db6973 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -173,16

[patch,v2 03/10] scsi: make scsi_alloc_sdev numa-aware

Use the numa node id set in the Scsi_Host to allocate the sdev structure on the device-local numa node. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi_scan.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi

[patch,v2 10/10] cciss: use blk_init_queue_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/block/cciss.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index b0f553b..5fe5546 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -1930,7 +1930,8

[patch 09/10] lpfc: use scsi_host_alloc_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/lpfc/lpfc_init.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 7dc4218..65956d3 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b

[patch 07/10] megaraid_sas: use scsi_host_alloc_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/megaraid/megaraid_sas_base.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index d2c5366..707a6cd 100644

[patch 01/10] scsi: make __scsi_alloc_queue numa-aware

Pass the numa node id set in the Scsi_Host on to blk_init_queue_node in order to keep all allocations local to the numa node the device is closest to. Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi_lib.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[patch 03/10] scsi: allocate scsi_cmnd-s from the device's local numa node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/scsi.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2936b44..4db6973 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -173,16

[patch 04/10] sd: use alloc_disk_node

Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/scsi/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 12f6fdf..8deb915 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2714,7 +2714,7 @@ static int

Re: [patch/rfc/rft] sd: allocate request_queue on device's local numa node

Bart Van Assche bvanass...@acm.org writes: On 10/22/12 21:01, Jeff Moyer wrote: All of the infrastructure is available to allocate a request_queue on a particular numa node, but it isn't being utilized at all. Wire up the sd driver to allocate the request_queue on the HBA's local numa node

[patch/rfc/rft] sd: allocate request_queue on device's local numa node

more). I believe that this should be a performance win, but I have no numbers to back it up as yet. Suggestions for workloads to test are welcome. Cheers, Jeff Signed-off-by: Jeff Moyer jmo...@redhat.com diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index da36a3a..7986483 100644