Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-07 Thread Jon Mason
On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: Signed-off-by: Alexander Gordeev agord...@redhat.com --- drivers/ntb/ntb_hw.c |2

Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-07 Thread Jon Mason
On Mon, Oct 07, 2013 at 08:38:45PM +0200, Alexander Gordeev wrote: On Mon, Oct 07, 2013 at 09:50:57AM -0700, Jon Mason wrote: On Sat, Oct 05, 2013 at 11:43:04PM +0200, Alexander Gordeev wrote: On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: On Wed, Oct 02, 2013 at 12:49:10PM

Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-03 Thread Jon Mason
On Thu, Oct 03, 2013 at 10:46:21PM +0100, Ben Hutchings wrote: On Wed, 2013-10-02 at 17:39 -0700, Jon Mason wrote: On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote: Signed-off-by: Alexander Gordeev agord...@redhat.com Since you are changing the behavior

Re: [PATCH RFC 77/77] vxge: Update MSI/MSI-X interrupts enablement code

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:33PM +0200, Alexander Gordeev wrote: As result of recent re-design of the MSI/MSI-X interrupts enabling pattern this driver has to be updated to use the new technique to obtain a optimal number of MSI/MSI-X interrupts required. Signed-off-by: Alexander Gordeev

Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote: Signed-off-by: Alexander Gordeev agord...@redhat.com Since you are changing the behavior of the msix_capability_init function on populate_msi_sysfs error, a comment describing why in this commit would be nice. ---

Re: [PATCH RFC 54/77] ntb: Ensure number of MSIs on SNB is enough for the link interrupt

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: Signed-off-by: Alexander Gordeev agord...@redhat.com --- drivers/ntb/ntb_hw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c index de2062c..eccd5e5

Re: [PATCH RFC 55/77] ntb: Update MSI/MSI-X interrupts enablement code

2013-10-02 Thread Jon Mason
On Wed, Oct 02, 2013 at 12:49:11PM +0200, Alexander Gordeev wrote: As result of recent re-design of the MSI/MSI-X interrupts enabling pattern this driver has to be updated to use the new technique to obtain a optimal number of MSI/MSI-X interrupts required. Signed-off-by: Alexander Gordeev

[PATCH RESUBMIT 0/1] lpfc: remove unnecessary read of PCI_CAP_ID_EXP

2013-09-11 Thread Jon Mason
This is a resubmission of a patch from ~1 year ago, which was a resubmission of a patch series from ~1 year before that. There was originally some confusion regarding this patch, but it has been acked twice now by the driver maintainer. http://www.spinics.net/lists/linux-scsi/msg53169.html

[PATCH RESUBMIT 1/1] lpfc: remove unnecessary read of PCI_CAP_ID_EXP

2013-09-11 Thread Jon Mason
capability offset). Signed-off-by: Jon Mason jdma...@kudzu.us Acked-by: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 501147c..4d0f570

Re: [PATCH v2 1/6] scsi/bfa: use pcie_set/get_readrq to simplify code

2013-09-06 Thread Jon Mason
On Thu, Sep 5, 2013 at 12:55 AM, Yijing Wang wangyij...@huawei.com wrote: v1-v2: use pcie_get/set_readrq to simplify code a lot suggestd by Bjorn. Use pcie_get_readrq()/pcie_set_readrq() to simplify code. Very similar to a patch I sent out in 2011

Re: scsi target, likely GPL violation

2012-11-07 Thread Jon Mason
On Wed, Nov 7, 2012 at 9:50 AM, Andy Grover agro...@redhat.com wrote: Nick, Your company appears to be shipping kernel features in RTS OS that are not made available under the GPL, specifically support for the EXTENDED_COPY and COMPARE_AND_WRITE SCSI commands, in order to claim full Vmware

[PATCH RESUBMIT 0/3] remove unnecessary read of PCI_CAP_ID_EXP

2012-07-10 Thread Jon Mason
This is a resubmission of 3 of 19 patches from ~1 year ago. The rest were integrated by the other subsystem maintainers at the time. I believe the hiccup was some confusion as to whether this would cause an issue on PPC (http://www.spinics.net/lists/linux-scsi/msg53079.html). However, this was

[PATCH RESUBMIT 1/3] qla4xxx: remove unnecessary read of PCI_CAP_ID_EXP

2012-07-10 Thread Jon Mason
The PCIE capability offset is saved during PCI bus walking. It will remove an unnecessary search in the PCI configuration space if this value is referenced instead of reacquiring it. Signed-off-by: Jon Mason jdma...@kudzu.us Cc: Ravi Anand ravi.an...@qlogic.com Cc: Vikas Chaudhary vikas.chaudh

[PATCH RESUBMIT 2/3] qla2xxx: remove unnecessary reads of PCI_CAP_ID_EXP

2012-07-10 Thread Jon Mason
capability offset). Signed-off-by: Jon Mason jdma...@kudzu.us Cc: Andrew Vasquez andrew.vasq...@qlogic.com Cc: linux-dri...@qlogic.com --- drivers/scsi/qla2xxx/qla_init.c |4 ++-- drivers/scsi/qla2xxx/qla_nx.c |4 ++-- drivers/scsi/qla2xxx/qla_os.c |4 ++-- 3 files changed, 6

[PATCH RESUBMIT 3/3] lpfc: remove unnecessary read of PCI_CAP_ID_EXP

2012-07-10 Thread Jon Mason
capability offset). Signed-off-by: Jon Mason jdma...@kudzu.us Cc: James Smart james.sm...@emulex.com --- drivers/scsi/lpfc/lpfc_init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 411ed48..f30b3d2 100644