Re: Obtain file's inode in ufshcd driver

2018-06-18 Thread Julian Calaby
, so using reserved or unused fields of existing structures is > appropriate. The inode number is part of the filesystem so it wouldn't appear below that layer. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: QLogicPTI Hangs on SPARC64

2016-08-08 Thread Julian Calaby
t; limitation that prevents up from pinpointing what is acutally no longer > responding on the bus? > -- > To unsubscribe from this list: send the line "unsubscribe sparclinux" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.o

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby
Hi Joe, On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches <j...@perches.com> wrote: > On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote: >> Hi Joe, > > rehi Julian. (I always put a salutation on my emails and always finish them with "Thanks," =) ) >>

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby
Hi Joe, On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <j...@perches.com> wrote: > On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote: >> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c > > just fyi: the script name is not plural Thanks, must have typo

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby
si/vmw_pvscsi.c or ./scripts/get_maintainers.pl patchfile.patch Thanks, Julian Calaby > > Thanks! > Arvind > ________ > From: Julian Calaby <julian.cal...@gmail.com> > Sent: Thursday, June 16, 2016 6:48 PM > To: Jim Gill > Cc: j...@linu

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby
1301 > USA. > * > - * Maintained by: Arvind Kumar <arvindku...@vmware.com> > + * Maintained by: Jim Gill <jg...@vmware.com> Shouldn't you update MAINTAINERs too? And isn't having this information in these files redundant? Thanks, -- Julian Calaby Email: julian.cal...@gmai

Re: [PATCH] scsi:stex.c Support Pegasus 3 product

2016-06-13 Thread Julian Calaby
Hi Charles, On Mon, Jun 13, 2016 at 9:40 PM, Charles Chiou <ch1102ch...@gmail.com> wrote: > Hi Julian, > > > On 06/10/2016 08:10 AM, Julian Calaby wrote: >> >> Hi Charles, >> >> On Mon, Jun 6, 2016 at 5:53 PM, Charles Chiou <ch1102ch...@gmail.com

Re: [PATCH] scsi:stex.c Support Pegasus 3 product

2016-06-09 Thread Julian Calaby
e unrelated whitespace changes. > before = jiffies; > while (hba->ccb[tag].req_type & PASSTHRU_REQ_TYPE) { > if (time_after(jiffies, before + ST_INTERNAL_TIMEOUT * HZ)) { > @@ -1821,24 +1954,29 @@ static void stex_remove(struct pci_dev *pdev) >

Re: [PATCH] megaraid: add scsi_cmnd NULL check before use

2016-05-08 Thread Julian Calaby
Removing that test (and all the unnecessary parentheses) will reduce the second test to: else if (scsi_io_req->Function == MPI2_FUNCTION_SCSI_IO_REQUEST || scsi_io_req->Function == MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST) which is much cleaner. Thanks, -- Julian Calaby Email: julian.cal...@gma

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

2016-04-06 Thread Julian Calaby
t;lock); > + csio_unreg_rnode(rn); > + spin_unlock_irq(>lock); Are you _certain_ this is correct? This construct usually appears when a function has a particular lock held, then needs to unlock it to call some other function. Are you _certain_ that this isn't the case? Thanks, -

Re: [PATCH 3/7] scsi: Drop runtime PM usage count after host is added

2016-02-18 Thread Julian Calaby
enable_async_suspend(>shost_gendev); > @@ -290,6 +296,7 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, > struct device *dev, > goto out_destroy_host; > > scsi_proc_host_add(shost); > + scsi_autopm_put_host(shost); Would it be cleaner t

Re: [PATCH] add support for DWC UFS Host Controller

2016-02-02 Thread Julian Calaby
iver ufs-samsung-pci.c which will use common pci functions > from a > ufshcd-pci.c? Agree? That sounds sensible. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH] add support for DWC UFS Host Controller

2016-02-02 Thread Julian Calaby
Hi Joao, On Tue, Feb 2, 2016 at 9:22 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: > Hi Julian, > > Thanks for the review. My comments are below. > > On 2/2/2016 1:00 AM, Julian Calaby wrote: >> Hi Joao, >> >> On Mon, Feb 1, 2016 at 11:47 PM, Joao Pinto &l

Re: [PATCH] add support for DWC UFS Host Controller

2016-02-02 Thread Julian Calaby
Hi Joao, On Tue, Feb 2, 2016 at 10:47 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: > > Hi Julian, > I am already changing the architecture and I will send a v2 soon. > Thanks for the review. Awesome, I look forward to it. Thanks, -- Julian Calaby Email: julian.cal...

Re: [PATCH] add support for DWC UFS Host Controller

2016-02-01 Thread Julian Calaby
rs. Consequently, as the GEN2 hardware needs extra stuff, this stuff should be enabled either by: 1. detecting it at runtime 2. adding a second compatible string and checking it where needed 3. using a separate driver with a different compatible string [snip] > @@ -5645,8 +6449,16 @@ int ufshc

Re: How to set DPOFUA=0 ?

2015-12-29 Thread Julian Calaby
r why their new SSD etc. > isn't working in debian/ubuntu & co., as happened to me... :-( Have you reported this as a bug against Jessie's kernel package? I don't believe the Debian kernel maintainers read this mailing list. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile:

Re: Patch size problem

2015-12-17 Thread Julian Calaby
f you have a non-work account, you could send it through that with appropriate From headers at the top of the email. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscri

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

2015-12-04 Thread Julian Calaby
Hi Finn, On Sat, Dec 5, 2015 at 1:12 PM, Finn Thain <fth...@telegraphics.com.au> wrote: > > On Sat, 5 Dec 2015, Julian Calaby wrote: > >> Hi Finn, >> >> On Fri, Dec 4, 2015 at 7:38 PM, Finn Thain <fth...@telegraphics.com.au> >> wrote: >

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

2015-12-04 Thread Julian Calaby
Hi Finn, On Fri, Dec 4, 2015 at 7:38 PM, Finn Thain <fth...@telegraphics.com.au> wrote: > > On Fri, 4 Dec 2015, Julian Calaby wrote: > >> > - if (overrides[current_override].board == BOARD_NCR53C400A) >> > { >> > +

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

2015-12-03 Thread Julian Calaby
rrent_override].board == BOARD_NCR53C400A) { > + if (overrides[current_override].board == BOARD_NCR53C400A || > + overrides[current_override].board == BOARD_DTC3181E) { These if statements are starting to get a bit long, would it make sense to replace them with a flag or

Re: [PATCH v2] qla2xxx: Remove unavailable firmware files

2015-11-17 Thread Julian Calaby
d-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> The patch looks good so for what it's worth: Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profi

Re: [PATCH 1/2] qla2xxx: Remove unavailable firmware files

2015-10-14 Thread Julian Calaby
d-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com> For what it's worth, this looks good to me. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework

2015-10-12 Thread Julian Calaby
our script seems to have lost the actual warnings here. > Please review and possibly fold the followup patch. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

2015-10-08 Thread Julian Calaby
Hi James, On Fri, Oct 9, 2015 at 3:17 AM, James Bottomley <james.bottom...@hansenpartnership.com> wrote: > On Thu, 2015-10-08 at 15:46 +, Himanshu Madhani wrote: >> >> On 10/7/15, 4:41 PM, "Julian Calaby" <julian.cal...@gmail.com> wrote: >> >>

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

2015-10-07 Thread Julian Calaby
Hi Xose, On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > On Fri, May 22, 2015 at 10:00 AM, Julian Calaby <julian.cal...@gmail.com> > wrote: > >> Some qla2xxx devices have firmware stored in flash on the device, >> however

Re: RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k

2015-10-06 Thread Julian Calaby
Hi Rasmus, On Wed, Oct 7, 2015 at 2:39 AM, Rasmus Villemoes <li...@rasmusvillemoes.dk> wrote: > On Tue, Oct 06 2015, Julian Calaby <julian.cal...@gmail.com> wrote: > >> Hi Rasmus, >> >>> >>> diff --git a/drivers/scsi/constants.c b/drivers/scsi/

Re: RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k

2015-10-05 Thread Julian Calaby
nsigned offset = 0; > > *fmt = NULL; > - for (i = 0; additional[i].text; i++) > + for (i = 0; i < ARRAY_SIZE(additional); i++) { > if (additional[i].code12 == code) > - return additional[i].text; > + r

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

2015-05-21 Thread Julian Calaby
Hi Xose, Adding you to CC. On Fri, May 22, 2015 at 10:00 AM, Julian Calaby julian.cal...@gmail.com wrote: Some qla2xxx devices have firmware stored in flash on the device, however for debugging and triage purposes, Qlogic staff like to be able to load known-good versions of these firmwares

Re: [PATCH for-next] qla2xxx: delete references to unused firmware files

2015-05-21 Thread Julian Calaby
Hi All, On Thu, May 21, 2015 at 8:42 PM, Xose Vazquez Perez xose.vazq...@gmail.com wrote: On 05/19/2015 05:51 PM, Himanshu Madhani wrote: On 5/18/15, 6:50 PM, Julian Calaby julian.cal...@gmail.com wrote: Do the devices these firmware files are for exist and is there any chance of the files

[PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

2015-05-21 Thread Julian Calaby
Signed-off-by: Julian Calaby julian.cal...@gmail.com --- drivers/scsi/qla2xxx/Kconfig | 25 + drivers/scsi/qla2xxx/qla_os.c | 40 +++- 2 files changed, 52 insertions(+), 13 deletions(-) This is against linux-next @next-20150520 and has

Re: [PATCH v2 1/9] snic: snic module infrastructure

2015-03-11 Thread Julian Calaby
/snic_os.h Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 2/4] Fix for crash when bfa_itnim is NULL

2015-01-29 Thread Julian Calaby
(hba_attr-vendor_info, QLogic); Shouldn't this be in the next patch? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [PATCH 0/20] fix misspelling of current function in string

2014-12-09 Thread Julian Calaby
Hi Julia, On Mon, Dec 8, 2014 at 5:43 PM, Julia Lawall julia.law...@lip6.fr wrote: On Mon, 8 Dec 2014, Julian Calaby wrote: Hi Julia, On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall julia.law...@lip6.fr wrote: These patches replace what appears to be a reference to the name of the current

Re: [PATCH 0/4] Fix performance burning or extracting audio etc. from multiple optical drives.

2014-11-26 Thread Julian Calaby
by sr_block_open(), and in turn calls check_disk_change... scsi_test_unit_ready). How do I work out why blk_execute_rq is blocking? As you're playing with locks, I assume you're running with LOCKDEP enabled? If not, that might tell you what's going on. Thanks, -- Julian Calaby Email

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread Julian Calaby
==NULL) || ...) S - memset((T2)x,0,E2); I don't know much about SmPL, but wouldn't having that if statement there reduce your matches? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-07 Thread Julian Calaby
is doing things like this: eeprom-member[0] = (u8)(CONSTANT 0xff); eeprom-member[1] = (u8)(CONSTANT 8); Which is exactly the same as code along the lines of: eeprom-member = cpu_to_le16(CONSTANT); Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-07 Thread Julian Calaby
Hi Jingoo, On Wed, Aug 7, 2013 at 6:36 PM, Jingoo Han jg1@samsung.com wrote: -Original Message- From: Julian Calaby [mailto:julian.cal...@gmail.com] Sent: Wednesday, August 07, 2013 5:21 PM To: Jingoo Han Cc: Oliver Neukum; James Bottomley; Ali Akcaagac; Jamie Lenehan; dc3

Re: [PATCH v13 1/9] scsi: sr: support runtime pm

2013-01-21 Thread Julian Calaby
Hi Aaron, On Mon, Jan 21, 2013 at 7:14 PM, Aaron Lu aaron...@intel.com wrote: On Mon, Jan 21, 2013 at 02:31:50PM +1100, Julian Calaby wrote: Hi Alan, On Sun, Jan 20, 2013 at 5:46 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 19 Jan 2013, Aaron Lu wrote: closed. Do we want

Re: [PATCH v13 1/9] scsi: sr: support runtime pm

2013-01-20 Thread Julian Calaby
) Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: scsi target, likely GPL violation

2012-11-11 Thread Julian Calaby
that there is no GPL licensed code within their proprietary target code? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [PATCH] SMP request handlers need to update resid

2007-12-19 Thread Julian Calaby
; not work? Thanks, -- Julian Calaby Email: [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SMP request handlers need to update resid

2007-12-19 Thread Julian Calaby
On Dec 20, 2007 2:20 PM, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Thu, 20 Dec 2007 14:13:15 +1100 Julian Calaby [EMAIL PROTECTED] wrote: On Dec 20, 2007 1:44 PM, FUJITA Tomonori [EMAIL PROTECTED] wrote: --- a/drivers/message/fusion/mptsas.c +++ b/drivers/message/fusion/mptsas.c

Re: What still uses the block layer?

2007-10-15 Thread Julian Calaby
that your gigabit card is always assigned to eth0. -- Julian Calaby Email: [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: What still uses the block layer?

2007-10-15 Thread Julian Calaby
[adding back CCs which were dropped because I'm stupid - sorry!] On 10/16/07, Rob Landley [EMAIL PROTECTED] wrote: On Monday 15 October 2007 5:27:55 am Julian Calaby wrote: On 10/15/07, Rob Landley [EMAIL PROTECTED] wrote: On Monday 15 October 2007 4:06:20 am Julian Calaby wrote: On 10

Re: aic79xx problems

2007-09-20 Thread Julian Calaby
for boot messages. Hope that helps =) -- Julian Calaby Email: [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

2007-09-11 Thread Julian Calaby
cmnd_size, int timeout, unsigned sense_bytes) Shouldn't that be unsigned _int_? Thanks, -- Julian Calaby Email: [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] zfcp: Stop system after memory corruption

2007-05-08 Thread Julian Calaby
On 5/8/07, Christof Schmitt [EMAIL PROTECTED] wrote: On Tue, May 08, 2007 at 01:56:07AM +1000, Julian Calaby wrote: From: Christof Schmitt [EMAIL PROTECTED] [snip] - ZFCP_LOG_NORMAL(bug: unexpected inbound - packet