Re: [PATCH] scsi: cxlflash: fix assignment of the backend operations

Thanks for catching this Cedric! Acked-by: Matthew R. Ochs

Re: [PATCH 2/6] scsi: cxlflash: Drop unused sense buffers

On Tue, May 22, 2018 at 11:15:08AM -0700, Kees Cook wrote: > This removes the unused sense buffer in read_cap16() and write_same16(). > > Signed-off-by: Kees Cook <keesc...@chromium.org> Looks good. Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 7/7] cxlflash: Isolate external module dependencies

f > to avoid compilation errors. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 6/7] cxlflash: Abstract hardware dependent assignments

> Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 5/7] cxlflash: Add include guards to backend.h

On Fri, May 11, 2018 at 02:05:51PM -0500, Uma Krishnan wrote: > The new header file, backend.h, that was recently added is missing > the include guards. This commit adds the guards. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 3/7] cxlflash: Acquire semaphore before invoking ioctl services

leading > to the hang. > > To support the current design point of holding the semaphore on the > ioctl() paths, the release fop should acquire it before invoking any > ioctl services. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 2/7] cxlflash: Limit the debug logs in the IO path

to debug issues that involve command > tracking, the abundance of data can overwrite other useful data in the > log. The best option available is to limit the messages that should > serve most of the common use cases. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com

Re: [PATCH 1/7] cxlflash: Yield to active send threads

ter can > also be used for the active send threads. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v3 41/41] cxlflash: Handle spurious interrupts

lem, a boolean will indicate if the hardware queue is > ready to process interrupts or not. This can be evaluated in the interrupt > handler before proessing an interrupt. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v3 40/41] cxlflash: Remove commmands from pending list on timeout

ing command list > before freeing the buffer. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v3 39/41] cxlflash: Synchronize reset and remove ops

evice state and yield to any active reset or probing threads. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Looks good! Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 00/38] cxlflash: OpenCXL transport support

and agree that the OpenCXL terminology should be consistent throughout the kernel. So...contingent upon a V2 with OpenCXL references being replaced by OCXL: Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > > Matthew R. Ochs (1): > cxlflash: Avoid clobbering context co

Re: [PATCH] scsi: cxlflash: Select SCSI_SCAN_ASYNC

On Tue, Feb 20, 2018 at 07:56:35PM +1100, Michael Ellerman wrote: > Vaibhav Jain writes: > > > The cxlflash driver uses "Asynchronous SCSI scanning" enabled by > > CONFIG_SCSI_SCAN_ASYNC. Without this enabled the modprobe of cxlflash > > module gets hung with

Re: [PATCH 5/6] cxlflash: Adapter context init can return error

On Wed, Jan 03, 2018 at 04:55:04PM -0600, Uma Krishnan wrote: > Adapter context creation can return either NULL or an error pointer. > Updating the check condition to reflect this. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 2/6] cxlflash: Update cxl-specific arguments to generic cookie

On Wed, Jan 03, 2018 at 04:54:25PM -0600, Uma Krishnan wrote: > Convert cxl-specific pointers to generic cookies to facilitate future > enhancements. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 1/6] cxlflash: Reset command ioasc

On Thu, Jan 04, 2018 at 05:33:48PM +1100, Andrew Donnellan wrote: > On 04/01/18 09:54, Uma Krishnan wrote: > >In the event of a command failure, cxlflash returns the failure to the > >upper layers to process. After processing the error, when the command is > >queued again, the private command

Re: [PATCH 1/6] cxlflash: Reset command ioasc

a hang or IO failure. > > To fix the issue, clear the ioasc before queuing any command. > > Fixes: 479ad8e9d48c ("scsi: cxlflash: Remove zeroing of private command > data") > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH] scsi: cxlflash: Fix an error handling path in 'cxlflash_disk_attach()'

ristophe.jail...@wanadoo.fr> Yep, that's a bug. Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH] cxlflash: return -EFAULT if copy_from_user() fails

debug") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Good catch Dan! Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

[PATCH 3/3] cxlflash: Update debug prints in reset handlers

and associated CDB. This is not necessary as the SCSI command is simply the messenger in these scenarios. Refactor the debug prints in the host and reset handlers to only present information that is applicable given the function scope. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.

[PATCH 2/3] cxlflash: Update send_tmf() parameters

. As a nice side effect, this will ease the burden of converting caller routines to be based solely off of a SCSI device reference. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 27 +-- 1 file changed, 13 insertions(

[PATCH 1/3] cxlflash: Avoid double free of character device

ement interface") Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index 7a787b6..455564f 100644 --- a/drivers/scsi/cxlflash/main.c ++

[PATCH 0/3] cxlflash: Minor fix and EH refactoring

This small series fixes a recently injected double free and also includes two patches to refactor the host and reset handlers to ease the burden of making this driver compatible with an updated SCSI EH framework. This series is intended for 4.13 and is bisectable. Matthew R. Ochs (3): cxlflash

Re: [PATCH 33/47] cxlflash: use dedicated reset command in send_tmf()

Hi Hannes, We actually just reworked these paths in a series that was pulled in on Monday. While testing, I came across a bug in that series and was planning on sending out a fix for it. I'll include some patches that will ease the burden of incorporating your EH updates for cxlflash. Many

Re: [PATCH 09/17] cxlflash: Create character device to provide host management interface

gt; manage the adapter. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 08/17] cxlflash: Add scsi command abort handler

support to process command timeouts > and abort requests. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 06/17] cxlflash: Track pending scsi commands in each hardware queue

> > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 07/17] cxlflash: Flush pending commands in cleanup path

-layer and indicating that the command > can be retried. > > Once the card has been quiesced, the hardware send queue lock is acquired > to prevent any data movement while the pending commands are processed. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 05/17] cxlflash: Handle AFU sync failures

> > Update documentation to reflect behavior in the event of an AFU sync > failure. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 03/17] cxlflash: Reset hardware queue context via specified register

ue > reference instead of a single command to better reflect that the entire > queue associated with the context is impacted by the reset. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 04/17] cxlflash: Schedule asynchronous reset of the host

o recoverable actions. > > To avoid this situation, context reset failures will be escalated to a host > reset operation. This will be done asynchronously to allow the acting > thread to return to the user with a failure. > > Signed-off-by: Uma Krishnan <ukri...@linux.vne

Re: [PATCH 02/17] cxlflash: Update cxlflash_afu_sync() to return errno

rly indicate the failure cause to the > caller. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 01/17] cxlflash: Combine the send queue locks

mplification and to support serialization with enqueue > operations, move to only a single lock that is used for enqueueing > regardless of the queueing model. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH] cxlflash: Select IRQ_POLL

sh: Implement IRQ polling for RRQ > processing") > Signed-off-by: Guenter Roeck <li...@roeck-us.net> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 15/17] cxlflash: Support multiple hardware queues

initially implemented as a static array > embedded in the AFU. This will be transitioned to a dynamic allocation in a > later series to improve the memory footprint of the driver. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Looks good! Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 10/17] cxlflash: Fence EEH during probe

> On Apr 13, 2017, at 1:27 AM, Andrew Donnellan <andrew.donnel...@au1.ibm.com> > wrote: > > On 13/04/17 05:14, Uma Krishnan wrote: >> From: "Matthew R. Ochs" <mro...@linux.vnet.ibm.com> >> >> An EEH during probe can lead to a crash as the reco

Re: [PATCH 4/4] cxlflash: Cancel scheduled workers before stopping AFU

is > cancelled after interrupts have been disabled and prior to the mapping > being freed. > > Fixes: b45cdbaf9f7f ("cxlflash: Resolve oops in wait_port_offline") > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Looks good. Acked-by: Matthew R. Ochs <mr

Re: [PATCH v2 04/14] cxlflash: Avoid command room violation

o account the > current thread consuming a hardware command. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/14] cxlflash: Avoid command room violation

Hi Uma, I do see a potential hang issue with this patch. See my comments below. -matt > On Nov 15, 2016, at 5:14 PM, Uma Krishnan wrote: > > During test, a command room violation interrupt is occasionally seen > for the master context when the CXL flash devices

Re: [PATCH 03/14] cxlflash: Improve context_reset() logic

itionally it adds a debug trace to help pinpoint > hardware errors when a context reset does not complete. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line

Re: [PATCH 02/14] cxlflash: Fix crash in cxlflash_restore_luntable()

LUN information structure is updated to > reflect the LUN is no longer in the LUN table once all references to > the LUN are gone. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from

Re: [PATCH 01/14] cxlflash: Set sg_tablesize to 1 instead of SG_NONE

issue, sg_tablesize for cxlflash can simply be set > to 1, a value which satisfies the constraints in cxlflash and the > lack of support of SG_NONE in SCSI blk_mq. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vn

Re: [PATCH 1/6] cxlflash: Scan host only after the port is ready for I/O

problem, scsi_scan_host() should be called only after the > 'login succeeded' interrupt. > > Signed-off-by: Uma Krishna <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 2/6] cxlflash: Remove the device cleanly in the system shutdown path

ime, the remove hook is updated to protect against being > called when the device is not enabled. > > Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash > cards") > Signed-off-by: Uma Krishna <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs

[PATCH 5/6] cxlflash: Remove adapter file descriptor cache

t;v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.c | 26 +- drivers/scsi/cxlflash/superpipe.h | 1 - 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/cxlflash/superpipe.

[PATCH 1/6] cxlflash: Avoid mutex when destroying context

of these context management paths are superfluous. This commit removes the obtaining of the context mutex in the context initialization routine and assumes the mutex is not held in the context free path. Inspired-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Och

[PATCH 4/6] cxlflash: Transition to application close model

that they are responsible for the close following the cleanup (detach) of a context. The documentation is also updated to reflect this change in behavior. Inspired-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Documentation/powerpc/cxlfl

[PATCH 3/6] cxlflash: Add kref to context

bug injection. To improve code comprehension and better protect against future bugs, add explicit reference counting to contexts and migrate the context removal code to the kref release handler. Inspired-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Och

[PATCH 6/6] cxlflash: Update documentation

Update the block library link in the API documentation. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Documentation/powerpc/cxlflash.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/powerpc/cxlflash.txt b/Documentation/powerpc/cxlfla

[PATCH 2/6] cxlflash: Cache owning adapter within context

reference as the sole parameter, another means is needed to derive the owning adapter. As a remedy, the owning adapter reference is saved off within the context during initialization. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.c | 1 + driver

[PATCH 0/6] cxlflash: Improvements and cleanup

alongside the modifications. The series is based upon 4.8-rc1, intended for 4.9, and is bisectable. Matthew R. Ochs (6): cxlflash: Avoid mutex when destroying context cxlflash: Cache owning adapter within context cxlflash: Add kref to context cxlflash: Transition to application close model

Re: [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers

> On Jul 21, 2016, at 3:44 PM, Uma Krishnan <ukri...@linux.vnet.ibm.com> wrote: > > Adding myself as a cxlflash maintainer. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscr

Re: [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown

tdown notify support > for CXL Flash cards"). > > As a fix, shutdown notification should only occur when the AFU is mapped. > > Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards") > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com&

Re: [PATCH] cxl: remove dead Kconfig options

perst_reloads_same_image() in cxlflash which is > only used if CXL_EEH isn't defined (i.e. never). > > Suggested-by: Ian Munsie <imun...@au1.ibm.com> > Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com

Re: [PATCH 3/3] cxlflash: Shutdown notify support for CXL Flash cards

the card and returns. When the device > is removed in the PCI remove path, notification code will > wait for shutdown processing to complete. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe fr

Re: [PATCH 1/3] cxlflash: Fix to drain operations from previous reset

drain_ioctls() was static, it had to be moved up a bit to be before > cxlflash_eh_host_reset_handler(). > > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] cxlflash: Fix to resolve dead-lock during EEH recovery

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] cxlflash: Move to exponential back-off when cmd_room is not available

ad the least > overall cost. Cost as being defined as overall time spent waiting. > > The fix is to change the linear back-off to an exponential back-off. > This solution also takes care of the problem with the initial > delay (starts with 1 usec). > > Signed

Re: [PATCH 1/2] cxlflash: Fix regression issue with re-ordering patch

o keep the initialization process symmetric, separate the AFU interrupt > setup also to a distinct function: init_intr(). > > Fixes: 6ded8b3cbd9a ("cxlflash: Unmap problem state area before detaching > master context") > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm

Re: [PATCH 7/7] cxlflash: Increase cmd_per_lun for better throughput

. > > Increase the value of cmd_per_lun to 256 to improve > throughput. With this change a single adapter is able to > attain close to the maximum throughput (380kIOPS). > Also change the number of RRQ entries that can be queued. > > Signed-off-by: Manoj N. Kumar <ma...@linux.vne

Re: [PATCH 6/7] cxlflash: Fix to avoid unnecessary scan with internal LUNs

gt;max_channel is retained. This > causes an unnecessary scan over the second port/channel. > > This fix alters the host->max_channel to 0 (1 port), if internal > LUNs are configured and switches it back to 1 (2 ports) while > going back to external LUNs. > > Sign

Re: [PATCH 5/7] cxlflash: Reorder user context initialization

ix this problem, cxl_start_work() is called before obtaining > the process element id. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [PATCH 2/7] cxlflash: Unmap problem state area before detaching master context

> > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] cxlflash: Simplify PCI registration

the call the > pci_release_regions() from cxlflash_remove(). > > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 19/20] cxlflash: Use new cxl_pci_read_adapter_vpd() API

This patch should have also been sent to the SCSI list (included now). Changes look fine. Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > On Mar 4, 2016, at 5:26 AM, Frederic Barrat <fbar...@linux.vnet.ibm.com> > wrote: > > To read the adapter VPD, drivers

Re: [PATCH v2] osd: remove deadcode

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] imm: check parport_claim

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hpsa: update MAINTAINERS with new e-mail

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/7] hpsa: update copyright information

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/7] hpsa: remove function definition for sanitize_inquiry_string

Thanks again for implementing this feedback! Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/7] hpsa: check for a null phys_disk pointer in ioaccel2 path

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/7] hpsa: correct abort tmf for hba devices

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/7] hpsa: correct lun data caching bitmap definition

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/7] hpsa: add SMR drive support

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] hpsa: do not get enclosure info for external devices

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: export function scsi_scan.c:sanitize_inquiry_string

ggestion when reviewing the same patch: https://www.marc.info/?l=linux-scsi=144613827316617=2 Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > > Suggested-by: Hannes Reinecke <h...@suse.de> > Reviewed-by: Kevin Barnett <kevin.barn...@pmcs.com> > Reviewed-by: Justin Lindl

Re: [PATCH v2] ipr: fix out-of-bounds null overwrite

f(fname, 99, "%s", buf); Changing the 99 to sizeof(fname) as part of this change would also make for cleaner code in my opinion. Will leave it up to you if you'd like to do a v3. Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this li

Re: [PATCH v2 3/3] hpsa: add box and bay information for enclosure devices

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] hpsa: fix path_info_show

don.br...@pmcs.com> FYI, I did review and stamp this one back on 12/9. Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] hpsa: change SAS transport devices to bus 0.

> On Dec 15, 2015, at 9:25 AM, Don Brace <brace77...@gmail.com> wrote: > > On 12/09/2015 05:21 PM, Matthew R. Ochs wrote: >>> On Dec 9, 2015, at 3:18 PM, Don Brace <don.br...@pmcs.com> wrote: >>> >>> sas transport places devices on bus 0 but driver

Re: [PATCH 3/3] hpsa: add box and bay information for enclosure devices

Hi Don, Did you see these comments I had from my review of this patch? -matt > On Dec 9, 2015, at 5:41 PM, Matthew R. Ochs <mro...@linux.vnet.ibm.com> wrote: > >> On Dec 9, 2015, at 3:18 PM, Don Brace <don.br...@pmcs.com> wrote: > > No commit message? You can d

Re: [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/6] cxlflash: Removed driver date print

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/6] cxlflash: Fix to resolve cmd leak after host reset

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/6] cxlflash: Resolve oops in wait_port_offline

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] cxlflash: Enable device id for future IBM CXL adapter

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] cxlflash: Fix to escalate LINK_RESET also on port 1

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] hpsa: fix path_info_show

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] hpsa: change SAS transport devices to bus 0.

> On Dec 9, 2015, at 3:18 PM, Don Brace wrote: > > sas transport places devices on bus 0 but driver was setting > the bus to 3. > > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett > Reviewed-by: Scott Teel

Re: [PATCH 3/3] hpsa: add box and bay information for enclosure devices

> On Dec 9, 2015, at 3:18 PM, Don Brace wrote: No commit message? > > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett > Reviewed-by: Scott Teel > Signed-off-by: Don Brace

[PATCH RESEND] cxlflash: drop unlikely before IS_ERR_OR_NULL

From: Geliang Tang <geliangt...@163.com> IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it. Signed-off-by: Geliang Tang <geliangt...@163.com> Acked-by: Manoj Kumar <ma...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-

[PATCH RESEND] cxlflash: a couple off by one bugs

a...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- This patch was originally sent by Dan Carpenter in September 2015. I had based my large patch series that went into 4.4 off of it but this pat

Re: [PATCH v2 18/27] hpsa: refactor hpsa_figure_bus_target_lun

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 20/27] hpsa: generalize external arrays

> struct ctlr_info *h, > c->Request.CDB[7] = (size >> 16) & 0xFF; > c->Request.CDB[8] = (size >> 8) & 0XFF; > break; > + case BMIC_IDENTIFY_CONTROLLER: > +

Re: [PATCH] st: trivial: remove form feed characters

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1 24/25] hpsa: add in sas transport class

> On Oct 30, 2015, at 5:00 PM, Don Brace <brace77...@gmail.com> wrote: > On 10/30/2015 03:07 PM, Matthew R. Ochs wrote: >>> On Oct 28, 2015, at 5:06 PM, Don Brace <don.br...@pmcs.com> wrote: >>> >>> From: Kevin Barnett <kevin.barn...@pmcs.com> &g

Re: [PATCH 1 17/25] hpsa: move scsi_add_device and scsi_remove_device calls to new function

> On Oct 29, 2015, at 3:30 PM, Don Brace <brace77...@gmail.com> wrote: > > On 10/29/2015 12:21 PM, Matthew R. Ochs wrote: >>> On Oct 28, 2015, at 5:06 PM, Don Brace <don.br...@pmcs.com> wrote: >>> >>> From: Kevin Barnett <kevin.barn...@pmcs.com

Re: [PATCH 1 21/25] hpsa: disable report lun data caching

+ > + /* Now verify that it got set: */ > + if (fill_cmd(c, BMIC_SENSE_DIAG_OPTIONS, h, options, 4, 0, > + RAID_CTLR_LUNID, TYPE_CMD)) > + goto errout; > + > + rc = hpsa_scsi_do_simple_cmd_with_retry(h, c, > + PCI_DMA_FROMDEVICE,

  1   2   3   4   5   >