[no subject]

2014-04-07 Thread Michael Reed
unsubscribe linux-scsi -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

panic in sg_add when class_device_create() fails

2008-01-14 Thread Michael Reed
We're seeing an occasional panic in sg_add() when class_device_create() fails. It's obvious in the code that it uses the pointer to sg_class_member even though it's invalid. We do see the class_device_create failed message. class_set_devdata(cl_dev, sdp); error = cdev_add(cdev,

Re: generating a Linux WWN?

2007-10-08 Thread Michael Reed
David Miller wrote: From: James Bottomley [EMAIL PROTECTED] Date: Sat, 06 Oct 2007 10:04:55 -0500 If you remember Rusty's guide to interfaces, this is a level 14 easy to misuse interface: The obvious use is wrong; since the obvious use is to put it in module parameters and have the

Re: generating a Linux WWN?

2007-10-03 Thread Michael Reed
Jeff Garzik wrote: Luben Tuikov wrote: Do you mean: The admin will have the option to SPECIFY(SET) a WWN, should they sodesire. OR do you mean: The admin will have the option to HAVE THE KERNEL auto-generate a WWN, should they so desire. Both. It is up to admin policy to

Re: generating a Linux WWN?

2007-09-27 Thread Michael Reed
Jeff Garzik wrote: James Smart wrote: Uh, although this may work very well for small constrained configs, as one who debugs larger environments (and things always grow or get connected in ways you don't expect), depending on a random number for uniqueness makes me very unsettled. Debugging

Re: generating a Linux WWN?

2007-09-27 Thread Michael Reed
Matthew Wilcox wrote: On Thu, Sep 27, 2007 at 09:16:13AM -0500, [EMAIL PROTECTED] wrote: Unfortunately, it looks like IEEE doesn't have any OID's registered for Linux or other reserved areas (http://standards.ieee.org/regauth/oui/oui.txt). However, it does look like they go in order...

Re: generating a Linux WWN?

2007-09-27 Thread Michael Reed
Michael Reed wrote: Matthew Wilcox wrote: On Thu, Sep 27, 2007 at 09:16:13AM -0500, [EMAIL PROTECTED] wrote: Unfortunately, it looks like IEEE doesn't have any OID's registered for Linux or other reserved areas (http://standards.ieee.org/regauth/oui/oui.txt). However, it does look like

Re: [PATCH 6/9] mpt fusion: error recovery improvements,andsynchronizing internal commands

2007-09-25 Thread Michael Reed
Jeff Garzik wrote: Moore, Eric wrote: On Tuesday, September 25, 2007 11:32 AM, James Bottomley wrote: Youve rejected the error recovery patchs, which is fair enough. Just the separation ... the actual patch looks OK. I'll will continue working to separate the error recovery

[PATCH 1/1] stale residual returned on write following BUSY retry

2007-09-17 Thread Michael Reed
status. This patch applies to 2.6.23-rc6-git7. Signed-off-by: Michael Reed [EMAIL PROTECTED] --- linux-2.6.23-rc6-git7.orig/drivers/scsi/scsi_lib.c 2007-09-17 14:02:03.0 -0700 +++ linux-2.6.23-rc6-git7/drivers/scsi/scsi_lib.c 2007-09-17 14:05:51.0 -0700 @@ -443,6 +443,7

Re: persistent scsi with udev

2007-02-08 Thread Michael Reed
While you didn't explicitly mention which distro you're using, some already have udev in their initrd. If this applies in your case, you should be able to change the root= parameter passed to the kernel to specify your root device via a persistent name. For example:

[PATCH 0/2] Prevent infinite retries due to DID_RESET return status

2007-01-31 Thread Michael Reed
by modifying a LLDD to return DID_RESET for every command received. Patches apply to 2.6.20-rc6-git1. Signed-off-by: Michael Reed [EMAIL PROTECTED] Christoph Hellwig wrote: On Mon, Dec 11, 2006 at 03:42:34PM -0600, Michael Reed wrote: Due to a firmware mismatch between a host and target (names

[PATCH 1/2] Prevent infinite retries due to DID_RESET return status

2007-01-31 Thread Michael Reed
retaining it's original jiffies_at_alloc. Signed-off-by: Michael Reed [EMAIL PROTECTED] Move scsi_release_buffers() call so that buffers are retained until after a determination is made about whether the command will be requeued via scsi_queue_insert(). Doing so allows a command which receives DID_RESET

[PATCH 2/2] Prevent infinite retries due to DID_RESET return status

2007-01-31 Thread Michael Reed
Limit lifetime of scsi commands receiving DID_RESET status. Signed-off-by: Michael Reed [EMAIL PROTECTED] Limit lifetime of scsi commands receiving DID_RESET status. Signed-off-by: Michael Reed [EMAIL PROTECTED] --- rg61u/include/scsi/scsi.h 2006-10-31 21:08:47.0 -0600 +++ rg61/include

Re: [patch] scsi: use lock per host instead of per device for shared queue tag host

2007-01-24 Thread Michael Reed
How 'bout a comment in scsh_host.h indicating that the pointer will be NULL unless initialized by the driver? Protect shared block queue tag is unique to stex. Perhaps have no comment on the variable declaration in scsi_host.h and explain why you use it in stex. Mike Ed Lin wrote: The block

Re: [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries

2007-01-09 Thread Michael Reed
Moore, Eric wrote: On Monday, January 08, 2007 3:25 PM, James Bottomley wrote: Right, I sort of suspected something like this. BUSY/QUEUE_FULL handling was a bit iffy in 2.4; but it was sorted out in the 2003/4 timeframe. Nowadays, I think you want to translate the MPI_SCSI_STATUS_BUSY

Re: REGRESSION: 2.6.20-rc3-git4: EIO not returned to direct i/o application following disk error

2007-01-09 Thread Michael Reed
to dead device (huge numbers of these occur) I tried the same test using O_FSYNC instead of O_DIRECT and the write error following the portdisable propagated to the test and it exited with an EIO. Mike Michael Reed wrote: Testing using 2.6.20-rc3-git4 I observed that my direct i/o test

REGRESSION: 2.6.20-rc3-git4: EIO not returned to direct i/o application following disk error

2007-01-05 Thread Michael Reed
Testing using 2.6.20-rc3-git4 I observed that my direct i/o test application no longer receives an EIO when the fc transport deletes a target following a fibre channel switch port disable. With 2.6.19 EIO is returned and the application terminates. With 2.6.20, the requested read length is

[PATCH 1/1] fusion: fibre channel: return DID_ERROR for MPI_IOCSTATUS_SCSI_IOC_TERMINATED

2006-12-20 Thread Michael Reed
The fibre channel IOC may kill a request for a variety of reasons, some of which may be recovered by a retry, some of which are unlikely to be recovered. Return DID_ERROR instead of DID_RESET to permit retry of the command, just not an infinite number of them. Signed-off-by: Michael Reed [EMAIL

[RFC] Prevent infinite retries due to DID_RESET return status

2006-12-11 Thread Michael Reed
Due to a firmware mismatch between a host and target (names withheld to protect the innocent?), the LLDD was returning DID_RESET for every i/o command. This patch modifies the scsi layer to take into account when the command which received DID_RESET was issued and eventually give up on it instead

Re: Infinite retries reading the partition table

2006-12-05 Thread Michael Reed
Luben Tuikov wrote: ...snip... This statement in scsi_io_completion() causes the infinite retry loop: if (scsi_end_request(cmd, 1, good_bytes, !!result) == NULL) return; The code in 2.6.19 is result==0, not !!result, which is logically the same as result!=0. Did you mean to