Re: [PATCH 2/2] tests/scsi/0001: Regression test for SCSI device blacklisting

On Wed, Dec 13, 2017 at 01:29:39AM -0800, Omar Sandoval wrote: > On Tue, Aug 15, 2017 at 11:00:49PM -0700, Omar Sandoval wrote: > > On Wed, Aug 09, 2017 at 12:50:06PM +0200, Hannes Reinecke wrote: > > > SCSI device blacklisting seems to be a tricky subject, with > > > lo

Re: [PATCH blktests] scsi/004: add regression test for false BLK_STS_OK with non good SAM status

On Mon, Apr 23, 2018 at 02:25:03PM +0200, Steffen Maier wrote: > > On 04/19/2018 10:18 PM, Omar Sandoval wrote: > > On Thu, Apr 19, 2018 at 01:44:41PM -0600, Jens Axboe wrote: > >> On 4/19/18 1:41 PM, Bart Van Assche wrote: > >>> On Thu, 2018-04-19 at

Re: [PATCH blktests] scsi/004: add regression test for false BLK_STS_OK with non good SAM status

On Thu, Apr 19, 2018 at 01:44:41PM -0600, Jens Axboe wrote: > On 4/19/18 1:41 PM, Bart Van Assche wrote: > > On Thu, 2018-04-19 at 12:13 -0700, Omar Sandoval wrote: > >> On Thu, Apr 19, 2018 at 11:53:30AM -0700, Omar Sandoval wrote: > >>> Thanks for the test! Appl

Re: [PATCH blktests] scsi/004: add regression test for false BLK_STS_OK with non good SAM status

On Thu, Apr 19, 2018 at 11:53:30AM -0700, Omar Sandoval wrote: > Thanks for the test! Applied. Side note, it's unfortunate that this test takes 180 seconds to run only because we have to wait for the command timeout. We should be able to export request_queue->rq_timeout writeable in sysfs.

Re: [PATCH blktests] scsi/004: add regression test for false BLK_STS_OK with non good SAM status

On Tue, Apr 17, 2018 at 11:03:37AM +0200, Steffen Maier wrote: > Signed-off-by: Steffen Maier > --- > tests/scsi/004 | 59 > > tests/scsi/004.out |3 ++ > 2 files changed, 62 insertions(+), 0 deletions(-) >

Re: [PATCH V2 4/8] block: null_blk: introduce module parameter of 'g_global_tags'

/nullb0 --name=nullb1 --filename=/dev/nullb1 > --name=nullb2 --filename=/dev/nullb2 --name=nullb3 --filename=/dev/nullb3 > > 1M IOPS can be reached in both above tests which is done in one VM. > > Cc: Arun Easi <arun.e...@cavium.com> > Cc: Omar Sandoval <osan...@fb.com

Re: [PATCH V2 1/8] blk-mq: tags: define several fields of tags as pointer

ober...@redhat.com> > Reviewed-by: Hannes Reinecke <h...@suse.com> Assuming it builds :) Reviewed-by: Omar Sandoval <osan...@fb.com> > Cc: Mike Snitzer <snit...@redhat.com> > Cc: Christoph Hellwig <h...@infradead.org> > Signed-off-by: Ming Lei <ming@redhat.

Re: [PATCH V2 2/8] blk-mq: introduce BLK_MQ_F_GLOBAL_TAGS

ious performance loss is observed when the whole > hw queue depth is same. > > Cc: Hannes Reinecke <h...@suse.de> > Cc: Arun Easi <arun.e...@cavium.com> > Cc: Omar Sandoval <osan...@fb.com>, > Cc: "Martin K. Petersen" <martin.peter...@oracle.com>

Re: [PATCH V2 5/8] scsi: introduce force_blk_mq

ntly[3]: > > [3] https://marc.info/?l=linux-scsi=151727684915589=2 > > Cc: Arun Easi <arun.e...@cavium.com> > Cc: Omar Sandoval <osan...@fb.com>, > Cc: "Martin K. Petersen" <martin.peter...@oracle.com>, > Cc: James Bottomley <james.bottom...@

Re: [PATCH 2/2] tests/scsi/0001: Regression test for SCSI device blacklisting

On Tue, Aug 15, 2017 at 11:00:49PM -0700, Omar Sandoval wrote: > On Wed, Aug 09, 2017 at 12:50:06PM +0200, Hannes Reinecke wrote: > > SCSI device blacklisting seems to be a tricky subject, with > > lots of potential for messing up the selection algorithm. > > This add

Re: [PATCH V6 5/5] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed

ake sure that request isn't dequeued until ->dispatch is > flushed. > > Reviewed-by: Bart Van Assche <bart.vanass...@wdc.com> > Reviewed-by: Christoph Hellwig <h...@lst.de> I think this will do for now. Reviewed-by: Omar Sandoval <osan...@fb.com> > Signed-off

Re: [PATCH V6 4/5] blk-mq-sched: improve dispatching from sw queue

This still didn't address Jens' concern about using q->queue_depth as the heuristic for whether to do the full sw queue flush or one-by-one dispatch. The EWMA approach is a bit too complex for now, can you please try the heuristic of whether the driver ever returned BLK_STS_RESOURCE? > Reviewed-by: Om

Re: [PATCH V6 3/5] sbitmap: introduce __sbitmap_for_each_set()

On Mon, Oct 09, 2017 at 07:24:22PM +0800, Ming Lei wrote: > We need to iterate ctx starting from any ctx in round robin > way, so introduce this helper. > > Cc: Omar Sandoval <osan...@fb.com> Reviewed-by: Omar Sandoval <osan...@fb.com> > Signed-off-by: Mi

Re: [PATCH V6 1/5] blk-mq-sched: fix scheduler bad performance

) when mq-deadline/kyber > is used by not taking requests if hw queue is busy. > > Reviewed-by: Bart Van Assche <bart.vanass...@wdc.com> > Reviewed-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Omar Sandoval <osan...@fb.com> > Signed-off-by: Ming Lei <m

Re: [PATCH 2/2] tests/scsi/0001: Regression test for SCSI device blacklisting

On Wed, Aug 09, 2017 at 12:50:06PM +0200, Hannes Reinecke wrote: > SCSI device blacklisting seems to be a tricky subject, with > lots of potential for messing up the selection algorithm. > This adds a test for catching regressions here. I'm waiting to see how the patches end up before applying

Re: [PATCH 1/2] tests/scsi: add SCSI midlayer test group

On Wed, Aug 09, 2017 at 12:50:05PM +0200, Hannes Reinecke wrote: > Add a test group for tests of the SCSI midlayer. > > Signed-off-by: Hannes Reinecke > --- > tests/scsi/group | 26 ++ > 1 file changed, 26 insertions(+) > create mode 100644

Re: [PATCH blktests] sg: add regression test for patch scsi: sg: fix SG_DXFER_FROM_DEV transfers

On Thu, Jul 06, 2017 at 02:09:21PM +0200, Johannes Thumshirn wrote: > Add a regression test for the patch titled "scsi: sg: fix > SG_DXFER_FROM_DEV transfers" which reassembles the syscalls done by Nero > Burning ROM to discover CD and DVD burners. Fixed up a few things below and applied, thanks!

Re: [PATCH blktests v2 0/3] Add SCSI generic test group

On Fri, May 19, 2017 at 03:55:28PM +0200, Johannes Thumshirn wrote: > Add a test group for the SCSI generic driver and one syzcaller > reproducer for this group. > > The reprodcuer is distributed as a C program, so the makefile is > amended to build C files to be used in the test. > > Changes to

Re: [PATCH blktests v2 3/3] sg/001: add regression test for syzcaller generated GPF in sg_read path

On Fri, May 19, 2017 at 03:55:31PM +0200, Johannes Thumshirn wrote: > Add a regression test for commit 48ae8484e9fc ("scsi: sg: don't return > bogus Sg_requests"). This is a general protection fault triggered by > syzcaller via issuing bogus read(2)s on the /dev/sg devices. > > Signed-off-by:

Re: [PATCH blktests 0/3] Add SCSI generic test group

On Thu, May 18, 2017 at 03:29:45PM +0200, Johannes Thumshirn wrote: > On 05/18/2017 03:19 PM, Christoph Hellwig wrote: > > All SG_IO test should also apply to block device nodes that support > > the ioctl.. > > > > But these are not necessarily SG_IO tests, are they? > > The test included is

Re: [PATCH blktests 2/3] tests/sg: add SCSI generic test grouop

On Thu, May 18, 2017 at 02:06:20PM -0700, Omar Sandoval wrote: > On Thu, May 18, 2017 at 02:13:07PM +0200, Johannes Thumshirn wrote: > > Add a test group for tests of the SCSI generic driver and and > > functions common to the SCSI generic driver and it's test cases. >

Re: [PATCH blktests 3/3] sg/001: add regression test for syzcaller generated GPF

On Thu, May 18, 2017 at 02:13:08PM +0200, Johannes Thumshirn wrote: > Add a regression test for commit 48ae8484e9fc ("scsi: sg: don't return > bogus Sg_requests"). This is a general protection fault triggered by > syzcaller. > > Signed-off-by: Johannes Thumshirn > --- >

Re: [PATCH blktests 2/3] tests/sg: add SCSI generic test grouop

On Thu, May 18, 2017 at 02:13:07PM +0200, Johannes Thumshirn wrote: > Add a test group for tests of the SCSI generic driver and and > functions common to the SCSI generic driver and it's test cases. > > Signed-off-by: Johannes Thumshirn > --- > common/sg | 22

Re: [PATCH v5 10/10] scsi: Implement blk_mq_ops.show_rq()

ingful number. For the sake of this not getting bike-shedded to death, Reviewed-by: Omar Sandoval <osan...@fb.com> > Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> > Cc: Martin K. Petersen <martin.peter...@oracle.com> > Cc: James Bottomley <james.bottom.

Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

On Mon, Apr 24, 2017 at 07:19:50PM -0400, Martin K. Petersen wrote: > > Bart, > > > SCSI tracing has to be enabled before a test is started, produces a > > huge amount of data, and deriving state information from a huge trace > > is far from easy. The information in debugfs provides an easy to

Re: [RFC PATCH 0/2] block,scsi: support host-wide tagset

On Tue, Apr 04, 2017 at 02:07:43PM +0200, Hannes Reinecke wrote: > Hi all, > > as discussed recently most existing HBAs have a host-wide tagset which > does not map easily onto the per-queue tagset model of block mq. > This patchset implements a flag BLK_MQ_F_GLOBAL_TAGS for block-mq, which >

Re: [PATCH 0/4] block: Fixes for bdi handling

On Wed, Mar 08, 2017 at 08:50:51AM -0800, Omar Sandoval wrote: > On Wed, Mar 08, 2017 at 05:48:30PM +0100, Jan Kara wrote: > > Hi! > > > > patches in this series fix the most urgent bugs that were introduced by > > commit > > 165a5e22fafb "block

Re: [PATCH 0/4] block: Fixes for bdi handling

On Wed, Mar 08, 2017 at 05:48:30PM +0100, Jan Kara wrote: > Hi! > > patches in this series fix the most urgent bugs that were introduced by commit > 165a5e22fafb "block: Move bdi_unregister() to del_gendisk()" and by > 0dba1314d4f8 "scsi, block: fix duplicate bdi name registration crashes". > In

Re: [PATCH] mpt3sas: Avoid sleeping in interrupt context

On Wed, Mar 01, 2017 at 05:09:48PM +, Bart Van Assche wrote: > On Wed, 2017-03-01 at 09:04 -0800, Omar Sandoval wrote: > > Thanks, Bart, you can add > > > > Tested-by: Omar Sandoval <osan...@fb.com> > > Hello Omar, > > Have you been able to test both c

Re: [PATCH] mpt3sas: Avoid sleeping in interrupt context

: > > _base_interrupt() > -> _base_async_event() >-> mpt3sas_scsih_event_callback() > -> _scsih_check_topo_delete_events() > -> _scsih_block_io_to_children_attached_directly() > -> _scsih_block_io_device() >-> _scsih_internal_device_block()

Re: mpt3sas sleep from atomic context on v4.10

On Wed, Mar 01, 2017 at 01:07:12AM +, Bart Van Assche wrote: > On Tue, 2017-02-28 at 16:25 -0800, Omar Sandoval wrote: > > I'm seeing this while testing on Linus' current master: > > > > [ 427.814466] WARNING: CPU: 0 PID: 0 at kernel/irq/handle.c:149 > > __ha

mpt3sas sleep from atomic context on v4.10

I'm seeing this while testing on Linus' current master: [ 427.814466] WARNING: CPU: 0 PID: 0 at kernel/irq/handle.c:149 __handle_irq_event_percpu+0x187/0x190 [ 427.832552] irq 116 handler _base_interrupt+0x0/0x9e0 [mpt3sas] enabled interrupts I tracked it down to commit 669f044170d8 ("scsi:

Re: Manual driver binding and unbinding broken for SCSI

On Fri, Feb 17, 2017 at 04:43:56PM -0800, James Bottomley wrote: > This seems to be related to a 0day test we got on the block tree, > details here: > > http://marc.info/?t=14862406881 > > I root caused the above to something not being released when it should > be, so it looks like you have

Manual driver binding and unbinding broken for SCSI

Hi, everyone, As per $SUBJECT, I can cause a crash on v4.10-rc8, Jens' block/for-next, and Jan's bdi branch [1] by doing this: # lsscsi [0:0:0:0]diskQEMU QEMU HARDDISK2.5+ /dev/sda # echo 0:0:0:0 > /sys/bus/scsi/drivers/sd/unbind # echo 0:0:0:0 > /sys/bus/scsi/drivers/sd/bind

[PATCH 2/2] scsi_lib: untangle 0 and BLK_MQ_RQ_QUEUE_OK

From: Omar Sandoval <osan...@fb.com> Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having specific values. No functional change. Signed-off-by: Omar Sandoval <osan...@fb.com> --- drivers/scsi/scsi_lib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 1/2] nvme: untangle 0 and BLK_MQ_RQ_QUEUE_OK

From: Omar Sandoval <osan...@fb.com> Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having specific values. No functional change. Signed-off-by: Omar Sandoval <osan...@fb.com> --- drivers/nvme/host/core.c | 4 ++-- drivers/nvme/host/pci.c| 8 drivers/nvme

[PATCH] blk-mq drivers: untangle 0 and BLK_MQ_RQ_QUEUE_OK

From: Omar Sandoval <osan...@fb.com> Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having specific values. No functional change. Signed-off-by: Omar Sandoval <osan...@fb.com> --- Hi, Jens, Some more trivial cleanup, feel free to apply or not if it's too intrusive.

Re: Device or HBA level QD throttling creates randomness in sequetial workload

On Tue, Oct 25, 2016 at 12:24:24AM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Omar Sandoval [mailto:osan...@osandov.com] > > Sent: Monday, October 24, 2016 9:11 PM > > To: Kashyap Desai > > Cc: linux-scsi@vger.kernel.org; linux-ker...@

Re: Device or HBA level QD throttling creates randomness in sequetial workload

On Mon, Oct 24, 2016 at 06:35:01PM +0530, Kashyap Desai wrote: > > > > On Fri, Oct 21, 2016 at 05:43:35PM +0530, Kashyap Desai wrote: > > > Hi - > > > > > > I found below conversation and it is on the same line as I wanted some > > > input from mailing list. > > > > > >

Re: Device or HBA level QD throttling creates randomness in sequetial workload

On Fri, Oct 21, 2016 at 05:43:35PM +0530, Kashyap Desai wrote: > Hi - > > I found below conversation and it is on the same line as I wanted some > input from mailing list. > > http://marc.info/?l=linux-kernel=147569860526197=2 > > I can do testing on any WIP item as Omar mentioned in above