Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-09 Thread Sagi Grimberg
Hellwig h...@lst.de Cc: Hannes Reinecke h...@suse.de Cc: Sagi Grimberg sa...@mellanox.com Cc: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/target/target_core_sbc.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/target

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-09 Thread Sagi Grimberg
assoicated with the ramdisk backend device. Cc: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h...@lst.de Cc: Hannes Reinecke h...@suse.de Cc: Sagi Grimberg sa...@mellanox.com Cc: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers

Re: [PATCH 02/14] target: Add DIF CHECK_CONDITION ASC/ASCQ exception cases

2014-01-09 Thread Sagi Grimberg
BLOCK APPLICATION TAG CHECK FAILED LOGICAL BLOCK REFERENCE TAG CHECK FAILED that used by DIF TYPE1 and TYPE3 failure cases. Cc: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h...@lst.de Cc: Hannes Reinecke h...@suse.de Cc: Sagi Grimberg sa...@mellanox.com Cc: Or Gerlitz ogerl

Re: [PATCH 01/14] target: Add DIF related base definitions

2014-01-09 Thread Sagi Grimberg
Grimberg's original patch. Cc: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h...@lst.de Cc: Hannes Reinecke h...@suse.de Cc: Sagi Grimberg sa...@mellanox.com Cc: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org target: more defs Signed

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-09 Thread Sagi Grimberg
explicit and this routine should be called upon getting FORMAT_UNIT as well. Cc: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h...@lst.de Cc: Hannes Reinecke h...@suse.de Cc: Sagi Grimberg sa...@mellanox.com Cc: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Nicholas

Re: [PATCH 03/14] target/sbc: Add sbc_check_prot + update sbc_parse_cdb for DIF

2014-01-09 Thread Sagi Grimberg
[10,12,16] + WRITE_[10,12,16] to perform DIF sanity checking. Cc: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h...@lst.de Cc: Hannes Reinecke h...@suse.de Cc: Sagi Grimberg sa...@mellanox.com Cc: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux

[PATCH 02/11] IB/isert: seperate connection protection domains and dma MRs

2014-01-09 Thread Sagi Grimberg
It is more correct to seperate connections protection domains and dma_mr handles. protection information support requires to do so. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/ulp/isert/ib_isert.c | 46 --- drivers/infiniband/ulp/isert

[PATCH 03/11] IB/isert: Avoid frwr notation, user fastreg

2014-01-09 Thread Sagi Grimberg
Use fast registration lingo. fast registration will also incorporate signature/DIF registration. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/ulp/isert/ib_isert.c | 84 --- drivers/infiniband/ulp/isert/ib_isert.h |8 ++-- 2 files

[PATCH 01/11] Target/core: Fixes for isert compilation

2014-01-09 Thread Sagi Grimberg
replace prot_interleaved with prot_handover in se_cmd. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- include/target/target_core_base.h | 22 ++ 1 files changed, 14 insertions(+), 8 deletions(-) diff --git a/include/target/target_core_base.h b/include/target

[PATCH 00/11] iSER target initial support for T10-DIF offload

2014-01-09 Thread Sagi Grimberg
ccb0a907 IB/mlx5: Break wqe handling to begin finish routines cda0569 IB/mlx5: Initialize mlx5_ib_qp signature related 33b4079 IB/mlx5, mlx5_core: Support for create_mr and destroy_mr 8b343e6 IB/core: Introduce Signature Verbs API c1b0358 IB/core: Introduce protected memory regions Sagi Grimberg (11

[PATCH 04/11] IB/isert: Move fastreg descriptor creation to a function

2014-01-09 Thread Sagi Grimberg
This routine may be called both by fast registration descriptors for data and for integrity buffers. This patch does not change any functionality. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/ulp/isert/ib_isert.c | 52 +++ 1 files changed

[PATCH 07/11] IB/isert: pass scatterlist instead of cmd to fast_reg_mr routine

2014-01-09 Thread Sagi Grimberg
This routine may help for protection registration as well. This patch does not change any functionality. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/ulp/isert/ib_isert.c | 28 1 files changed, 12 insertions(+), 16 deletions(-) diff --git

[PATCH 05/11] Target/iscsi: Add T10-PI indication for iscsi_portal_group

2014-01-09 Thread Sagi Grimberg
. This is a hook for the iscsi target layer to signal the transport at connection establishment that this connection will carry protected transactions. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/target/iscsi/iscsi_target_core.h |5 - drivers/target/iscsi/iscsi_target_tpg.c |2 ++ 2

[PATCH 06/11] IB/isert: Initialize T10-PI resources

2014-01-09 Thread Sagi Grimberg
Upon connection establishment check if network portal is T10-PI enabled and allocate T10-PI resources if necessary, allocate signature enabled memory regions and mark connection queue-pair as signature enabled. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/ulp/isert

[PATCH 10/11] IB/isert: Support T10-PI protected transactions

2014-01-09 Thread Sagi Grimberg
completion check the signature status - if succeeded send good SCSI response - if failed send SCSI bad response with appropriate sense buffer Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/ulp/isert/ib_isert.c | 376 ++- 1 files changed

[PATCH 09/11] IB/isert: Accept RDMA_WRITE completions

2014-01-09 Thread Sagi Grimberg
In case of protected transactions, we will need to check the protection status of the transaction before sending SCSI response. So be ready for RDMA_WRITE completions. currently we don't ask for these completions, but for T10-PI we will. Signed-off-by: Sagi Grimberg sa...@mellanox.com

[PATCH 11/11] Target/configfs: Expose iSCSI network portal group T10-PI support

2014-01-09 Thread Sagi Grimberg
User may enable T10-PI support per network portal group. any connection established on top of it, will be required to serve protected transactions. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/target/iscsi/iscsi_target_configfs.c |6 ++ drivers/target/iscsi

[PATCH 08/11] IB/isert: pass mr and frpl to isert_fast_reg_mr routine

2014-01-09 Thread Sagi Grimberg
This commit generalizes isert_fast_reg_mr to receive mr and frpl instead of fr_desc to do registration. In T10-PI we also register protection memory region so we want to use this routine. This commit does not change any functionality. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers

Re: [LSF/MM TOPIC] Reducing the SRP initiator failover time

2013-02-08 Thread Sagi Grimberg
On 2/8/2013 12:42 AM, Vu Pham wrote: It is known that it takes about two to three minutes before the upstream SRP initiator fails over from a failed path to a working path. This is not only considered longer than acceptable but is also longer than other Linux SCSI initiators (e.g. iSCSI

<    1   2   3   4   5   6