Re: [PATCH] virtio_scsi: always read VPD pages for multiqueue too

2017-07-11 Thread Stefan Hajnoczi
: David Gibson <da...@gibson.dropbear.id.au> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > drivers/scsi/virtio_scsi.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [PATCH] virtio_scsi: Always try to read VPD pages

2017-04-13 Thread Stefan Hajnoczi
On Thu, Apr 13, 2017 at 12:13:00PM +1000, David Gibson wrote: > @@ -705,6 +706,28 @@ static int virtscsi_device_reset(struct scsi_cmnd *sc) > return virtscsi_tmf(vscsi, cmd); > } > > +static int virtscsi_device_alloc(struct scsi_device *sdevice) > +{ > + /* > + * Passed through

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

2016-12-07 Thread Stefan Hajnoczi
ers/vhost/Makefile | 1 + > drivers/virtio/Makefile | 3 +++ > net/9p/Makefile | 1 + > net/packet/Makefile | 1 + > net/vmw_vsock/Makefile | 2 ++ > 14 files changed, 21 insertions(+) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Application error handling with write-back caching

2016-05-10 Thread Stefan Hajnoczi
SBC-3 4.15.3 Write caching says: "If processing a write command results in logical block data in cache that is different from the logical block data on the medium, then the device server shall retain that logical block data in cache until a write medium operation is performed using that logical

Re: [RFC 0/2] target: userspace pass-through backend

2014-07-14 Thread Stefan Hajnoczi
On Tue, Jul 1, 2014 at 9:11 PM, Andy Grover agro...@redhat.com wrote: Shaohua Li wrote an initial implementation of this, late last year[1]. Starting from that, I started working on some alternate implementation choices, and ended up with something rather different. Please take a look and let

Re: Fwd: Re: [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items

2014-06-11 Thread Stefan Hajnoczi
, venkate...@google.com Subject: Re: [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items Message-ID: 20140611124731.ga16...@infradead.org In-Reply-To: 1401881699-1456-4-git-send-email-pbonz...@redhat.com Can I get a second review on this one from anyone? Reviewed-by: Stefan

Re: [Qemu-devel] Testing NPIV Feature with Qemu-KVM

2013-09-05 Thread Stefan Hajnoczi
On Mon, Sep 2, 2013 at 2:34 PM, chandrashekar shastri cshas...@oc2505588478.ibm.com wrote: I am testing NPIV feature on upstream Qemu, I have configured the zone and able to see the created vport on the storage array. Since, I am learning on how to setup the NPIV, I haven't created the

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Stefan Hajnoczi
On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: +/** + * virtqueue_start_buf - start building buffer for the other end + * @vq: the struct virtqueue we're talking about. + * @buf: a struct keeping the state of the buffer + * @data: the token identifying the buffer. + * @count:

Re: [PATCH v2 5/5] virtio-scsi: introduce multiqueue support

2012-12-19 Thread Stefan Hajnoczi
On Tue, Dec 18, 2012 at 01:32:52PM +0100, Paolo Bonzini wrote: struct virtio_scsi_target_state { - /* Never held at the same time as vq_lock. */ + /* This spinlock ever held at the same time as vq_lock. */ s/ever/is never/ -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Stefan Hajnoczi
On Wed, Dec 19, 2012 at 1:04 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 19/12/2012 11:47, Stefan Hajnoczi ha scritto: On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: What is the purpose of count_sg? It is needed to decide whether to use an indirect or a direct buffer

Re: [PATCH 0/5] Multiqueue virtio-scsi

2012-08-30 Thread Stefan Hajnoczi
(so that commands are not reordered); queue switching occurs when the request being queued is the only one for the target. Also based on Jason's patches, the virtqueue affinity is set so that each CPU is associated to one virtqueue. Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

Re: virtio-scsi - vhost multi lun/adapter performance results with 3.6-rc0

2012-08-11 Thread Stefan Hajnoczi
On Sat, Aug 11, 2012 at 12:23 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: Using a KVM guest with 32x vCPUs and 4G memory, the results for 4x random I/O now look like: workload | jobs | 25% write / 75% read | 75% write / 25% read

Re: [PATCH] scsi: virtio-scsi: Fix address translation failure of HighMem pages used by sg list

2012-07-25 Thread Stefan Hajnoczi
-by: Wang Sen senw...@linux.vnet.ibm.com --- drivers/scsi/virtio_scsi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [PATCH] scsi: virtio-scsi: Fix address translation failure of HighMem pages used by sg list

2012-07-25 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 10:44:14AM +0200, Paolo Bonzini wrote: Il 25/07/2012 10:29, Wang Sen ha scritto: When using the commands below to write some data to a virtio-scsi LUN of the QEMU guest(32-bit) with 1G physical memory(qemu -m 1024), the qemu will crash. # sudo mkfs.ext4

Re: [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION

2012-07-25 Thread Stefan Hajnoczi
if you have any concerns here. Thanks! Reported-by: Anthony Liguori aligu...@us.ibm.com Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off

Re: [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION

2012-07-25 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 02:14:50PM -0700, Nicholas A. Bellinger wrote: On Wed, 2012-07-25 at 12:55 +0100, Stefan Hajnoczi wrote: On Tue, Jul 24, 2012 at 01:45:24PM -0700, Nicholas A. Bellinger wrote: On Mon, 2012-07-23 at 18:56 -0700, Greg Kroah-Hartman wrote: On Tue, Jul 24, 2012 at 01

Re: [PATCH RESEND 0/5] Add vhost-blk support

2012-07-18 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 4:09 PM, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: Hi folks, [I am resending to fix the broken thread in the previous one.] This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk device

Re: [PATCH v4] virtio-scsi: hotplug support for virtio-scsi

2012-07-12 Thread Stefan Hajnoczi
++- include/linux/virtio_scsi.h |9 +++ 2 files changed, 135 insertions(+), 1 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord