RE: crash in iscsi/scsi initiator with linux-4.15.0-rc1

> > Hey Ewan, Yan, Bart, > > > > I'm still seeing this issue with 4.15-rc4. Is the issue still outstanding? > > > > Steve. > > > > Please apply the following commit from the 4.15/scsi-fixes branch of > > git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git > > and advise if it does not

RE: crash in iscsi/scsi initiator with linux-4.15.0-rc1

> > Hey, > > > > I'm seeing this null pointer dereference with linux-4.15.0-rc1. To > > reproduce > > it, I connect two ram disks via iscsi/TCP, and start an fio: > > > > iscsiadm -m discovery --op update --type sendtargets -p 172.16.1.10:3260 > > iscsiadm -m node -p 172.16.1.10:3260 -l > >

RE: crash in iscsi/scsi initiator with linux-4.15.0-rc1

> > Then I hit this crash. Has anyone else encountered this issue? Wondering > > if > > there is a fix handy. :) > > > > This is the same problem that is being discussed under the thread: > "[PATCH] scsi: fix race condition when removing target". > > We had good test results with both Jason

crash in iscsi/scsi initiator with linux-4.15.0-rc1

Hey, I'm seeing this null pointer dereference with linux-4.15.0-rc1. To reproduce it, I connect two ram disks via iscsi/TCP, and start an fio: iscsiadm -m discovery --op update --type sendtargets -p 172.16.1.10:3260 iscsiadm -m node -p 172.16.1.10:3260 -l ISCSI_DISKS=/dev/sdd:/dev/sde; fio

RE: [RFC 4/8] p2pmem: Add debugfs "stats" file

> > > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > > + if (!p2pmem_debugfs_root) > > + pr_info("could not create debugfs entry, continuing\n"); > > + > > Why continue? I think it'd be better to just fail it. > Because not having debugfs support isn't fatal to

RE: [RFC 2/8] cxgb4: setup pcie memory window 4 and create p2pmem region

> > > > +static void setup_memwin_p2pmem(struct adapter *adap) > > +{ > > + unsigned int mem_base = t4_read_reg(adap, > CIM_EXTMEM2_BASE_ADDR_A); > > + unsigned int mem_size = t4_read_reg(adap, > CIM_EXTMEM2_ADDR_SIZE_A); > > + > > + if (!use_p2pmem) > > + return; > > This is

RE: A question regarding "multiple SGL"

> > Hi Robert, > > Hey Robert, Christoph, > > > please explain your use cases that isn't handled. The one and only > > reason to set MSDBD to 1 is to make the code a lot simpler given that > > there is no real use case for supporting more. > > > > RDMA uses memory registrations to register

RE: [PATCH 9/9] [RFC] nvme: Fix a race condition

> > Hello James and Steve, > > I will add a comment. > > Please note that the above patch does not change the behavior of > nvme_stop_queues() except that it causes nvme_stop_queues() to wait > until any ongoing nvme_queue_rq() calls have finished. > blk_resume_queue() does not affect the value

RE: [PATCH 9/9] [RFC] nvme: Fix a race condition

> On 09/27/2016 09:31 AM, Steve Wise wrote: > >> @@ -2079,11 +2075,15 @@ EXPORT_SYMBOL_GPL(nvme_kill_queues); > >> void nvme_stop_queues(struct nvme_ctrl *ctrl) > >> { > >>struct nvme_ns *ns; > >> + struct request_que

RE: [PATCH 9/9] [RFC] nvme: Fix a race condition

> @@ -2079,11 +2075,15 @@ EXPORT_SYMBOL_GPL(nvme_kill_queues); > void nvme_stop_queues(struct nvme_ctrl *ctrl) > { > struct nvme_ns *ns; > + struct request_queue *q; > > mutex_lock(>namespaces_mutex); > list_for_each_entry(ns, >namespaces, list) { > -

RE: [net-next 6/6] cxgb3i,cxgb4i: fix symbol not declared sparse warning

off-by: Varun Prakash <va...@chelsio.com> looks fine. Reviewed-by: Steve Wise <sw...@opengridcomputing.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [net-next 5/6] libcxgb: export ppm release and tagmask set api

> Export cxgbi_ppm_release() to release > ppod manager and cxgbi_tagmask_set() to > set tag mask, they are used by cxgb3i, cxgb4i > and cxgbit. > > Signed-off-by: Varun Prakash <va...@chelsio.com> Looks good. Reviewd-by: Steve Wise <sw...@opengridcomputing.co

RE: [net-next 4/6] cxgb3i: add iSCSI DDP support

> Add iSCSI DDP support in cxgb3i driver > using common iSCSI DDP Page Pod Manager. > > Signed-off-by: Varun Prakash <va...@chelsio.com> Looks ok. Reviewed-by: Steve Wise <sw...@opengridcomputing.com> -- To unsubscribe from this list: send the line "unsubs

RE: [net-next 3/6] cxgb4i,libcxgbi: add iSCSI DDP support

> Add iSCSI DDP support in cxgb4i driver > using common iSCSI DDP Page Pod Manager. > > Signed-off-by: Varun Prakash > --- > drivers/scsi/cxgbi/Makefile| 2 + > drivers/scsi/cxgbi/cxgb3i/Kbuild | 1 + > drivers/scsi/cxgbi/cxgb3i/Kconfig | 1 + Should the

RE: [net-next 2/6] cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support

/scsi/cxgbi/cxgb4i/cxgb4i.c | 142 - > drivers/scsi/cxgbi/libcxgbi.c | 578 - > drivers/scsi/cxgbi/libcxgbi.h | 161 --- > 4 files changed, 1009 deletions(-) Looks good. I guess this series needs to be squashed or we'll have bisect comp

RE: [net-next 1/6] libcxgb: add library module for Chelsio drivers

e iSCSI Data-In or Data-Out PDU's payload into > @@ -462,3 +466,20 @@ unsigned int cxgbi_tagmask_set(unsigned int ppmax) > > return 1 << (bits + PPOD_IDX_SHIFT); > } > + > +static int __init libcxgb_init(void) > +{ > + return 0; > +} > + > +static void __exi

RE: [net-next 0/6] common library for Chelsio drivers

> > Hi, > > > > This patch series adds common library module(libcxgb.ko) > > for Chelsio drivers to remove duplicate code. > > > > This series moves common iSCSI DDP Page Pod manager > > code from cxgb4.ko to libcxgb.ko, earlier this code > > was used by only cxgbit.ko now it is used by > > three

RE: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

> > > In first series libcxgb.ko will have common > > > iSCSI DDP Page Pod Manager that will be shared > > > by three Chelsio iSCSI drivers > > > cxgb3i, cxgb4i, cxgbit. > > > > cool > > > > > In subsequent series I will add common connection > > > management and other hardware specific common

RE: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

> From: Or Gerlitz [mailto:gerlitz...@gmail.com] > > On Tue, May 24, 2016 at 9:40 AM, Nicholas A. Bellinger > wrote: > > Hi Or & Co, > > On Wed, 2016-05-18 at 14:45 +0300, Or Gerlitz wrote: > >> On Sat, Apr 30, 2016 at 6:54 PM, Or Gerlitz wrote: > >>

RE: [PATCH 3/9] IB: add a helper to safely drain a QP

> -Original Message- > From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] > Sent: Monday, November 23, 2015 4:29 AM > To: Steve Wise; 'Christoph Hellwig'; linux-r...@vger.kernel.org > Cc: bart.vanass...@sandisk.com; ax...@fb.com; linux-scsi@vger.kernel.or

RE: [PATCH 3/9] IB: add a helper to safely drain a QP

> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Sagi Grimberg > Sent: Monday, November 23, 2015 4:36 AM > To: Steve Wise; 'Christoph Hellwig'; linux-r...@vger.kernel.org > Cc: bart.vanass.

Re: [PATCH 3/9] IB: add a helper to safely drain a QP

On 11/18/2015 8:06 AM, Christoph Hellwig wrote: On Wed, Nov 18, 2015 at 01:32:19PM +0200, Sagi Grimberg wrote: Christoph, Given the discussion around this patch I think it would be a good idea remove it from the patchset since it's not mandatory for the CQ abstraction. I think that we should

Re: [PATCH 3/9] IB: add a helper to safely drain a QP

On 11/15/2015 3:34 AM, Sagi Grimberg wrote: + +struct ib_stop_cqe { +struct ib_cqecqe; +struct completion done; +}; + +static void ib_stop_done(struct ib_cq *cq, struct ib_wc *wc) +{ +struct ib_stop_cqe *stop = +container_of(wc->wr_cqe, struct ib_stop_cqe, cqe); + +

RE: [PATCH 3/9] IB: add a helper to safely drain a QP

> -Original Message- > From: Steve Wise [mailto:sw...@opengridcomputing.com] > Sent: Monday, November 16, 2015 10:38 AM > To: Sagi Grimberg; Christoph Hellwig; linux-r...@vger.kernel.org > Cc: bart.vanass...@sandisk.com; ax...@fb.com; linux-scsi@vger.kernel.or

RE: [PATCH 3/9] IB: add a helper to safely drain a QP

> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Sagi Grimberg > Sent: Monday, November 16, 2015 12:38 PM > To: Steve Wise; 'Christoph Hellwig'; linux-r...@vger.kernel.org > Cc: bart.vanass.

Re: [PATCH 3/9] IB: add a helper to safely drain a QP

On 11/13/2015 7:46 AM, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig --- drivers/infiniband/core/cq.c | 46 include/rdma/ib_verbs.h | 2 ++ 2 files changed, 48 insertions(+) diff --git

Re: [PATCH net-next v2 1/4] cxgb4/iw_cxgb4/cxgb4i: remove duplicate definitions

Acked-by: Steve Wise sw...@opengridcomputing.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 net-next 00/22] Add support for Chelsio T5 adapter

Acked-by: Steve Wise sw...@opengridcomputing.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next 05/22] cxgb4: Add T5 write combining support

On 3/12/2013 7:19 AM, David Miller wrote: From: Vipul Pandya vi...@chelsio.com Date: Tue, 12 Mar 2013 17:16:17 +0530 + writel(n, adap-bar2 + q-udb + 8); +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64) + asm volatile(sfence : : :